cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(zone.js): fix 2 bluebird test cases for each/mapSeries (#36295)

Browse Source 
`Bluebird.each` and `Bluebird.mapSeries` will accept a callback with `value` parameter,
the `value` should be the item in the array, not array itself.

For example:
```
const arr = [1, 2];
Bluebird.each(arr, function(value, idx) {
  console.log(`value: ${value}, idx: ${idx}`);
})
```

the output will be
```
value: 1, idx: 0
value: 2, idx: 1
```

This PR fix the test cases for `each` and `mapSeries` APIs.

PR Close #36295
This commit is contained in:
JiaLiPassion 2020-03-28 19:26:53 +09:00 committed by Alex Rickabaugh
parent c5df9ce474
commit b44f7b5e16
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/zone.js/test/extra/bluebird.spec.ts
View File

@ -283,8 +283,8 @@ describe('bluebird promise', () => {
BluebirdPromise BluebirdPromise
.each( .each(
BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)), BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)),
(r: number[], idx: number) => { (r: number, idx: number) => {
expect(r[idx] === arr[idx]); expect(r).toBe(arr[idx]);
expect(Zone.current.name).toEqual('bluebird'); expect(Zone.current.name).toEqual('bluebird');
}) })
.then((r: any) => { .then((r: any) => {
@ -304,8 +304,8 @@ describe('bluebird promise', () => {
BluebirdPromise BluebirdPromise
.mapSeries( .mapSeries(
BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)), BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)),
(r: number[], idx: number) => { (r: number, idx: number) => {
expect(r[idx] === arr[idx]); expect(r).toBe(arr[idx]);
expect(Zone.current.name).toEqual('bluebird'); expect(Zone.current.name).toEqual('bluebird');
}) })
.then((r: any) => { .then((r: any) => {