cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): Attribute decorator attributeName is mandatory (#38131)

Browse Source 
`Attribute` decorator has defined `attributeName` as optional but actually its
 mandatory and compiler throws an error if `attributeName` is undefined. Made
`attributeName` mandatory in the `Attribute` decorator to reflect this functionality

Fixes #32658

PR Close #38131
This commit is contained in:
Ajit Singh 2020-07-18 18:35:28 +05:30 committed by Michael Prentice
parent 63894062d4
commit d3999d904a
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
goldens/public-api/core/core.d.ts vendored
View File

@ -53,7 +53,7 @@ export declare function asNativeElements(debugEls: DebugElement[]): any;
export declare function assertPlatform(requiredToken: any): PlatformRef;
export declare interface Attribute {
attributeName?: string;
attributeName: string;
}
export declare const Attribute: AttributeDecorator;

4
packages/compiler/src/core.ts
View File

@ -22,10 +22,10 @@ export const createInjectionToken = makeMetadataFactory<object>(
'InjectionToken', (desc: string) => ({_desc: desc, ɵprov: undefined}));
export interface Attribute {
attributeName?: string;
attributeName: string;
}
export const createAttribute =
makeMetadataFactory<Attribute>('Attribute', (attributeName?: string) => ({attributeName}));
makeMetadataFactory<Attribute>('Attribute', (attributeName: string) => ({attributeName}));
export interface Query {
descendants: boolean;

2
packages/core/src/di/metadata.ts
View File

@ -271,7 +271,7 @@ export interface Attribute {
/**
* The name of the attribute whose value can be injected.
*/
attributeName?: string;
attributeName: string;
}
/**