cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): update fixmes in packages/core/test/linker/jit_summaries_integration_spec.ts (#27639)

Browse Source 
the issues referenced were stale and unrelated.

PR Close #27639
This commit is contained in:
Igor Minar 2018-12-12 22:16:02 -08:00 committed by Miško Hevery
parent 8f8c5ba12e
commit d528e30cef
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/core/test/linker/jit_summaries_integration_spec.ts
View File

@ -15,7 +15,6 @@ import {expect} from '@angular/platform-browser/testing/src/matchers';
import {fixmeIvy} from '@angular/private/testing';
{
// ivy fix in https://github.com/angular/angular/pull/26871
describe('Jit Summaries', () => {
let instances: Map<any, Base>;
let summaries: () => any[];
@ -138,7 +137,7 @@ import {fixmeIvy} from '@angular/private/testing';
afterEach(() => { resetTestEnvironmentWithSummaries(); });
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should use directive metadata from summaries', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -153,7 +152,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomeDirective);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should use pipe metadata from summaries', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -166,7 +165,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomePipe);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should use Service metadata from summaries', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -177,7 +176,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomeService);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should use NgModule metadata from summaries', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -192,7 +191,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomeService);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should allow to create private components from imported NgModule summaries', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -201,7 +200,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomePrivateComponent);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should throw when trying to mock a type with a summary', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -221,7 +220,7 @@ import {fixmeIvy} from '@angular/private/testing';
.toThrowError('SomeModule was AOT compiled, so its metadata cannot be changed.');
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should return stack trace and component data on resetTestingModule when error is thrown',
() => {
resetTestEnvironmentWithSummaries();
@ -248,7 +247,7 @@ import {fixmeIvy} from '@angular/private/testing';
.toHaveBeenCalledWith('Error during cleanup of component', expectedObject);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should allow to add summaries via configureTestingModule', () => {
resetTestEnvironmentWithSummaries();
@ -266,7 +265,7 @@ import {fixmeIvy} from '@angular/private/testing';
expectInstanceCreated(SomeDirective);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should allow to override a provider', () => {
resetTestEnvironmentWithSummaries(summaries);
@ -280,7 +279,7 @@ import {fixmeIvy} from '@angular/private/testing';
expect(fixture.componentInstance.dep).toBe(overwrittenValue);
});
fixmeIvy('FW-514: ngSummary shims not generated by ngtsc')
fixmeIvy('FW-838: ivy testbed doesn\'t support jit summaries')
.it('should allow to override a template', () => {
resetTestEnvironmentWithSummaries(summaries);