cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: fix bazel protractor tests not capturing console output (#28697)

Browse Source 
Currently we depend on the "rules_webtesting" version that is
installed by "rules_typescript//:package.bzl". This version of
the webtesting rules comes with a very old version of Chromium
and the `chromedriver` that does not support capturing console
errors properly (with stack traces). Since we have a few e2e
tests that depend on console output (e.g. playground/src/source-map),
we need to make sure that these tests can pass upon Bazel
migration.

**Note for patch version**: Technically this commit is no longer updating
the `rules_webtesting` version because a different PR/commit already updated
the version transitively in `master & patch` and reverted 0094b99176264b27582ab620565632788cab66c5
partially, so in order to keep master and patch in sync, we should not update the
version of `rules_webtesting`.

PR Close #28697
This commit is contained in:
Paul Gschwendtner 2019-01-31 22:57:45 +01:00 committed by Miško Hevery
parent 424a3b95aa
commit d9f3316021
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/playground/e2e_test/sourcemap/sourcemap_spec.ts
View File

@ -20,9 +20,6 @@ describe('sourcemaps', function() {
$('error-app .errorButton').click(); $('error-app .errorButton').click();
// TODO(tbosch): Bug in ChromeDriver: Need to execute at least one command
// so that the browser logs can be read out!
browser.executeScript('1+1');
browser.manage().logs().get(logging.Type.BROWSER).then(function(logs: any) { browser.manage().logs().get(logging.Type.BROWSER).then(function(logs: any) {
let errorLine: number = null; let errorLine: number = null;
let errorColumn: number = null; let errorColumn: number = null;