9630 Commits

Author SHA1 Message Date
George Kalpakas
2fa61e8ee1 build(docs-infra): use pinned dependencies when possible in ng-packages-installer (#28510)
Previously, `ng-packages-installer` would replace the version ranges for
all dependencies that were peer dependencies of an Angular package with
the version range used in the Angular package. This effectively meant
that the pinned version (from `yarn.lock`) for that dependency was
ignored (even if the pinned version satisfied the new version range).

This commit reduces non-determinism in CI jobs using the locally built
Angular packages by always using pinned versions of dependencies for
Angular package peer dependencies if possible.

For example, assuming the following versions for the RxJS dependency:

- **aio/package.json**: `rxjs: ^6.3.0`
- **aio/yarn.lock**: `rxjs@^6.3.0: 6.3.3`
- **@angular/core#peerDependencies**: `rxjs: ^6.0.0`

...the following versions would be used with `ng-packages-installer`:

- Before this commit:
  - **aio/package.json**: `rxjs: ^6.0.0`
  - **node_modules/rxjs/**: `6.4.0` (latest version satisfying `^6.0.0`)
- After this commit:
  - **aio/package.json**: `rxjs: ^6.3.0`
  - **node_modules/rxjs/**: `6.3.3` (because it satisfies `^6.0.0`)

PR Close #28510
2019-03-06 19:14:13 +02:00
George Kalpakas
1eb0bc8ba8 build(docs-infra): keep other dependencies pinned when installing local Angular packages (#28510)
`ng-packages-installer` can be used to replace Angular packages with
locally built ones (from `dist/packages-dist/`) along with their peer
dependencies.

Previously, in order to achieve this, `yarn install` was called with the
`--no-lockfile` option, which resulted in installing the latest versions
of all dependencies (including transitive ones) permitted by the
corresponding version ranges in `package.json` files. As a result, newly
released versions would be picked, resulting in unexpected,
non-deterministic breakages in CI.

This commit calls `yarn install` with the `--pure-lockfile` option
instead. As a result, only the Angular packages (for which the locally
built ones are used) and their peer dependencies are unpinned; the
pinned versions from `yarn.lock` are used for all other (direct and
transitive) dependencies.

While this does not eliminate non-determinism across builds, it
significantly reduces it.

PR Close #28510
2019-03-06 19:05:25 +02:00
George Kalpakas
c2cde43b59 perf(docs-infra): avoid unnecessary I/O operation in ng-packages-installer (#28510)
PR Close #28510
2019-03-06 19:05:05 +02:00
George Kalpakas
bd4a3a88ae refactor(docs-infra): format package.json for readability in ng-packages-installer (#28510)
PR Close #28510
2019-03-06 19:04:35 +02:00
George Kalpakas
6ee866cb77 ci(docs-infra): fix deployment to Firebase
This is a backport of f1a860f to 5.2.x.
Related to #29030.
2019-03-06 18:55:31 +02:00
George Kalpakas
d8b63d0b83 build(compiler-cli): upgrade chokidar to latest version
This is a backport of 745c9c5 to 5.2.x.
Related to #28771.
2019-02-28 18:29:19 +02:00
Pete Bacon Darwin
a065dc24cd fix(compiler): remove bogus lines
These seem to have been added by mistake in
408d8cb735085bec4dcfab17bcf17b66368b98f2
2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
45d90b58b9 ci: add docs-infra as a commit message scope 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
21a9f59ff2 docs(docs-infra): the build.sh script was renamed to create-image.sh 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
1c34e02ae6 ci(docs-infra): rename 'upload-server' to 'preview-server'
The server no longer has files uploaded to it. Instead it is more
accurate to refer to it as dealing with "previews" of PRs.
2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
2f791ce68b ci(docs-infra): add explicit return types to methods 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
e5018c4d77 ci(docs-infra): improve preview-server logging 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
f7b041c7f5 ci(docs-infra): change AIO preview server stuff to pull builds from CircleCI
Previously, Travis pushed the build artitfacts to the preview server.
This required us to use JWT to secure the POST request from Travis, to
ensure we couldn't receive malicious builds.

JWT has been deprecated and we are moving our builds to CircleCI.

This commit rewrites the TypeScript part of the preview server that
handles converting build artifact into hosted previews of the docs.
2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
08c8d7fe56 ci(docs-infra): factor out the aio-builds-setup environment variables 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
98e3ef4003 ci(docs-infra): move the payload-size check to the test job 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
ec3ecfcdf1 ci(docs-infra): add helper scripts for running TDD in Docker 2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
32f67d9161 docs(docs-infra): update the preview server documentation
# Conflicts:
#	aio/aio-builds-setup/docs/vm-setup--start-docker-container.md
2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
55c7430856 ci(docs-infra): move AIO preview deployment to CircleCI
Now instead of pushing the AIO build artifacts to the preview server
from inside a Travis job, the artifacts are built and hosted on the
CircleCI infrastructure. The preview server will then pull these
down after being triggered by a CircleCI build webhook.

# Conflicts:
#	.circleci/config.yml
2018-08-31 09:52:13 -07:00
Pete Bacon Darwin
2a276fcabe ci(docs-infra): update upload-server to run on node.js v10 2018-08-31 09:52:13 -07:00
Alex Rickabaugh
408d8cb735 build: release script should release v5-lts 2018-05-16 15:00:55 -07:00
Alex Rickabaugh
95e9107899 docs: add changelog for 5.2.11 5.2.11 2018-05-16 14:45:13 -07:00
Alex Rickabaugh
ad369903f1 release: cut the 5.2.11 release 2018-05-16 14:40:58 -07:00
George Kalpakas
bc27d4aae4 fix(service-worker): correctly handle requests with empty clientId (#23625)
Requests from clients that are not assigned a client ID by the browser
will produce `fetch` events with `null` or empty (`''`) `clientId`s.

Previously, the ServiceWorker only handled `null` values correctly. Yet
empty strings are also valid (see for example [here][1] and [there][2]).
With this commit, the SW will interpret _all_ falsy `clientId` values
the same (i.e. "no client ID assigned") and handle them appropriately.

Related Chromium issue/discussion: [#832105][3]

[1]: 4cc72bd0f1/docs/index.bs (L1392)
[2]: https://w3c.github.io/ServiceWorker/#fetchevent-interface
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=832105

Fixes #23526

PR Close #23625
2018-05-15 12:11:51 -07:00
George Kalpakas
3df879fe17 test(service-worker): support mock requests with null/empty client ID (#23625)
PR Close #23625
2018-05-15 12:11:51 -07:00
George Kalpakas
b004be5169 test(service-worker): improve adding clients in SwTestHarness (#23625)
This commits changes how clients are added in `SwTestHarness`, so that
the behavior in tests closer mimics what would happen in an actual
ServiceWorker.
It also removes auto-adding clients when calling `clients.get()`, which
could hide bugs related to non-existing clients.

PR Close #23625
2018-05-15 12:11:51 -07:00
Igor Minar
65dba9d0a8 test: fix firebase deployment script test
When I fixed the project id in 2c4850dc582287b7c34d4d26066fe4993638cbf0,
I didn't realize we had a test that verified the wrong behavior.
2018-05-04 15:09:54 -07:00
Igor Minar
354910203e fix(aio): correct project id for deployment of archive sites 2018-05-03 15:08:09 -07:00
Igor Minar
402f452761 docs(aio): add front page campaign for the ng-conf live stream (#23391)
PR Close #23391
2018-04-17 14:15:20 -07:00
Igor Minar
d2e7c99a93 docs: release notes for the 5.2.10 release 5.2.10 2018-04-16 01:21:13 -06:00
Igor Minar
80b9c65667 release: cut the 5.2.10 release 2018-04-16 01:19:21 -06:00
Tiep Phan
c78ae83b5a docs: update lifecycle hooks section in cheatsheet (#23320)
PR Close #23320
2018-04-15 23:44:44 -07:00
systemallica
509d440bce docs(aio): add missing word in the Component metadata section (#23384)
PR Close #23384
2018-04-15 23:36:56 -07:00
HiveSolution
7b23983859 fix(service-worker): add badge to NOTIFICATION_OPTION_NAMES (#23241)
Add badge to NOTIFICATION_OPTION_NAMES to support custom notification badge/icon.
Fixes #23196
PR Close #23241
2018-04-15 23:23:38 -07:00
Rafael
21f3301746 refactor: ensure all 'TODO's are consistent (#23252)
PR Close #23252
2018-04-13 13:12:00 -07:00
George Kalpakas
a3204f87fd test(aio): fix DocViewerComponent tests (#23359)
Obsolete assertions left over from #23249.

PR Close #23359
2018-04-13 08:13:34 -07:00
George Kalpakas
75d1ab9065 refactor(aio): remove file that should not be tracked (#23359)
PR Close #23359
2018-04-13 08:06:19 -07:00
Amit Portnoy
61bddebe65 fix(aio): remove additional 'googlebot' reference (#23249)
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close #23249
2018-04-13 00:35:29 -07:00
Suguru Inatomi
31d95c2cd1 docs(aio): Add link to Japanese localization (#20630)
PR Close #20630
2018-04-13 00:26:13 -07:00
Camilo Giraldo
a1133303d3 refactor(language-service): fix typo on type.ts language-service 2018-04-13 00:08:54 -07:00
Juan Camilo Giraldo Chaverra
c1251a8430 docs(aio): fix typo on AOT compiler section 2018-04-13 00:07:36 -07:00
Jack Twilley
3cf5719435 docs: lock version of in-memory API (#23242)
The in-memory API has been updated for v6 but the Angular CLI has not.

Closes angular/in-memory-web-api#189
Fixes #22977
Fixes #23205

PR Close #23242
2018-04-13 00:01:19 -07:00
Michael Huang
47229fa87b docs(aio): update text InMemoryWebApiModule to HttpClientInMemoryWebApiModule (#23285)
PR Close #23285
2018-04-12 23:17:19 -07:00
Jeremy Attali
dabc076267 docs: fix typo in injected variable name (#23315)
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close #23315
2018-04-12 23:16:53 -07:00
Nathan Friend
af3b308e63 docs(upgrade): fix detail regarding bootstrapping order (#23225) (#23270)
Clarify that Angular should be bootstrapped before AngularJS.

Closes angular/angular#23225

PR Close #23270
2018-04-12 23:16:18 -07:00
Jack Twilley
4ea8b17896 docs: lock version of in-memory API (#23242)
The in-memory API has been updated for v6 but the Angular CLI has not.

Closes angular/in-memory-web-api#189
Fixes #22977
Fixes #23205

PR Close #23242
2018-04-12 22:36:57 -07:00
Igor Minar
c5b6e31d97 build: fix aio size tracking, we need to use node_modules local to aio (#23328)
This fixes an issue introduced by 4f0cae067656fa4563417542297c67030d911a36 which removed firebase from the root node_modules.

PR Close #23328
2018-04-11 23:14:23 -07:00
Igor Minar
22686f8a2f build(aio): fix scripts/test-production.sh file permission issue
it needs to be executable for CI tests to run.
2018-04-10 18:32:56 -07:00
paulmojicatech
bda6908484 docs(core): update directives documentation (#23255)
fix(release): wrong input names in bank-account component

Directive example has errors #22382

PR Close #23255
2018-04-09 15:19:11 -07:00
Anuj Jain
a1231bed9c docs: fixed live example for the lifecycle hooks. (#23201)
PR Close #23201
2018-04-05 16:29:38 -07:00
George Kalpakas
a50ce6568a refactor(aio): remove unused images (#23018)
PR Close #23018
2018-04-05 10:12:10 -07:00