cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,623 Commits 56 Branches 477 Tags
Commit Graph

10623 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vikram Subramanian
0560751381 fix(core): stop reusing provider definitions across NgModuleRef instances (#25088) 
Fixes #25018.

Instantiating a NgModuleRef from NgModuleFactory reuses the NgModuleDefinition if it is already present. However the NgModuleDefinition has a providers array which modified when tree shakable providers are instantiated. This corrupts the provider definitions the next time the same factory is used to create a new NgModuleRef - Two provider definitions can end up with the same index and the injector could potentially return a completely wrong object for a provider token.

This scenario is more likely on the server where the same NgModuleFactory is reused across requests.

The fix clones the cached NgModuleDefinition so that any tree shakable providers added later do not affect the cached copy.

PR Close #25022

PR Close #25088
 2018-07-25 10:16:13 -07:00
Johan CHOUQUET
e32c1b692a docs(animations): typo fix in the comments (#22652) 
PR Close #22652
 2018-07-25 10:13:19 -07:00
Daniel
ae7b96ba13 docs: refactor style guide example 03-06 (#24996) 
docs: refactor style guide example 03-06


docs: refactor style guide example 03-06


docs: refactor style guide example 03-06


PR Close #24996
 2018-07-25 08:04:13 -07:00
Victor Berchet
01b6aad309
Revert "docs: refactor style guide example 03-06 (#24996)" 
This reverts commit 93d325ccd5fe20fd7b3e00d42543da558ef576ce.
 2018-07-24 22:12:19 -07:00
Daniel
40cdab2225 docs: refactor ngmodules example (#25072) 
PR Close #25072
 2018-07-24 21:03:39 -07:00
Daniel
a38127fb47 docs: replace angular/http with HttpClient (#25068) 
PR Close #25068
 2018-07-24 20:54:45 -07:00
Daniel
cd811da672 docs: replace angular/http with HttpClient (#25066) 
PR Close #25066
 2018-07-24 20:51:50 -07:00
Daniel Sogl
76fb905916 docs: replaced old angular/http example (#25065) 
PR Close #25065
 2018-07-24 20:47:20 -07:00
Daniel
93d325ccd5 docs: refactor style guide example 03-06 (#24996) 
PR Close #24996
 2018-07-24 20:46:08 -07:00
Victor Berchet
c7d147eb96 Revert "build: update to newer circleCI bazel remote cache proxy (#25054)" (#25076) 
This reverts commit d6016f1d1d37e9ab6ee3e7725add1bb63e41f7e4.

PR Close #25076
 2018-07-24 16:05:59 -07:00
Stefanie Fluin
70fb65fd00 docs(aio): cleanup aalert, callout, subsection use and author style (#24986) 
PR Close #24986
 2018-07-24 08:22:14 -07:00
Alex Eagle
10863e5817 build: update to newer circleCI bazel remote cache proxy (#25054) 
it fixes the error we currently get on CI

PR Close #25054
 2018-07-24 08:20:28 -07:00
Victor Berchet
5f680d4d6d refactor(common): fix a merge error (#25053) 
A `keyvalue-pipe` was inadvertently pulled in  When merging #25028 (commit
6eca36756). This pipe is NOT in the patch branch and the test fails.

This commit remove the faulty spec.

PR Close #25053
 2018-07-23 20:12:19 -07:00
cexbrayat
6eca36756a
docs: tests for number/percent/currency pipe (#25028) 
Will avoid errors in examples like the one fixed in #24661

Closes #25028
 2018-07-23 13:17:31 -07:00
Alex Eagle
060867dcc4 build: Fix windows tests (#24927) 
closes #24927
 2018-07-23 11:53:19 -07:00
Judy Bogart
4d840cba59 docs: technical review incorporated (#24744) 
closes #24744
 2018-07-23 11:46:16 -07:00
Judy Bogart
0222b5846b docs: add api doc to commonly queried elements 2018-07-23 11:45:31 -07:00
Pete Bacon Darwin
ac52e1a6b6 build(docs-infra): ensure all API headings are sentence cased (#24949) 
Closes #24880

PR Close #24949
 2018-07-23 08:43:08 -07:00
Arun Kumar
7f3a5ec741 docs: square odds example in rxjs guide (#24947) 
Added argument type to filter function of rxjs. Fixed the
return value of filtering of odd numbers

PR Close #24947
 2018-07-23 08:41:58 -07:00
Mateusz Karkula
ac7658e1b9 docs: fix multicasting example in observable guide (#24911) 
PR Close #24911
 2018-07-23 08:40:46 -07:00
Maicon Wagner
dc0340c79e docs: add Truly-UI to resources (#24615) 
PR Close #24615
 2018-07-23 08:39:35 -07:00
Dario Braun
6a74ef0fbc docs: fix instructions for switching directories (#24439) 
docs: fix instructions for switching directories


PR Close #24439
 2018-07-23 08:38:10 -07:00
Kelly Marchewa
68df0d2c26 docs: update rxjs link to version 6 (#24269) 
PR Close #24269
 2018-07-23 08:36:51 -07:00
Daniel
d3656bcecc docs: refactor style guide example 01-01 (#22738) 
docs: refactor style guide example 01-01


PR Close #22738
 2018-07-23 08:35:38 -07:00
Alex Eagle
4834fdaf59 fix(service-worker): don't include sourceMappingURL in ngsw-worker (#24877) 
Fixes #23596

PR Close #24877
 2018-07-20 11:49:46 -07:00
Judy Bogart
f2aeb703de docs: fix bad link (#24825) 
PR Close #24825
 2018-07-20 11:34:39 -07:00
Xapuu
5a1ca35bc4 docs: remove closing parenthesis from provides guide (#24935) 
PR Close #24935
 2018-07-20 11:07:54 -07:00
George Kalpakas
2a5a05b28b fix(docs-infra): fix table header layout in API pages (#24919) 
PR Close #24919
 2018-07-20 10:48:43 -07:00
George Kalpakas
4a29100ac8 test(platform-webworker): avoid flakes due to existing PlatformRef (#24916) 
PR Close #24916
 2018-07-20 10:47:17 -07:00
Marius Lichtblau
39afb01510 docs: update i18n with requested changes (#24875) 
use more general project name in code example

PR Close #24875
 2018-07-20 10:36:13 -07:00
Marius Lichtblau
7229899396 docs: update i18n doc regarding aot compilation (#24875) 
Add missing lines to code example to allow using ng serve with custom i18n configurations.

PR Close #24875
 2018-07-20 10:36:13 -07:00
George Kalpakas
740ab7cdcf build(docs-infra): add support for examples of type elements (#24840) 
Examples using `@angular/elements` need to transpile to es2015 for
Custom Elements to work (on browsers that natively support them).

Alternatively, a polyfill would need to be loaded. For now, changing the
transpilation target to es2015 is the simplest solution.

PR Close #24840
 2018-07-20 10:34:48 -07:00
Jan De Wilde
e22abb4d98 docs: add e2e tests for elements example (#24840) 
PR Close #24840
 2018-07-20 10:34:48 -07:00
Jan De Wilde
a5f100947a docs: fix elements example (#24840) 
PR Close #24840
 2018-07-20 10:34:48 -07:00
George Kalpakas
731ceee440 docs: refactor elements example (#24840) 
This makes the closing behavior more deterministic, which makes it
easier to be e2e-tested.

PR Close #24840
 2018-07-20 10:34:48 -07:00
George Kalpakas
7a87680710 docs: clean up elements example (indentation, import order, etc) (#24840) 
PR Close #24840
 2018-07-20 10:34:47 -07:00
cexbrayat
ae0fce613f docs: more info on currency digits (#24661) 
Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
which will format the amount with no digits if `digitsInfo` is not provided:

    <!-- outputs CA$14.00 -->
    {{ 14 | currency:'CAD' }}
    <!-- outputs CLP14 -->
    {{ 14 | currency:'CLP' }}

Amends the docs, adds an example and fix an error with a current example.

PR Close #24661
 2018-07-20 10:33:07 -07:00
Raphaël Jamet
422de27601 docs: Add notes on manual sanitization to security guide (#24176) 
Some users have remarked that we don't explain how to manually call
sanitization, so add a few lines on that.

PR Close #24176
 2018-07-20 10:27:12 -07:00
Victor Berchet
28de0c7cb9 ci: remove Tina from pullaprove (#25006) 
She has been removed as a collaborator to the project and pullaprove rejects
this config file which still lists her name.

PR Close #25006
 2018-07-20 10:25:52 -07:00
Brandon Roberts
6b32622e18 docs: add new Reactive Forms guide (#24578) 
PR Close #24578
 2018-07-19 13:46:31 -04:00
Jamie Krug
6731c3daba docs: fix typo in user input guide (#22630) 
PR Close #22630
 2018-07-18 14:04:10 -04:00
cexbrayat
0cbef9a073 docs: typos in directives docs (#24665) 
Fixes some typos introduced by #23902

PR Close #24665
 2018-07-17 16:45:18 -04:00
Carlos Ortiz Garcia
e97d961234 fix(compiler): i18n_extractor now outputs the correct source file name (#24885) 
for non-inline templates

- Non-inline templates used to ouput the path to the component TS file
instead of the path to the original HTML file.
- Inline templates keep the same behavior.

Fixes #24884

PR Close #24885
 2018-07-16 16:09:01 -04:00
Matias Niemelä
d42a6623fb build: disable IE web worker tests (#24908) 
Travis (saucelabs) has been super flaky when running IE
web worker tests lately. This patch temporarily disables
these tests on IE (not edge) until things get more stable.

PR Close #24908
 2018-07-16 16:07:57 -04:00
Pete Bacon Darwin
1f163cd1d6 feat(docs-infra): enable filtering by package on API list page (#24631) 
PR Close #24631
 2018-07-13 19:45:55 -04:00
Pete Bacon Darwin
6d690b5daa build(docs-infra): implement the 'package' API template (#24631) 
PR Close #24631
 2018-07-13 19:45:55 -04:00
Alex Eagle
15df5f749a build: update to Bazel 0.15 (#24841) 
PR Close #24841
 2018-07-13 15:05:17 -04:00
Dario Braun
e295206965 docs: update component styles doc regarding relative URL (#24471) 
Update the documentation to match the CLI mechanics regarding relative URL in link tags.
docs: update info on stylesheet location for CLI


PR Close #24471
 2018-07-12 16:44:01 -04:00
George Kalpakas
0e7501b47a build: fix windows scripts (#23121) 
The `packages/core/src/animation/dsl.ts` symlink ws removed in #22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.

PR Close #23121
 2018-07-12 16:42:56 -04:00
Alain Chautard
6bf8aefe7a docs(aio): Add Angular Training to list of training companies (#23907) 
PR Close #23907
 2018-07-12 16:39:56 -04:00