9612 Commits

Author SHA1 Message Date
Pete Bacon Darwin
2a276fcabe ci(docs-infra): update upload-server to run on node.js v10 2018-08-31 09:52:13 -07:00
Alex Rickabaugh
408d8cb735 build: release script should release v5-lts 2018-05-16 15:00:55 -07:00
Alex Rickabaugh
95e9107899 docs: add changelog for 5.2.11 5.2.11 2018-05-16 14:45:13 -07:00
Alex Rickabaugh
ad369903f1 release: cut the 5.2.11 release 2018-05-16 14:40:58 -07:00
George Kalpakas
bc27d4aae4 fix(service-worker): correctly handle requests with empty clientId (#23625)
Requests from clients that are not assigned a client ID by the browser
will produce `fetch` events with `null` or empty (`''`) `clientId`s.

Previously, the ServiceWorker only handled `null` values correctly. Yet
empty strings are also valid (see for example [here][1] and [there][2]).
With this commit, the SW will interpret _all_ falsy `clientId` values
the same (i.e. "no client ID assigned") and handle them appropriately.

Related Chromium issue/discussion: [#832105][3]

[1]: 4cc72bd0f1/docs/index.bs (L1392)
[2]: https://w3c.github.io/ServiceWorker/#fetchevent-interface
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=832105

Fixes #23526

PR Close #23625
2018-05-15 12:11:51 -07:00
George Kalpakas
3df879fe17 test(service-worker): support mock requests with null/empty client ID (#23625)
PR Close #23625
2018-05-15 12:11:51 -07:00
George Kalpakas
b004be5169 test(service-worker): improve adding clients in SwTestHarness (#23625)
This commits changes how clients are added in `SwTestHarness`, so that
the behavior in tests closer mimics what would happen in an actual
ServiceWorker.
It also removes auto-adding clients when calling `clients.get()`, which
could hide bugs related to non-existing clients.

PR Close #23625
2018-05-15 12:11:51 -07:00
Igor Minar
65dba9d0a8 test: fix firebase deployment script test
When I fixed the project id in 2c4850dc582287b7c34d4d26066fe4993638cbf0,
I didn't realize we had a test that verified the wrong behavior.
2018-05-04 15:09:54 -07:00
Igor Minar
354910203e fix(aio): correct project id for deployment of archive sites 2018-05-03 15:08:09 -07:00
Igor Minar
402f452761 docs(aio): add front page campaign for the ng-conf live stream (#23391)
PR Close #23391
2018-04-17 14:15:20 -07:00
Igor Minar
d2e7c99a93 docs: release notes for the 5.2.10 release 5.2.10 2018-04-16 01:21:13 -06:00
Igor Minar
80b9c65667 release: cut the 5.2.10 release 2018-04-16 01:19:21 -06:00
Tiep Phan
c78ae83b5a docs: update lifecycle hooks section in cheatsheet (#23320)
PR Close #23320
2018-04-15 23:44:44 -07:00
systemallica
509d440bce docs(aio): add missing word in the Component metadata section (#23384)
PR Close #23384
2018-04-15 23:36:56 -07:00
HiveSolution
7b23983859 fix(service-worker): add badge to NOTIFICATION_OPTION_NAMES (#23241)
Add badge to NOTIFICATION_OPTION_NAMES to support custom notification badge/icon.
Fixes #23196
PR Close #23241
2018-04-15 23:23:38 -07:00
Rafael
21f3301746 refactor: ensure all 'TODO's are consistent (#23252)
PR Close #23252
2018-04-13 13:12:00 -07:00
George Kalpakas
a3204f87fd test(aio): fix DocViewerComponent tests (#23359)
Obsolete assertions left over from #23249.

PR Close #23359
2018-04-13 08:13:34 -07:00
George Kalpakas
75d1ab9065 refactor(aio): remove file that should not be tracked (#23359)
PR Close #23359
2018-04-13 08:06:19 -07:00
Amit Portnoy
61bddebe65 fix(aio): remove additional 'googlebot' reference (#23249)
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close #23249
2018-04-13 00:35:29 -07:00
Suguru Inatomi
31d95c2cd1 docs(aio): Add link to Japanese localization (#20630)
PR Close #20630
2018-04-13 00:26:13 -07:00
Camilo Giraldo
a1133303d3 refactor(language-service): fix typo on type.ts language-service 2018-04-13 00:08:54 -07:00
Juan Camilo Giraldo Chaverra
c1251a8430 docs(aio): fix typo on AOT compiler section 2018-04-13 00:07:36 -07:00
Jack Twilley
3cf5719435 docs: lock version of in-memory API (#23242)
The in-memory API has been updated for v6 but the Angular CLI has not.

Closes angular/in-memory-web-api#189
Fixes #22977
Fixes #23205

PR Close #23242
2018-04-13 00:01:19 -07:00
Michael Huang
47229fa87b docs(aio): update text InMemoryWebApiModule to HttpClientInMemoryWebApiModule (#23285)
PR Close #23285
2018-04-12 23:17:19 -07:00
Jeremy Attali
dabc076267 docs: fix typo in injected variable name (#23315)
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close #23315
2018-04-12 23:16:53 -07:00
Nathan Friend
af3b308e63 docs(upgrade): fix detail regarding bootstrapping order (#23225) (#23270)
Clarify that Angular should be bootstrapped before AngularJS.

Closes angular/angular#23225

PR Close #23270
2018-04-12 23:16:18 -07:00
Jack Twilley
4ea8b17896 docs: lock version of in-memory API (#23242)
The in-memory API has been updated for v6 but the Angular CLI has not.

Closes angular/in-memory-web-api#189
Fixes #22977
Fixes #23205

PR Close #23242
2018-04-12 22:36:57 -07:00
Igor Minar
c5b6e31d97 build: fix aio size tracking, we need to use node_modules local to aio (#23328)
This fixes an issue introduced by 4f0cae067656fa4563417542297c67030d911a36 which removed firebase from the root node_modules.

PR Close #23328
2018-04-11 23:14:23 -07:00
Igor Minar
22686f8a2f build(aio): fix scripts/test-production.sh file permission issue
it needs to be executable for CI tests to run.
2018-04-10 18:32:56 -07:00
paulmojicatech
bda6908484 docs(core): update directives documentation (#23255)
fix(release): wrong input names in bank-account component

Directive example has errors #22382

PR Close #23255
2018-04-09 15:19:11 -07:00
Anuj Jain
a1231bed9c docs: fixed live example for the lifecycle hooks. (#23201)
PR Close #23201
2018-04-05 16:29:38 -07:00
George Kalpakas
a50ce6568a refactor(aio): remove unused images (#23018)
PR Close #23018
2018-04-05 10:12:10 -07:00
George Kalpakas
baa444ba7d docs(aio): update live-example docs in authors style guide (#23018)
PR Close #23018
2018-04-05 10:12:10 -07:00
George Kalpakas
73172dd67a ci(aio): upload the preview before checking the bundle sizes (#23123)
This makes the preview available even if the bundle sizes are out of
limits.

PR Close #23123
2018-04-05 10:11:00 -07:00
George Kalpakas
8aa49ac6d7 fix(aio): update trusted GitHub teams (angular-core --> team) (#23181)
PR Close #23181
2018-04-05 10:07:14 -07:00
Pawel Kozlowski
3900c36b1c refactor(common): simplify NgClass code, add comments (#21937)
PR Close #21937
2018-04-04 09:41:18 -07:00
Pawel Kozlowski
54e910841e fix(common): properly take className changes into account (#21937)
Fixes #21932

PR Close #21937
2018-04-04 09:41:18 -07:00
Steven Liekens
9703079e0b test(router): fix typo in expectation (#23137)
PR Close #23137
2018-04-04 08:22:05 -07:00
Dirk Luijk
dd615950d5 fix(forms): improve error message for invalid value accessors (#22731)
Signed-off-by: Dirk Luijk <mail@dirkluijk.nl>

PR Close #22731
2018-04-04 08:20:56 -07:00
Jason Bedard
ae76eeca6a fix(upgrade): propagate return value of resumeBootstrap (#22754)
Fixes #22723

PR Close #22754
2018-04-02 14:20:59 -07:00
Shannon Dunn
f43fba64cc fix(upgrade): correctly handle downgraded OnPush components (#22209)
Fixes #14286

PR Close #22209
2018-04-02 14:12:46 -07:00
George Kalpakas
4473da7de7 ci(aio): add monitoring for angular.io (#23093)
This commit configures a periodic job to be run on CircleCI, performing several
checks against the actual apps deployed to production (https://angular.io) and
staging (https://next.angular.io).

Fixes #21942

PR Close #23093
2018-03-30 15:27:21 -07:00
George Kalpakas
55eaeb17d9 fix(aio): fix SW routing RegExp to allow redirecting /api/animate URLs (#23093)
PR Close #23093
2018-03-30 15:27:21 -07:00
George Kalpakas
0614b2b941 refactor(aio): move deployment config tests and helpers around (#23093)
This commit prepares the ground for adding different types of tests.

PR Close #23093
2018-03-30 15:27:21 -07:00
George Kalpakas
650c6e56ec fix(aio): wait for the app to stabilize before registering the SW (#23093)
This commit also waits for the app to stabilize, before starting to
check for ServiceWorker updates. This avoids setting up a long timeout,
which would prevent the app from stabilizing and thus cause issues with
Protractor.

PR Close #23093
2018-03-30 15:27:21 -07:00
Victor Berchet
4f7c369847 fix(compiler): fix support for html-like text in translatable attributes (#23053)
PR Close #23053
2018-03-29 08:58:29 -07:00
Teamop
e7b2e97b46 style(aio): fix typo in the scrollbar (#23064)
PR Close #23064
2018-03-29 08:57:43 -07:00
George Kalpakas
0d4fe38a09 fix(service-worker): ignore invalid only-if-cached requests (#22883)
Under some circumstances (possibly related to opening Chrome DevTools),
requests are made with `cache: 'only-if-cached'` and `mode: 'no-cors'`.
These request will eventually fail, because `only-if-cached` is only
allowed to be used with `mode: 'same-origin'`.
This is likely a bug in Chrome DevTools.

This commit avoids errors related to such requests by not handling them.

Fixes #22362

PR Close #22883
2018-03-28 10:02:18 -07:00
George Kalpakas
ae9c25ff3d fix(service-worker): do not enter degraded mode when offline (#22883)
Previously, when trying to fetch `ngsw.json` (e.g. during
`checkForUpdate()`) while either the client or the server were offline,
the ServiceWorker would enter a degrade mode, where only existing
clients would be served. This essentially meant that the ServiceWorker
didn't work offline.
This commit fixes it by differentiating offline errors and not entering
degraded mode. The ServiceWorker will remain in the current mode until
connectivity to the server is restored.

Fixes #21636

PR Close #22883
2018-03-28 10:02:18 -07:00
George Kalpakas
d0f575bc54 test(service-worker): minor test fixes and refactorings (#22883)
PR Close #22883
2018-03-28 10:02:18 -07:00