docs(changelog): add changelog for 2.4.7

PR Close #14314

.bazelrc

@@ -1,6 +0,0 @@
-# Disable sandboxing because it's too slow.
-# https://github.com/bazelbuild/bazel/issues/2424
-build --spawn_strategy=standalone
-
-# Performance: avoid stat'ing input files
-build --watchfs

.circleci/config.yml

@@ -1,55 +0,0 @@
-# Configuration file for https://circleci.com/gh/angular/angular
-
-# Note: YAML anchors allow an object to be re-used, reducing duplication.
-# The ampersand declares an alias for an object, then later the `<<: *name`
-# syntax dereferences it.
-# See http://blog.daemonl.com/2016/02/yaml.html
-# To validate changes, use an online parser, eg.
-# http://yaml-online-parser.appspot.com/
-
-# Settings common to each job
-anchor_1: &job_defaults
-  working_directory: ~/ng
-  docker:
-    - image: angular/ngcontainer:0.0.2
-
-# After checkout, rebase on top of master.
-# Similar to travis behavior, but not quite the same.
-# See https://discuss.circleci.com/t/1662
-anchor_2: &post_checkout
-  post: git pull --ff-only origin "refs/pull/${CI_PULL_REQUEST//*pull\//}/merge"
-
-version: 2
-jobs:
-  lint:
-    <<: *job_defaults
-    steps:
-      - checkout:
-          <<: *post_checkout
-      - restore_cache:
-          key: angular-{{ .Branch }}-{{ checksum "yarn.lock" }}
-
-      - run: yarn install --freeze-lockfile --non-interactive
-      - run: ./node_modules/.bin/gulp lint
-
-  build:
-    <<: *job_defaults
-    steps:
-      - checkout:
-          <<: *post_checkout
-      - restore_cache:
-          key: angular-{{ .Branch }}-{{ checksum "yarn.lock" }}
-
-      - run: bazel run @yarn//:yarn
-      - run: bazel build ...
-      - save_cache:
-          key: angular-{{ .Branch }}-{{ checksum "yarn.lock" }}
-          paths:
-            - "node_modules"
-
-workflows:
-  version: 2
-  default_workflow:
-    jobs:
-      - lint
-      - build

.github/ISSUE_TEMPLATE.md

@@ -1,57 +1,39 @@
 <!--
-PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
-
-ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
+IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING
 -->
 
-## I'm submitting a...
-<!-- Check one of the following options with "x" -->
-<pre><code>
-[ ] Regression (a behavior that used to work and stopped working in a new release)
-[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
-[ ] Feature request
-[ ] Documentation issue or request
-[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
-</code></pre>
+**I'm submitting a ...**  (check one with "x")
+```
+[ ] bug report => search github for a similar issue or PR before submitting
+[ ] feature request
+[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
+```
 
-## Current behavior
-<!-- Describe how the issue manifests. -->
+**Current behavior**
+<!-- Describe how the bug manifests. -->
 
+**Expected behavior**
+<!-- Describe what the behavior would be without the bug. -->
 
-## Expected behavior
-<!-- Describe what the desired behavior would be. -->
-
-
-## Minimal reproduction of the problem with instructions
+**Minimal reproduction of the problem with instructions**
 <!--
-For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
+If the current behavior is a bug or you can illustrate your feature request better with an example, 
+please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
 https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
 -->
 
-## What is the motivation / use case for changing the behavior?
-<!-- Describe the motivation or the concrete use case. -->
+**What is the motivation / use case for changing the behavior?**
+<!-- Describe the motivation or the concrete use case -->
 
+**Please tell us about your environment:**
+<!-- Operating system, IDE, package manager, HTTP server, ... -->
 
-## Environment
-
-<pre><code>
-Angular version: X.Y.Z
+* **Angular version:** 2.0.X
 <!-- Check whether this is still an issue in the most recent Angular version -->
 
-Browser:
-- [ ] Chrome (desktop) version XX
-- [ ] Chrome (Android) version XX
-- [ ] Chrome (iOS) version XX
-- [ ] Firefox version XX
-- [ ] Safari (desktop) version XX
-- [ ] Safari (iOS) version XX
-- [ ] IE version XX
-- [ ] Edge version XX
+* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
+<!-- All browsers where this could be reproduced -->
  
-For Tooling issues:
-- Node version: XX  <!-- run `node --version` -->
-- Platform:  <!-- Mac, Linux, Windows -->
+* **Language:** [all | TypeScript X.X | ES6/7 | ES5]
 
-Others:
-<!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
-</code></pre>
+* **Node (for AoT issues):** `node --version` =   

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,10 @@
-## PR Checklist
-Please check if your PR fulfills the following requirements:
-
+**Please check if the PR fulfills these requirements**
 - [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
 - [ ] Tests for the changes have been added (for bug fixes / features)
 - [ ] Docs have been added / updated (for bug fixes / features)
 
 
-## PR Type
-What kind of change does this PR introduce?
-
-<!-- Please check the one that applies to this PR using "x". -->
+**What kind of change does this PR introduce?** (check one with "x")
 ```
 [ ] Bugfix
 [ ] Feature
@@ -17,27 +12,25 @@ What kind of change does this PR introduce?
 [ ] Refactoring (no functional changes, no api changes)
 [ ] Build related changes
 [ ] CI related changes
-[ ] Documentation content changes
-[ ] angular.io application / infrastructure changes
 [ ] Other... Please describe:
 ```
 
-## What is the current behavior?
-<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
-
-Issue Number: N/A
+**What is the current behavior?** (You can also link to an open issue here)
 
 
-## What is the new behavior?
+
+**What is the new behavior?**
 
 
-## Does this PR introduce a breaking change?
+
+**Does this PR introduce a breaking change?** (check one with "x")
 ```
 [ ] Yes
 [ ] No
 ```
 
-<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
+If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
 
 
-## Other information
+**Other information**:
+

.gitignore

@@ -1,8 +1,6 @@
 .DS_STORE
 
 /dist/
-bazel-*
-e2e_test.*
 node_modules
 bower_components
 
@@ -19,9 +17,8 @@ modules/.vscode
 # Don't check in secret files
 *secret.js
 
-# Ignore npm/yarn debug log
+# Ignore npm debug log
 npm-debug.log
-yarn-error.log
 
 # build-analytics
 .build-analytics

.mailmap

@@ -1 +0,0 @@
-Michał Gołębiowski-Owczarek <m.goleb@gmail.com>

.nvmrc

@@ -1 +1 @@
-6.9.5
+6.6.0

.pullapprove.yml

@@ -8,11 +8,8 @@
 # alexeagle - Alex Eagle
 # alxhub - Alex Rickabaugh
 # chuckjaz - Chuck Jazdzewski
-# Foxandxss - Jesús Rodríguez
 # gkalpak - George Kalpakas
 # IgorMinar - Igor Minar
-# jasonaden - Jason Aden
-# juleskremer - Jules Kremer
 # kara - Kara Erickson
 # matsko - Matias Niemelä
 # mhevery - Misko Hevery
@@ -20,11 +17,8 @@
 # pkozlowski-opensource - Pawel Kozlowski
 # robwormald - Rob Wormald
 # tbosch - Tobias Bosch
-# tinayuangao - Tina Gao
 # vicb - Victor Berchet
 # vikerman - Vikram Subramanian
-# wardbell - Ward Bell
-
 
 version: 2
 
@@ -42,10 +36,9 @@ groups:
         include:
           - "*"
         exclude:
-          - "aio/*"
+          - "angular.io/*"
           - "integration/*"
           - "modules/*"
-          - "packages/*"
           - "tools/*"
     users:
       - IgorMinar
@@ -71,12 +64,9 @@ groups:
         exclude:
           - "tools/@angular/tsc-wrapped/*"
           - "tools/public_api_guard/*"
-          - "aio/*"
     users:
       - IgorMinar #primary
-      - alexeagle
-      - jasonaden
-      - mhevery #fallback
+      - mhevery
 
   integration:
     conditions:
@@ -93,29 +83,27 @@ groups:
   core:
     conditions:
       files:
-        - "packages/core/*"
+        - "modules/@angular/core/*"
     users:
       - tbosch #primary
-      - chuckjaz
       - mhevery
       - vicb
       - IgorMinar #fallback
 
-  animations:
+  compiler/animations:
     conditions:
       files:
-        - "packages/animations/*"
-        - "packages/platform-browser/animations/*"
+        - "modules/@angular/compiler/src/animation/*"
     users:
       - matsko #primary
-      - chuckjaz #fallback
-      - mhevery #fallback
+      - tbosch
       - IgorMinar #fallback
+      - mhevery #fallback
 
   compiler/i18n:
     conditions:
       files:
-        - "packages/compiler/src/i18n/*"
+        - "modules/@angular/compiler/src/i18n/*"
     users:
       - vicb #primary
       - tbosch
@@ -125,11 +113,9 @@ groups:
   compiler:
     conditions:
       files:
-        - "packages/compiler/*"
+        - "modules/@angular/compiler/*"
     users:
       - tbosch #primary
-      - vicb
-      - chuckjaz
       - mhevery
       - IgorMinar #fallback
 
@@ -137,11 +123,10 @@ groups:
     conditions:
       files:
         - "tools/@angular/tsc-wrapped/*"
-        - "packages/compiler-cli/*"
+        - "modules/@angular/compiler-cli/*"
     users:
       - alexeagle
       - chuckjaz
-      - vicb
       - tbosch
       - IgorMinar #fallback
       - mhevery #fallback
@@ -149,7 +134,7 @@ groups:
   common:
     conditions:
       files:
-        - "packages/common/*"
+        - "modules/@angular/common/*"
     users:
       - pkozlowski-opensource #primary
       - vicb
@@ -159,17 +144,17 @@ groups:
   forms:
     conditions:
       files:
-        - "packages/forms/*"
+        - "modules/@angular/forms/*"
     users:
       - kara #primary
-      - tinayuangao #secondary
+      # needs secondary
       - IgorMinar #fallback
       - mhevery #fallback
 
   http:
     conditions:
       files:
-        - "packages/http/*"
+        - "modules/@angular/http/*"
     users:
       - vikerman #primary
       - alxhub
@@ -179,28 +164,27 @@ groups:
   language-service:
     conditions:
       files:
-        - "packages/language-service/*"
+        - "modules/@angular/language-service/*"
     users:
       - chuckjaz #primary
-      - tbosch #secondary
-      - vicb
+      # needs secondary
       - IgorMinar #fallback
       - mhevery #fallback
 
   router:
     conditions:
       files:
-        - "packages/router/*"
+        - "modules/@angular/router/*"
     users:
-      - jasonaden
-      - vicb
+      - vicb #primary
+      # needs secondary
       - IgorMinar #fallback
       - mhevery #fallback
 
   upgrade:
     conditions:
       files:
-        - "packages/upgrade/*"
+        - "modules/@angular/upgrade/*"
     users:
       - petebacondarwin #primary
       - gkalpak
@@ -210,32 +194,30 @@ groups:
   platform-browser:
     conditions:
       files:
-        - "packages/platform-browser/*"
+        - "modules/@angular/platform-browser/*"
     users:
       - tbosch #primary
-      - vicb #secondary
+      - vicb
       - IgorMinar #fallback
       - mhevery #fallback
 
   platform-server:
     conditions:
       files:
-        - "packages/platform-server/*"
+        - "modules/@angular/platform-server/*"
     users:
       - vikerman #primary
       - alxhub
-      - vicb
-      - tbosch
       - IgorMinar #fallback
       - mhevery #fallback
 
   platform-webworker:
     conditions:
       files:
-        - "packages/platform-webworker/*"
+        - "modules/@angular/platform-webworker/*"
     users:
       - vicb #primary
-      - tbosch #secondary
+      # needs secondary
       - IgorMinar #fallback
       - mhevery #fallback
 
@@ -244,7 +226,7 @@ groups:
   benchpress:
     conditions:
       files:
-        - "packages/benchpress/*"
+        - "modules/@angular/benchpress/*"
     users:
       - tbosch #primary
       # needs secondary
@@ -254,46 +236,9 @@ groups:
   angular.io:
     conditions:
       files:
-        include:
-          - "aio/*"
-        exclude:
-          - "aio/content/*"
+        - "angular.io/*"
     users:
-      - petebacondarwin #primary
       - IgorMinar
-      - gkalpak
-      - mhevery #fallback
-
-  angular.io-guide-and-tutorial:
-    conditions:
-      files:
-        include:
-          - "aio/content/*"
-        exclude:
-          - "aio/content/marketing/*"
-          - "aio/content/navigation.json"
-          - "aio/content/license.md"
-    users:
-      - juleskremer #primary
-      - Foxandxss
-      - stephenfluin
-      - wardbell
+      - robwormald
       - petebacondarwin
-      - gkalpak
-      - IgorMinar #fallback
-      - mhevery #fallback
-
-  angular.io-marketing:
-    conditions:
-      files:
-        include:
-          - "aio/content/marketing/*"
-          - "aio/content/navigation.json"
-          - "aio/content/license.md"
-    users:
-      - juleskremer #primary
-      - stephenfluin
-      - petebacondarwin
-      - gkalpak
-      - IgorMinar #fallback
       - mhevery #fallback

.travis.yml

@@ -1,64 +1,42 @@
 language: node_js
 sudo: false
-# force trusty as Google Chrome addon is not supported on Precise
-dist: trusty
 node_js:
-  - '6.9.5'
+  - '6.6.0'
+git:
+  # Increased from default (50) to ensure last release tag is in this range
+  depth: 150
 
 addons:
-  chrome: stable
 #  firefox: "38.0"
   apt:
     sources:
       # needed to install g++ that is used by npms's native modules
       - ubuntu-toolchain-r-test
     packages:
-      # needed to install g++ that is used by npms's native modules
       - g++-4.8
-  # https://docs.travis-ci.com/user/jwt
-  jwt:
-    # SAUCE_ACCESS_KEY<=secret for NGBUILDS_IO_KEY to work around travis-ci/travis-ci#7223, unencrypted value in valentine as NGBUILDS_IO_KEY>
-    # we alias NGBUILDS_IO_KEY to $SAUCE_ACCESS_KEY in env.sh and set the SAUCE_ACCESS_KEY there
-    - secure: "L7nrZwkAtFtYrP2DykPXgZvEKjkv0J/TwQ/r2QGxFTaBq4VZn+2Dw0YS7uCxoMqYzDwH0aAOqxoutibVpk8Z/16nE3tNmU5RzltMd6Xmt3qU2f/JDQLMo6PSlBodnjOUsDHJgmtrcbjhqrx/znA237BkNUu6UZRT7mxhXIZpn0U="
+
 branches:
   except:
-    - g3
+    - g3_v2_0
 
 cache:
-  yarn: true
   directories:
      - ./node_modules
      - ./.chrome/chromium
-     - ./aio/node_modules
 
 env:
   global:
-    # GITHUB_TOKEN_ANGULAR=<github token, a personal access token of the angular-builds account, account access in valentine>
+    # GITHUB_TOKEN_ANGULAR
     # This is needed for the e2e Travis matrix task to publish packages to github for continuous packages delivery.
-    - secure: "aCdHveZuY8AT4Jr1JoJB4LxZsnGWRe/KseZh1YXYe5UtufFCtTVHvUcLn0j2aLBF0KpdyS+hWf0i4np9jthKu2xPKriefoPgCMpisYeC0MFkwbmv+XlgkUbgkgVZMGiVyX7DCYXVahxIoOUjVMEDCbNiHTIrfEuyq24U3ok2tHc="
-    # FIREBASE_TOKEN
-    # This is needed for publishing builds to the "aio-staging" and "angular-io" firebase projects.
-    # This token was generated using the aio-deploy@angular.io account using `firebase login:ci` and password from valentine
-    - secure: "L5CyQmpwWtoR4Qi4xlWQh/cL1M6ZeJL4W4QAr4HdKFMgYt9h+Whqkymyh2NxwmCbPvWa7yUd+OiLQUDCY7L2VIg16hTwoe2CgYDyQA0BEwLzxtRrJXl93TfwMlrUx5JSIzAccD6D4sjtz8kSFMomK2Nls33xOXOukwyhVMjd0Cg="
-    # ANGULAR_PAYLOAD_FIREBASE_TOKEN
-    # This is for payload size data to "angular-payload-size" firebase project
-    # This token was generated using the payload@angular.io account using `firebase login:ci` and password from valentine
-    - secure: "SxotP/ymNy6uWAVbfwM9BlwETPEBpkRvU/F7fCtQDDic99WfQHzzUSQqHTk8eKk3GrGAOSL09vT0WfStQYEIGEoS5UHWNgOnelxhw+d5EnaoB8vQ0dKQBTK092hQg4feFprr+B/tCasyMV6mVwpUzZMbIJNn/Rx7H5g1bp+Gkfg="
+    - secure: "fq/U7VDMWO8O8SnAQkdbkoSe2X92PVqg4d044HmRYVmcf6YbO48+xeGJ8yOk0pCBwl3ISO4Q2ot0x546kxfiYBuHkZetlngZxZCtQiFT9kyId8ZKcYdXaIW9OVdw3Gh3tQyUwDucfkVhqcs52D6NZjyE2aWZ4/d1V4kWRO/LMgo="
   matrix:
     # Order: a slower build first, so that we don't occupy an idle travis worker waiting for others to complete.
-    - CI_MODE=e2e
-    - CI_MODE=e2e_2
-    - CI_MODE=js
-    - CI_MODE=saucelabs_required
-    # deactivated, see #19768
-    # - CI_MODE=browserstack_required
-    - CI_MODE=saucelabs_optional
-    - CI_MODE=browserstack_optional
-    - CI_MODE=aio_tools_test
-    - CI_MODE=aio
-    - CI_MODE=aio_e2e AIO_SHARD=0
-    - CI_MODE=aio_e2e AIO_SHARD=1
-    - CI_MODE=bazel
+   - CI_MODE=js
+   - CI_MODE=e2e
+   - CI_MODE=saucelabs_required
+   - CI_MODE=browserstack_required
+   - CI_MODE=saucelabs_optional
+   - CI_MODE=browserstack_optional
 
 matrix:
   fast_finish: true
@@ -66,19 +44,11 @@ matrix:
     - env: "CI_MODE=saucelabs_optional"
     - env: "CI_MODE=browserstack_optional"
 
-before_install:
-  # source the env.sh script so that the exported variables are available to other scripts later on
-  - source ./scripts/ci/env.sh print
-
 install:
-  - ./scripts/ci/install.sh
+  - ./scripts/ci-lite/install.sh
 
 script:
-  - ./scripts/ci/build.sh
-  - ./scripts/ci/test.sh
-  # deploy is part of 'script' and not 'after_success' so that we fail the build if the deployment fails
-  - ./scripts/ci/deploy.sh
-  - ./scripts/ci/angular.sh
-  # all the scripts under this line will not quickly abort in case ${TRAVIS_TEST_RESULT} is 1 (job failure)
-  - ./scripts/ci/cleanup.sh
-  - ./scripts/ci/print-logs.sh
+  - ./scripts/ci-lite/build.sh && ./scripts/ci-lite/test.sh
+
+after_script:
+  - ./scripts/ci-lite/cleanup.sh

BUILD.bazel

@@ -1,25 +0,0 @@
-package(default_visibility = ["//visibility:public"])
-exports_files(["tsconfig.json"])
-
-# This rule belongs in node_modules/BUILD
-# It's here as a workaround for
-# https://github.com/bazelbuild/bazel/issues/374#issuecomment-296217940
-filegroup(
-    name = "node_modules",
-    srcs = glob([
-        # Performance workaround: list individual files
-        # This won't scale in the general case.
-        # TODO(alexeagle): figure out what to do
-        "node_modules/typescript/**",
-        "node_modules/zone.js/**",
-        "node_modules/rxjs/**/*.d.ts",
-        "node_modules/rxjs/**/*.js",
-        "node_modules/@types/**/*.d.ts",
-        "node_modules/tsickle/**",
-        "node_modules/hammerjs/**/*.d.ts",
-        "node_modules/protobufjs/**",
-        "node_modules/bytebuffer/**",
-        "node_modules/reflect-metadata/**",
-        "node_modules/minimist/**/*.js",
-    ]),
-)

COMMITTER.md

@@ -0,0 +1,21 @@
+# Pushing changes into the Angular 2 tree
+
+Please see [Using git with Angular repositories](https://docs.google.com/document/d/1h8nijFSaa1jG_UE8v4WP7glh5qOUXnYtAtJh_gwOQHI/edit)
+for details about how we maintain a linear commit history, and the rules for committing.
+
+As a contributor, just read the instructions in [CONTRIBUTING.md](CONTRIBUTING.md) and send a pull request.
+Someone with committer access will do the rest.
+
+# Change approvals
+
+Change approvals in our monorepo are managed via [pullapprove.com](https://about.pullapprove.com/) and are configured via the `.pullapprove.yaml` file.
+
+
+# Merging
+
+Once a change has all the approvals either the last approver or the PR author (if PR author has the project collaborator status) should mark the PR with "PR: merge" label.
+This signals to the caretaker that the PR should be merged.
+
+# Who is the Caretaker?
+
+See [this explanation](https://twitter.com/IgorMinar/status/799365744806854656).

CONTRIBUTING.md

@@ -17,15 +17,15 @@ Help us keep Angular open and inclusive. Please read and follow our [Code of Con
 
 ## <a name="question"></a> Got a Question or Problem?
 
-Do not open issues for general support questions as we want to keep GitHub issues for bug reports and feature requests. You've got much better chances of getting your question answered on [Stack Overflow](https://stackoverflow.com/questions/tagged/angular) where the questions should be tagged with tag `angular`.
+Please, do not open issues for the general support questions as we want to keep GitHub issues for bug reports and feature requests. You've got much better chances of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/angular) where the questions should be tagged with tag `angular`.
 
-Stack Overflow is a much better place to ask questions since:
+StackOverflow is a much better place to ask questions since:
 
-- there are thousands of people willing to help on Stack Overflow
+- there are thousands of people willing to help on StackOverflow
 - questions and answers stay available for public viewing so your question / answer might help someone else
-- Stack Overflow's voting system assures that the best answers are prominently visible.
+- StackOverflow's voting system assures that the best answers are prominently visible.
 
-To save your and our time, we will systematically close all issues that are requests for general support and redirect people to Stack Overflow.
+To save your and our time we will be systematically closing all the issues that are requests for general support and redirecting people to StackOverflow.
 
 If you would like to chat about the question in real-time, you can reach out via [our gitter channel][gitter].
 
@@ -147,7 +147,7 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
 * All public API methods **must be documented**. (Details TBC).
 * We follow [Google's JavaScript Style Guide][js-style-guide], but wrap all code at
   **100 characters**. An automated formatter is available, see
-  [DEVELOPER.md](docs/DEVELOPER.md#clang-format).
+  [DEVELOPER.md](DEVELOPER.md#clang-format).
 
 ## <a name="commit"></a> Commit Message Guidelines
 
@@ -191,44 +191,21 @@ If the commit reverts a previous commit, it should begin with `revert: `, follow
 ### Type
 Must be one of the following:
 
-* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
-* **ci**: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
-* **docs**: Documentation only changes
 * **feat**: A new feature
 * **fix**: A bug fix
-* **perf**: A code change that improves performance
+* **docs**: Documentation only changes
+* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing
+  semi-colons, etc)
 * **refactor**: A code change that neither fixes a bug nor adds a feature
-* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
+* **perf**: A code change that improves performance
 * **test**: Adding missing tests or correcting existing tests
+* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
+* **ci**: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
+* **chore**: Other changes that don't modify `src` or `test` files
 
 ### Scope
-The scope should be the name of the npm package affected (as perceived by person reading changelog generated from commit messages.
-
-The following is the list of supported scopes:
-
-* **animations**
-* **common**
-* **compiler**
-* **compiler-cli**
-* **core**
-* **forms**
-* **http**
-* **language-service**
-* **platform-browser**
-* **platform-browser-dynamic**
-* **platform-server**
-* **platform-webworker**
-* **platform-webworker-dynamic**
-* **router**
-* **upgrade**
-* **tsc-wrapped**
-
-There are currently a few exceptions to the "use package name" rule:
-
-* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc.
-* **changelog**: used for updating the release notes in CHANGELOG.md
-* **aio**: used for docs-app (angular.io) related changes within the /aio directory of the repo
-* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`)
+The scope could be anything specifying place of the commit change. For example
+`Compiler`, `ElementInjector`, etc.
 
 ### Subject
 The subject contains succinct description of the change:
@@ -263,7 +240,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
 [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md
 [commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
 [corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
-[dev-doc]: https://github.com/angular/angular/blob/master/docs/DEVELOPER.md
+[dev-doc]: https://github.com/angular/angular/blob/master/DEVELOPER.md
 [github]: https://github.com/angular/angular
 [gitter]: https://gitter.im/angular/angular
 [individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html

DEVELOPER.md

@@ -21,13 +21,11 @@ following products on your development machine:
   [Windows](http://windows.github.com)); [GitHub's Guide to Installing
   Git](https://help.github.com/articles/set-up-git) is a good source of information.
 
-* [Node.js](http://nodejs.org), (version `>=6.9.5 <7.0.0`) which is used to run a development web server,
+* [Node.js](http://nodejs.org), (version `>=5.4.1 <6`) which is used to run a development web server,
   run tests, and generate distributable files. We also use Node's Package Manager, `npm`
-  (version `>=3.10.7 <4.0.0`), which comes with Node. Depending on your system, you can install Node either from
+  (version `>=3.5.3 <4.0`), which comes with Node. Depending on your system, you can install Node either from
   source or as a pre-packaged bundle.
 
-* [Yarn](https://yarnpkg.com) (version `>=1.0.2 <2.0.0`) which is used to install dependencies.
-
 * [Java Development Kit](http://www.oracle.com/technetwork/es/java/javase/downloads/index.html) which is used
   to execute the selenium standalone server for e2e testing.
 
@@ -58,13 +56,29 @@ Next, install the JavaScript modules needed to build and test Angular:
 
 ```shell
 # Install Angular project dependencies (package.json)
-yarn install
+npm install
 ```
 
 **Optional**: In this document, we make use of project local `npm` package scripts and binaries
 (stored under `./node_modules/.bin`) by prefixing these command invocations with `$(npm bin)`; in
 particular `gulp` and `protractor` commands. If you prefer, you can drop this path prefix by either:
 
+*Option 1*: globally installing these two packages as follows:
+
+* `npm install -g gulp` (you might need to prefix this command with `sudo`)
+* `npm install -g protractor` (you might need to prefix this command with `sudo`)
+
+Since global installs can become stale, and required versions can vary by project, we avoid their
+use in these instructions.
+
+*Option 2*: globally installing the package `npm-run` by running `npm install -g npm-run`
+(you might need to prefix this command with `sudo`). You will then be able to run locally installed
+package scripts by invoking: e.g., `npm-run gulp build`
+(see [npm-run project page](https://github.com/timoxley/npm-run) for more details).
+
+
+*Option 3*: defining a bash alias like `alias nbin='PATH=$(npm bin):$PATH'` as detailed in this
+[Stackoverflow answer](http://stackoverflow.com/questions/9679932/how-to-use-package-installed-locally-in-node-modules/15157360#15157360) and used like this: e.g., `nbin gulp build`.
 
 ## Installing Bower Modules
 
@@ -147,13 +161,7 @@ You can check that your code is properly formatted and adheres to coding style b
 $ gulp lint
 ```
 
-## Publishing snapshot builds
-
-When the `master` branch successfully builds on Travis, it automatically publishes build artifacts
-to repositories in the Angular org, eg. the `@angular/core` package is published to
-http://github.com/angular/core-builds.
-The ES2015 version of Angular is published to a different branch in these repos, for example
-http://github.com/angular/core-builds#master-es2015
+## Publishing your own personal snapshot build
 
 You may find that your un-merged change needs some validation from external participants.
 Rather than requiring them to pull your Pull Request and build Angular locally, you can

NAMING.md

@@ -1,13 +1,13 @@
-Naming Conventions in Angular
+Naming Conventions in Angular2
 ---
 
-In general Angular should follow TypeScript naming conventions.
+In general Angular2 should follow TypeScript naming conventions.
 See: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
 
 
 Classes:
   - Example: `Compiler`, `ApplicationMetadata`
-  - Camel case with first letter uppercase
+  - Camel case with first letter upper-case
   - In general prefer single words. (This is so that when appending `Proto` or `Factory` the class 
     is still reasonable to work with.)
   - Should not end with `Impl` or any other word which describes a specific implementation of an 
@@ -21,10 +21,10 @@ Interfaces:
   
 Methods and functions:
   - Example: `bootstrap`, `someMethod`
-  - Should be camel case with first letter lowercase
+  - Should be camel case with first lower case
 
 
-Constants:
+Constants
   - Example: `CORE_DIRECTIVES`
   - Should be all uppercase with SNAKE_CASE
 

README.md

@@ -3,21 +3,25 @@
 [![Join the chat at https://gitter.im/angular/angular](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/angular/angular?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Issue Stats](http://issuestats.com/github/angular/angular/badge/pr?style=flat)](http://issuestats.com/github/angular/angular)
 [![Issue Stats](http://issuestats.com/github/angular/angular/badge/issue?style=flat)](http://issuestats.com/github/angular/angular)
-[![npm version](https://badge.fury.io/js/%40angular%2Fcore.svg)](https://www.npmjs.com/@angular/core)
-
-
-[![Sauce Test Status](https://saucelabs.com/browser-matrix/angular2-ci.svg)](https://saucelabs.com/u/angular2-ci)
+[![npm version](https://badge.fury.io/js/%40angular%2Fcore.svg)](https://badge.fury.io/js/%40angular%2Fcore)
 
+[![Sauce Test Status](https://saucelabs.com/browser-matrix/angular2-ci.svg)](https://saucelabs.com/u/angular2-ci)  
 *Safari (7+), iOS (7+), Edge (14) and IE mobile (11) are tested on [BrowserStack][browserstack].*
 
-# Angular
+Angular
+=========
+
+Angular is a development platform for building mobile and desktop web applications. This is the
+repository for [Angular 2][ng2] Typescript/JavaScript (JS).
+ 
+Angular2 for [Dart][dart] can be found at [dart-lang/angular2][ng2dart].
 
-Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.
 
 ## Quickstart
 
 [Get started in 5 minutes][quickstart].
 
+
 ## Want to help?
 
 Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our
@@ -25,5 +29,9 @@ guidelines for [contributing][contributing] and then check out one of our issues
 
 [browserstack]: https://www.browserstack.com/
 [contributing]: http://github.com/angular/angular/blob/master/CONTRIBUTING.md
+[dart]: http://www.dartlang.org
 [quickstart]: https://angular.io/docs/ts/latest/quickstart.html
-[ng]: http://angular.io
+[ng2]: http://angular.io
+[ngDart]: http://angulardart.org
+[ngJS]: http://angularjs.org
+[ng2dart]: https://github.com/dart-lang/angular2

SAVED_REPLIES.md

@@ -19,12 +19,6 @@ I'm sorry but we don't understand the problem you are reporting.
 If the problem still exists please open a new issue and provide a plunker reproducing the problem and describing the difference between the expected and current behavior. You can use this plunker template: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5?p=catalogue
 ```
 
-## Angular: Plunker Needed (v1)
-```
-I'm sorry but reported issues require a plunker reproducing the problem.
-
-If this issue persists, please create a plunker using this template and describe the difference between the expected and current behavior and create a new issue: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5?p=catalogue
-```
 
 ## Angular: Duplicate (v1)
 ```
@@ -44,10 +38,6 @@ If the problem still persists, please file a new issue and ensure you provide al
 I'm sorry but this issue is not caused by Angular. Please contact the author(s) of project <PROJECT NAME> or file issue on their issue tracker.
 ```
 
-## Angular: Behaving as Expected (v1)
-```
-It appears this behaves as expected. If you still feel there is an issue, please provide further details in a new issue.
-```
 
 ## Angular: Non-reproducible (v1)
 ```

TOOLS.md

@@ -1,4 +1,4 @@
-# Developer Tools for Angular
+# Developer Tools for Angular 2
 
 Here you will find a collection of tools and tips for keeping your application
 perform well and contain fewer bugs.
@@ -37,7 +37,7 @@ ng.profiler.timeChangeDetection();
 ### Change detection profiler
 
 If your application is janky (it misses frames) or is slow according to other
-metrics, it is important to find the root cause of the issue. Change detection
+metrics it is important to find the root cause of the issue. Change detection
 is a phase in Angular's lifecycle that detects changes in values that are
 bound to UI, and if it finds a change it performs the corresponding UI update.
 However, sometimes it is hard to tell if the slowness is due to the act of
@@ -45,7 +45,7 @@ computing the changes being slow, or due to the act of applying those changes
 to the UI. For your application to be performant it is important that the
 process of computing changes is very fast. For best results it should be under
 3 milliseconds in order to leave room for the application logic, the UI updates
-and browser's rendering pipeline to fit within the 16 millisecond frame
+and browser's rendering pipeline to fit withing the 16 millisecond frame
 (assuming the 60 FPS target frame rate).
 
 Change detection profiler repeatedly performs change detection without invoking

TRIAGE_AND_LABELS.md

@@ -0,0 +1,158 @@
+# Triage Process and Github Labels for Angular 2
+
+This document describes how the Angular team uses labels and milestones 
+to triage issues on github. The basic idea of the process is that
+caretaker only assigns a component and type (bug, feature) label. The 
+owner of the component than is in full control of how the issues should 
+be triaged further.
+
+Once this process is implemented and in use, we will revisit it to see 
+if further labeling is needed.
+
+## Components
+
+A caretaker should be able to determine which component the issue 
+belongs to. The components have a clear piece of source code associated
+with it.
+
+* `comp: animations`: `@matsko`
+* `comp: benchpress`: `@tbosch`
+* `comp: build & ci`: `@IgorMinar` -- All build and CI scripts 
+* `comp: common`: `@mhevery`  -- This includes core components / pipes.
+* `comp: core & compiler`: `@tbosch` -- Because core and compiler are very 
+  intertwined, we will be treating them as one.
+* `comp: forms`: `@kara`
+* `comp: http`: `@jeffbcross`
+* `comp: i18n`: `@vicb`
+* `comp: language service`: `@chuckjaz`
+* `comp: metadata-extractor`: `@chuckjaz`
+* `comp: router`: `@vicb`
+* `comp: testing`: `@juliemr`
+* `comp: upgrade`: `@mhevery`
+* `comp: web-worker`: `@vicb`
+* `comp: zones`: `@mhevery`
+
+There are few components which are cross-cutting. They don't have
+a clear location in the source tree. We will treat them as a component
+even thought no specific source tree is associated with them.
+
+* `comp: docs`: `@naomiblack`
+* `comp: packaging`: `@IgorMinar`
+* `comp: performance`: `@tbosch`
+* `comp: security`: `@IgorMinar`
+
+
+## Type
+What kind of problem is this?
+
+* `type: RFC / discussion / question`
+* `type: bug`
+* `type: chore`
+* `type: feature`
+* `type: performance`
+* `type: refactor`
+
+## Caretaker Triage Process
+
+It is the caretaker's responsibility to assign `comp:  *` to each new
+issue as they come in. The reason why we limit the responsibility of the
+caretaker to this one label is that it is likely that without domain
+knowledge the caretaker could mislabel issues or lack knowledge of
+duplicate issues.
+
+
+## Component's owner Triage Process
+
+At this point we are leaving each component owner to determine their own
+process for their component.
+
+It will be up to the component owner to determine the order in which the
+issues within the component will be resolved.
+
+Several owners have adopted the issue categorization based on
+[user pain](http://www.lostgarden.com/2008/05/improving-bug-triage-with-user-pain.html)
+used by Angular 1. In this system every issue is assigned frequency and
+severity based on which the total user pain score is calculated.
+
+Following is the definition of various frequency and severity levels:
+
+1. `freq(score): *` – How often does this issue come up? How many developers does this affect?
+    * low (1) - obscure issue affecting a handful of developers
+    * moderate (2) - impacts auxiliary usage patterns, only small number of applications are affected
+    * high (3) - impacts primary usage patterns, affecting most Angular apps
+    * critical (4) - impacts all Angular apps
+1. `severity(score): *` - How bad is the issue?
+    * inconvenience (1) - causes ugly/boilerplate code in apps
+    * confusing (2) - unexpected or inconsistent behavior; hard-to-debug
+    * broken expected use (3) - it's hard or impossible for a developer using Angular to accomplish something that Angular should be able to do
+    * memory leak (4)
+    * regression (5) - functionality that used to work no longer works in a new release due to an unintentional change
+    * security issue (6)
+
+
+These criteria are then used to calculate a "user pain" score as follows:
+
+`pain = severity × frequency`
+
+
+### Assigning Issues to Milestones
+
+Any issue that is being worked on must have:
+
+* An `Assignee`: The person doing the work.
+* A `Milestone`: When we expect to complete this work.
+
+We aim to only have at most three milestones open at a time:
+
+* Closing Milestone: A milestone with a very small number of issues, about to release. 
+* Current Milestone: Work that we plan to complete within one week.
+* Next Milestone: Work that is > 1 week but current for the team.
+
+The [backlog](https://github.com/angular/angular/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone) 
+consists of all issues that have been triaged but do not have an assignee or milestone.  
+
+## Triaged vs Untrained PRs
+
+PRs should also be label with a `comp: *` so that it is clear which 
+primary area the PR effects.
+
+Because of the cumulative pain associated with rebasing PRs, we triage PRs daily, and 
+closing or reviewing PRs is a top priority ahead of other ongoing work. 
+
+Every triaged PR must have a `pr_action` label assigned to it and an assignee:
+ 
+* `pr_action: review` -- work is complete and comment is needed from the assignee.
+* `pr_action: cleanup` -- more work is needed from the current assignee. 
+* `pr_action: discuss` -- discussion is needed, to be led by the current assignee.
+* `pr_action: merge` -- the PR should be merged. Add this to a PR when you would like to 
+  trigger automatic merging following a successful build. This is described in [COMMITTER.md](COMMITTER.md).
+
+In addition, PRs can have the following states:
+
+* `pr_state: LGTM` -- PR may have outstanding changes but does not require further review.
+* `pr_state: WIP` -- PR is experimental or rapidly changing. Not ready for review or triage.
+* `pr_state: blocked` -- PR is blocked on an issue or other PR. Not ready for review or triage.
+
+Note that an LGTM state does not mean a PR is ready to merge: for example, a reviewer might set the
+LGTM state but request a minor tweak that doesn't need further review, e.g., a rebase or small 
+uncontroversial change.
+
+PRs do not need to be assigned to milestones, unless a milestone release should be held for that 
+PR to land.
+
+
+## Special Labels
+
+### action:design
+More active discussion is needed before the issue can be worked on further. Typically used for 
+`type: feature` or `type: RFC/discussion/question`
+
+[See all issues that need discussion](https://github.com/angular/angular/labels/action:%20Design)
+
+### cla
+Managed by googlebot. Indicates whether a PR has a CLA on file for its author(s). Only issues with 
+`cla:yes` should be merged into master.
+
+### WORKS_AS_INTENDED
+
+Only used on closed issues, to indicate to the reporter why we closed it.

WORKSPACE

@@ -1,17 +0,0 @@
-load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
-
-git_repository(
-   name = "build_bazel_rules_typescript",
-   remote = "https://github.com/bazelbuild/rules_typescript.git",
-   tag = "0.0.5",
-)
-
-load("@build_bazel_rules_typescript//:defs.bzl", "node_repositories")
-
-node_repositories(package_json = "//:package.json")
-
-git_repository(
-    name = "build_bazel_rules_angular",
-    remote = "https://github.com/bazelbuild/rules_angular.git",
-    tag = "0.0.1",
-)

aio/.angular-cli.json

@@ -1,67 +0,0 @@
-{
-  "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
-  "project": {
-    "name": "site"
-  },
-  "apps": [
-    {
-      "root": "src",
-      "outDir": "dist",
-      "assets": [
-        "assets",
-        "generated",
-        "app/search/search-worker.js",
-        "favicon.ico",
-        "pwa-manifest.json",
-        "google385281288605d160.html"
-      ],
-      "index": "index.html",
-      "main": "main.ts",
-      "polyfills": "polyfills.ts",
-      "test": "test.ts",
-      "tsconfig": "tsconfig.app.json",
-      "testTsconfig": "tsconfig.spec.json",
-      "prefix": "aio",
-      "serviceWorker": false,
-      "styles": [
-        "styles.scss"
-      ],
-      "scripts": [
-      ],
-      "environmentSource": "environments/environment.ts",
-      "environments": {
-        "dev": "environments/environment.ts",
-        "next": "environments/environment.next.ts",
-        "stable": "environments/environment.stable.ts",
-        "archive": "environments/environment.archive.ts"
-      }
-    }
-  ],
-  "e2e": {
-    "protractor": {
-      "config": "./protractor.conf.js"
-    }
-  },
-  "lint": [
-    {
-      "project": "src/tsconfig.app.json"
-    },
-    {
-      "project": "src/tsconfig.spec.json"
-    },
-    {
-      "project": "e2e/tsconfig.e2e.json"
-    }
-  ],
-  "test": {
-    "karma": {
-      "config": "./karma.conf.js"
-    }
-  },
-  "defaults": {
-    "styleExt": "scss",
-    "component": {
-      "inlineStyle": true
-    }
-  }
-}

aio/.gitignore

@@ -1,48 +0,0 @@
-# See http://help.github.com/ignore-files/ for more about ignoring files.
-
-# compiled output
-/dist
-/out-tsc
-/src/generated
-/tmp
-
-# dependencies
-/node_modules
-
-# IDEs and editors
-/.idea
-.project
-.classpath
-.c9/
-*.launch
-.settings/
-*.sublime-workspace
-
-# IDE - VSCode
-.vscode/*
-!.vscode/settings.json
-!.vscode/tasks.json
-!.vscode/launch.json
-!.vscode/extensions.json
-
-# misc
-/.sass-cache
-/connect.lock
-/coverage
-/libpeerconnection.log
-npm-debug.log
-testem.log
-/typings
-yarn-error.log
-
-# e2e
-/e2e/*.js
-/e2e/*.map
-protractor-results*.txt
-
-# System Files
-.DS_Store
-Thumbs.db
-
-# copied dependencies
-src/assets/js/lunr*

aio/README.md

@@ -1,126 +0,0 @@
-# Angular documentation project (https://angular.io)
-
-Everything in this folder is part of the documentation project. This includes
-
-* the web site for displaying the documentation
-* the dgeni configuration for converting source files to rendered files that can be viewed in the web site.
-* the tooling for setting up examples for development; and generating plunkers and zip files from the examples.
-
-## Developer tasks
-
-We use `yarn` to manage the dependencies and to run build tasks.
-You should run all these tasks from the `angular/aio` folder.
-Here are the most important tasks you might need to use:
-
-* `yarn` - install all the dependencies.
-* `yarn setup` - install all the dependencies, boilerplate, plunkers, zips and run dgeni on the docs.
-* `yarn setup-local` - same as `setup`, but use the locally built Angular packages for aio and docs examples boilerplate.
-
-* `yarn build` - create a production build of the application (after installing dependencies, boilerplate, etc).
-* `yarn build-local` - same as `build`, but use `setup-local` instead of `setup`.
-
-* `yarn start` - run a development web server that watches the files; then builds the doc-viewer and reloads the page, as necessary.
-* `yarn serve-and-sync` - run both the `docs-watch` and `start` in the same console.
-* `yarn lint` - check that the doc-viewer code follows our style rules.
-* `yarn test` - watch all the source files, for the doc-viewer, and run all the unit tests when any change.
-* `yarn e2e` - run all the e2e tests for the doc-viewer.
-
-* `yarn docs` - generate all the docs from the source files.
-* `yarn docs-watch` - watch the Angular source and the docs files and run a short-circuited doc-gen for the docs that changed.
-* `yarn docs-lint` - check that the doc gen code follows our style rules.
-* `yarn docs-test` - run the unit tests for the doc generation code.
-
-* `yarn boilerplate:add` - generate all the boilerplate code for the examples, so that they can be run locally. Add the option `--local` to use your local version of Angular contained in the "dist" folder.
-* `yarn boilerplate:remove` - remove all the boilerplate code that was added via `yarn boilerplate:add`.
-* `yarn generate-plunkers` - generate the plunker files that are used by the `live-example` tags in the docs.
-* `yarn generate-zips` - generate the zip files from the examples. Zip available via the `live-example` tags in the docs.
-
-* `yarn example-e2e` - run all e2e tests for examples
-  - `yarn example-e2e --setup` - force webdriver update & other setup, then run tests
-  - `yarn example-e2e --filter=foo` - limit e2e tests to those containing the word "foo"
-  - `yarn example-e2e --setup --local` - run e2e tests with the local version of Angular contained in the "dist" folder
-
-* `yarn build-ie-polyfills` - generates a js file of polyfills that can be loaded in Internet Explorer.
-
-## Using ServiceWorker locally
-
-Since abb36e3cb, running `yarn start --prod` will no longer set up the ServiceWorker, which
-would require manually running `yarn sw-manifest` and `yarn sw-copy` (something that is not possible
-with webpack serving the files from memory).
-
-If you want to test ServiceWorker locally, you can use `yarn build` and serve the files in `dist/`
-with `yarn http-server dist -p 4200`.
-
-For more details see #16745.
-
-
-## Guide to authoring
-
-There are two types of content in the documentation:
-
-* **API docs**: descriptions of the modules, classes, interfaces, decorators, etc that make up the Angular platform.
-API docs are generated directly from the source code.
-The source code is contained in TypeScript files, located in the `angular/packages` folder.
-Each API item may have a preceding comment, which contains JSDoc style tags and content.
-The content is written in markdown.
-
-* **Other content**: guides, tutorials, and other marketing material.
-All other content is written using markdown in text files, located in the `angular/aio/content` folder.
-More specifically, there are sub-folders that contain particular types of content: guides, tutorial and marketing.
-
-We use the [dgeni](https://github.com/angular/dgeni) tool to convert these files into docs that can be viewed in the doc-viewer.
-
-The [Authors Style Guide](https://angular.io/guide/docs-style-guide) prescribes guidelines for
-writing guide pages, explains how to use the documentation classes and components, and how to markup sample source code to produce code snippets.
-
-### Generating the complete docs
-
-The main task for generating the docs is `yarn docs`. This will process all the source files (API and other),
-extracting the documentation and generating JSON files that can be consumed by the doc-viewer.
-
-### Partial doc generation for editors
-
-Full doc generation can take up to one minute. That's too slow for efficient document creation and editing.
-
-You can make small changes in a smart editor that displays formatted markdown:
->In VS Code, _Cmd-K, V_ opens markdown preview in side pane; _Cmd-B_ toggles left sidebar
-
-You also want to see those changes displayed properly in the doc viewer
-with a quick, edit/view cycle time.
-
-For this purpose, use the `yarn docs-watch` task, which watches for changes to source files and only
-re-processes the the files necessary to generate the docs that are related to the file that has changed.
-Since this task takes shortcuts, it is much faster (often less than 1 second) but it won't produce full
-fidelity content. For example, links to other docs and code examples may not render correctly. This is
-most particularly noticed in links to other docs and in the embedded examples, which may not always render
-correctly.
-
-The general setup is as follows:
-
-* Open a terminal, ensure the dependencies are installed; run an initial doc generation; then start the doc-viewer:
-
-```bash
-yarn
-yarn docs
-yarn start
-```
-
-* Open a second terminal and start watching the docs
-
-```bash
-yarn docs-watch
-```
-
->Alternatively, try the consolidated `serve-and-sync` command that builds, watches and serves in the same terminal window
-```bash
-yarn serve-and-sync
-```
-
-* Open a browser at https://localhost:4200/ and navigate to the document on which you want to work.
-You can automatically open the browser by using `yarn start -o` in the first terminal.
-
-* Make changes to the page's associated doc or example files. Every time a file is saved, the doc will
-be regenerated, the app will rebuild and the page will reload.
-
-* If you get a build error complaining about examples or any other odd behavior, be sure to consult
-the [Authors Style Guide](https://angular.io/guide/docs-style-guide).

aio/aio-builds-setup/dockerbuild/.dockerignore

@@ -1,3 +0,0 @@
-scripts-js/lib
-scripts-js/node_modules
-scripts-js/**/test

aio/aio-builds-setup/dockerbuild/Dockerfile

@@ -1,168 +0,0 @@
-# Image metadata and config
-FROM debian:jessie
-
-LABEL name="angular.io PR preview" \
-      description="This image implements the PR preview functionality for angular.io." \
-      vendor="Angular" \
-      version="1.0"
-
-VOLUME /aio-secrets
-VOLUME /var/www/aio-builds
-
-EXPOSE 80 443
-
-
-# Build-time args and env vars
-ARG      AIO_BUILDS_DIR=/var/www/aio-builds
-ARG TEST_AIO_BUILDS_DIR=/tmp/aio-builds
-ARG      AIO_DOMAIN_NAME=ngbuilds.io
-ARG TEST_AIO_DOMAIN_NAME=$AIO_DOMAIN_NAME.localhost
-ARG      AIO_GITHUB_ORGANIZATION=angular
-ARG TEST_AIO_GITHUB_ORGANIZATION=angular
-ARG      AIO_GITHUB_TEAM_SLUGS=angular-core,aio-contributors
-ARG TEST_AIO_GITHUB_TEAM_SLUGS=angular-core,aio-contributors
-ARG      AIO_NGINX_HOSTNAME=$AIO_DOMAIN_NAME
-ARG TEST_AIO_NGINX_HOSTNAME=$TEST_AIO_DOMAIN_NAME
-ARG      AIO_NGINX_PORT_HTTP=80
-ARG TEST_AIO_NGINX_PORT_HTTP=8080
-ARG      AIO_NGINX_PORT_HTTPS=443
-ARG TEST_AIO_NGINX_PORT_HTTPS=4433
-ARG      AIO_REPO_SLUG=angular/angular
-ARG TEST_AIO_REPO_SLUG=test-repo/test-slug
-ARG      AIO_TRUSTED_PR_LABEL="aio: preview"
-ARG TEST_AIO_TRUSTED_PR_LABEL="aio: preview"
-ARG      AIO_UPLOAD_HOSTNAME=upload.localhost
-ARG TEST_AIO_UPLOAD_HOSTNAME=upload.localhost
-ARG      AIO_UPLOAD_MAX_SIZE=20971520
-ARG TEST_AIO_UPLOAD_MAX_SIZE=20971520
-ARG      AIO_UPLOAD_PORT=3000
-ARG TEST_AIO_UPLOAD_PORT=3001
-
-ENV AIO_BUILDS_DIR=$AIO_BUILDS_DIR                     TEST_AIO_BUILDS_DIR=$TEST_AIO_BUILDS_DIR                     \
-    AIO_DOMAIN_NAME=$AIO_DOMAIN_NAME                   TEST_AIO_DOMAIN_NAME=$TEST_AIO_DOMAIN_NAME                   \
-    AIO_GITHUB_ORGANIZATION=$AIO_GITHUB_ORGANIZATION   TEST_AIO_GITHUB_ORGANIZATION=$TEST_AIO_GITHUB_ORGANIZATION   \
-    AIO_GITHUB_TEAM_SLUGS=$AIO_GITHUB_TEAM_SLUGS       TEST_AIO_GITHUB_TEAM_SLUGS=$TEST_AIO_GITHUB_TEAM_SLUGS       \
-    AIO_LOCALCERTS_DIR=/etc/ssl/localcerts             TEST_AIO_LOCALCERTS_DIR=/etc/ssl/localcerts-test             \
-    AIO_NGINX_HOSTNAME=$AIO_NGINX_HOSTNAME             TEST_AIO_NGINX_HOSTNAME=$TEST_AIO_NGINX_HOSTNAME             \
-    AIO_NGINX_LOGS_DIR=/var/log/aio/nginx              TEST_AIO_NGINX_LOGS_DIR=/var/log/aio/nginx-test              \
-    AIO_NGINX_PORT_HTTP=$AIO_NGINX_PORT_HTTP           TEST_AIO_NGINX_PORT_HTTP=$TEST_AIO_NGINX_PORT_HTTP           \
-    AIO_NGINX_PORT_HTTPS=$AIO_NGINX_PORT_HTTPS         TEST_AIO_NGINX_PORT_HTTPS=$TEST_AIO_NGINX_PORT_HTTPS         \
-    AIO_REPO_SLUG=$AIO_REPO_SLUG                       TEST_AIO_REPO_SLUG=$TEST_AIO_REPO_SLUG                       \
-    AIO_SCRIPTS_JS_DIR=/usr/share/aio-scripts-js                                                                    \
-    AIO_SCRIPTS_SH_DIR=/usr/share/aio-scripts-sh                                                                    \
-    AIO_TRUSTED_PR_LABEL=$AIO_TRUSTED_PR_LABEL         TEST_AIO_TRUSTED_PR_LABEL=$TEST_AIO_TRUSTED_PR_LABEL         \
-    AIO_UPLOAD_HOSTNAME=$AIO_UPLOAD_HOSTNAME           TEST_AIO_UPLOAD_HOSTNAME=$TEST_AIO_UPLOAD_HOSTNAME           \
-    AIO_UPLOAD_MAX_SIZE=$AIO_UPLOAD_MAX_SIZE           TEST_AIO_UPLOAD_MAX_SIZE=$TEST_AIO_UPLOAD_MAX_SIZE           \
-    AIO_UPLOAD_PORT=$AIO_UPLOAD_PORT                   TEST_AIO_UPLOAD_PORT=$TEST_AIO_UPLOAD_PORT                   \
-    AIO_WWW_USER=www-data                                                                                           \
-    NODE_ENV=production
-
-
-# Create directory for logs
-RUN mkdir /var/log/aio
-
-
-# Add extra package sources
-RUN apt-get update -y && apt-get install -y curl
-RUN curl --silent --show-error --location https://deb.nodesource.com/setup_6.x | bash -
-RUN curl --silent --show-error https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
-RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
-RUN echo "deb http://ftp.debian.org/debian jessie-backports main" | tee /etc/apt/sources.list.d/backports.list
-
-
-# Install packages
-RUN apt-get update -y && apt-get install -y \
-    chkconfig \
-    cron \
-    dnsmasq \
-    nano \
-    nodejs \
-    openssl \
-    rsyslog \
-    yarn
-RUN apt-get install -t jessie-backports -y nginx
-RUN yarn global add pm2@2
-
-
-# Set up log rotation
-COPY logrotate/* /etc/logrotate.d/
-RUN chmod 0644 /etc/logrotate.d/*
-
-
-# Set up cronjobs
-COPY cronjobs/aio-builds-cleanup /etc/cron.d/
-RUN chmod 0744 /etc/cron.d/aio-builds-cleanup
-RUN crontab /etc/cron.d/aio-builds-cleanup
-RUN printenv | grep AIO_ >> /etc/environment
-
-
-# Set up dnsmasq
-COPY dnsmasq/dnsmasq.conf /etc/
-RUN sed -i "s|{{\$AIO_NGINX_HOSTNAME}}|$AIO_NGINX_HOSTNAME|g" /etc/dnsmasq.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_HOSTNAME}}|$AIO_UPLOAD_HOSTNAME|g" /etc/dnsmasq.conf
-RUN sed -i "s|{{\$TEST_AIO_NGINX_HOSTNAME}}|$TEST_AIO_NGINX_HOSTNAME|g" /etc/dnsmasq.conf
-RUN sed -i "s|{{\$TEST_AIO_UPLOAD_HOSTNAME}}|$TEST_AIO_UPLOAD_HOSTNAME|g" /etc/dnsmasq.conf
-
-
-# Set up SSL/TLS certificates
-COPY nginx/create-selfsigned-cert.sh /tmp/
-RUN chmod a+x /tmp/create-selfsigned-cert.sh
-RUN /tmp/create-selfsigned-cert.sh "selfcert-prod" "$AIO_NGINX_HOSTNAME" "$AIO_LOCALCERTS_DIR"
-RUN /tmp/create-selfsigned-cert.sh "selfcert-test" "$TEST_AIO_NGINX_HOSTNAME" "$TEST_AIO_LOCALCERTS_DIR"
-RUN rm /tmp/create-selfsigned-cert.sh
-RUN update-ca-certificates
-
-
-# Set up nginx (for production and testing)
-RUN sed -i -E "s|^user\s+\S+;|user $AIO_WWW_USER;|" /etc/nginx/nginx.conf
-RUN rm -f /etc/nginx/conf.d/*
-RUN rm -f /etc/nginx/sites-enabled/*
-
-COPY nginx/aio-builds.conf /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_BUILDS_DIR}}|$AIO_BUILDS_DIR|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_DOMAIN_NAME}}|$AIO_DOMAIN_NAME|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_LOCALCERTS_DIR}}|$AIO_LOCALCERTS_DIR|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_NGINX_LOGS_DIR}}|$AIO_NGINX_LOGS_DIR|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_NGINX_PORT_HTTP}}|$AIO_NGINX_PORT_HTTP|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_NGINX_PORT_HTTPS}}|$AIO_NGINX_PORT_HTTPS|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_HOSTNAME}}|$AIO_UPLOAD_HOSTNAME|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_MAX_SIZE}}|$AIO_UPLOAD_MAX_SIZE|g" /etc/nginx/conf.d/aio-builds-prod.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_PORT}}|$AIO_UPLOAD_PORT|g" /etc/nginx/conf.d/aio-builds-prod.conf
-
-COPY nginx/aio-builds.conf /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_BUILDS_DIR}}|$TEST_AIO_BUILDS_DIR|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_DOMAIN_NAME}}|$TEST_AIO_DOMAIN_NAME|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_LOCALCERTS_DIR}}|$TEST_AIO_LOCALCERTS_DIR|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_NGINX_LOGS_DIR}}|$TEST_AIO_NGINX_LOGS_DIR|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_NGINX_PORT_HTTP}}|$TEST_AIO_NGINX_PORT_HTTP|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_NGINX_PORT_HTTPS}}|$TEST_AIO_NGINX_PORT_HTTPS|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_HOSTNAME}}|$TEST_AIO_UPLOAD_HOSTNAME|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_MAX_SIZE}}|$TEST_AIO_UPLOAD_MAX_SIZE|g" /etc/nginx/conf.d/aio-builds-test.conf
-RUN sed -i "s|{{\$AIO_UPLOAD_PORT}}|$TEST_AIO_UPLOAD_PORT|g" /etc/nginx/conf.d/aio-builds-test.conf
-
-
-# Set up pm2
-RUN pm2 startup systemv -u root > /dev/null
-RUN chkconfig pm2-root on
-
-
-# Set up the shell scripts
-COPY scripts-sh/ $AIO_SCRIPTS_SH_DIR/
-RUN chmod a+x $AIO_SCRIPTS_SH_DIR/*
-RUN find $AIO_SCRIPTS_SH_DIR -maxdepth 1 -type f -printf "%P\n" \
-    | while read file; do ln -s $AIO_SCRIPTS_SH_DIR/$file /usr/local/bin/aio-${file%.*}; done
-
-
-# Set up the Node.js scripts
-COPY scripts-js/ $AIO_SCRIPTS_JS_DIR/
-WORKDIR $AIO_SCRIPTS_JS_DIR/
-RUN yarn install --production --freeze-lockfile
-
-
-# Set up health check
-HEALTHCHECK --interval=5m CMD /usr/local/bin/aio-health-check
-
-
-# Go!
-WORKDIR /
-CMD aio-init && tail -f /dev/null

aio/aio-builds-setup/dockerbuild/cronjobs/aio-builds-cleanup

@@ -1,2 +0,0 @@
-# Periodically clean up builds that do not correspond to currently open PRs
-0 12 * * * root /usr/local/bin/aio-clean-up >> /var/log/cron.log 2>&1

aio/aio-builds-setup/dockerbuild/dnsmasq/dnsmasq.conf

@@ -1,16 +0,0 @@
-# Do not read /etc/resolv.conf. Get servers from this file instead.
-no-resolv
-server=8.8.8.8
-server=8.8.4.4
-
-# Listen for DHCP and DNS requests only on this address.
-listen-address=127.0.0.1
-
-# Force an IP address for these domains.
-address=/{{$AIO_NGINX_HOSTNAME}}/127.0.0.1
-address=/{{$AIO_UPLOAD_HOSTNAME}}/127.0.0.1
-address=/{{$TEST_AIO_NGINX_HOSTNAME}}/127.0.0.1
-address=/{{$TEST_AIO_UPLOAD_HOSTNAME}}/127.0.0.1
-
-# Run as root (required from inside docker container).
-user=root

aio/aio-builds-setup/dockerbuild/logrotate/aio-misc

@@ -1,9 +0,0 @@
-/var/log/aio/clean-up.log /var/log/aio/init.log /var/log/aio/verify-setup.log {
-  compress
-  create
-  delaycompress
-  missingok
-  monthly
-  notifempty
-  rotate 6
-}

aio/aio-builds-setup/dockerbuild/logrotate/aio-nginx

@@ -1,13 +0,0 @@
-/var/log/aio/nginx/*.log /var/log/aio/nginx-test/*.log {
-  compress
-  create
-  delaycompress
-  missingok
-  monthly
-  notifempty
-  rotate 6
-  sharedscripts
-  postrotate
-    service nginx rotate >/dev/null 2>&1
-  endscript
-}

aio/aio-builds-setup/dockerbuild/logrotate/aio-upload-server

@@ -1,9 +0,0 @@
-/var/log/aio/upload-server-*.log {
-  compress
-  copytruncate
-  delaycompress
-  missingok
-  monthly
-  notifempty
-  rotate 6
-}

aio/aio-builds-setup/dockerbuild/nginx/aio-builds.conf

@@ -1,110 +0,0 @@
-# Redirect all HTTP traffic to HTTPS
-server {
-  server_name _;
-
-  listen {{$AIO_NGINX_PORT_HTTP}} default_server;
-  listen [::]:{{$AIO_NGINX_PORT_HTTP}};
-
-  access_log {{$AIO_NGINX_LOGS_DIR}}/access.log;
-  error_log  {{$AIO_NGINX_LOGS_DIR}}/error.log;
-
-  # Ideally we want 308 (permanent + keep original method),
-  # but it is relatively new and not supported by some clients (e.g. cURL).
-  return 307 https://$host:{{$AIO_NGINX_PORT_HTTPS}}$request_uri;
-}
-
-# Serve PR-preview requests
-server {
-  server_name "~^pr(?<pr>[1-9][0-9]*)-(?<sha>[0-9a-f]{7,40})\.";
-
-  listen {{$AIO_NGINX_PORT_HTTPS}} ssl http2;
-  listen [::]:{{$AIO_NGINX_PORT_HTTPS}} ssl http2;
-
-  ssl_certificate           {{$AIO_LOCALCERTS_DIR}}/{{$AIO_DOMAIN_NAME}}.crt;
-  ssl_certificate_key       {{$AIO_LOCALCERTS_DIR}}/{{$AIO_DOMAIN_NAME}}.key;
-  ssl_prefer_server_ciphers on;
-  ssl_ciphers               EECDH+CHACHA20:EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5;
-
-  root             {{$AIO_BUILDS_DIR}}/$pr/$sha;
-  disable_symlinks on from=$document_root;
-  index            index.html;
-
-  gzip            on;
-  gzip_comp_level 7;
-  gzip_types      *;
-
-  access_log {{$AIO_NGINX_LOGS_DIR}}/access.log;
-  error_log  {{$AIO_NGINX_LOGS_DIR}}/error.log;
-
-  location "~/[^/]+\.[^/]+$" {
-    try_files $uri $uri/ =404;
-  }
-
-  location / {
-    try_files $uri $uri/ /index.html =404;
-  }
-}
-
-# Handle all other requests
-server {
-  server_name _;
-
-  listen {{$AIO_NGINX_PORT_HTTPS}} ssl http2 default_server;
-  listen [::]:{{$AIO_NGINX_PORT_HTTPS}} ssl http2;
-
-  ssl_certificate           {{$AIO_LOCALCERTS_DIR}}/{{$AIO_DOMAIN_NAME}}.crt;
-  ssl_certificate_key       {{$AIO_LOCALCERTS_DIR}}/{{$AIO_DOMAIN_NAME}}.key;
-  ssl_prefer_server_ciphers on;
-  ssl_ciphers               EECDH+CHACHA20:EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5;
-
-  access_log {{$AIO_NGINX_LOGS_DIR}}/access.log;
-  error_log  {{$AIO_NGINX_LOGS_DIR}}/error.log;
-
-  # Health check
-  location "~^/health-check/?$" {
-    add_header Content-Type text/plain;
-    return 200 '';
-  }
-
-  # Upload builds
-  location "~^/create-build/(?<pr>[1-9][0-9]*)/(?<sha>[0-9a-f]{40})/?$" {
-    if ($request_method != "POST") {
-      add_header Allow "POST";
-      return 405;
-    }
-
-    client_body_temp_path    /tmp/aio-create-builds;
-    client_body_buffer_size  128K;
-    client_max_body_size     {{$AIO_UPLOAD_MAX_SIZE}};
-    client_body_in_file_only on;
-
-    proxy_pass_request_headers on;
-    proxy_set_header           X-FILE $request_body_file;
-    proxy_set_body             off;
-    proxy_redirect             off;
-    proxy_method               GET;
-    proxy_pass                 http://{{$AIO_UPLOAD_HOSTNAME}}:{{$AIO_UPLOAD_PORT}}$request_uri;
-
-    resolver 127.0.0.1;
-  }
-
-  # Notify about PR changes
-  location "~^/pr-updated/?$" {
-    if ($request_method != "POST") {
-      add_header Allow "POST";
-      return 405;
-    }
-
-    proxy_pass_request_headers on;
-    proxy_redirect             off;
-    proxy_method               POST;
-    proxy_pass                 http://{{$AIO_UPLOAD_HOSTNAME}}:{{$AIO_UPLOAD_PORT}}$request_uri;
-
-    resolver 127.0.0.1;
-  }
-
-  # Everything else
-  location / {
-    return 404;
-  }
-}

aio/aio-builds-setup/dockerbuild/nginx/create-selfsigned-cert.sh

@@ -1,20 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-
-# Variables
-confFile=/tmp/$1.conf
-domainName=$2
-outDir=$3
-
-
-# Create certificate
-cp /etc/ssl/openssl.cnf "$confFile"
-echo "[subjectAltName]" >> "$confFile"
-echo "subjectAltName = DNS:$domainName, DNS:*.$domainName" >> "$confFile"
-mkdir -p $outDir
-openssl req -days 365 -newkey rsa:2048 -nodes -sha256 -x509 \
-            -config "$confFile" -extensions subjectAltName -subj "/CN=$domainName" \
-            -out "$outDir/$domainName.crt" -keyout "$outDir/$domainName.key"
-chmod -R 400 "$outDir"
-cp "$outDir/$domainName.crt" /usr/local/share/ca-certificates

aio/aio-builds-setup/dockerbuild/scripts-js/.gitignore

@@ -1,2 +0,0 @@
-/dist
-/node_modules

aio/aio-builds-setup/dockerbuild/scripts-js/lib/clean-up/build-cleaner.ts

@@ -1,81 +0,0 @@
-// Imports
-import * as fs from 'fs';
-import * as path from 'path';
-import * as shell from 'shelljs';
-import {HIDDEN_DIR_PREFIX} from '../common/constants';
-import {GithubPullRequests} from '../common/github-pull-requests';
-import {assertNotMissingOrEmpty} from '../common/utils';
-
-// Classes
-export class BuildCleaner {
-  // Constructor
-  constructor(protected buildsDir: string, protected repoSlug: string, protected githubToken: string) {
-    assertNotMissingOrEmpty('buildsDir', buildsDir);
-    assertNotMissingOrEmpty('repoSlug', repoSlug);
-    assertNotMissingOrEmpty('githubToken', githubToken);
-  }
-
-  // Methods - Public
-  public cleanUp(): Promise<void> {
-    return Promise.all([
-      this.getExistingBuildNumbers(),
-      this.getOpenPrNumbers(),
-    ]).then(([existingBuilds, openPrs]) => this.removeUnnecessaryBuilds(existingBuilds, openPrs));
-  }
-
-  // Methods - Protected
-  protected getExistingBuildNumbers(): Promise<number[]> {
-    return new Promise((resolve, reject) => {
-      fs.readdir(this.buildsDir, (err, files) => {
-        if (err) {
-          return reject(err);
-        }
-
-        const buildNumbers = files.
-          map(name => name.replace(HIDDEN_DIR_PREFIX, '')).   // Remove the "hidden dir" prefix
-          map(Number).                                        // Convert string to number
-          filter(Boolean);                                    // Ignore NaN (or 0), because they are not builds
-
-        resolve(buildNumbers);
-      });
-    });
-  }
-
-  protected getOpenPrNumbers(): Promise<number[]> {
-    const githubPullRequests = new GithubPullRequests(this.githubToken, this.repoSlug);
-
-    return githubPullRequests.
-      fetchAll('open').
-      then(prs => prs.map(pr => pr.number));
-  }
-
-  protected removeDir(dir: string) {
-    try {
-      if (shell.test('-d', dir)) {
-        // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
-        (shell as any).chmod('-R', 'a+w', dir);
-        shell.rm('-rf', dir);
-      }
-    } catch (err) {
-      console.error(`ERROR: Unable to remove '${dir}' due to:`, err);
-    }
-  }
-
-  protected removeUnnecessaryBuilds(existingBuildNumbers: number[], openPrNumbers: number[]) {
-    const toRemove = existingBuildNumbers.filter(num => !openPrNumbers.includes(num));
-
-    console.log(`Existing builds: ${existingBuildNumbers.length}`);
-    console.log(`Open pull requests: ${openPrNumbers.length}`);
-    console.log(`Removing ${toRemove.length} build(s): ${toRemove.join(', ')}`);
-
-    // Try removing public dirs.
-    toRemove.
-      map(num => path.join(this.buildsDir, String(num))).
-      forEach(dir => this.removeDir(dir));
-
-    // Try removing hidden dirs.
-    toRemove.
-      map(num => path.join(this.buildsDir, HIDDEN_DIR_PREFIX + String(num))).
-      forEach(dir => this.removeDir(dir));
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/clean-up/index.ts

@@ -1,23 +0,0 @@
-// Imports
-import {getEnvVar} from '../common/utils';
-import {BuildCleaner} from './build-cleaner';
-
-// Constants
-const AIO_BUILDS_DIR = getEnvVar('AIO_BUILDS_DIR');
-const AIO_GITHUB_TOKEN = getEnvVar('AIO_GITHUB_TOKEN', true);
-const AIO_REPO_SLUG = getEnvVar('AIO_REPO_SLUG');
-
-// Run
-_main();
-
-// Functions
-function _main() {
-  console.log(`[${new Date()}] - Cleaning up builds...`);
-
-  const buildCleaner = new BuildCleaner(AIO_BUILDS_DIR, AIO_REPO_SLUG, AIO_GITHUB_TOKEN);
-
-  buildCleaner.cleanUp().catch(err => {
-    console.error('ERROR:', err);
-    process.exit(1);
-  });
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/constants.ts

@@ -1,3 +0,0 @@
-// Constants
-export const HIDDEN_DIR_PREFIX = 'hidden--';
-export const SHORT_SHA_LEN = 7;

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/github-api.ts

@@ -1,110 +0,0 @@
-// Imports
-import {IncomingMessage} from 'http';
-import * as https from 'https';
-import {assertNotMissingOrEmpty} from './utils';
-
-// Constants
-const GITHUB_HOSTNAME = 'api.github.com';
-
-// Interfaces - Types
-interface RequestParams {
-  [key: string]: string | number;
-}
-
-type RequestParamsOrNull = RequestParams | null;
-
-// Classes
-export class GithubApi {
-  protected requestHeaders: {[key: string]: string};
-
-  // Constructor
-  constructor(githubToken: string) {
-    assertNotMissingOrEmpty('githubToken', githubToken);
-
-    this.requestHeaders = {
-      'Authorization': `token ${githubToken}`,
-      'User-Agent': `Node/${process.versions.node}`,
-    };
-  }
-
-  // Methods - Public
-  public get<T>(pathname: string, params?: RequestParamsOrNull): Promise<T> {
-    const path = this.buildPath(pathname, params);
-    return this.request<T>('get', path);
-  }
-
-  public post<T>(pathname: string, params?: RequestParamsOrNull, data?: any): Promise<T> {
-    const path = this.buildPath(pathname, params);
-    return this.request<T>('post', path, data);
-  }
-
-  // Methods - Protected
-  protected buildPath(pathname: string, params?: RequestParamsOrNull): string {
-    if (params == null) {
-      return pathname;
-    }
-
-    const search = (params === null) ? '' : this.serializeSearchParams(params);
-    const joiner = search && '?';
-
-    return `${pathname}${joiner}${search}`;
-  }
-
-  protected getPaginated<T>(pathname: string, baseParams: RequestParams = {}, currentPage: number = 0): Promise<T[]> {
-    const perPage = 100;
-    const params = {
-      ...baseParams,
-      page: currentPage,
-      per_page: perPage,
-    };
-
-    return this.get<T[]>(pathname, params).then(items => {
-      if (items.length < perPage) {
-        return items;
-      }
-
-      return this.getPaginated<T>(pathname, baseParams, currentPage + 1).then(moreItems => [...items, ...moreItems]);
-    });
-  }
-
-  protected request<T>(method: string, path: string, data: any = null): Promise<T> {
-    return new Promise<T>((resolve, reject) => {
-      const options = {
-        headers: {...this.requestHeaders},
-        host: GITHUB_HOSTNAME,
-        method,
-        path,
-      };
-
-      const onError = (statusCode: number, responseText: string) => {
-        const url = `https://${GITHUB_HOSTNAME}${path}`;
-        reject(`Request to '${url}' failed (status: ${statusCode}): ${responseText}`);
-      };
-      const onSuccess = (responseText: string) => {
-        try { resolve(JSON.parse(responseText)); } catch (err) { reject(err); }
-      };
-      const onResponse = (res: IncomingMessage) => {
-        const statusCode = res.statusCode || -1;
-        const isSuccess = (200 <= statusCode) && (statusCode < 400);
-        let responseText = '';
-
-        res.
-          on('data', d => responseText += d).
-          on('end', () => isSuccess ? onSuccess(responseText) : onError(statusCode, responseText)).
-          on('error', reject);
-      };
-
-      https.
-        request(options, onResponse).
-        on('error', reject).
-        end(data && JSON.stringify(data));
-    });
-  }
-
-  protected serializeSearchParams(params: RequestParams): string {
-    return Object.keys(params).
-      filter(key => params[key] != null).
-      map(key => `${key}=${encodeURIComponent(String(params[key]))}`).
-      join('&');
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/github-pull-requests.ts

@@ -1,46 +0,0 @@
-// Imports
-import {assertNotMissingOrEmpty} from '../common/utils';
-import {GithubApi} from './github-api';
-
-// Interfaces - Types
-export interface PullRequest  {
-  number: number;
-  user: {login: string};
-  labels: {name: string}[];
-}
-
-export type PullRequestState = 'all' | 'closed' | 'open';
-
-// Classes
-export class GithubPullRequests extends GithubApi {
-  // Constructor
-  constructor(githubToken: string, protected repoSlug: string) {
-    super(githubToken);
-    assertNotMissingOrEmpty('repoSlug', repoSlug);
-  }
-
-  // Methods - Public
-  public addComment(pr: number, body: string): Promise<void> {
-    if (!(pr > 0)) {
-      throw new Error(`Invalid PR number: ${pr}`);
-    } else if (!body) {
-      throw new Error(`Invalid or empty comment body: ${body}`);
-    }
-
-    return this.post<void>(`/repos/${this.repoSlug}/issues/${pr}/comments`, null, {body});
-  }
-
-  public fetch(pr: number): Promise<PullRequest> {
-    // Using the `/issues/` URL, because the `/pulls/` one does not provide labels.
-    return this.get<PullRequest>(`/repos/${this.repoSlug}/issues/${pr}`);
-  }
-
-  public fetchAll(state: PullRequestState = 'all'): Promise<PullRequest[]> {
-    console.log(`Fetching ${state} pull requests...`);
-
-    const pathname = `/repos/${this.repoSlug}/pulls`;
-    const params = {state};
-
-    return this.getPaginated<PullRequest>(pathname, params);
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/github-teams.ts

@@ -1,45 +0,0 @@
-// Imports
-import {assertNotMissingOrEmpty} from '../common/utils';
-import {GithubApi} from './github-api';
-
-// Interfaces - Types
-interface Team {
-  id: number;
-  slug: string;
-}
-
-interface TeamMembership {
-  state: string;
-}
-
-// Classes
-export class GithubTeams extends GithubApi {
-  // Constructor
-  constructor(githubToken: string, protected organization: string) {
-    super(githubToken);
-    assertNotMissingOrEmpty('organization', organization);
-  }
-
-  // Methods - Public
-  public fetchAll(): Promise<Team[]> {
-    return this.getPaginated<Team>(`/orgs/${this.organization}/teams`);
-  }
-
-  public isMemberById(username: string, teamIds: number[]): Promise<boolean> {
-    const getMembership = (teamId: number) =>
-      this.get<TeamMembership>(`/teams/${teamId}/memberships/${username}`).
-        then(membership => membership.state === 'active').
-        catch(() => false);
-    const reduceFn = (promise: Promise<boolean>, teamId: number) =>
-      promise.then(isMember => isMember || getMembership(teamId));
-
-    return teamIds.reduce(reduceFn, Promise.resolve(false));
-  }
-
-  public isMemberBySlug(username: string, teamSlugs: string[]): Promise<boolean> {
-    return this.fetchAll().
-      then(teams => teams.filter(team => teamSlugs.includes(team.slug)).map(team => team.id)).
-      then(teamIds => this.isMemberById(username, teamIds)).
-      catch(() => false);
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/run-tests.ts

@@ -1,23 +0,0 @@
-export const runTests = (specFiles: string[], helpers?: string[]) => {
-  // We can't use `import` here, because of the following mess:
-  // - GitHub project `jasmine/jasmine` is `jasmine-core` on npm and its typings `@types/jasmine`.
-  // - GitHub project `jasmine/jasmine-npm` is `jasmine` on npm and has no typings.
-  //
-  // Using `import...from 'jasmine'` here, would import from `@types/jasmine` (which refers to the
-  // `jasmine-core` module and the `jasmine` module).
-  // tslint:disable-next-line: no-var-requires variable-name
-  const Jasmine = require('jasmine');
-  const config = {
-    helpers,
-    random: true,
-    spec_files: specFiles,
-    stopSpecOnExpectationFailure: true,
-  };
-
-  process.on('unhandledRejection', (reason: any) => console.log('Unhandled rejection:', reason));
-
-  const runner = new Jasmine();
-  runner.loadConfig(config);
-  runner.onComplete((passed: boolean) => process.exit(passed ? 0 : 1));
-  runner.execute();
-};

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/utils.ts

@@ -1,17 +0,0 @@
-// Functions
-export const assertNotMissingOrEmpty = (name: string, value: string | null | undefined) => {
-  if (!value) {
-    throw new Error(`Missing or empty required parameter '${name}'!`);
-  }
-};
-
-export const getEnvVar = (name: string, isOptional = false): string => {
-  const value = process.env[name];
-
-  if (!isOptional && !value) {
-    console.error(`ERROR: Missing required environment variable '${name}'!`);
-    process.exit(1);
-  }
-
-  return value || '';
-};

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/build-creator.ts

@@ -1,141 +0,0 @@
-// Imports
-import * as cp from 'child_process';
-import {EventEmitter} from 'events';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as shell from 'shelljs';
-import {HIDDEN_DIR_PREFIX, SHORT_SHA_LEN} from '../common/constants';
-import {assertNotMissingOrEmpty} from '../common/utils';
-import {ChangedPrVisibilityEvent, CreatedBuildEvent} from './build-events';
-import {UploadError} from './upload-error';
-
-// Classes
-export class BuildCreator extends EventEmitter {
-  // Constructor
-  constructor(protected buildsDir: string) {
-    super();
-    assertNotMissingOrEmpty('buildsDir', buildsDir);
-  }
-
-  // Methods - Public
-  public create(pr: string, sha: string, archivePath: string, isPublic: boolean): Promise<void> {
-    // Use only part of the SHA for more readable URLs.
-    sha = sha.substr(0, SHORT_SHA_LEN);
-
-    const {newPrDir: prDir} = this.getCandidatePrDirs(pr, isPublic);
-    const shaDir = path.join(prDir, sha);
-    let dirToRemoveOnError: string;
-
-    return Promise.resolve().
-      // If the same PR exists with different visibility, update the visibility first.
-      then(() => this.updatePrVisibility(pr, isPublic)).
-      then(() => Promise.all([this.exists(prDir), this.exists(shaDir)])).
-      then(([prDirExisted, shaDirExisted]) => {
-        if (shaDirExisted) {
-          const publicOrNot = isPublic ? 'public' : 'non-public';
-          throw new UploadError(409, `Request to overwrite existing ${publicOrNot} directory: ${shaDir}`);
-        }
-
-        dirToRemoveOnError = prDirExisted ? shaDir : prDir;
-
-        return Promise.resolve().
-          then(() => shell.mkdir('-p', shaDir)).
-          then(() => this.extractArchive(archivePath, shaDir)).
-          then(() => this.emit(CreatedBuildEvent.type, new CreatedBuildEvent(+pr, sha, isPublic))).
-          then(() => undefined);
-      }).
-      catch(err => {
-        if (dirToRemoveOnError) {
-          shell.rm('-rf', dirToRemoveOnError);
-        }
-
-        if (!(err instanceof UploadError)) {
-          err = new UploadError(500, `Error while uploading to directory: ${shaDir}\n${err}`);
-        }
-
-        throw err;
-      });
-  }
-
-  public updatePrVisibility(pr: string, makePublic: boolean): Promise<boolean> {
-    const {oldPrDir: otherVisPrDir, newPrDir: targetVisPrDir} = this.getCandidatePrDirs(pr, makePublic);
-
-    return Promise.
-      all([this.exists(otherVisPrDir), this.exists(targetVisPrDir)]).
-      then(([otherVisPrDirExisted, targetVisPrDirExisted]) => {
-        if (!otherVisPrDirExisted) {
-          // No visibility change: Either the visibility is up-to-date or the PR does not exist.
-          return false;
-        } else if (targetVisPrDirExisted) {
-          // Error: Directories for both visibilities exist.
-          throw new UploadError(409, `Request to move '${otherVisPrDir}' to existing directory '${targetVisPrDir}'.`);
-        }
-
-        // Visibility change: Moving `otherVisPrDir` to `targetVisPrDir`.
-        return Promise.resolve().
-          then(() => shell.mv(otherVisPrDir, targetVisPrDir)).
-          then(() => this.listShasByDate(targetVisPrDir)).
-          then(shas => this.emit(ChangedPrVisibilityEvent.type, new ChangedPrVisibilityEvent(+pr, shas, makePublic))).
-          then(() => true);
-      }).
-      catch(err => {
-        if (!(err instanceof UploadError)) {
-          err = new UploadError(500, `Error while making PR ${pr} ${makePublic ? 'public' : 'hidden'}.\n${err}`);
-        }
-
-        throw err;
-      });
-  }
-
-  // Methods - Protected
-  protected exists(fileOrDir: string): Promise<boolean> {
-    return new Promise(resolve => fs.access(fileOrDir, err => resolve(!err)));
-  }
-
-  protected extractArchive(inputFile: string, outputDir: string): Promise<void> {
-    return new Promise<void>((resolve, reject) => {
-      const cmd = `tar --extract --gzip --directory "${outputDir}" --file "${inputFile}"`;
-
-      cp.exec(cmd, (err, _stdout, stderr) => {
-        if (err) {
-          return reject(err);
-        }
-
-        if (stderr) {
-          console.warn(stderr);
-        }
-
-        try {
-          // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
-          (shell as any).chmod('-R', 'a-w', outputDir);
-          shell.rm('-f', inputFile);
-          resolve();
-        } catch (err) {
-          reject(err);
-        }
-      });
-    });
-  }
-
-  protected getCandidatePrDirs(pr: string, isPublic: boolean) {
-    const hiddenPrDir = path.join(this.buildsDir, HIDDEN_DIR_PREFIX + pr);
-    const publicPrDir = path.join(this.buildsDir, pr);
-
-    const oldPrDir = isPublic ? hiddenPrDir : publicPrDir;
-    const newPrDir = isPublic ? publicPrDir : hiddenPrDir;
-
-    return {oldPrDir, newPrDir};
-  }
-
-  protected listShasByDate(inputDir: string): Promise<string[]> {
-    return Promise.resolve().
-      then(() => shell.ls('-l', inputDir) as any as Promise<(fs.Stats & {name: string})[]>).
-      // Keep directories only.
-      // (Also, convert to standard Array - ShellJS provides custom `sort()` method for sorting file contents.)
-      then(items => items.filter(item => item.isDirectory())).
-      // Sort by modification date.
-      then(items => items.sort((a, b) => a.mtime.getTime() - b.mtime.getTime())).
-      // Return directory names.
-      then(items => items.map(item => item.name));
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/build-events.ts

@@ -1,16 +0,0 @@
-// Classes
-export class ChangedPrVisibilityEvent {
-  // Properties - Public, Static
-  public static type = 'pr.changedVisibility';
-
-  // Constructor
-  constructor(public pr: number, public shas: string[], public isPublic: boolean) {}
-}
-
-export class CreatedBuildEvent {
-  // Properties - Public, Static
-  public static type = 'build.created';
-
-  // Constructor
-  constructor(public pr: number, public sha: string, public isPublic: boolean) {}
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/build-verifier.ts

@@ -1,87 +0,0 @@
-// Imports
-import * as jwt from 'jsonwebtoken';
-import {GithubPullRequests, PullRequest} from '../common/github-pull-requests';
-import {GithubTeams} from '../common/github-teams';
-import {assertNotMissingOrEmpty} from '../common/utils';
-import {UploadError} from './upload-error';
-
-// Interfaces - Types
-interface JwtPayload {
-  slug: string;
-  'pull-request': number;
-}
-
-// Enums
-export enum BUILD_VERIFICATION_STATUS {
-  verifiedAndTrusted,
-  verifiedNotTrusted,
-}
-
-// Classes
-export class BuildVerifier {
-  // Properties - Protected
-  protected githubPullRequests: GithubPullRequests;
-  protected githubTeams: GithubTeams;
-
-  // Constructor
-  constructor(protected secret: string, githubToken: string, protected repoSlug: string, organization: string,
-              protected allowedTeamSlugs: string[], protected trustedPrLabel: string) {
-    assertNotMissingOrEmpty('secret', secret);
-    assertNotMissingOrEmpty('githubToken', githubToken);
-    assertNotMissingOrEmpty('repoSlug', repoSlug);
-    assertNotMissingOrEmpty('organization', organization);
-    assertNotMissingOrEmpty('allowedTeamSlugs', allowedTeamSlugs && allowedTeamSlugs.join(''));
-    assertNotMissingOrEmpty('trustedPrLabel', trustedPrLabel);
-
-    this.githubPullRequests = new GithubPullRequests(githubToken, repoSlug);
-    this.githubTeams = new GithubTeams(githubToken, organization);
-  }
-
-  // Methods - Public
-  public getPrIsTrusted(pr: number): Promise<boolean> {
-    return Promise.resolve().
-      then(() => this.githubPullRequests.fetch(pr)).
-      then(prInfo => this.hasLabel(prInfo, this.trustedPrLabel) ||
-                     this.githubTeams.isMemberBySlug(prInfo.user.login, this.allowedTeamSlugs));
-  }
-
-  public verify(expectedPr: number, authHeader: string): Promise<BUILD_VERIFICATION_STATUS> {
-    return Promise.resolve().
-      then(() => this.extractJwtString(authHeader)).
-      then(jwtString => this.verifyJwt(expectedPr, jwtString)).
-      then(jwtPayload => this.verifyPr(jwtPayload['pull-request'])).
-      catch(err => { throw new UploadError(403, `Error while verifying upload for PR ${expectedPr}: ${err}`); });
-  }
-
-  // Methods - Protected
-  protected extractJwtString(input: string): string {
-    return input.replace(/^token +/i, '');
-  }
-
-  protected hasLabel(prInfo: PullRequest, label: string) {
-    return prInfo.labels.some(labelObj => labelObj.name === label);
-  }
-
-  protected verifyJwt(expectedPr: number, token: string): Promise<JwtPayload> {
-    return new Promise((resolve, reject) => {
-      jwt.verify(token, this.secret, {issuer: 'Travis CI, GmbH'}, (err, payload: JwtPayload) => {
-        if (err) {
-          reject(err.message || err);
-        } else if (payload.slug !== this.repoSlug) {
-          reject(`jwt slug invalid. expected: ${this.repoSlug}`);
-        } else if (payload['pull-request'] !== expectedPr) {
-          reject(`jwt pull-request invalid. expected: ${expectedPr}`);
-        } else {
-          resolve(payload);
-        }
-      });
-    });
-  }
-
-  protected verifyPr(pr: number): Promise<BUILD_VERIFICATION_STATUS> {
-    return this.getPrIsTrusted(pr).
-      then(isTrusted => Promise.resolve(isTrusted ?
-          BUILD_VERIFICATION_STATUS.verifiedAndTrusted :
-          BUILD_VERIFICATION_STATUS.verifiedNotTrusted));
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/index-preverify-pr.ts

@@ -1,39 +0,0 @@
-// Imports
-import {getEnvVar} from '../common/utils';
-import {BuildVerifier} from './build-verifier';
-
-// Run
-_main();
-
-// Functions
-function _main() {
-  const secret = 'unused';
-  const githubToken = getEnvVar('AIO_GITHUB_TOKEN');
-  const repoSlug = getEnvVar('AIO_REPO_SLUG');
-  const organization = getEnvVar('AIO_GITHUB_ORGANIZATION');
-  const allowedTeamSlugs = getEnvVar('AIO_GITHUB_TEAM_SLUGS').split(',');
-  const trustedPrLabel = getEnvVar('AIO_TRUSTED_PR_LABEL');
-  const pr = +getEnvVar('AIO_PREVERIFY_PR');
-
-  const buildVerifier = new BuildVerifier(secret, githubToken, repoSlug, organization, allowedTeamSlugs,
-                                          trustedPrLabel);
-
-  // Exit codes:
-  // - 0: The PR can be automatically trusted (i.e. author belongs to trusted team or PR has the "trusted PR" label).
-  // - 1: An error occurred.
-  // - 2: The PR cannot be automatically trusted.
-  buildVerifier.getPrIsTrusted(pr).
-    then(isTrusted => {
-      if (!isTrusted) {
-        console.warn(
-            `The PR cannot be automatically verified, because it doesn't have the "${trustedPrLabel}" label and the ` +
-            `the author is not an active member of any of the following teams: ${allowedTeamSlugs.join(', ')}`);
-      }
-
-      process.exit(isTrusted ? 0 : 2);
-    }).
-    catch(err => {
-      console.error(err);
-      process.exit(1);
-    });
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/index.ts

@@ -1,34 +0,0 @@
-// Imports
-import {getEnvVar} from '../common/utils';
-import {uploadServerFactory} from './upload-server-factory';
-
-// Constants
-const AIO_BUILDS_DIR = getEnvVar('AIO_BUILDS_DIR');
-const AIO_DOMAIN_NAME = getEnvVar('AIO_DOMAIN_NAME');
-const AIO_GITHUB_ORGANIZATION = getEnvVar('AIO_GITHUB_ORGANIZATION');
-const AIO_GITHUB_TEAM_SLUGS = getEnvVar('AIO_GITHUB_TEAM_SLUGS');
-const AIO_GITHUB_TOKEN = getEnvVar('AIO_GITHUB_TOKEN');
-const AIO_PREVIEW_DEPLOYMENT_TOKEN = getEnvVar('AIO_PREVIEW_DEPLOYMENT_TOKEN');
-const AIO_REPO_SLUG = getEnvVar('AIO_REPO_SLUG');
-const AIO_TRUSTED_PR_LABEL = getEnvVar('AIO_TRUSTED_PR_LABEL');
-const AIO_UPLOAD_HOSTNAME = getEnvVar('AIO_UPLOAD_HOSTNAME');
-const AIO_UPLOAD_PORT = +getEnvVar('AIO_UPLOAD_PORT');
-
-// Run
-_main();
-
-// Functions
-function _main() {
-  uploadServerFactory.
-    create({
-      buildsDir: AIO_BUILDS_DIR,
-      domainName: AIO_DOMAIN_NAME,
-      githubOrganization: AIO_GITHUB_ORGANIZATION,
-      githubTeamSlugs: AIO_GITHUB_TEAM_SLUGS.split(','),
-      githubToken: AIO_GITHUB_TOKEN,
-      repoSlug: AIO_REPO_SLUG,
-      secret: AIO_PREVIEW_DEPLOYMENT_TOKEN,
-      trustedPrLabel: AIO_TRUSTED_PR_LABEL,
-    }).
-    listen(AIO_UPLOAD_PORT, AIO_UPLOAD_HOSTNAME);
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/upload-error.ts

@@ -1,8 +0,0 @@
-// Classes
-export class UploadError extends Error {
-  // Constructor
-  constructor(public status: number = 500, message?: string) {
-    super(message);
-    Object.setPrototypeOf(this, UploadError.prototype);
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/upload-server-factory.ts

@@ -1,153 +0,0 @@
-// Imports
-import * as bodyParser from 'body-parser';
-import * as express from 'express';
-import * as http from 'http';
-import {GithubPullRequests} from '../common/github-pull-requests';
-import {assertNotMissingOrEmpty} from '../common/utils';
-import {BuildCreator} from './build-creator';
-import {ChangedPrVisibilityEvent, CreatedBuildEvent} from './build-events';
-import {BUILD_VERIFICATION_STATUS, BuildVerifier} from './build-verifier';
-import {UploadError} from './upload-error';
-
-// Constants
-const AUTHORIZATION_HEADER = 'AUTHORIZATION';
-const X_FILE_HEADER = 'X-FILE';
-
-// Interfaces - Types
-interface UploadServerConfig {
-  buildsDir: string;
-  domainName: string;
-  githubOrganization: string;
-  githubTeamSlugs: string[];
-  githubToken: string;
-  repoSlug: string;
-  secret: string;
-  trustedPrLabel: string;
-}
-
-// Classes
-class UploadServerFactory {
-  // Methods - Public
-  public create({
-    buildsDir,
-    domainName,
-    githubOrganization,
-    githubTeamSlugs,
-    githubToken,
-    repoSlug,
-    secret,
-    trustedPrLabel,
-  }: UploadServerConfig): http.Server {
-    assertNotMissingOrEmpty('domainName', domainName);
-
-    const buildVerifier = new BuildVerifier(secret, githubToken, repoSlug, githubOrganization, githubTeamSlugs,
-                                            trustedPrLabel);
-    const buildCreator = this.createBuildCreator(buildsDir, githubToken, repoSlug, domainName);
-
-    const middleware = this.createMiddleware(buildVerifier, buildCreator);
-    const httpServer = http.createServer(middleware as any);
-
-    httpServer.on('listening', () => {
-      const info = httpServer.address();
-      console.info(`Up and running (and listening on ${info.address}:${info.port})...`);
-    });
-
-    return httpServer;
-  }
-
-  // Methods - Protected
-  protected createBuildCreator(buildsDir: string, githubToken: string, repoSlug: string,
-                               domainName: string): BuildCreator {
-    const buildCreator = new BuildCreator(buildsDir);
-    const githubPullRequests = new GithubPullRequests(githubToken, repoSlug);
-    const postPreviewsComment = (pr: number, shas: string[]) => {
-      const body = shas.
-        map(sha => `You can preview ${sha} at https://pr${pr}-${sha}.${domainName}/.`).
-        join('\n');
-
-      return githubPullRequests.addComment(pr, body);
-    };
-
-    buildCreator.on(CreatedBuildEvent.type, ({pr, sha, isPublic}: CreatedBuildEvent) => {
-      if (isPublic) {
-        postPreviewsComment(pr, [sha]);
-      }
-    });
-
-    buildCreator.on(ChangedPrVisibilityEvent.type, ({pr, shas, isPublic}: ChangedPrVisibilityEvent) => {
-      if (isPublic && shas.length) {
-        postPreviewsComment(pr, shas);
-      }
-    });
-
-    return buildCreator;
-  }
-
-  protected createMiddleware(buildVerifier: BuildVerifier, buildCreator: BuildCreator): express.Express {
-    const middleware = express();
-    const jsonParser = bodyParser.json();
-
-    middleware.get(/^\/create-build\/([1-9][0-9]*)\/([0-9a-f]{40})\/?$/, (req, res) => {
-      const pr = req.params[0];
-      const sha = req.params[1];
-      const archive = req.header(X_FILE_HEADER);
-      const authHeader = req.header(AUTHORIZATION_HEADER);
-
-      if (!authHeader) {
-        this.throwRequestError(401, `Missing or empty '${AUTHORIZATION_HEADER}' header`, req);
-      } else if (!archive) {
-        this.throwRequestError(400, `Missing or empty '${X_FILE_HEADER}' header`, req);
-      } else {
-        Promise.resolve().
-          then(() => buildVerifier.verify(+pr, authHeader)).
-          then(verStatus => verStatus === BUILD_VERIFICATION_STATUS.verifiedAndTrusted).
-          then(isPublic => buildCreator.create(pr, sha, archive, isPublic).
-            then(() => res.sendStatus(isPublic ? 201 : 202))).
-          catch(err => this.respondWithError(res, err));
-      }
-    });
-    middleware.get(/^\/health-check\/?$/, (_req, res) => res.sendStatus(200));
-    middleware.post(/^\/pr-updated\/?$/, jsonParser, (req, res) => {
-      const {action, number: prNo}: {action?: string, number?: number} = req.body;
-      const visMayHaveChanged = !action || (action === 'labeled') || (action === 'unlabeled');
-
-      if (!visMayHaveChanged) {
-        res.sendStatus(200);
-      } else if (!prNo) {
-        this.throwRequestError(400, `Missing or empty 'number' field`, req);
-      } else {
-        Promise.resolve().
-          then(() => buildVerifier.getPrIsTrusted(prNo)).
-          then(isPublic => buildCreator.updatePrVisibility(String(prNo), isPublic)).
-          then(() => res.sendStatus(200)).
-          catch(err => this.respondWithError(res, err));
-      }
-    });
-    middleware.all('*', req => this.throwRequestError(404, 'Unknown resource', req));
-    middleware.use((err: any, _req: any, res: express.Response, _next: any) => this.respondWithError(res, err));
-
-    return middleware;
-  }
-
-  protected respondWithError(res: express.Response, err: any) {
-    if (!(err instanceof UploadError)) {
-      err = new UploadError(500, String((err && err.message) || err));
-    }
-
-    const statusText = http.STATUS_CODES[err.status] || '???';
-    console.error(`Upload error: ${err.status} - ${statusText}`);
-    console.error(err.message);
-
-    res.status(err.status).end(err.message);
-  }
-
-  protected throwRequestError(status: number, error: string, req: express.Request) {
-    const message = `${error} in request: ${req.method} ${req.originalUrl}` +
-                    (!req.body ? '' : ` ${JSON.stringify(req.body)}`);
-
-    throw new UploadError(status, message);
-  }
-}
-
-// Exports
-export const uploadServerFactory = new UploadServerFactory();

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/constants.ts

@@ -1,16 +0,0 @@
-// Using the values below, we can fake the response of the corresponding methods in tests. This is
-// necessary, because the test upload-server will be running as a separate node process, so we will
-// not have direct access to the code (e.g. for mocking).
-// (See also 'lib/verify-setup/start-test-upload-server.ts'.)
-
-/* tslint:disable: variable-name */
-
-// Special values to be used as `authHeader` in `BuildVerifier#verify()`.
-export const BV_verify_error = 'FAKE_VERIFICATION_ERROR';
-export const BV_verify_verifiedNotTrusted = 'FAKE_VERIFIED_NOT_TRUSTED';
-
-// Special values to be used as `pr` in `BuildVerifier#getPrIsTrusted()`.
-export const BV_getPrIsTrusted_error = 32203;
-export const BV_getPrIsTrusted_notTrusted = 72457;
-
-/* tslint:enable: variable-name */

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/helper.ts

@@ -1,215 +0,0 @@
-// Imports
-import * as cp from 'child_process';
-import * as fs from 'fs';
-import * as http from 'http';
-import * as path from 'path';
-import * as shell from 'shelljs';
-import {HIDDEN_DIR_PREFIX, SHORT_SHA_LEN} from '../common/constants';
-import {getEnvVar} from '../common/utils';
-
-// Constans
-const TEST_AIO_BUILDS_DIR = getEnvVar('TEST_AIO_BUILDS_DIR');
-const TEST_AIO_NGINX_HOSTNAME = getEnvVar('TEST_AIO_NGINX_HOSTNAME');
-const TEST_AIO_NGINX_PORT_HTTP = +getEnvVar('TEST_AIO_NGINX_PORT_HTTP');
-const TEST_AIO_NGINX_PORT_HTTPS = +getEnvVar('TEST_AIO_NGINX_PORT_HTTPS');
-const TEST_AIO_UPLOAD_HOSTNAME = getEnvVar('TEST_AIO_UPLOAD_HOSTNAME');
-const TEST_AIO_UPLOAD_MAX_SIZE = +getEnvVar('TEST_AIO_UPLOAD_MAX_SIZE');
-const TEST_AIO_UPLOAD_PORT = +getEnvVar('TEST_AIO_UPLOAD_PORT');
-const WWW_USER = getEnvVar('AIO_WWW_USER');
-
-// Interfaces - Types
-export interface CmdResult { success: boolean; err: Error | null; stdout: string; stderr: string; }
-export interface FileSpecs { content?: string; size?: number; }
-
-export type CleanUpFn = () => void;
-export type TestSuiteFactory = (scheme: string, port: number) => void;
-export type VerifyCmdResultFn = (result: CmdResult) => void;
-
-// Classes
-class Helper {
-  // Properties - Public
-  public get buildsDir() { return TEST_AIO_BUILDS_DIR; }
-  public get nginxHostname() { return TEST_AIO_NGINX_HOSTNAME; }
-  public get nginxPortHttp() { return TEST_AIO_NGINX_PORT_HTTP; }
-  public get nginxPortHttps() { return TEST_AIO_NGINX_PORT_HTTPS; }
-  public get uploadHostname() { return TEST_AIO_UPLOAD_HOSTNAME; }
-  public get uploadPort() { return TEST_AIO_UPLOAD_PORT; }
-  public get uploadMaxSize() { return TEST_AIO_UPLOAD_MAX_SIZE; }
-  public get wwwUser() { return WWW_USER; }
-
-  // Properties - Protected
-  protected cleanUpFns: CleanUpFn[] = [];
-  protected portPerScheme: {[scheme: string]: number} = {
-    http: this.nginxPortHttp,
-    https: this.nginxPortHttps,
-  };
-
-  // Constructor
-  constructor() {
-    shell.mkdir('-p', this.buildsDir);
-    shell.exec(`chown -R ${this.wwwUser} ${this.buildsDir}`);
-  }
-
-  // Methods - Public
-  public buildExists(pr: string, sha = '', isPublic = true, legacy = false): boolean {
-    const prDir = this.getPrDir(pr, isPublic);
-    const dir = !sha ? prDir : this.getShaDir(prDir, sha, legacy);
-    return fs.existsSync(dir);
-  }
-
-  public cleanUp() {
-    while (this.cleanUpFns.length) {
-      // Clean-up fns remove themselves from the list.
-      this.cleanUpFns[0]();
-    }
-
-    if (fs.readdirSync(this.buildsDir).length) {
-      throw new Error(`Directory '${this.buildsDir}' is not empty after clean-up.`);
-    }
-  }
-
-  public createDummyArchive(pr: string, sha: string, archivePath: string): CleanUpFn {
-    const inputDir = this.getShaDir(this.getPrDir(`uploaded/${pr}`, true), sha);
-    const cmd1 = `tar --create --gzip --directory "${inputDir}" --file "${archivePath}" .`;
-    const cmd2 = `chown ${this.wwwUser} ${archivePath}`;
-
-    const cleanUpTemp = this.createDummyBuild(`uploaded/${pr}`, sha, true, true);
-    shell.exec(cmd1);
-    shell.exec(cmd2);
-    cleanUpTemp();
-
-    return this.createCleanUpFn(() => shell.rm('-rf', archivePath));
-  }
-
-  public createDummyBuild(pr: string, sha: string, isPublic = true, force = false, legacy = false): CleanUpFn {
-    const prDir = this.getPrDir(pr, isPublic);
-    const shaDir = this.getShaDir(prDir, sha, legacy);
-    const idxPath = path.join(shaDir, 'index.html');
-    const barPath = path.join(shaDir, 'foo', 'bar.js');
-
-    this.writeFile(idxPath, {content: `PR: ${pr} | SHA: ${sha} | File: /index.html`}, force);
-    this.writeFile(barPath, {content: `PR: ${pr} | SHA: ${sha} | File: /foo/bar.js`}, force);
-    shell.exec(`chown -R ${this.wwwUser} ${prDir}`);
-
-    return this.createCleanUpFn(() => shell.rm('-rf', prDir));
-  }
-
-  public deletePrDir(pr: string, isPublic = true) {
-    const prDir = this.getPrDir(pr, isPublic);
-
-    if (fs.existsSync(prDir)) {
-      // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
-      (shell as any).chmod('-R', 'a+w', prDir);
-      shell.rm('-rf', prDir);
-    }
-  }
-
-  public getPrDir(pr: string, isPublic: boolean): string {
-    const prDirName = isPublic ? pr : HIDDEN_DIR_PREFIX + pr;
-    return path.join(this.buildsDir, prDirName);
-  }
-
-  public getShaDir(prDir: string, sha: string, legacy = false): string {
-    return path.join(prDir, legacy ? sha : this.getShordSha(sha));
-  }
-
-  public getShordSha(sha: string): string {
-    return sha.substr(0, SHORT_SHA_LEN);
-  }
-
-  public readBuildFile(pr: string, sha: string, relFilePath: string, isPublic = true, legacy = false): string {
-    const shaDir = this.getShaDir(this.getPrDir(pr, isPublic), sha, legacy);
-    const absFilePath = path.join(shaDir, relFilePath);
-    return fs.readFileSync(absFilePath, 'utf8');
-  }
-
-  public runCmd(cmd: string, opts: cp.ExecFileOptions = {}): Promise<CmdResult> {
-    return new Promise(resolve => {
-      const proc = cp.exec(cmd, opts, (err, stdout, stderr) => resolve({success: !err, err, stdout, stderr}));
-      this.createCleanUpFn(() => proc.kill());
-    });
-  }
-
-  public runForAllSupportedSchemes(suiteFactory: TestSuiteFactory) {
-    Object.keys(this.portPerScheme).forEach(scheme => suiteFactory(scheme, this.portPerScheme[scheme]));
-  }
-
-  public verifyResponse(status: number | [number, string], regex = /^/): VerifyCmdResultFn {
-    let statusCode: number;
-    let statusText: string;
-
-    if (Array.isArray(status)) {
-      statusCode = status[0];
-      statusText = status[1];
-    } else {
-      statusCode = status;
-      statusText = http.STATUS_CODES[statusCode] || 'UNKNOWN_STATUS_CODE';
-    }
-
-    return (result: CmdResult) => {
-      const [headers, body] = result.stdout.
-        split(/(?:\r?\n){2,}/).
-        map(s => s.trim()).
-        slice(-2);   // In case of redirect, discard the previous headers.
-                     // Only keep the last to sections (final headers and body).
-
-      if (!result.success) {
-        console.log('Stdout:', result.stdout);
-        console.log('Stderr:', result.stderr);
-        console.log('Error:', result.err);
-      }
-
-      expect(result.success).toBe(true);
-      expect(headers).toContain(`${statusCode} ${statusText}`);
-      expect(body).toMatch(regex);
-    };
-  }
-
-  public writeBuildFile(pr: string, sha: string, relFilePath: string, content: string, isPublic = true,
-                        legacy = false): CleanUpFn {
-    const shaDir = this.getShaDir(this.getPrDir(pr, isPublic), sha, legacy);
-    const absFilePath = path.join(shaDir, relFilePath);
-    return this.writeFile(absFilePath, {content}, true);
-  }
-
-  public writeFile(filePath: string, {content, size}: FileSpecs, force = false): CleanUpFn {
-    if (!force && fs.existsSync(filePath)) {
-      throw new Error(`Refusing to overwrite existing file '${filePath}'.`);
-    }
-
-    let cleanUpTarget = filePath;
-    while (!fs.existsSync(path.dirname(cleanUpTarget))) {
-      cleanUpTarget = path.dirname(cleanUpTarget);
-    }
-
-    shell.mkdir('-p', path.dirname(filePath));
-    if (size) {
-      // Create a file of the specified size.
-      cp.execSync(`fallocate -l ${size} ${filePath}`);
-    } else {
-      // Create a file with the specified content.
-      fs.writeFileSync(filePath, content || '');
-    }
-    shell.exec(`chown ${this.wwwUser} ${filePath}`);
-
-    return this.createCleanUpFn(() => shell.rm('-rf', cleanUpTarget));
-  }
-
-  // Methods - Protected
-  protected createCleanUpFn(fn: () => void): CleanUpFn {
-    const cleanUpFn = () => {
-      const idx = this.cleanUpFns.indexOf(cleanUpFn);
-      if (idx !== -1) {
-        this.cleanUpFns.splice(idx, 1);
-        fn();
-      }
-    };
-
-    this.cleanUpFns.push(cleanUpFn);
-
-    return cleanUpFn;
-  }
-}
-
-// Exports
-export const helper = new Helper();

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/index.ts

@@ -1,6 +0,0 @@
-// Imports
-import {runTests} from '../common/run-tests';
-
-// Run
-const specFiles = [`${__dirname}/**/*.e2e.js`];
-runTests(specFiles);

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/nginx.e2e.ts

@@ -1,389 +0,0 @@
-// Imports
-import * as path from 'path';
-import {helper as h} from './helper';
-
-// Tests
-describe(`nginx`, () => {
-
-  beforeEach(() => jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000);
-  afterEach(() => h.cleanUp());
-
-
-  it('should redirect HTTP to HTTPS', done => {
-    const httpHost = `${h.nginxHostname}:${h.nginxPortHttp}`;
-    const httpsHost = `${h.nginxHostname}:${h.nginxPortHttps}`;
-    const urlMap = {
-      [`http://${httpHost}/`]: `https://${httpsHost}/`,
-      [`http://${httpHost}/foo`]: `https://${httpsHost}/foo`,
-      [`http://foo.${httpHost}/`]: `https://foo.${httpsHost}/`,
-    };
-
-    const verifyRedirection = (httpUrl: string) => h.runCmd(`curl -i ${httpUrl}`).then(result => {
-      h.verifyResponse(307)(result);
-
-      const headers = result.stdout.split(/(?:\r?\n){2,}/)[0];
-      expect(headers).toContain(`Location: ${urlMap[httpUrl]}`);
-    });
-
-    Promise.
-      all(Object.keys(urlMap).map(verifyRedirection)).
-      then(done);
-  });
-
-
-  h.runForAllSupportedSchemes((scheme, port) => describe(`(on ${scheme.toUpperCase()})`, () => {
-    const hostname = h.nginxHostname;
-    const host = `${hostname}:${port}`;
-    const pr = '9';
-    const sha9 = '9'.repeat(40);
-    const sha0 = '0'.repeat(40);
-    const shortSha9 = h.getShordSha(sha9);
-    const shortSha0 = h.getShordSha(sha0);
-
-
-    describe(`pr<pr>-<sha>.${host}/*`, () => {
-
-      describe('(for public builds)', () => {
-
-        beforeEach(() => {
-          h.createDummyBuild(pr, sha9);
-          h.createDummyBuild(pr, sha0);
-        });
-
-
-        it('should return /index.html', done => {
-          const origin = `${scheme}://pr${pr}-${shortSha9}.${host}`;
-          const bodyRegex = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /index\\.html$`);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${origin}/index.html`).then(h.verifyResponse(200, bodyRegex)),
-            h.runCmd(`curl -iL ${origin}/`).then(h.verifyResponse(200, bodyRegex)),
-            h.runCmd(`curl -iL ${origin}`).then(h.verifyResponse(200, bodyRegex)),
-          ]).then(done);
-        });
-
-
-        it('should return /index.html (for legacy builds)', done => {
-          const origin = `${scheme}://pr${pr}-${sha9}.${host}`;
-          const bodyRegex = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /index\\.html$`);
-
-          h.createDummyBuild(pr, sha9, true, false, true);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${origin}/index.html`).then(h.verifyResponse(200, bodyRegex)),
-            h.runCmd(`curl -iL ${origin}/`).then(h.verifyResponse(200, bodyRegex)),
-            h.runCmd(`curl -iL ${origin}`).then(h.verifyResponse(200, bodyRegex)),
-          ]).then(done);
-        });
-
-
-        it('should return /foo/bar.js', done => {
-          const bodyRegex = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /foo/bar\\.js$`);
-
-          h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}.${host}/foo/bar.js`).
-            then(h.verifyResponse(200, bodyRegex)).
-            then(done);
-        });
-
-
-        it('should return /foo/bar.js (for legacy builds)', done => {
-          const origin = `${scheme}://pr${pr}-${sha9}.${host}`;
-          const bodyRegex = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /foo/bar\\.js$`);
-
-          h.createDummyBuild(pr, sha9, true, false, true);
-
-          h.runCmd(`curl -iL ${origin}/foo/bar.js`).
-            then(h.verifyResponse(200, bodyRegex)).
-            then(done);
-        });
-
-
-        it('should respond with 403 for directories', done => {
-          Promise.all([
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}.${host}/foo/`).then(h.verifyResponse(403)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}.${host}/foo`).then(h.verifyResponse(403)),
-          ]).then(done);
-        });
-
-
-        it('should respond with 404 for unknown paths to files', done => {
-          h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}.${host}/foo/baz.css`).
-            then(h.verifyResponse(404)).
-            then(done);
-        });
-
-
-        it('should rewrite to \'index.html\' for unknown paths that don\'t look like files', done => {
-          const origin = `${scheme}://pr${pr}-${shortSha9}.${host}`;
-          const bodyRegex = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /index\\.html$`);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${origin}/foo/baz`).then(h.verifyResponse(200, bodyRegex)),
-            h.runCmd(`curl -iL ${origin}/foo/baz/`).then(h.verifyResponse(200, bodyRegex)),
-          ]).then(done);
-        });
-
-
-        it('should respond with 404 for unknown PRs/SHAs', done => {
-          const otherPr = 54321;
-          const otherShortSha = h.getShordSha('8'.repeat(40));
-
-          Promise.all([
-            h.runCmd(`curl -iL ${scheme}://pr${pr}9-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${otherPr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}9.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${otherShortSha}.${host}`).then(h.verifyResponse(404)),
-          ]).then(done);
-        });
-
-
-        it('should respond with 404 if the subdomain format is wrong', done => {
-          Promise.all([
-            h.runCmd(`curl -iL ${scheme}://xpr${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://prx${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://xx${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://p${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://r${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://${pr}-${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}_${shortSha9}.${host}`).then(h.verifyResponse(404)),
-          ]).then(done);
-        });
-
-
-        it('should reject PRs with leading zeros', done => {
-          h.runCmd(`curl -iL ${scheme}://pr0${pr}-${shortSha9}.${host}`).
-            then(h.verifyResponse(404)).
-            then(done);
-        });
-
-
-        it('should accept SHAs with leading zeros (but not trim the zeros)', done => {
-          const bodyRegex9 = new RegExp(`^PR: ${pr} | SHA: ${sha9} | File: /index\\.html$`);
-          const bodyRegex0 = new RegExp(`^PR: ${pr} | SHA: ${sha0} | File: /index\\.html$`);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-0${shortSha9}.${host}`).then(h.verifyResponse(404)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha9}.${host}`).then(h.verifyResponse(200, bodyRegex9)),
-            h.runCmd(`curl -iL ${scheme}://pr${pr}-${shortSha0}.${host}`).then(h.verifyResponse(200, bodyRegex0)),
-          ]).then(done);
-        });
-
-      });
-
-
-      describe('(for hidden builds)', () => {
-
-        it('should respond with 404 for any file or directory', done => {
-          const origin = `${scheme}://pr${pr}-${shortSha9}.${host}`;
-          const assert404 = h.verifyResponse(404);
-
-          h.createDummyBuild(pr, sha9, false);
-          expect(h.buildExists(pr, sha9, false)).toBe(true);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${origin}/index.html`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/`).then(assert404),
-            h.runCmd(`curl -iL ${origin}`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo/bar.js`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo/`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo`).then(assert404),
-          ]).then(done);
-        });
-
-
-        it('should respond with 404 for any file or directory (for legacy builds)', done => {
-          const origin = `${scheme}://pr${pr}-${sha9}.${host}`;
-          const assert404 = h.verifyResponse(404);
-
-          h.createDummyBuild(pr, sha9, false, false, true);
-          expect(h.buildExists(pr, sha9, false, true)).toBe(true);
-
-          Promise.all([
-            h.runCmd(`curl -iL ${origin}/index.html`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/`).then(assert404),
-            h.runCmd(`curl -iL ${origin}`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo/bar.js`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo/`).then(assert404),
-            h.runCmd(`curl -iL ${origin}/foo`).then(assert404),
-          ]).then(done);
-        });
-
-      });
-
-    });
-
-
-    describe(`${host}/health-check`, () => {
-
-      it('should respond with 200', done => {
-        Promise.all([
-          h.runCmd(`curl -iL ${scheme}://${host}/health-check`).then(h.verifyResponse(200)),
-          h.runCmd(`curl -iL ${scheme}://${host}/health-check/`).then(h.verifyResponse(200)),
-        ]).then(done);
-      });
-
-
-      it('should respond with 404 if the path does not match exactly', done => {
-        Promise.all([
-          h.runCmd(`curl -iL ${scheme}://${host}/health-check/foo`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/health-check-foo`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/health-checknfoo`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/foo/health-check`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/foo-health-check`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/foonhealth-check`).then(h.verifyResponse(404)),
-        ]).then(done);
-      });
-
-    });
-
-
-    describe(`${host}/create-build/<pr>/<sha>`, () => {
-
-      it('should disallow non-POST requests', done => {
-        const url = `${scheme}://${host}/create-build/${pr}/${sha9}`;
-
-        Promise.all([
-          h.runCmd(`curl -iLX GET ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX PUT ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX PATCH ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX DELETE ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-        ]).then(done);
-      });
-
-
-      it(`should reject files larger than ${h.uploadMaxSize}B (according to header)`, done => {
-        const headers = `--header "Content-Length: ${1.5 * h.uploadMaxSize}"`;
-        const url = `${scheme}://${host}/create-build/${pr}/${sha9}`;
-
-        h.runCmd(`curl -iLX POST ${headers} ${url}`).
-          then(h.verifyResponse([413, 'Request Entity Too Large'])).
-          then(done);
-      });
-
-
-      it(`should reject files larger than ${h.uploadMaxSize}B (without header)`, done => {
-        const filePath = path.join(h.buildsDir, 'snapshot.tar.gz');
-        const url = `${scheme}://${host}/create-build/${pr}/${sha9}`;
-
-        h.writeFile(filePath, {size: 1.5 * h.uploadMaxSize});
-
-        h.runCmd(`curl -iLX POST --data-binary "@${filePath}" ${url}`).
-          then(h.verifyResponse([413, 'Request Entity Too Large'])).
-          then(done);
-      });
-
-
-      it('should pass requests through to the upload server', done => {
-        h.runCmd(`curl -iLX POST ${scheme}://${host}/create-build/${pr}/${sha9}`).
-          then(h.verifyResponse(401, /Missing or empty 'AUTHORIZATION' header/)).
-          then(done);
-      });
-
-
-      it('should respond with 404 for unknown paths', done => {
-        const cmdPrefix = `curl -iLX POST ${scheme}://${host}`;
-
-        Promise.all([
-          h.runCmd(`${cmdPrefix}/foo/create-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/foo-create-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/fooncreate-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/create-build/foo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/create-build-foo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/create-buildnfoo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/create-build/pr${pr}/${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/create-build/${pr}/${sha9}42`).then(h.verifyResponse(404)),
-        ]).then(done);
-      });
-
-
-      it('should reject PRs with leading zeros', done => {
-        h.runCmd(`curl -iLX POST ${scheme}://${host}/create-build/0${pr}/${sha9}`).
-          then(h.verifyResponse(404)).
-          then(done);
-      });
-
-
-      it('should accept SHAs with leading zeros (but not trim the zeros)', done => {
-        const cmdPrefix = `curl -iLX POST  ${scheme}://${host}/create-build/${pr}`;
-        const bodyRegex = /Missing or empty 'AUTHORIZATION' header/;
-
-        Promise.all([
-          h.runCmd(`${cmdPrefix}/0${sha9}`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/${sha0}`).then(h.verifyResponse(401, bodyRegex)),
-        ]).then(done);
-      });
-
-    });
-
-
-    describe(`${host}/pr-updated`, () => {
-      const url = `${scheme}://${host}/pr-updated`;
-
-
-      it('should disallow non-POST requests', done => {
-        Promise.all([
-          h.runCmd(`curl -iLX GET ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX PUT ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX PATCH ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-          h.runCmd(`curl -iLX DELETE ${url}`).then(h.verifyResponse([405, 'Not Allowed'])),
-        ]).then(done);
-      });
-
-
-      it('should pass requests through to the upload server', done => {
-        const cmdPrefix = `curl -iLX POST --header "Content-Type: application/json"`;
-
-        const cmd1 = `${cmdPrefix} ${url}`;
-        const cmd2 = `${cmdPrefix} --data '{"number":${pr}}' ${url}`;
-        const cmd3 = `${cmdPrefix} --data '{"number":${pr},"action":"foo"}' ${url}`;
-
-        Promise.all([
-          h.runCmd(cmd1).then(h.verifyResponse(400, /Missing or empty 'number' field/)),
-          h.runCmd(cmd2).then(h.verifyResponse(200)),
-          h.runCmd(cmd3).then(h.verifyResponse(200)),
-        ]).then(done);
-      });
-
-
-      it('should respond with 404 for unknown paths', done => {
-        const cmdPrefix = `curl -iLX POST ${scheme}://${host}`;
-
-        Promise.all([
-          h.runCmd(`${cmdPrefix}/foo/pr-updated`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/foo-pr-updated`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/foonpr-updated`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/pr-updated/foo`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/pr-updated-foo`).then(h.verifyResponse(404)),
-          h.runCmd(`${cmdPrefix}/pr-updatednfoo`).then(h.verifyResponse(404)),
-        ]).then(done);
-      });
-
-    });
-
-
-    describe(`${host}/*`, () => {
-
-      it('should respond with 404 for unknown URLs (even if the resource exists)', done => {
-        ['index.html', 'foo.js', 'foo/index.html'].forEach(relFilePath => {
-          const absFilePath = path.join(h.buildsDir, relFilePath);
-          h.writeFile(absFilePath, {content: `File: /${relFilePath}`});
-        });
-
-        Promise.all([
-          h.runCmd(`curl -iL ${scheme}://${host}/index.html`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://foo.${host}/index.html`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://foo.${host}/`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://foo.${host}`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/foo.js`).then(h.verifyResponse(404)),
-          h.runCmd(`curl -iL ${scheme}://${host}/foo/index.html`).then(h.verifyResponse(404)),
-        ]).then(done);
-      });
-
-    });
-
-  }));
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/server-integration.e2e.ts

@@ -1,319 +0,0 @@
-// Imports
-import * as path from 'path';
-import * as c from './constants';
-import {helper as h} from './helper';
-
-// Tests
-h.runForAllSupportedSchemes((scheme, port) => describe(`integration (on ${scheme.toUpperCase()})`, () => {
-  const hostname = h.nginxHostname;
-  const host = `${hostname}:${port}`;
-  const pr9 = '9';
-  const sha9 = '9'.repeat(40);
-  const sha0 = '0'.repeat(40);
-  const archivePath = path.join(h.buildsDir, 'snapshot.tar.gz');
-
-  const getFile = (pr: string, sha: string, file: string) =>
-    h.runCmd(`curl -iL ${scheme}://pr${pr}-${h.getShordSha(sha)}.${host}/${file}`);
-  const uploadBuild = (pr: string, sha: string, archive: string, authHeader = 'Token FOO') => {
-    const curlPost = `curl -iLX POST --header "Authorization: ${authHeader}"`;
-    return h.runCmd(`${curlPost} --data-binary "@${archive}" ${scheme}://${host}/create-build/${pr}/${sha}`);
-  };
-  const prUpdated = (pr: number, action?: string) => {
-    const url = `${scheme}://${host}/pr-updated`;
-    const payloadStr = JSON.stringify({number: pr, action});
-    return h.runCmd(`curl -iLX POST --header "Content-Type: application/json" --data '${payloadStr}' ${url}`);
-  };
-
-  beforeEach(() => jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000);
-  afterEach(() => {
-    h.deletePrDir(pr9);
-    h.deletePrDir(pr9, false);
-    h.cleanUp();
-  });
-
-
-  describe('for a new/non-existing PR', () => {
-
-    it('should be able to upload and serve a public build', done => {
-      const regexPrefix9 = `^PR: uploaded\\/${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath).
-        then(() => Promise.all([
-          getFile(pr9, sha9, 'index.html').then(h.verifyResponse(200, idxContentRegex9)),
-          getFile(pr9, sha9, 'foo/bar.js').then(h.verifyResponse(200, barContentRegex9)),
-        ])).
-        then(done);
-    });
-
-
-    it('should be able to upload but not serve a hidden build', done => {
-      const regexPrefix9 = `^PR: uploaded\\/${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath, c.BV_verify_verifiedNotTrusted).
-        then(() => Promise.all([
-          getFile(pr9, sha9, 'index.html').then(h.verifyResponse(404)),
-          getFile(pr9, sha9, 'foo/bar.js').then(h.verifyResponse(404)),
-        ])).
-        then(() => {
-          expect(h.buildExists(pr9, sha9)).toBe(false);
-          expect(h.buildExists(pr9, sha9, false)).toBe(true);
-          expect(h.readBuildFile(pr9, sha9, 'index.html', false)).toMatch(idxContentRegex9);
-          expect(h.readBuildFile(pr9, sha9, 'foo/bar.js', false)).toMatch(barContentRegex9);
-        }).
-        then(done);
-    });
-
-
-    it('should reject an upload if verification fails', done => {
-      const errorRegex9 = new RegExp(`Error while verifying upload for PR ${pr9}: Test`);
-
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath, c.BV_verify_error).
-        then(h.verifyResponse(403, errorRegex9)).
-        then(() => {
-          expect(h.buildExists(pr9)).toBe(false);
-          expect(h.buildExists(pr9, '', false)).toBe(false);
-        }).
-        then(done);
-    });
-
-
-    it('should be able to notify that a PR has been updated (and do nothing)', done => {
-      prUpdated(+pr9).
-        then(h.verifyResponse(200)).
-        then(() => {
-          // The PR should still not exist.
-          expect(h.buildExists(pr9, '', false)).toBe(false);
-          expect(h.buildExists(pr9, '', true)).toBe(false);
-        }).
-        then(done);
-    });
-
-  });
-
-
-  describe('for an existing PR', () => {
-
-    it('should be able to upload and serve a public build', done => {
-      const regexPrefix0 = `^PR: ${pr9} \\| SHA: ${sha0} \\| File:`;
-      const idxContentRegex0 = new RegExp(`${regexPrefix0} \\/index\\.html$`);
-      const barContentRegex0 = new RegExp(`${regexPrefix0} \\/foo\\/bar\\.js$`);
-
-      const regexPrefix9 = `^PR: uploaded\\/${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyBuild(pr9, sha0);
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath).
-        then(() => Promise.all([
-          getFile(pr9, sha0, 'index.html').then(h.verifyResponse(200, idxContentRegex0)),
-          getFile(pr9, sha0, 'foo/bar.js').then(h.verifyResponse(200, barContentRegex0)),
-          getFile(pr9, sha9, 'index.html').then(h.verifyResponse(200, idxContentRegex9)),
-          getFile(pr9, sha9, 'foo/bar.js').then(h.verifyResponse(200, barContentRegex9)),
-        ])).
-        then(done);
-    });
-
-
-    it('should be able to upload but not serve a hidden build', done => {
-      const regexPrefix0 = `^PR: ${pr9} \\| SHA: ${sha0} \\| File:`;
-      const idxContentRegex0 = new RegExp(`${regexPrefix0} \\/index\\.html$`);
-      const barContentRegex0 = new RegExp(`${regexPrefix0} \\/foo\\/bar\\.js$`);
-
-      const regexPrefix9 = `^PR: uploaded\\/${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyBuild(pr9, sha0, false);
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath, c.BV_verify_verifiedNotTrusted).
-        then(() => Promise.all([
-          getFile(pr9, sha0, 'index.html').then(h.verifyResponse(404)),
-          getFile(pr9, sha0, 'foo/bar.js').then(h.verifyResponse(404)),
-          getFile(pr9, sha9, 'index.html').then(h.verifyResponse(404)),
-          getFile(pr9, sha9, 'foo/bar.js').then(h.verifyResponse(404)),
-        ])).
-        then(() => {
-          expect(h.buildExists(pr9, sha9)).toBe(false);
-          expect(h.buildExists(pr9, sha9, false)).toBe(true);
-          expect(h.readBuildFile(pr9, sha0, 'index.html', false)).toMatch(idxContentRegex0);
-          expect(h.readBuildFile(pr9, sha0, 'foo/bar.js', false)).toMatch(barContentRegex0);
-          expect(h.readBuildFile(pr9, sha9, 'index.html', false)).toMatch(idxContentRegex9);
-          expect(h.readBuildFile(pr9, sha9, 'foo/bar.js', false)).toMatch(barContentRegex9);
-        }).
-        then(done);
-    });
-
-
-    it('should reject an upload if verification fails', done => {
-      const errorRegex9 = new RegExp(`Error while verifying upload for PR ${pr9}: Test`);
-
-      h.createDummyBuild(pr9, sha0);
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath, c.BV_verify_error).
-        then(h.verifyResponse(403, errorRegex9)).
-        then(() => {
-          expect(h.buildExists(pr9)).toBe(true);
-          expect(h.buildExists(pr9, sha0)).toBe(true);
-          expect(h.buildExists(pr9, sha9)).toBe(false);
-        }).
-        then(done);
-
-    });
-
-
-    it('should not be able to overwrite an existing public build', done => {
-      const regexPrefix9 = `^PR: ${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyBuild(pr9, sha9);
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath).
-        then(h.verifyResponse(409)).
-        then(() => Promise.all([
-          getFile(pr9, sha9, 'index.html').then(h.verifyResponse(200, idxContentRegex9)),
-          getFile(pr9, sha9, 'foo/bar.js').then(h.verifyResponse(200, barContentRegex9)),
-        ])).
-        then(done);
-    });
-
-
-    it('should not be able to overwrite an existing hidden build', done => {
-      const regexPrefix9 = `^PR: ${pr9} \\| SHA: ${sha9} \\| File:`;
-      const idxContentRegex9 = new RegExp(`${regexPrefix9} \\/index\\.html$`);
-      const barContentRegex9 = new RegExp(`${regexPrefix9} \\/foo\\/bar\\.js$`);
-
-      h.createDummyBuild(pr9, sha9, false);
-      h.createDummyArchive(pr9, sha9, archivePath);
-
-      uploadBuild(pr9, sha9, archivePath, c.BV_verify_verifiedNotTrusted).
-        then(h.verifyResponse(409)).
-        then(() => {
-          expect(h.readBuildFile(pr9, sha9, 'index.html', false)).toMatch(idxContentRegex9);
-          expect(h.readBuildFile(pr9, sha9, 'foo/bar.js', false)).toMatch(barContentRegex9);
-        }).
-        then(done);
-    });
-
-
-    it('should be able to request re-checking visibility (if outdated)', done => {
-      const publicPr = pr9;
-      const hiddenPr = String(c.BV_getPrIsTrusted_notTrusted);
-
-      h.createDummyBuild(publicPr, sha9, false);
-      h.createDummyBuild(hiddenPr, sha9, true);
-
-      // PR visibilities are outdated (i.e. the opposte of what the should).
-      expect(h.buildExists(publicPr, '', false)).toBe(true);
-      expect(h.buildExists(publicPr, '', true)).toBe(false);
-      expect(h.buildExists(hiddenPr, '', false)).toBe(false);
-      expect(h.buildExists(hiddenPr, '', true)).toBe(true);
-
-      Promise.
-        all([
-          prUpdated(+publicPr).then(h.verifyResponse(200)),
-          prUpdated(+hiddenPr).then(h.verifyResponse(200)),
-        ]).
-        then(() => {
-          // PR visibilities should have been updated.
-          expect(h.buildExists(publicPr, '', false)).toBe(false);
-          expect(h.buildExists(publicPr, '', true)).toBe(true);
-          expect(h.buildExists(hiddenPr, '', false)).toBe(true);
-          expect(h.buildExists(hiddenPr, '', true)).toBe(false);
-        }).
-        then(() => {
-          h.deletePrDir(publicPr, true);
-          h.deletePrDir(hiddenPr, false);
-        }).
-        then(done);
-    });
-
-
-    it('should be able to request re-checking visibility (if up-to-date)', done => {
-      const publicPr = pr9;
-      const hiddenPr = String(c.BV_getPrIsTrusted_notTrusted);
-
-      h.createDummyBuild(publicPr, sha9, true);
-      h.createDummyBuild(hiddenPr, sha9, false);
-
-      // PR visibilities are already up-to-date.
-      expect(h.buildExists(publicPr, '', false)).toBe(false);
-      expect(h.buildExists(publicPr, '', true)).toBe(true);
-      expect(h.buildExists(hiddenPr, '', false)).toBe(true);
-      expect(h.buildExists(hiddenPr, '', true)).toBe(false);
-
-      Promise.
-        all([
-          prUpdated(+publicPr).then(h.verifyResponse(200)),
-          prUpdated(+hiddenPr).then(h.verifyResponse(200)),
-        ]).
-        then(() => {
-          // PR visibilities are still up-to-date.
-          expect(h.buildExists(publicPr, '', false)).toBe(false);
-          expect(h.buildExists(publicPr, '', true)).toBe(true);
-          expect(h.buildExists(hiddenPr, '', false)).toBe(true);
-          expect(h.buildExists(hiddenPr, '', true)).toBe(false);
-        }).
-        then(done);
-    });
-
-
-    it('should reject a request if re-checking visibility fails', done => {
-      const errorPr = String(c.BV_getPrIsTrusted_error);
-
-      h.createDummyBuild(errorPr, sha9, true);
-
-      expect(h.buildExists(errorPr, '', false)).toBe(false);
-      expect(h.buildExists(errorPr, '', true)).toBe(true);
-
-      prUpdated(+errorPr).
-        then(h.verifyResponse(500, /Test/)).
-        then(() => {
-          // PR visibility should not have been updated.
-          expect(h.buildExists(errorPr, '', false)).toBe(false);
-          expect(h.buildExists(errorPr, '', true)).toBe(true);
-        }).
-        then(done);
-    });
-
-
-    it('should reject a request if updating visibility fails', done => {
-      // One way to cause an error is to have both a public and a hidden directory for the same PR.
-      h.createDummyBuild(pr9, sha9, false);
-      h.createDummyBuild(pr9, sha9, true);
-
-      const hiddenPrDir = h.getPrDir(pr9, false);
-      const publicPrDir = h.getPrDir(pr9, true);
-      const bodyRegex = new RegExp(`Request to move '${hiddenPrDir}' to existing directory '${publicPrDir}'`);
-
-      expect(h.buildExists(pr9, '', false)).toBe(true);
-      expect(h.buildExists(pr9, '', true)).toBe(true);
-
-      prUpdated(+pr9).
-        then(h.verifyResponse(409, bodyRegex)).
-        then(() => {
-          // PR visibility should not have been updated.
-          expect(h.buildExists(pr9, '', false)).toBe(true);
-          expect(h.buildExists(pr9, '', true)).toBe(true);
-        }).
-        then(done);
-    });
-
-  });
-
-}));

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/start-test-upload-server.ts

@@ -1,38 +0,0 @@
-// Imports
-import {GithubPullRequests} from '../common/github-pull-requests';
-import {BUILD_VERIFICATION_STATUS, BuildVerifier} from '../upload-server/build-verifier';
-import {UploadError} from '../upload-server/upload-error';
-import * as c from './constants';
-
-// Run
-// TODO(gkalpak): Add e2e tests to cover these interactions as well.
-GithubPullRequests.prototype.addComment = () => Promise.resolve();
-BuildVerifier.prototype.getPrIsTrusted = (pr: number) => {
-  switch (pr) {
-    case c.BV_getPrIsTrusted_error:
-      // For e2e tests, fake an error.
-      return Promise.reject('Test');
-    case c.BV_getPrIsTrusted_notTrusted:
-      // For e2e tests, fake an untrusted PR (`false`).
-      return Promise.resolve(false);
-    default:
-      // For e2e tests, default to trusted PRs (`true`).
-      return Promise.resolve(true);
-  }
-};
-BuildVerifier.prototype.verify = (expectedPr: number, authHeader: string) => {
-  switch (authHeader) {
-    case c.BV_verify_error:
-      // For e2e tests, fake a verification error.
-      return Promise.reject(new UploadError(403, `Error while verifying upload for PR ${expectedPr}: Test`));
-    case c.BV_verify_verifiedNotTrusted:
-      // For e2e tests, fake a `verifiedNotTrusted` verification status.
-      return Promise.resolve(BUILD_VERIFICATION_STATUS.verifiedNotTrusted);
-    default:
-      // For e2e tests, default to `verifiedAndTrusted` verification status.
-      return Promise.resolve(BUILD_VERIFICATION_STATUS.verifiedAndTrusted);
-  }
-};
-
-// tslint:disable-next-line: no-var-requires
-require('../upload-server/index');

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/upload-server.e2e.ts

@@ -1,571 +0,0 @@
-// Imports
-import * as fs from 'fs';
-import * as path from 'path';
-import * as c from './constants';
-import {CmdResult, helper as h} from './helper';
-
-// Tests
-describe('upload-server (on HTTP)', () => {
-  const hostname = h.uploadHostname;
-  const port = h.uploadPort;
-  const host = `${hostname}:${port}`;
-  const pr = '9';
-  const sha9 = '9'.repeat(40);
-  const sha0 = '0'.repeat(40);
-
-  beforeEach(() => jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000);
-  afterEach(() => h.cleanUp());
-
-
-  describe(`${host}/create-build/<pr>/<sha>`, () => {
-    const authorizationHeader = `--header "Authorization: Token FOO"`;
-    const xFileHeader = `--header "X-File: ${h.buildsDir}/snapshot.tar.gz"`;
-    const defaultHeaders = `${authorizationHeader} ${xFileHeader}`;
-    const curl = (url: string, headers = defaultHeaders) => `curl -iL ${headers} ${url}`;
-
-
-    it('should disallow non-GET requests', done => {
-      const url = `http://${host}/create-build/${pr}/${sha9}`;
-      const bodyRegex = /^Unknown resource/;
-
-      Promise.all([
-        h.runCmd(`curl -iLX PUT ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX POST ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX PATCH ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX DELETE ${url}`).then(h.verifyResponse(404, bodyRegex)),
-      ]).then(done);
-    });
-
-
-    it('should reject requests without an \'AUTHORIZATION\' header', done => {
-      const headers1 = '';
-      const headers2 = '--header "AUTHORIXATION: "';
-      const url = `http://${host}/create-build/${pr}/${sha9}`;
-      const bodyRegex = /^Missing or empty 'AUTHORIZATION' header/;
-
-      Promise.all([
-        h.runCmd(curl(url, headers1)).then(h.verifyResponse(401, bodyRegex)),
-        h.runCmd(curl(url, headers2)).then(h.verifyResponse(401, bodyRegex)),
-      ]).then(done);
-    });
-
-
-    it('should reject requests without an \'X-FILE\' header', done => {
-      const headers1 = authorizationHeader;
-      const headers2 = `${authorizationHeader} --header "X-FILE: "`;
-      const url = `http://${host}/create-build/${pr}/${sha9}`;
-      const bodyRegex = /^Missing or empty 'X-FILE' header/;
-
-      Promise.all([
-        h.runCmd(curl(url, headers1)).then(h.verifyResponse(400, bodyRegex)),
-        h.runCmd(curl(url, headers2)).then(h.verifyResponse(400, bodyRegex)),
-      ]).then(done);
-    });
-
-
-    it('should reject requests for which the PR verification fails', done => {
-      const headers = `--header "Authorization: ${c.BV_verify_error}" ${xFileHeader}`;
-      const url = `http://${host}/create-build/${pr}/${sha9}`;
-      const bodyRegex = new RegExp(`Error while verifying upload for PR ${pr}: Test`);
-
-      h.runCmd(curl(url, headers)).
-        then(h.verifyResponse(403, bodyRegex)).
-        then(done);
-    });
-
-
-    it('should respond with 404 for unknown paths', done => {
-      const cmdPrefix = curl(`http://${host}`);
-
-      Promise.all([
-        h.runCmd(`${cmdPrefix}/foo/create-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/foo-create-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/fooncreate-build/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/create-build/foo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/create-build-foo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/create-buildnfoo/${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/create-build/pr${pr}/${sha9}`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/create-build/${pr}/${sha9}42`).then(h.verifyResponse(404)),
-      ]).then(done);
-    });
-
-
-    it('should reject PRs with leading zeros', done => {
-      h.runCmd(curl(`http://${host}/create-build/0${pr}/${sha9}`)).
-        then(h.verifyResponse(404)).
-        then(done);
-    });
-
-
-    it('should accept SHAs with leading zeros (but not trim the zeros)', done => {
-      Promise.all([
-        h.runCmd(curl(`http://${host}/create-build/${pr}/0${sha9}`)).then(h.verifyResponse(404)),
-        h.runCmd(curl(`http://${host}/create-build/${pr}/${sha9}`)).then(h.verifyResponse(500)),
-        h.runCmd(curl(`http://${host}/create-build/${pr}/${sha0}`)).then(h.verifyResponse(500)),
-      ]).then(done);
-    });
-
-
-    [true, false].forEach(isPublic => describe(`(for ${isPublic ? 'public' : 'hidden'} builds)`, () => {
-      const authorizationHeader2 = isPublic ?
-        authorizationHeader : `--header "Authorization: ${c.BV_verify_verifiedNotTrusted}"`;
-      const cmdPrefix = curl('', `${authorizationHeader2} ${xFileHeader}`);
-      const overwriteRe = RegExp(`^Request to overwrite existing ${isPublic ? 'public' : 'non-public'} directory`);
-
-
-      it('should not overwrite existing builds', done => {
-        h.createDummyBuild(pr, sha9, isPublic);
-        expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain('index.html');
-
-        h.writeBuildFile(pr, sha9, 'index.html', 'My content', isPublic);
-        expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toBe('My content');
-
-        h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9}`).
-          then(h.verifyResponse(409, overwriteRe)).
-          then(() => expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toBe('My content')).
-          then(done);
-      });
-
-
-      it('should not overwrite existing builds (even if the SHA is different)', done => {
-        // Since only the first few characters of the SHA are used, it is possible for two different
-        // SHAs to correspond to the same directory. In that case, we don't want the second SHA to
-        // overwrite the first.
-
-        const sha9Almost = sha9.replace(/.$/, '8');
-        expect(sha9Almost).not.toBe(sha9);
-
-        h.createDummyBuild(pr, sha9, isPublic);
-        expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain('index.html');
-
-        h.writeBuildFile(pr, sha9, 'index.html', 'My content', isPublic);
-        expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toBe('My content');
-
-        h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9Almost}`).
-          then(h.verifyResponse(409, overwriteRe)).
-          then(() => expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toBe('My content')).
-          then(done);
-      });
-
-
-      it('should delete the PR directory on error (for new PR)', done => {
-        h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9}`).
-          then(h.verifyResponse(500)).
-          then(() => expect(h.buildExists(pr, '', isPublic)).toBe(false)).
-          then(done);
-      });
-
-
-      it('should only delete the SHA directory on error (for existing PR)', done => {
-        h.createDummyBuild(pr, sha0, isPublic);
-
-        h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9}`).
-          then(h.verifyResponse(500)).
-          then(() => {
-            expect(h.buildExists(pr, sha9, isPublic)).toBe(false);
-            expect(h.buildExists(pr, '', isPublic)).toBe(true);
-          }).
-          then(done);
-      });
-
-
-      describe('on successful upload', () => {
-        const archivePath = path.join(h.buildsDir, 'snapshot.tar.gz');
-        const statusCode = isPublic ? 201 : 202;
-        let uploadPromise: Promise<CmdResult>;
-
-        beforeEach(() => {
-          h.createDummyArchive(pr, sha9, archivePath);
-          uploadPromise = h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9}`);
-        });
-        afterEach(() => h.deletePrDir(pr, isPublic));
-
-
-        it(`should respond with ${statusCode}`, done => {
-          uploadPromise.then(h.verifyResponse(statusCode)).then(done);
-        });
-
-
-        it('should extract the contents of the uploaded file', done => {
-          uploadPromise.
-            then(() => {
-              expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain(`uploaded/${pr}`);
-              expect(h.readBuildFile(pr, sha9, 'foo/bar.js', isPublic)).toContain(`uploaded/${pr}`);
-            }).
-            then(done);
-        });
-
-
-        it(`should create files/directories owned by '${h.wwwUser}'`, done => {
-          const prDir = h.getPrDir(pr, isPublic);
-          const shaDir = h.getShaDir(prDir, sha9);
-          const idxPath = path.join(shaDir, 'index.html');
-          const barPath = path.join(shaDir, 'foo', 'bar.js');
-
-          uploadPromise.
-            then(() => Promise.all([
-              h.runCmd(`find ${shaDir}`),
-              h.runCmd(`find ${shaDir} -user ${h.wwwUser}`),
-            ])).
-            then(([{stdout: allFiles}, {stdout: userFiles}]) => {
-              expect(userFiles).toBe(allFiles);
-              expect(userFiles).toContain(shaDir);
-              expect(userFiles).toContain(idxPath);
-              expect(userFiles).toContain(barPath);
-            }).
-            then(done);
-        });
-
-
-        it('should delete the uploaded file', done => {
-          expect(fs.existsSync(archivePath)).toBe(true);
-          uploadPromise.
-            then(() => expect(fs.existsSync(archivePath)).toBe(false)).
-            then(done);
-        });
-
-
-        it('should make the build directory non-writable', done => {
-          const prDir = h.getPrDir(pr, isPublic);
-          const shaDir = h.getShaDir(prDir, sha9);
-          const idxPath = path.join(shaDir, 'index.html');
-          const barPath = path.join(shaDir, 'foo', 'bar.js');
-
-          // See https://github.com/nodejs/node-v0.x-archive/issues/3045#issuecomment-4862588.
-          const isNotWritable = (fileOrDir: string) => {
-            const mode = fs.statSync(fileOrDir).mode;
-            // tslint:disable-next-line: no-bitwise
-            return !(mode & parseInt('222', 8));
-          };
-
-          uploadPromise.
-            then(() => {
-              expect(isNotWritable(shaDir)).toBe(true);
-              expect(isNotWritable(idxPath)).toBe(true);
-              expect(isNotWritable(barPath)).toBe(true);
-            }).
-            then(done);
-        });
-
-
-        it('should ignore a legacy 40-chars long build directory (even if it starts with the same chars)', done => {
-          // It is possible that 40-chars long build directories exist, if they had been deployed
-          // before implementing the shorter build directory names. In that case, we don't want the
-          // second (shorter) name to be considered the same as the old one (even if they originate
-          // from the same SHA).
-
-          h.createDummyBuild(pr, sha9, isPublic, false, true);
-          expect(h.readBuildFile(pr, sha9, 'index.html', isPublic, true)).toContain('index.html');
-
-          h.writeBuildFile(pr, sha9, 'index.html', 'My content', isPublic, true);
-          expect(h.readBuildFile(pr, sha9, 'index.html', isPublic, true)).toBe('My content');
-
-          h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha9}`).
-            then(h.verifyResponse(statusCode)).
-            then(() => {
-              expect(h.buildExists(pr, sha9, isPublic)).toBe(true);
-              expect(h.buildExists(pr, sha9, isPublic, true)).toBe(true);
-              expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain('index.html');
-              expect(h.readBuildFile(pr, sha9, 'index.html', isPublic, true)).toBe('My content');
-            }).
-            then(done);
-        });
-
-      });
-
-
-      describe('when the PR\'s visibility has changed', () => {
-        const archivePath = path.join(h.buildsDir, 'snapshot.tar.gz');
-        const statusCode = isPublic ? 201 : 202;
-
-        const checkPrVisibility = (isPublic2: boolean) => {
-          expect(h.buildExists(pr, '', isPublic2)).toBe(true);
-          expect(h.buildExists(pr, '', !isPublic2)).toBe(false);
-          expect(h.buildExists(pr, sha0, isPublic2)).toBe(true);
-          expect(h.buildExists(pr, sha0, !isPublic2)).toBe(false);
-        };
-        const uploadBuild = (sha: string) => h.runCmd(`${cmdPrefix} http://${host}/create-build/${pr}/${sha}`);
-
-        beforeEach(() => {
-          h.createDummyBuild(pr, sha0, !isPublic);
-          h.createDummyArchive(pr, sha9, archivePath);
-          checkPrVisibility(!isPublic);
-        });
-        afterEach(() => h.deletePrDir(pr, isPublic));
-
-
-        it('should update the PR\'s visibility', done => {
-          uploadBuild(sha9).
-            then(h.verifyResponse(statusCode)).
-            then(() => {
-              checkPrVisibility(isPublic);
-              expect(h.buildExists(pr, sha9, isPublic)).toBe(true);
-              expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain(`uploaded/${pr}`);
-              expect(h.readBuildFile(pr, sha9, 'index.html', isPublic)).toContain(sha9);
-            }).
-            then(done);
-        });
-
-
-        it('should not overwrite existing builds (but keep the updated visibility)', done => {
-          expect(h.buildExists(pr, sha0, isPublic)).toBe(false);
-
-          uploadBuild(sha0).
-            then(h.verifyResponse(409, overwriteRe)).
-            then(() => {
-              checkPrVisibility(isPublic);
-              expect(h.readBuildFile(pr, sha0, 'index.html', isPublic)).toContain(pr);
-              expect(h.readBuildFile(pr, sha0, 'index.html', isPublic)).not.toContain(`uploaded/${pr}`);
-              expect(h.readBuildFile(pr, sha0, 'index.html', isPublic)).toContain(sha0);
-              expect(h.readBuildFile(pr, sha0, 'index.html', isPublic)).not.toContain(sha9);
-            }).
-            then(done);
-        });
-
-
-        it('should reject the request if it fails to update the PR\'s visibility', done => {
-          // One way to cause an error is to have both a public and a hidden directory for the same PR.
-          h.createDummyBuild(pr, sha0, isPublic);
-
-          expect(h.buildExists(pr, sha0, isPublic)).toBe(true);
-          expect(h.buildExists(pr, sha0, !isPublic)).toBe(true);
-
-          const errorRegex = new RegExp(`^Request to move '${h.getPrDir(pr, !isPublic)}' ` +
-                                        `to existing directory '${h.getPrDir(pr, isPublic)}'.`);
-
-          uploadBuild(sha9).
-            then(h.verifyResponse(409, errorRegex)).
-            then(() => {
-              expect(h.buildExists(pr, sha0, isPublic)).toBe(true);
-              expect(h.buildExists(pr, sha0, !isPublic)).toBe(true);
-              expect(h.buildExists(pr, sha9, isPublic)).toBe(false);
-              expect(h.buildExists(pr, sha9, !isPublic)).toBe(false);
-            }).
-            then(done);
-        });
-
-      });
-
-    }));
-
-  });
-
-
-  describe(`${host}/health-check`, () => {
-
-    it('should respond with 200', done => {
-      Promise.all([
-        h.runCmd(`curl -iL http://${host}/health-check`).then(h.verifyResponse(200)),
-        h.runCmd(`curl -iL http://${host}/health-check/`).then(h.verifyResponse(200)),
-      ]).then(done);
-    });
-
-
-    it('should respond with 404 if the path does not match exactly', done => {
-      Promise.all([
-        h.runCmd(`curl -iL http://${host}/health-check/foo`).then(h.verifyResponse(404)),
-        h.runCmd(`curl -iL http://${host}/health-check-foo`).then(h.verifyResponse(404)),
-        h.runCmd(`curl -iL http://${host}/health-checknfoo`).then(h.verifyResponse(404)),
-        h.runCmd(`curl -iL http://${host}/foo/health-check`).then(h.verifyResponse(404)),
-        h.runCmd(`curl -iL http://${host}/foo-health-check`).then(h.verifyResponse(404)),
-        h.runCmd(`curl -iL http://${host}/foonhealth-check`).then(h.verifyResponse(404)),
-      ]).then(done);
-    });
-
-  });
-
-
-  describe(`${host}/pr-updated`, () => {
-    const url = `http://${host}/pr-updated`;
-
-    // Helpers
-    const curl = (payload?: {number: number, action?: string}) => {
-      const payloadStr = payload && JSON.stringify(payload) || '';
-      return `curl -iLX POST --header "Content-Type: application/json" --data '${payloadStr}' ${url}`;
-    };
-
-
-    it('should disallow non-POST requests', done => {
-      const bodyRegex = /^Unknown resource in request/;
-
-      Promise.all([
-        h.runCmd(`curl -iLX GET ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX PUT ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX PATCH ${url}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX DELETE ${url}`).then(h.verifyResponse(404, bodyRegex)),
-      ]).then(done);
-    });
-
-
-    it('should respond with 400 for requests without a payload', done => {
-      const bodyRegex = /^Missing or empty 'number' field in request/;
-
-      h.runCmd(curl()).
-        then(h.verifyResponse(400, bodyRegex)).
-        then(done);
-    });
-
-
-    it('should respond with 400 for requests without a \'number\' field', done => {
-      const bodyRegex = /^Missing or empty 'number' field in request/;
-
-      Promise.all([
-        h.runCmd(curl({} as any)).then(h.verifyResponse(400, bodyRegex)),
-        h.runCmd(curl({number: null} as any)).then(h.verifyResponse(400, bodyRegex)),
-      ]).then(done);
-    });
-
-
-    it('should reject requests for which checking the PR visibility fails', done => {
-      h.runCmd(curl({number: c.BV_getPrIsTrusted_error})).
-        then(h.verifyResponse(500, /Test/)).
-        then(done);
-    });
-
-
-    it('should respond with 404 for unknown paths', done => {
-      const mockPayload = JSON.stringify({number: +pr});
-      const cmdPrefix = `curl -iLX POST --data "${mockPayload}" http://${host}`;
-
-      Promise.all([
-        h.runCmd(`${cmdPrefix}/foo/pr-updated`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/foo-pr-updated`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/foonpr-updated`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/pr-updated/foo`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/pr-updated-foo`).then(h.verifyResponse(404)),
-        h.runCmd(`${cmdPrefix}/pr-updatednfoo`).then(h.verifyResponse(404)),
-      ]).then(done);
-    });
-
-
-    it('should do nothing if PR\'s visibility is already up-to-date', done => {
-      const publicPr = pr;
-      const hiddenPr = String(c.BV_getPrIsTrusted_notTrusted);
-      const checkVisibilities = () => {
-        // Public build is already public.
-        expect(h.buildExists(publicPr, '', false)).toBe(false);
-        expect(h.buildExists(publicPr, '', true)).toBe(true);
-        // Hidden build is already hidden.
-        expect(h.buildExists(hiddenPr, '', false)).toBe(true);
-        expect(h.buildExists(hiddenPr, '', true)).toBe(false);
-      };
-
-      h.createDummyBuild(publicPr, sha9, true);
-      h.createDummyBuild(hiddenPr, sha9, false);
-      checkVisibilities();
-
-      Promise.
-        all([
-          h.runCmd(curl({number: +publicPr, action: 'foo'})).then(h.verifyResponse(200)),
-          h.runCmd(curl({number: +hiddenPr, action: 'foo'})).then(h.verifyResponse(200)),
-        ]).
-        // Visibilities should not have changed, because the specified action could not have triggered a change.
-        then(checkVisibilities).
-        then(done);
-    });
-
-
-    it('should do nothing if \'action\' implies no visibility change', done => {
-      const publicPr = pr;
-      const hiddenPr = String(c.BV_getPrIsTrusted_notTrusted);
-      const checkVisibilities = () => {
-        // Public build is hidden atm.
-        expect(h.buildExists(publicPr, '', false)).toBe(true);
-        expect(h.buildExists(publicPr, '', true)).toBe(false);
-        // Hidden build is public atm.
-        expect(h.buildExists(hiddenPr, '', false)).toBe(false);
-        expect(h.buildExists(hiddenPr, '', true)).toBe(true);
-      };
-
-      h.createDummyBuild(publicPr, sha9, false);
-      h.createDummyBuild(hiddenPr, sha9, true);
-      checkVisibilities();
-
-      Promise.
-        all([
-          h.runCmd(curl({number: +publicPr, action: 'foo'})).then(h.verifyResponse(200)),
-          h.runCmd(curl({number: +hiddenPr, action: 'foo'})).then(h.verifyResponse(200)),
-        ]).
-        // Visibilities should not have changed, because the specified action could not have triggered a change.
-        then(checkVisibilities).
-        then(done);
-    });
-
-
-    describe('when the visiblity has changed', () => {
-      const publicPr = pr;
-      const hiddenPr = String(c.BV_getPrIsTrusted_notTrusted);
-
-      beforeEach(() => {
-        // Create initial PR builds with opposite visibilities as the ones that will be reported:
-        // - The now public PR was previously hidden.
-        // - The now hidden PR was previously public.
-        h.createDummyBuild(publicPr, sha9, false);
-        h.createDummyBuild(hiddenPr, sha9, true);
-
-        expect(h.buildExists(publicPr, '', false)).toBe(true);
-        expect(h.buildExists(publicPr, '', true)).toBe(false);
-        expect(h.buildExists(hiddenPr, '', false)).toBe(false);
-        expect(h.buildExists(hiddenPr, '', true)).toBe(true);
-      });
-      afterEach(() => {
-        // Expect PRs' visibility to have been updated:
-        // - The public PR should be actually public (previously it was hidden).
-        // - The hidden PR should be actually hidden (previously it was public).
-        expect(h.buildExists(publicPr, '', false)).toBe(false);
-        expect(h.buildExists(publicPr, '', true)).toBe(true);
-        expect(h.buildExists(hiddenPr, '', false)).toBe(true);
-        expect(h.buildExists(hiddenPr, '', true)).toBe(false);
-
-        h.deletePrDir(publicPr, true);
-        h.deletePrDir(hiddenPr, false);
-      });
-
-
-      it('should update the PR\'s visibility (action: undefined)', done => {
-        Promise.all([
-          h.runCmd(curl({number: +publicPr})).then(h.verifyResponse(200)),
-          h.runCmd(curl({number: +hiddenPr})).then(h.verifyResponse(200)),
-        ]).then(done);
-      });
-
-
-      it('should update the PR\'s visibility (action: labeled)', done => {
-        Promise.all([
-          h.runCmd(curl({number: +publicPr, action: 'labeled'})).then(h.verifyResponse(200)),
-          h.runCmd(curl({number: +hiddenPr, action: 'labeled'})).then(h.verifyResponse(200)),
-        ]).then(done);
-      });
-
-
-      it('should update the PR\'s visibility (action: unlabeled)', done => {
-        Promise.all([
-          h.runCmd(curl({number: +publicPr, action: 'unlabeled'})).then(h.verifyResponse(200)),
-          h.runCmd(curl({number: +hiddenPr, action: 'unlabeled'})).then(h.verifyResponse(200)),
-        ]).then(done);
-      });
-
-    });
-
-  });
-
-
-  describe(`${host}/*`, () => {
-
-    it('should respond with 404 for requests to unknown URLs', done => {
-      const bodyRegex = /^Unknown resource/;
-
-      Promise.all([
-        h.runCmd(`curl -iL http://${host}/index.html`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iL http://${host}/`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iL http://${host}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX PUT http://${host}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX POST http://${host}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX PATCH http://${host}`).then(h.verifyResponse(404, bodyRegex)),
-        h.runCmd(`curl -iLX DELETE http://${host}`).then(h.verifyResponse(404, bodyRegex)),
-      ]).then(done);
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/package.json

@@ -1,45 +0,0 @@
-{
-  "name": "aio-scripts-js",
-  "version": "1.0.0",
-  "description": "Performing various tasks on PR build artifacts for angular.io.",
-  "repository": "https://github.com/angular/angular.git",
-  "author": "Angular",
-  "license": "MIT",
-  "scripts": {
-    "prebuild": "yarn clean-dist",
-    "build": "tsc",
-    "build-watch": "yarn tsc --watch",
-    "clean-dist": "node --eval \"require('shelljs').rm('-rf', 'dist')\"",
-    "dev": "concurrently --kill-others --raw --success first \"yarn build-watch\" \"yarn test-watch\"",
-    "lint": "tslint --project tsconfig.json",
-    "pre~~test-only": "yarn lint",
-    "~~test-only": "node dist/test",
-    "pretest": "yarn build",
-    "test": "yarn ~~test-only",
-    "pretest-watch": "yarn build",
-    "test-watch": "nodemon --exec \"yarn ~~test-only\" --watch dist"
-  },
-  "dependencies": {
-    "body-parser": "^1.18.2",
-    "express": "^4.15.4",
-    "jasmine": "^2.8.0",
-    "jsonwebtoken": "^8.0.1",
-    "shelljs": "^0.7.8",
-    "tslib": "^1.7.1"
-  },
-  "devDependencies": {
-    "@types/body-parser": "^1.16.5",
-    "@types/express": "^4.0.37",
-    "@types/jasmine": "^2.6.0",
-    "@types/jsonwebtoken": "^7.2.3",
-    "@types/node": "^8.0.30",
-    "@types/shelljs": "^0.7.4",
-    "@types/supertest": "^2.0.3",
-    "concurrently": "^3.5.0",
-    "nodemon": "^1.12.1",
-    "supertest": "^3.0.0",
-    "tslint": "^5.7.0",
-    "tslint-jasmine-noSkipOrFocus": "^1.0.8",
-    "typescript": "^2.5.2"
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/test/clean-up/build-cleaner.spec.ts

@@ -1,360 +0,0 @@
-// Imports
-import * as fs from 'fs';
-import * as path from 'path';
-import * as shell from 'shelljs';
-import {BuildCleaner} from '../../lib/clean-up/build-cleaner';
-import {HIDDEN_DIR_PREFIX} from '../../lib/common/constants';
-import {GithubPullRequests} from '../../lib/common/github-pull-requests';
-
-// Tests
-describe('BuildCleaner', () => {
-  let cleaner: BuildCleaner;
-
-  beforeEach(() => cleaner = new BuildCleaner('/foo/bar', 'baz/qux', '12345'));
-
-
-  describe('constructor()', () => {
-
-    it('should throw if \'buildsDir\' is empty', () => {
-      expect(() => new BuildCleaner('', '/baz/qux', '12345')).
-        toThrowError('Missing or empty required parameter \'buildsDir\'!');
-    });
-
-
-    it('should throw if \'repoSlug\' is empty', () => {
-      expect(() => new BuildCleaner('/foo/bar', '', '12345')).
-        toThrowError('Missing or empty required parameter \'repoSlug\'!');
-    });
-
-
-    it('should throw if \'githubToken\' is empty', () => {
-      expect(() => new BuildCleaner('/foo/bar', 'baz/qux', '')).
-        toThrowError('Missing or empty required parameter \'githubToken\'!');
-    });
-
-  });
-
-
-  describe('cleanUp()', () => {
-    let cleanerGetExistingBuildNumbersSpy: jasmine.Spy;
-    let cleanerGetOpenPrNumbersSpy: jasmine.Spy;
-    let cleanerRemoveUnnecessaryBuildsSpy: jasmine.Spy;
-    let existingBuildsDeferred: {resolve: (v?: any) => void, reject: (e?: any) => void};
-    let openPrsDeferred: {resolve: (v?: any) => void, reject: (e?: any) => void};
-    let promise: Promise<void>;
-
-    beforeEach(() => {
-      cleanerGetExistingBuildNumbersSpy = spyOn(cleaner as any, 'getExistingBuildNumbers').and.callFake(() => {
-        return new Promise((resolve, reject) => existingBuildsDeferred = {resolve, reject});
-      });
-      cleanerGetOpenPrNumbersSpy = spyOn(cleaner as any, 'getOpenPrNumbers').and.callFake(() => {
-        return new Promise((resolve, reject) => openPrsDeferred = {resolve, reject});
-      });
-      cleanerRemoveUnnecessaryBuildsSpy = spyOn(cleaner as any, 'removeUnnecessaryBuilds');
-
-      promise = cleaner.cleanUp();
-    });
-
-
-    it('should return a promise', () => {
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should get the existing builds', () => {
-      expect(cleanerGetExistingBuildNumbersSpy).toHaveBeenCalled();
-    });
-
-
-    it('should get the open PRs', () => {
-      expect(cleanerGetOpenPrNumbersSpy).toHaveBeenCalled();
-    });
-
-
-    it('should reject if \'getExistingBuildNumbers()\' rejects', done => {
-      promise.catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      existingBuildsDeferred.reject('Test');
-    });
-
-
-    it('should reject if \'getOpenPrNumbers()\' rejects', done => {
-      promise.catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      openPrsDeferred.reject('Test');
-    });
-
-
-    it('should reject if \'removeUnnecessaryBuilds()\' rejects', done => {
-      promise.catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      cleanerRemoveUnnecessaryBuildsSpy.and.returnValue(Promise.reject('Test'));
-      existingBuildsDeferred.resolve();
-      openPrsDeferred.resolve();
-    });
-
-
-    it('should pass existing builds and open PRs to \'removeUnnecessaryBuilds()\'', done => {
-      promise.then(() => {
-        expect(cleanerRemoveUnnecessaryBuildsSpy).toHaveBeenCalledWith('foo', 'bar');
-        done();
-      });
-
-      existingBuildsDeferred.resolve('foo');
-      openPrsDeferred.resolve('bar');
-    });
-
-
-    it('should resolve with the value returned by \'removeUnnecessaryBuilds()\'', done => {
-      promise.then(result => {
-        expect(result as any).toBe('Test');
-        done();
-      });
-
-      cleanerRemoveUnnecessaryBuildsSpy.and.returnValue(Promise.resolve('Test'));
-      existingBuildsDeferred.resolve();
-      openPrsDeferred.resolve();
-    });
-
-  });
-
-
-  // Protected methods
-
-  describe('getExistingBuildNumbers()', () => {
-    let fsReaddirSpy: jasmine.Spy;
-    let readdirCb: (err: any, files?: string[]) => void;
-    let promise: Promise<number[]>;
-
-    beforeEach(() => {
-      fsReaddirSpy = spyOn(fs, 'readdir').and.callFake((_: string, cb: typeof readdirCb) => readdirCb = cb);
-      promise = (cleaner as any).getExistingBuildNumbers();
-    });
-
-
-    it('should return a promise', () => {
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should get the contents of the builds directory', () => {
-      expect(fsReaddirSpy).toHaveBeenCalled();
-      expect(fsReaddirSpy.calls.argsFor(0)[0]).toBe('/foo/bar');
-    });
-
-
-    it('should reject if an error occurs while getting the files', done => {
-      promise.catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      readdirCb('Test');
-    });
-
-
-    it('should resolve with the returned files (as numbers)', done => {
-      promise.then(result => {
-        expect(result).toEqual([12, 34, 56]);
-        done();
-      });
-
-      readdirCb(null, ['12', '34', '56']);
-    });
-
-
-    it('should remove `HIDDEN_DIR_PREFIX` from the filenames', done => {
-      promise.then(result => {
-        expect(result).toEqual([12, 34, 56]);
-        done();
-      });
-
-      readdirCb(null, [`${HIDDEN_DIR_PREFIX}12`, '34', `${HIDDEN_DIR_PREFIX}56`]);
-    });
-
-
-    it('should ignore files with non-numeric (or zero) names', done => {
-      promise.then(result => {
-        expect(result).toEqual([12, 34, 56]);
-        done();
-      });
-
-      readdirCb(null, ['12', 'foo', '34', 'bar', '56', '000']);
-    });
-
-  });
-
-
-  describe('getOpenPrNumbers()', () => {
-    let prDeferred: {resolve: (v: any) => void, reject: (v: any) => void};
-    let promise: Promise<number[]>;
-
-    beforeEach(() => {
-      spyOn(GithubPullRequests.prototype, 'fetchAll').and.callFake(() => {
-        return new Promise((resolve, reject) => prDeferred = {resolve, reject});
-      });
-
-      promise = (cleaner as any).getOpenPrNumbers();
-    });
-
-
-    it('should return a promise', () => {
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should fetch open PRs via \'GithubPullRequests\'', () => {
-      expect(GithubPullRequests.prototype.fetchAll).toHaveBeenCalledWith('open');
-    });
-
-
-    it('should reject if an error occurs while fetching PRs', done => {
-      promise.catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      prDeferred.reject('Test');
-    });
-
-
-    it('should resolve with the numbers of the fetched PRs', done => {
-      promise.then(prNumbers => {
-        expect(prNumbers).toEqual([1, 2, 3]);
-        done();
-      });
-
-      prDeferred.resolve([{id: 0, number: 1}, {id: 1, number: 2}, {id: 2, number: 3}]);
-    });
-
-  });
-
-
-  describe('removeDir()', () => {
-    let shellChmodSpy: jasmine.Spy;
-    let shellRmSpy: jasmine.Spy;
-    let shellTestSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      shellChmodSpy = spyOn(shell, 'chmod');
-      shellRmSpy = spyOn(shell, 'rm');
-      shellTestSpy = spyOn(shell, 'test').and.returnValue(true);
-    });
-
-
-    it('should test if the directory exists (and return if is does not)', () => {
-      shellTestSpy.and.returnValue(false);
-      (cleaner as any).removeDir('/foo/bar');
-
-      expect(shellTestSpy).toHaveBeenCalledWith('-d', '/foo/bar');
-      expect(shellChmodSpy).not.toHaveBeenCalled();
-      expect(shellRmSpy).not.toHaveBeenCalled();
-    });
-
-
-    it('should remove the specified directory and its content', () => {
-      (cleaner as any).removeDir('/foo/bar');
-      expect(shellRmSpy).toHaveBeenCalledWith('-rf', '/foo/bar');
-    });
-
-
-    it('should make the directory and its content writable before removing', () => {
-      shellRmSpy.and.callFake(() => expect(shellChmodSpy).toHaveBeenCalledWith('-R', 'a+w', '/foo/bar'));
-      (cleaner as any).removeDir('/foo/bar');
-
-      expect(shellRmSpy).toHaveBeenCalled();
-    });
-
-
-    it('should catch errors and log them', () => {
-      const consoleErrorSpy = spyOn(console, 'error');
-      shellRmSpy.and.callFake(() => {
-        // tslint:disable-next-line: no-string-throw
-        throw 'Test';
-      });
-
-      (cleaner as any).removeDir('/foo/bar');
-
-      expect(consoleErrorSpy).toHaveBeenCalled();
-      expect(consoleErrorSpy.calls.argsFor(0)[0]).toContain('Unable to remove \'/foo/bar\'');
-      expect(consoleErrorSpy.calls.argsFor(0)[1]).toBe('Test');
-    });
-
-  });
-
-
-  describe('removeUnnecessaryBuilds()', () => {
-    let consoleLogSpy: jasmine.Spy;
-    let cleanerRemoveDirSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      consoleLogSpy = spyOn(console, 'log');
-      cleanerRemoveDirSpy = spyOn(cleaner as any, 'removeDir');
-    });
-
-
-    it('should log the number of existing builds, open PRs and builds to be removed', () => {
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3], [3, 4, 5, 6]);
-
-      expect(console.log).toHaveBeenCalledWith('Existing builds: 3');
-      expect(console.log).toHaveBeenCalledWith('Open pull requests: 4');
-      expect(console.log).toHaveBeenCalledWith('Removing 2 build(s): 1, 2');
-    });
-
-
-    it('should construct full paths to directories (by prepending \'buildsDir\')', () => {
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3], []);
-
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/1'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/2'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/3'));
-    });
-
-
-    it('should try removing hidden directories as well', () => {
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3], []);
-
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}1`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}2`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}3`));
-    });
-
-
-    it('should remove the builds that do not correspond to open PRs', () => {
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3, 4], [2, 4]);
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledTimes(4);
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/1'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/3'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}1`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}3`));
-      cleanerRemoveDirSpy.calls.reset();
-
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3, 4], [1, 2, 3, 4]);
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledTimes(0);
-      cleanerRemoveDirSpy.calls.reset();
-
-      (cleaner as any).removeUnnecessaryBuilds([1, 2, 3, 4], []);
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledTimes(8);
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/1'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/2'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/3'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize('/foo/bar/4'));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}1`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}2`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}3`));
-      expect(cleanerRemoveDirSpy).toHaveBeenCalledWith(path.normalize(`/foo/bar/${HIDDEN_DIR_PREFIX}4`));
-      cleanerRemoveDirSpy.calls.reset();
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/common/github-api.spec.ts

@@ -1,410 +0,0 @@
-// Imports
-import {EventEmitter} from 'events';
-import {ClientRequest, IncomingMessage} from 'http';
-import * as https from 'https';
-import {GithubApi} from '../../lib/common/github-api';
-
-// Tests
-describe('GithubApi', () => {
-  let api: GithubApi;
-
-  beforeEach(() => api = new GithubApi('12345'));
-
-
-  describe('constructor()', () => {
-
-    it('should throw if \'githubToken\' is missing or empty', () => {
-      expect(() => new GithubApi('')).toThrowError('Missing or empty required parameter \'githubToken\'!');
-    });
-
-  });
-
-
-  describe('get()', () => {
-    let apiBuildPathSpy: jasmine.Spy;
-    let apiRequestSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      apiBuildPathSpy = spyOn(api as any, 'buildPath');
-      apiRequestSpy = spyOn(api as any, 'request');
-    });
-
-
-    it('should call \'buildPath()\' with the pathname and params', () => {
-      api.get('/foo', {bar: 'baz'});
-
-      expect(apiBuildPathSpy).toHaveBeenCalled();
-      expect(apiBuildPathSpy.calls.argsFor(0)).toEqual(['/foo', {bar: 'baz'}]);
-    });
-
-
-    it('should call \'request()\' with the correct method', () => {
-      api.get('/foo');
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[0]).toBe('get');
-    });
-
-
-    it('should call \'request()\' with the correct path', () => {
-      apiBuildPathSpy.and.returnValue('/foo/bar');
-      api.get('foo');
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[1]).toBe('/foo/bar');
-    });
-
-
-    it('should not pass data to \'request()\'', () => {
-      (api.get as any)('foo', {}, {});
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[2]).toBeUndefined();
-    });
-
-  });
-
-
-  describe('post()', () => {
-    let apiBuildPathSpy: jasmine.Spy;
-    let apiRequestSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      apiBuildPathSpy = spyOn(api as any, 'buildPath');
-      apiRequestSpy = spyOn(api as any, 'request');
-    });
-
-
-    it('should call \'buildPath()\' with the pathname and params', () => {
-      api.post('/foo', {bar: 'baz'});
-
-      expect(apiBuildPathSpy).toHaveBeenCalled();
-      expect(apiBuildPathSpy.calls.argsFor(0)).toEqual(['/foo', {bar: 'baz'}]);
-    });
-
-
-    it('should call \'request()\' with the correct method', () => {
-      api.post('/foo');
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[0]).toBe('post');
-    });
-
-
-    it('should call \'request()\' with the correct path', () => {
-      apiBuildPathSpy.and.returnValue('/foo/bar');
-      api.post('/foo');
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[1]).toBe('/foo/bar');
-    });
-
-
-    it('should pass the data to \'request()\'', () => {
-      api.post('/foo', {}, {bar: 'baz'});
-
-      expect(apiRequestSpy).toHaveBeenCalled();
-      expect(apiRequestSpy.calls.argsFor(0)[2]).toEqual({bar: 'baz'});
-    });
-
-  });
-
-
-  // Protected methods
-
-  describe('buildPath()', () => {
-
-    it('should return the pathname if no params', () => {
-      expect((api as any).buildPath('/foo')).toBe('/foo');
-      expect((api as any).buildPath('/foo', undefined)).toBe('/foo');
-      expect((api as any).buildPath('/foo', null)).toBe('/foo');
-    });
-
-
-    it('should append the params to the pathname', () => {
-      expect((api as any).buildPath('/foo', {bar: 'baz'})).toBe('/foo?bar=baz');
-    });
-
-
-    it('should join the params with \'&\'', () => {
-      expect((api as any).buildPath('/foo', {bar: 1, baz: 2})).toBe('/foo?bar=1&baz=2');
-    });
-
-
-    it('should ignore undefined/null params', () => {
-      expect((api as any).buildPath('/foo', {bar: undefined, baz: null})).toBe('/foo');
-    });
-
-
-    it('should encode param values as URI components', () => {
-      expect((api as any).buildPath('/foo', {bar: 'b a&z'})).toBe('/foo?bar=b%20a%26z');
-    });
-
-  });
-
-
-  describe('getPaginated()', () => {
-    let deferreds: {resolve: (v: any) => void, reject: (v: any) => void}[];
-
-    beforeEach(() => {
-      deferreds = [];
-      spyOn(api, 'get').and.callFake(() => new Promise((resolve, reject) => deferreds.push({resolve, reject})));
-    });
-
-
-    it('should return a promise', () => {
-      expect((api as any).getPaginated()).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should call \'get()\' with the correct pathname and params', () => {
-      (api as any).getPaginated('/foo/bar');
-      (api as any).getPaginated('/foo/bar', {baz: 'qux'});
-
-      expect(api.get).toHaveBeenCalledWith('/foo/bar', {page: 0, per_page: 100});
-      expect(api.get).toHaveBeenCalledWith('/foo/bar', {baz: 'qux', page: 0, per_page: 100});
-    });
-
-
-    it('should reject if the request fails', done => {
-      (api as any).getPaginated('/foo/bar').catch((err: any) => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      deferreds[0].reject('Test');
-    });
-
-
-    it('should resolve with the returned items', done => {
-      const items = [{id: 1}, {id: 2}];
-
-      (api as any).getPaginated('/foo/bar').then((data: any) => {
-        expect(data).toEqual(items);
-        done();
-      });
-
-      deferreds[0].resolve(items);
-    });
-
-
-    it('should iteratively call \'get()\' to fetch all items', done => {
-      // Create an array or 250 objects.
-      const allItems = '.'.repeat(250).split('').map((_, i) => ({id: i}));
-      const apiGetSpy = api.get as jasmine.Spy;
-
-      (api as any).getPaginated('/foo/bar', {baz: 'qux'}).then((data: any) => {
-        const paramsForPage = (page: number) => ({baz: 'qux', page, per_page: 100});
-
-        expect(apiGetSpy).toHaveBeenCalledTimes(3);
-        expect(apiGetSpy.calls.argsFor(0)).toEqual(['/foo/bar', paramsForPage(0)]);
-        expect(apiGetSpy.calls.argsFor(1)).toEqual(['/foo/bar', paramsForPage(1)]);
-        expect(apiGetSpy.calls.argsFor(2)).toEqual(['/foo/bar', paramsForPage(2)]);
-
-        expect(data).toEqual(allItems);
-
-        done();
-      });
-
-      deferreds[0].resolve(allItems.slice(0, 100));
-      setTimeout(() => {
-        deferreds[1].resolve(allItems.slice(100, 200));
-        setTimeout(() => {
-          deferreds[2].resolve(allItems.slice(200));
-        }, 0);
-      }, 0);
-    });
-
-  });
-
-
-  describe('request()', () => {
-    let httpsRequestSpy: jasmine.Spy;
-    let latestRequest: ClientRequest;
-
-    beforeEach(() => {
-      const originalRequest = https.request;
-
-      httpsRequestSpy = spyOn(https, 'request').and.callFake((...args: any[]) => {
-        latestRequest = originalRequest.apply(https, args);
-
-        spyOn(latestRequest, 'on').and.callThrough();
-        spyOn(latestRequest, 'end');
-
-        return latestRequest;
-      });
-    });
-
-
-    it('should return a promise', () => {
-      expect((api as any).request()).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should call \'https.request()\' with the correct options', () => {
-      (api as any).request('method', 'path');
-
-      expect(httpsRequestSpy).toHaveBeenCalled();
-      expect(httpsRequestSpy.calls.argsFor(0)[0]).toEqual(jasmine.objectContaining({
-        headers: jasmine.objectContaining({
-          'User-Agent': `Node/${process.versions.node}`,
-        }),
-        host: 'api.github.com',
-        method: 'method',
-        path: 'path',
-      }));
-    });
-
-
-    it('should call specify an \'Authorization\' header if \'githubToken\' is present', () => {
-      (api as any).request('method', 'path');
-
-      expect(httpsRequestSpy).toHaveBeenCalled();
-      expect(httpsRequestSpy.calls.argsFor(0)[0].headers).toEqual(jasmine.objectContaining({
-        Authorization: 'token 12345',
-      }));
-    });
-
-
-    it('should reject on request error', done => {
-      (api as any).request('method', 'path').catch((err: any) => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      latestRequest.emit('error', 'Test');
-    });
-
-
-    it('should send the request (i.e. call \'end()\')', () => {
-      (api as any).request('method', 'path');
-      expect(latestRequest.end).toHaveBeenCalled();
-    });
-
-
-    it('should \'JSON.stringify\' and send the data along with the request', () => {
-      (api as any).request('method', 'path');
-      expect(latestRequest.end).toHaveBeenCalledWith(null);
-
-      (api as any).request('method', 'path', {key: 'value'});
-      expect(latestRequest.end).toHaveBeenCalledWith('{"key":"value"}');
-    });
-
-
-    describe('onResponse', () => {
-      let promise: Promise<object>;
-      let respond: (statusCode: number) => IncomingMessage;
-
-      beforeEach(() => {
-        promise = (api as any).request('method', 'path');
-
-        respond = (statusCode: number) => {
-          const mockResponse = new EventEmitter() as IncomingMessage;
-          mockResponse.statusCode = statusCode;
-
-          const onResponse = httpsRequestSpy.calls.argsFor(0)[1];
-          onResponse(mockResponse);
-
-          return mockResponse;
-        };
-      });
-
-
-      it('should reject on response error', done => {
-        promise.catch(err => {
-          expect(err).toBe('Test');
-          done();
-        });
-
-        const res = respond(200);
-        res.emit('error', 'Test');
-      });
-
-
-      it('should reject if returned statusCode is <200', done => {
-        promise.catch(err => {
-          expect(err).toContain('failed');
-          expect(err).toContain('status: 199');
-          done();
-        });
-
-        const res = respond(199);
-        res.emit('end');
-      });
-
-
-      it('should reject if returned statusCode is >=400', done => {
-        promise.catch(err => {
-          expect(err).toContain('failed');
-          expect(err).toContain('status: 400');
-          done();
-        });
-
-        const res = respond(400);
-        res.emit('end');
-      });
-
-
-      it('should include the response text in the rejection message', done => {
-        promise.catch(err => {
-          expect(err).toContain('Test');
-          done();
-        });
-
-        const res = respond(500);
-        res.emit('data', 'Test');
-        res.emit('end');
-      });
-
-
-      it('should resolve if returned statusCode is <=200 <400', done => {
-        promise.then(done);
-
-        const res = respond(200);
-        res.emit('data', '{}');
-        res.emit('end');
-      });
-
-
-      it('should resolve with the response text \'JSON.parsed\'', done => {
-        promise.then(data => {
-          expect(data).toEqual({foo: 'bar'});
-          done();
-        });
-
-        const res = respond(300);
-        res.emit('data', '{"foo":"bar"}');
-        res.emit('end');
-      });
-
-
-      it('should collect and concatenate the whole response text', done => {
-        promise.then(data => {
-          expect(data).toEqual({foo: 'bar', baz: 'qux'});
-          done();
-        });
-
-        const res = respond(300);
-        res.emit('data', '{"foo":');
-        res.emit('data', '"bar","baz"');
-        res.emit('data', ':"qux"}');
-        res.emit('end');
-      });
-
-
-      it('should reject if the response text is malformed JSON', done => {
-        promise.catch(err => {
-          expect(err).toEqual(jasmine.any(SyntaxError));
-          done();
-        });
-
-        const res = respond(300);
-        res.emit('data', '}');
-        res.emit('end');
-      });
-
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/common/github-pull-requests.spec.ts

@@ -1,141 +0,0 @@
-// Imports
-import {GithubPullRequests} from '../../lib/common/github-pull-requests';
-
-// Tests
-describe('GithubPullRequests', () => {
-
-  describe('constructor()', () => {
-
-    it('should throw if \'githubToken\' is missing or empty', () => {
-      expect(() => new GithubPullRequests('', 'foo/bar')).
-        toThrowError('Missing or empty required parameter \'githubToken\'!');
-    });
-
-
-    it('should throw if \'repoSlug\' is missing or empty', () => {
-      expect(() => new GithubPullRequests('12345', '')).
-        toThrowError('Missing or empty required parameter \'repoSlug\'!');
-    });
-
-  });
-
-
-  describe('addComment()', () => {
-    let prs: GithubPullRequests;
-    let deferred: {resolve: (v: any) => void, reject: (v: any) => void};
-
-    beforeEach(() => {
-      prs = new GithubPullRequests('12345', 'foo/bar');
-
-      spyOn(prs, 'post').and.callFake(() => new Promise((resolve, reject) => deferred = {resolve, reject}));
-    });
-
-
-    it('should return a promise', () => {
-      expect(prs.addComment(42, 'body')).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should throw if the PR number is invalid', () => {
-      expect(() => prs.addComment(-1337, 'body')).toThrowError(`Invalid PR number: -1337`);
-      expect(() => prs.addComment(NaN, 'body')).toThrowError(`Invalid PR number: NaN`);
-    });
-
-
-    it('should throw if the comment body is invalid or empty', () => {
-      expect(() => prs.addComment(42, '')).toThrowError(`Invalid or empty comment body: `);
-    });
-
-
-    it('should call \'post()\' with the correct pathname, params and data', () => {
-      prs.addComment(42, 'body');
-
-      expect(prs.post).toHaveBeenCalledWith('/repos/foo/bar/issues/42/comments', null, {body: 'body'});
-    });
-
-
-    it('should reject if the request fails', done => {
-      prs.addComment(42, 'body').catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-
-      deferred.reject('Test');
-    });
-
-
-    it('should resolve with the returned response', done => {
-      prs.addComment(42, 'body').then(data => {
-        expect(data as any).toBe('Test');
-        done();
-      });
-
-      deferred.resolve('Test');
-    });
-
-  });
-
-
-  describe('fetch()', () => {
-    let prs: GithubPullRequests;
-    let prsGetSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      prs = new GithubPullRequests('12345', 'foo/bar');
-      prsGetSpy = spyOn(prs as any, 'get');
-    });
-
-
-    it('should call \'get()\' with the correct pathname', () => {
-      prs.fetch(42);
-      expect(prsGetSpy).toHaveBeenCalledWith('/repos/foo/bar/issues/42');
-    });
-
-
-    it('should forward the value returned by \'get()\'', () => {
-      prsGetSpy.and.returnValue('Test');
-      expect(prs.fetch(42) as any).toBe('Test');
-    });
-
-  });
-
-
-  describe('fetchAll()', () => {
-    let prs: GithubPullRequests;
-    let prsGetPaginatedSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      prs = new GithubPullRequests('12345', 'foo/bar');
-      prsGetPaginatedSpy = spyOn(prs as any, 'getPaginated');
-      spyOn(console, 'log');
-    });
-
-
-    it('should call \'getPaginated()\' with the correct pathname and params', () => {
-      const expectedPathname = '/repos/foo/bar/pulls';
-
-      prs.fetchAll('all');
-      prs.fetchAll('closed');
-      prs.fetchAll('open');
-
-      expect(prsGetPaginatedSpy).toHaveBeenCalledTimes(3);
-      expect(prsGetPaginatedSpy.calls.argsFor(0)).toEqual([expectedPathname, {state: 'all'}]);
-      expect(prsGetPaginatedSpy.calls.argsFor(1)).toEqual([expectedPathname, {state: 'closed'}]);
-      expect(prsGetPaginatedSpy.calls.argsFor(2)).toEqual([expectedPathname, {state: 'open'}]);
-    });
-
-
-    it('should default to \'all\' if no state is specified', () => {
-      prs.fetchAll();
-      expect(prsGetPaginatedSpy).toHaveBeenCalledWith('/repos/foo/bar/pulls', {state: 'all'});
-    });
-
-
-    it('should forward the value returned by \'getPaginated()\'', () => {
-      prsGetPaginatedSpy.and.returnValue('Test');
-      expect(prs.fetchAll() as any).toBe('Test');
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/common/github-teams.spec.ts

@@ -1,235 +0,0 @@
-// Imports
-import {GithubTeams} from '../../lib/common/github-teams';
-
-// Tests
-describe('GithubTeams', () => {
-
-  describe('constructor()', () => {
-
-    it('should throw if \'githubToken\' is missing or empty', () => {
-      expect(() => new GithubTeams('', 'org')).
-        toThrowError('Missing or empty required parameter \'githubToken\'!');
-    });
-
-
-    it('should throw if \'organization\' is missing or empty', () => {
-      expect(() => new GithubTeams('12345', '')).
-        toThrowError('Missing or empty required parameter \'organization\'!');
-    });
-
-  });
-
-
-  describe('fetchAll()', () => {
-    let teams: GithubTeams;
-    let teamsGetPaginatedSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      teams = new GithubTeams('12345', 'foo');
-      teamsGetPaginatedSpy = spyOn(teams as any, 'getPaginated');
-    });
-
-
-    it('should call \'getPaginated()\' with the correct pathname and params', () => {
-      teams.fetchAll();
-      expect(teamsGetPaginatedSpy).toHaveBeenCalledWith('/orgs/foo/teams');
-    });
-
-
-    it('should forward the value returned by \'getPaginated()\'', () => {
-      teamsGetPaginatedSpy.and.returnValue('Test');
-      expect(teams.fetchAll() as any).toBe('Test');
-    });
-
-  });
-
-
-  describe('isMemberById()', () => {
-    let teams: GithubTeams;
-    let teamsGetSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      teams = new GithubTeams('12345', 'foo');
-      teamsGetSpy = spyOn(teams, 'get').and.returnValue(Promise.resolve(null));
-    });
-
-
-    it('should return a promise', done => {
-      const promise = teams.isMemberById('user', [1]);
-      promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                            // to avoid running the actual `get()`.
-
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should resolve with false if called with an empty array', done => {
-      teams.isMemberById('user', []).then(isMember => {
-        expect(isMember).toBe(false);
-        expect(teamsGetSpy).not.toHaveBeenCalled();
-        done();
-      });
-    });
-
-
-    it('should call \'get()\' with the correct pathname', done => {
-      teams.isMemberById('user', [1]).then(() => {
-        expect(teamsGetSpy).toHaveBeenCalledWith('/teams/1/memberships/user');
-        done();
-      });
-    });
-
-
-    it('should resolve with false if \'get()\' rejects', done => {
-      teamsGetSpy.and.returnValue(Promise.reject(null));
-      teams.isMemberById('user', [1]).then(isMember => {
-        expect(isMember).toBe(false);
-        expect(teamsGetSpy).toHaveBeenCalled();
-        done();
-      });
-    });
-
-
-    it('should resolve with false if the membership is not active', done => {
-      teamsGetSpy.and.returnValue(Promise.resolve({state: 'pending'}));
-      teams.isMemberById('user', [1]).then(isMember => {
-        expect(isMember).toBe(false);
-        expect(teamsGetSpy).toHaveBeenCalled();
-        done();
-      });
-    });
-
-
-    it('should resolve with true if the membership is active', done => {
-      teamsGetSpy.and.returnValue(Promise.resolve({state: 'active'}));
-      teams.isMemberById('user', [1]).then(isMember => {
-        expect(isMember).toBe(true);
-        done();
-      });
-    });
-
-
-    it('should sequentially call \'get()\' until an active membership is found', done => {
-      const trainedResponses: {[pathname: string]: Promise<{state: string}>} = {
-        '/teams/1/memberships/user': Promise.resolve({state: 'pending'}),
-        '/teams/2/memberships/user': Promise.reject(null),
-        '/teams/3/memberships/user': Promise.resolve({state: 'active'}),
-      };
-      teamsGetSpy.and.callFake((pathname: string) => trainedResponses[pathname]);
-
-      teams.isMemberById('user', [1, 2, 3, 4]).then(isMember => {
-        expect(isMember).toBe(true);
-
-        expect(teamsGetSpy).toHaveBeenCalledTimes(3);
-        expect(teamsGetSpy.calls.argsFor(0)[0]).toBe('/teams/1/memberships/user');
-        expect(teamsGetSpy.calls.argsFor(1)[0]).toBe('/teams/2/memberships/user');
-        expect(teamsGetSpy.calls.argsFor(2)[0]).toBe('/teams/3/memberships/user');
-
-        done();
-      });
-    });
-
-
-    it('should resolve with false if no active membership is found', done => {
-      const trainedResponses: {[pathname: string]: Promise<{state: string}>} = {
-        '/teams/1/memberships/user': Promise.resolve({state: 'pending'}),
-        '/teams/2/memberships/user':  Promise.reject(null),
-        '/teams/3/memberships/user': Promise.resolve({state: 'not active'}),
-        '/teams/4/memberships/user':  Promise.reject(null),
-      };
-      teamsGetSpy.and.callFake((pathname: string) => trainedResponses[pathname]);
-
-      teams.isMemberById('user', [1, 2, 3, 4]).then(isMember => {
-        expect(isMember).toBe(false);
-
-        expect(teamsGetSpy).toHaveBeenCalledTimes(4);
-        expect(teamsGetSpy.calls.argsFor(0)[0]).toBe('/teams/1/memberships/user');
-        expect(teamsGetSpy.calls.argsFor(1)[0]).toBe('/teams/2/memberships/user');
-        expect(teamsGetSpy.calls.argsFor(2)[0]).toBe('/teams/3/memberships/user');
-        expect(teamsGetSpy.calls.argsFor(3)[0]).toBe('/teams/4/memberships/user');
-
-        done();
-      });
-    });
-
-  });
-
-
-  describe('isMemberBySlug()', () => {
-    let teams: GithubTeams;
-    let teamsFetchAllSpy: jasmine.Spy;
-    let teamsIsMemberByIdSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      teams = new GithubTeams('12345', 'foo');
-
-      const mockResponse = Promise.resolve([{id: 1, slug: 'team1'}, {id: 2, slug: 'team2'}]);
-      teamsFetchAllSpy = spyOn(teams, 'fetchAll').and.returnValue(mockResponse);
-      teamsIsMemberByIdSpy = spyOn(teams, 'isMemberById');
-    });
-
-
-    it('should return a promise', () => {
-      expect(teams.isMemberBySlug('user', ['team-slug'])).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should call \'fetchAll()\'', () => {
-      teams.isMemberBySlug('user', ['team-slug']);
-      expect(teamsFetchAllSpy).toHaveBeenCalled();
-    });
-
-
-    it('should resolve with false if \'fetchAll()\' rejects', done => {
-      teamsFetchAllSpy.and.returnValue(Promise.reject(null));
-      teams.isMemberBySlug('user', ['team-slug']).then(isMember => {
-        expect(isMember).toBe(false);
-        done();
-      });
-    });
-
-
-    it('should call \'isMemberById()\' with the correct params if no team is found', done => {
-      teams.isMemberBySlug('user', ['no-match']).then(() => {
-        expect(teamsIsMemberByIdSpy).toHaveBeenCalledWith('user', []);
-        done();
-      });
-    });
-
-
-    it('should call \'isMemberById()\' with the correct params if teams are found', done => {
-      const spy = teamsIsMemberByIdSpy;
-
-      Promise.all([
-        teams.isMemberBySlug('user', ['team1']).then(() => expect(spy).toHaveBeenCalledWith('user', [1])),
-        teams.isMemberBySlug('user', ['team2']).then(() => expect(spy).toHaveBeenCalledWith('user', [2])),
-        teams.isMemberBySlug('user', ['team1', 'team2']).then(() => expect(spy).toHaveBeenCalledWith('user', [1, 2])),
-      ]).then(done);
-    });
-
-
-    it('should resolve with false if \'isMemberById()\' rejects', done => {
-      teamsIsMemberByIdSpy.and.returnValue(Promise.reject(null));
-      teams.isMemberBySlug('user', ['team1']).then(isMember => {
-        expect(isMember).toBe(false);
-        expect(teamsIsMemberByIdSpy).toHaveBeenCalled();
-        done();
-      });
-    });
-
-
-    it('should resolve with the value \'isMemberById()\' resolves with', done => {
-      teamsIsMemberByIdSpy.and.returnValues(Promise.resolve(false), Promise.resolve(true));
-
-      Promise.all([
-        teams.isMemberBySlug('user', ['team1']).then(isMember => expect(isMember).toBe(false)),
-        teams.isMemberBySlug('user', ['team1']).then(isMember => expect(isMember).toBe(true)),
-      ]).then(() => {
-        expect(teamsIsMemberByIdSpy).toHaveBeenCalledTimes(2);
-        done();
-      });
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/common/utils.spec.ts

@@ -1,81 +0,0 @@
-// Imports
-import {assertNotMissingOrEmpty, getEnvVar} from '../../lib/common/utils';
-
-// Tests
-describe('utils', () => {
-
-  describe('assertNotMissingOrEmpty()', () => {
-
-    it('should throw if passed an empty value', () => {
-      expect(() => assertNotMissingOrEmpty('foo', undefined)).
-        toThrowError('Missing or empty required parameter \'foo\'!');
-      expect(() => assertNotMissingOrEmpty('bar', null)).toThrowError('Missing or empty required parameter \'bar\'!');
-      expect(() => assertNotMissingOrEmpty('baz', '')).toThrowError('Missing or empty required parameter \'baz\'!');
-    });
-
-
-    it('should not throw if passed a non-empty value', () => {
-      expect(() => assertNotMissingOrEmpty('foo', ' ')).not.toThrow();
-      expect(() => assertNotMissingOrEmpty('bar', 'bar')).not.toThrow();
-      expect(() => assertNotMissingOrEmpty('baz', 'b a z')).not.toThrow();
-    });
-
-  });
-
-
-  describe('getEnvVar()', () => {
-    const emptyVar = '$$test_utils_getEnvVar_empty$$';
-    const nonEmptyVar = '$$test_utils_getEnvVar_nonEmpty$$';
-    const undefinedVar = '$$test_utils_getEnvVar_undefined$$';
-
-    beforeEach(() => {
-      process.env[emptyVar] = '';
-      process.env[nonEmptyVar] = 'foo';
-    });
-    afterEach(() => {
-      delete process.env[emptyVar];
-      delete process.env[nonEmptyVar];
-    });
-
-
-    it('should return an environment variable', () => {
-      expect(getEnvVar(nonEmptyVar)).toBe('foo');
-    });
-
-
-    it('should exit with an error if the environment variable is not defined', () => {
-      const consoleErrorSpy = spyOn(console, 'error');
-      const processExitSpy = spyOn(process, 'exit');
-
-      getEnvVar(undefinedVar);
-
-      expect(consoleErrorSpy).toHaveBeenCalled();
-      expect(consoleErrorSpy.calls.argsFor(0)[0]).toContain(undefinedVar);
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-    });
-
-
-    it('should exit with an error if the environment variable is empty', () => {
-      const consoleErrorSpy = spyOn(console, 'error');
-      const processExitSpy = spyOn(process, 'exit');
-
-      getEnvVar(emptyVar);
-
-      expect(consoleErrorSpy).toHaveBeenCalled();
-      expect(consoleErrorSpy.calls.argsFor(0)[0]).toContain(emptyVar);
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-    });
-
-
-    it('should return an empty string if an undefined variable is optional', () => {
-      expect(getEnvVar(undefinedVar, true)).toBe('');
-    });
-
-
-    it('should return an empty string if an empty variable is optional', () => {
-      expect(getEnvVar(emptyVar, true)).toBe('');
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/helpers.ts

@@ -1,6 +0,0 @@
-declare namespace jasmine {
-  export interface DoneFn extends Function {
-    (): void;
-    fail: (message: Error | string) => void;
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/test/index.ts

@@ -1,7 +0,0 @@
-// Imports
-import {runTests} from '../lib/common/run-tests';
-
-// Run
-const specFiles = [`${__dirname}/**/*.spec.js`];
-const helpers = [`${__dirname}/helpers.js`];
-runTests(specFiles, helpers);

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/build-creator.spec.ts

@@ -1,687 +0,0 @@
-// Imports
-import * as cp from 'child_process';
-import {EventEmitter} from 'events';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as shell from 'shelljs';
-import {SHORT_SHA_LEN} from '../../lib/common/constants';
-import {BuildCreator} from '../../lib/upload-server/build-creator';
-import {ChangedPrVisibilityEvent, CreatedBuildEvent} from '../../lib/upload-server/build-events';
-import {UploadError} from '../../lib/upload-server/upload-error';
-import {expectToBeUploadError} from './helpers';
-
-// Tests
-describe('BuildCreator', () => {
-  const pr = '9';
-  const sha = '9'.repeat(40);
-  const shortSha = sha.substr(0, SHORT_SHA_LEN);
-  const archive = 'snapshot.tar.gz';
-  const buildsDir = 'builds/dir';
-  const hiddenPrDir = path.join(buildsDir, `hidden--${pr}`);
-  const publicPrDir = path.join(buildsDir, pr);
-  const hiddenShaDir = path.join(hiddenPrDir, shortSha);
-  const publicShaDir = path.join(publicPrDir, shortSha);
-  let bc: BuildCreator;
-
-  beforeEach(() => bc = new BuildCreator(buildsDir));
-
-
-  describe('constructor()', () => {
-
-    it('should throw if \'buildsDir\' is missing or empty', () => {
-      expect(() => new BuildCreator('')).toThrowError('Missing or empty required parameter \'buildsDir\'!');
-    });
-
-
-    it('should extend EventEmitter', () => {
-      expect(bc).toEqual(jasmine.any(BuildCreator));
-      expect(bc).toEqual(jasmine.any(EventEmitter));
-
-      expect(Object.getPrototypeOf(bc)).toBe(BuildCreator.prototype);
-    });
-
-  });
-
-
-  describe('create()', () => {
-    let bcEmitSpy: jasmine.Spy;
-    let bcExistsSpy: jasmine.Spy;
-    let bcExtractArchiveSpy: jasmine.Spy;
-    let bcUpdatePrVisibilitySpy: jasmine.Spy;
-    let shellMkdirSpy: jasmine.Spy;
-    let shellRmSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      bcEmitSpy = spyOn(bc, 'emit');
-      bcExistsSpy = spyOn(bc as any, 'exists');
-      bcExtractArchiveSpy = spyOn(bc as any, 'extractArchive');
-      bcUpdatePrVisibilitySpy = spyOn(bc, 'updatePrVisibility');
-      shellMkdirSpy = spyOn(shell, 'mkdir');
-      shellRmSpy = spyOn(shell, 'rm');
-    });
-
-
-    [true, false].forEach(isPublic => {
-      const prDir = isPublic ? publicPrDir : hiddenPrDir;
-      const shaDir = isPublic ? publicShaDir : hiddenShaDir;
-
-
-      it('should return a promise', done => {
-        const promise = bc.create(pr, sha, archive, isPublic);
-        promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                              // to avoid running the actual `extractArchive()`.
-
-        expect(promise).toEqual(jasmine.any(Promise));
-      });
-
-
-      it('should update the PR\'s visibility first if necessary', done => {
-        bcUpdatePrVisibilitySpy.and.callFake(() => expect(shellMkdirSpy).not.toHaveBeenCalled());
-
-        bc.create(pr, sha, archive, isPublic).
-          then(() => {
-            expect(bcUpdatePrVisibilitySpy).toHaveBeenCalledWith(pr, isPublic);
-            expect(shellMkdirSpy).toHaveBeenCalled();
-          }).
-          then(done);
-      });
-
-
-      it('should create the build directory (and any parent directories)', done => {
-        bc.create(pr, sha, archive, isPublic).
-          then(() => expect(shellMkdirSpy).toHaveBeenCalledWith('-p', shaDir)).
-          then(done);
-      });
-
-
-      it('should extract the archive contents into the build directory', done => {
-        bc.create(pr, sha, archive, isPublic).
-          then(() => expect(bcExtractArchiveSpy).toHaveBeenCalledWith(archive, shaDir)).
-          then(done);
-      });
-
-
-      it('should emit a CreatedBuildEvent on success', done => {
-        let emitted = false;
-
-        bcEmitSpy.and.callFake((type: string, evt: CreatedBuildEvent) => {
-          expect(type).toBe(CreatedBuildEvent.type);
-          expect(evt).toEqual(jasmine.any(CreatedBuildEvent));
-          expect(evt.pr).toBe(+pr);
-          expect(evt.sha).toBe(shortSha);
-          expect(evt.isPublic).toBe(isPublic);
-
-          emitted = true;
-        });
-
-        bc.create(pr, sha, archive, isPublic).
-          then(() => expect(emitted).toBe(true)).
-          then(done);
-      });
-
-
-      describe('on error', () => {
-        let existsValues: {[dir: string]: boolean};
-
-        beforeEach(() => {
-          existsValues = {
-            [prDir]: false,
-            [shaDir]: false,
-          };
-
-          bcExistsSpy.and.callFake((dir: string) => existsValues[dir]);
-        });
-
-
-        it('should abort and skip further operations if changing the PR\'s visibility fails', done => {
-          const mockError = new UploadError(543, 'Test');
-          bcUpdatePrVisibilitySpy.and.returnValue(Promise.reject(mockError));
-
-          bc.create(pr, sha, archive, isPublic).catch(err => {
-            expect(err).toBe(mockError);
-
-            expect(bcExistsSpy).not.toHaveBeenCalled();
-            expect(shellMkdirSpy).not.toHaveBeenCalled();
-            expect(bcExtractArchiveSpy).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-
-            done();
-          });
-        });
-
-
-        it('should abort and skip further operations if the build does already exist', done => {
-          existsValues[shaDir] = true;
-          bc.create(pr, sha, archive, isPublic).catch(err => {
-            const publicOrNot = isPublic ? 'public' : 'non-public';
-            expectToBeUploadError(err, 409, `Request to overwrite existing ${publicOrNot} directory: ${shaDir}`);
-            expect(shellMkdirSpy).not.toHaveBeenCalled();
-            expect(bcExtractArchiveSpy).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should detect existing build directory after visibility change', done => {
-          bcUpdatePrVisibilitySpy.and.callFake(() => existsValues[prDir] = existsValues[shaDir] = true);
-
-          expect(bcExistsSpy(prDir)).toBe(false);
-          expect(bcExistsSpy(shaDir)).toBe(false);
-
-          bc.create(pr, sha, archive, isPublic).catch(err => {
-            const publicOrNot = isPublic ? 'public' : 'non-public';
-            expectToBeUploadError(err, 409, `Request to overwrite existing ${publicOrNot} directory: ${shaDir}`);
-            expect(shellMkdirSpy).not.toHaveBeenCalled();
-            expect(bcExtractArchiveSpy).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should abort and skip further operations if it fails to create the directories', done => {
-          shellMkdirSpy.and.throwError('');
-          bc.create(pr, sha, archive, isPublic).catch(() => {
-            expect(shellMkdirSpy).toHaveBeenCalled();
-            expect(bcExtractArchiveSpy).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should abort and skip further operations if it fails to extract the archive', done => {
-          bcExtractArchiveSpy.and.throwError('');
-          bc.create(pr, sha, archive, isPublic).catch(() => {
-            expect(shellMkdirSpy).toHaveBeenCalled();
-            expect(bcExtractArchiveSpy).toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should delete the PR directory (for new PR)', done => {
-          bcExtractArchiveSpy.and.throwError('');
-          bc.create(pr, sha, archive, isPublic).catch(() => {
-            expect(shellRmSpy).toHaveBeenCalledWith('-rf', prDir);
-            done();
-          });
-        });
-
-
-        it('should delete the SHA directory (for existing PR)', done => {
-          existsValues[prDir] = true;
-          bcExtractArchiveSpy.and.throwError('');
-
-          bc.create(pr, sha, archive, isPublic).catch(() => {
-            expect(shellRmSpy).toHaveBeenCalledWith('-rf', shaDir);
-            done();
-          });
-        });
-
-
-        it('should reject with an UploadError', done => {
-          // tslint:disable-next-line: no-string-throw
-          shellMkdirSpy.and.callFake(() => { throw 'Test'; });
-          bc.create(pr, sha, archive, isPublic).catch(err => {
-            expectToBeUploadError(err, 500, `Error while uploading to directory: ${shaDir}\nTest`);
-            done();
-          });
-        });
-
-
-        it('should pass UploadError instances unmodified', done => {
-          shellMkdirSpy.and.callFake(() => { throw new UploadError(543, 'Test'); });
-          bc.create(pr, sha, archive, isPublic).catch(err => {
-            expectToBeUploadError(err, 543, 'Test');
-            done();
-          });
-        });
-
-      });
-
-    });
-
-  });
-
-
-  describe('updatePrVisibility()', () => {
-    let bcEmitSpy: jasmine.Spy;
-    let bcExistsSpy: jasmine.Spy;
-    let bcListShasByDate: jasmine.Spy;
-    let shellMvSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      bcEmitSpy = spyOn(bc, 'emit');
-      bcExistsSpy = spyOn(bc as any, 'exists');
-      bcListShasByDate = spyOn(bc as any, 'listShasByDate');
-      shellMvSpy = spyOn(shell, 'mv');
-
-      bcExistsSpy.and.returnValues(Promise.resolve(true), Promise.resolve(false));
-      bcListShasByDate.and.returnValue([]);
-    });
-
-
-    it('should return a promise', done => {
-      const promise = bc.updatePrVisibility(pr, true);
-      promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                            // to avoid running the actual `extractArchive()`.
-
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    [true, false].forEach(makePublic => {
-      const oldPrDir = makePublic ? hiddenPrDir : publicPrDir;
-      const newPrDir = makePublic ? publicPrDir : hiddenPrDir;
-
-
-      it('should rename the directory', done => {
-        bc.updatePrVisibility(pr, makePublic).
-          then(() => expect(shellMvSpy).toHaveBeenCalledWith(oldPrDir, newPrDir)).
-          then(done);
-      });
-
-
-      describe('when the visibility is updated', () => {
-
-        it('should resolve to true', done => {
-          bc.updatePrVisibility(pr, makePublic).
-            then(result => expect(result).toBe(true)).
-            then(done);
-        });
-
-
-        it('should rename the directory', done => {
-          bc.updatePrVisibility(pr, makePublic).
-            then(() => expect(shellMvSpy).toHaveBeenCalledWith(oldPrDir, newPrDir)).
-            then(done);
-        });
-
-
-        it('should emit a ChangedPrVisibilityEvent on success', done => {
-          let emitted = false;
-
-          bcEmitSpy.and.callFake((type: string, evt: ChangedPrVisibilityEvent) => {
-            expect(type).toBe(ChangedPrVisibilityEvent.type);
-            expect(evt).toEqual(jasmine.any(ChangedPrVisibilityEvent));
-            expect(evt.pr).toBe(+pr);
-            expect(evt.shas).toEqual(jasmine.any(Array));
-            expect(evt.isPublic).toBe(makePublic);
-
-            emitted = true;
-          });
-
-          bc.updatePrVisibility(pr, makePublic).
-            then(() => expect(emitted).toBe(true)).
-            then(done);
-        });
-
-
-        it('should include all shas in the emitted event', done => {
-          const shas = ['foo', 'bar', 'baz'];
-          let emitted = false;
-
-          bcListShasByDate.and.returnValue(Promise.resolve(shas));
-          bcEmitSpy.and.callFake((type: string, evt: ChangedPrVisibilityEvent) => {
-            expect(bcListShasByDate).toHaveBeenCalledWith(newPrDir);
-
-            expect(type).toBe(ChangedPrVisibilityEvent.type);
-            expect(evt).toEqual(jasmine.any(ChangedPrVisibilityEvent));
-            expect(evt.pr).toBe(+pr);
-            expect(evt.shas).toBe(shas);
-            expect(evt.isPublic).toBe(makePublic);
-
-            emitted = true;
-          });
-
-          bc.updatePrVisibility(pr, makePublic).
-            then(() => expect(emitted).toBe(true)).
-            then(done);
-        });
-
-      });
-
-
-      it('should do nothing if the visibility is already up-to-date', done => {
-        bcExistsSpy.and.callFake((dir: string) => dir === newPrDir);
-        bc.updatePrVisibility(pr, makePublic).
-          then(result => {
-            expect(result).toBe(false);
-            expect(shellMvSpy).not.toHaveBeenCalled();
-            expect(bcListShasByDate).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-          }).
-          then(done);
-      });
-
-
-      it('should do nothing if the PR directory does not exist', done => {
-        bcExistsSpy.and.returnValue(false);
-        bc.updatePrVisibility(pr, makePublic).
-          then(result => {
-            expect(result).toBe(false);
-            expect(shellMvSpy).not.toHaveBeenCalled();
-            expect(bcListShasByDate).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-          }).
-          then(done);
-      });
-
-
-      describe('on error', () => {
-
-        it('should abort and skip further operations if both directories exist', done => {
-          bcExistsSpy.and.returnValue(true);
-          bc.updatePrVisibility(pr, makePublic).catch(err => {
-            expectToBeUploadError(err, 409, `Request to move '${oldPrDir}' to existing directory '${newPrDir}'.`);
-            expect(shellMvSpy).not.toHaveBeenCalled();
-            expect(bcListShasByDate).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should abort and skip further operations if it fails to rename the directory', done => {
-          shellMvSpy.and.throwError('');
-          bc.updatePrVisibility(pr, makePublic).catch(() => {
-            expect(shellMvSpy).toHaveBeenCalled();
-            expect(bcListShasByDate).not.toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should abort and skip further operations if it fails to list the SHAs', done => {
-          bcListShasByDate.and.throwError('');
-          bc.updatePrVisibility(pr, makePublic).catch(() => {
-            expect(shellMvSpy).toHaveBeenCalled();
-            expect(bcListShasByDate).toHaveBeenCalled();
-            expect(bcEmitSpy).not.toHaveBeenCalled();
-            done();
-          });
-        });
-
-
-        it('should reject with an UploadError', done => {
-          // tslint:disable-next-line: no-string-throw
-          shellMvSpy.and.callFake(() => { throw 'Test'; });
-          bc.updatePrVisibility(pr, makePublic).catch(err => {
-            expectToBeUploadError(err, 500, `Error while making PR ${pr} ${makePublic ? 'public' : 'hidden'}.\nTest`);
-            done();
-          });
-        });
-
-
-        it('should pass UploadError instances unmodified', done => {
-          shellMvSpy.and.callFake(() => { throw new UploadError(543, 'Test'); });
-          bc.updatePrVisibility(pr, makePublic).catch(err => {
-            expectToBeUploadError(err, 543, 'Test');
-            done();
-          });
-        });
-
-      });
-
-    });
-
-  });
-
-
-  // Protected methods
-
-  describe('exists()', () => {
-    let fsAccessSpy: jasmine.Spy;
-    let fsAccessCbs: ((v?: any) => void)[];
-
-    beforeEach(() => {
-      fsAccessCbs = [];
-      fsAccessSpy = spyOn(fs, 'access').and.callFake((_: string, cb: (v?: any) => void) => fsAccessCbs.push(cb));
-    });
-
-
-    it('should return a promise', () => {
-      expect((bc as any).exists('foo')).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should call \'fs.access()\' with the specified argument', () => {
-      (bc as any).exists('foo');
-      expect(fs.access).toHaveBeenCalledWith('foo', jasmine.any(Function));
-    });
-
-
-    it('should resolve with \'true\' if \'fs.access()\' succeeds', done => {
-      Promise.
-        all([(bc as any).exists('foo'), (bc as any).exists('bar')]).
-        then(results => expect(results).toEqual([true, true])).
-        then(done);
-
-      fsAccessCbs[0]();
-      fsAccessCbs[1](null);
-    });
-
-
-    it('should resolve with \'false\' if \'fs.access()\' errors', done => {
-      Promise.
-        all([(bc as any).exists('foo'), (bc as any).exists('bar')]).
-        then(results => expect(results).toEqual([false, false])).
-        then(done);
-
-      fsAccessCbs[0]('Error');
-      fsAccessCbs[1](new Error());
-    });
-
-  });
-
-
-  describe('extractArchive()', () => {
-    let consoleWarnSpy: jasmine.Spy;
-    let shellChmodSpy: jasmine.Spy;
-    let shellRmSpy: jasmine.Spy;
-    let cpExecSpy: jasmine.Spy;
-    let cpExecCbs: ((...args: any[]) => void)[];
-
-    beforeEach(() => {
-      cpExecCbs = [];
-
-      consoleWarnSpy = spyOn(console, 'warn');
-      shellChmodSpy = spyOn(shell, 'chmod');
-      shellRmSpy = spyOn(shell, 'rm');
-      cpExecSpy = spyOn(cp, 'exec').and.callFake((_: string, cb: (...args: any[]) => void) => cpExecCbs.push(cb));
-    });
-
-
-    it('should return a promise', () => {
-      expect((bc as any).extractArchive('foo', 'bar')).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should "gunzip" and "untar" the input file into the output directory', () => {
-      const cmd = 'tar --extract --gzip --directory "output/dir" --file "input/file"';
-
-      (bc as any).extractArchive('input/file', 'output/dir');
-      expect(cpExecSpy).toHaveBeenCalledWith(cmd, jasmine.any(Function));
-    });
-
-
-    it('should log (as a warning) any stderr output if extracting succeeded', done => {
-      (bc as any).extractArchive('foo', 'bar').
-        then(() => expect(consoleWarnSpy).toHaveBeenCalledWith('This is stderr')).
-        then(done);
-
-      cpExecCbs[0](null, 'This is stdout', 'This is stderr');
-    });
-
-
-    it('should make the build directory non-writable', done => {
-      (bc as any).extractArchive('foo', 'bar').
-        then(() => expect(shellChmodSpy).toHaveBeenCalledWith('-R', 'a-w', 'bar')).
-        then(done);
-
-      cpExecCbs[0]();
-    });
-
-
-    it('should delete the uploaded file on success', done => {
-      (bc as any).extractArchive('input/file', 'output/dir').
-        then(() => expect(shellRmSpy).toHaveBeenCalledWith('-f', 'input/file')).
-        then(done);
-
-      cpExecCbs[0]();
-    });
-
-
-    describe('on error', () => {
-
-      it('should abort and skip further operations if it fails to extract the archive', done => {
-        (bc as any).extractArchive('foo', 'bar').catch((err: any) => {
-          expect(shellChmodSpy).not.toHaveBeenCalled();
-          expect(shellRmSpy).not.toHaveBeenCalled();
-          expect(err).toBe('Test');
-          done();
-        });
-
-        cpExecCbs[0]('Test');
-      });
-
-
-      it('should abort and skip further operations if it fails to make non-writable', done => {
-        (bc as any).extractArchive('foo', 'bar').catch((err: any) => {
-          expect(shellChmodSpy).toHaveBeenCalled();
-          expect(shellRmSpy).not.toHaveBeenCalled();
-          expect(err).toBe('Test');
-          done();
-        });
-
-        shellChmodSpy.and.callFake(() => {
-          // tslint:disable-next-line: no-string-throw
-          throw 'Test';
-        });
-
-        cpExecCbs[0]();
-      });
-
-
-      it('should abort and reject if it fails to remove the uploaded file', done => {
-        (bc as any).extractArchive('foo', 'bar').catch((err: any) => {
-          expect(shellChmodSpy).toHaveBeenCalled();
-          expect(shellRmSpy).toHaveBeenCalled();
-          expect(err).toBe('Test');
-          done();
-        });
-
-        shellRmSpy.and.callFake(() => {
-          // tslint:disable-next-line: no-string-throw
-          throw 'Test';
-        });
-
-        cpExecCbs[0]();
-      });
-
-    });
-
-  });
-
-
-  describe('listShasByDate()', () => {
-    let shellLsSpy: jasmine.Spy;
-    const lsResult = (name: string, mtimeMs: number, isDirectory = true) => ({
-      isDirectory: () => isDirectory,
-      mtime: new Date(mtimeMs),
-      name,
-    });
-
-    beforeEach(() => {
-      shellLsSpy = spyOn(shell, 'ls').and.returnValue([]);
-    });
-
-
-    it('should return a promise', done => {
-      const promise = (bc as any).listShasByDate('input/dir');
-      promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                            // to avoid running the actual `ls()`.
-
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should `ls()` files with their metadata', done => {
-      (bc as any).listShasByDate('input/dir').
-        then(() => expect(shellLsSpy).toHaveBeenCalledWith('-l', 'input/dir')).
-        then(done);
-    });
-
-
-    it('should reject if listing files fails', done => {
-      shellLsSpy.and.returnValue(Promise.reject('Test'));
-      (bc as any).listShasByDate('input/dir').catch((err: string) => {
-        expect(err).toBe('Test');
-        done();
-      });
-    });
-
-
-    it('should return the filenames', done => {
-      shellLsSpy.and.returnValue(Promise.resolve([
-        lsResult('foo', 100),
-        lsResult('bar', 200),
-        lsResult('baz', 300),
-      ]));
-
-      (bc as any).listShasByDate('input/dir').
-        then((shas: string[]) => expect(shas).toEqual(['foo', 'bar', 'baz'])).
-        then(done);
-    });
-
-
-    it('should sort by date', done => {
-      shellLsSpy.and.returnValue(Promise.resolve([
-        lsResult('foo', 300),
-        lsResult('bar', 100),
-        lsResult('baz', 200),
-      ]));
-
-      (bc as any).listShasByDate('input/dir').
-        then((shas: string[]) => expect(shas).toEqual(['bar', 'baz', 'foo'])).
-        then(done);
-    });
-
-
-    it('should not break with ShellJS\' custom `sort()` method', done => {
-      const mockArray = [
-        lsResult('foo', 300),
-        lsResult('bar', 100),
-        lsResult('baz', 200),
-      ];
-      mockArray.sort = jasmine.createSpy('sort');
-
-      shellLsSpy.and.returnValue(Promise.resolve(mockArray));
-      (bc as any).listShasByDate('input/dir').
-        then((shas: string[]) => {
-          expect(shas).toEqual(['bar', 'baz', 'foo']);
-          expect(mockArray.sort).not.toHaveBeenCalled();
-        }).
-        then(done);
-    });
-
-
-    it('should only include directories', done => {
-      shellLsSpy.and.returnValue(Promise.resolve([
-        lsResult('foo', 100),
-        lsResult('bar', 200, false),
-        lsResult('baz', 300),
-      ]));
-
-      (bc as any).listShasByDate('input/dir').
-        then((shas: string[]) => expect(shas).toEqual(['foo', 'baz'])).
-        then(done);
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/build-events.spec.ts

@@ -1,58 +0,0 @@
-// Imports
-import {ChangedPrVisibilityEvent, CreatedBuildEvent} from '../../lib/upload-server/build-events';
-
-// Tests
-describe('ChangedPrVisibilityEvent', () => {
-  let evt: ChangedPrVisibilityEvent;
-
-  beforeEach(() => evt = new ChangedPrVisibilityEvent(42, ['foo', 'bar'], true));
-
-
-  it('should have a static \'type\' property', () => {
-    expect(ChangedPrVisibilityEvent.type).toBe('pr.changedVisibility');
-  });
-
-
-  it('should have a \'pr\' property', () => {
-    expect(evt.pr).toBe(42);
-  });
-
-
-  it('should have a \'shas\' property', () => {
-    expect(evt.shas).toEqual(['foo', 'bar']);
-  });
-
-
-  it('should have an \'isPublic\' property', () => {
-    expect(evt.isPublic).toBe(true);
-  });
-
-});
-
-
-describe('CreatedBuildEvent', () => {
-  let evt: CreatedBuildEvent;
-
-  beforeEach(() => evt = new CreatedBuildEvent(42, 'bar', true));
-
-
-  it('should have a static \'type\' property', () => {
-    expect(CreatedBuildEvent.type).toBe('build.created');
-  });
-
-
-  it('should have a \'pr\' property', () => {
-    expect(evt.pr).toBe(42);
-  });
-
-
-  it('should have a \'sha\' property', () => {
-    expect(evt.sha).toBe('bar');
-  });
-
-
-  it('should have an \'isPublic\' property', () => {
-    expect(evt.isPublic).toBe(true);
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/build-verifier.spec.ts

@@ -1,303 +0,0 @@
-// Imports
-import * as jwt from 'jsonwebtoken';
-import {GithubPullRequests, PullRequest} from '../../lib/common/github-pull-requests';
-import {GithubTeams} from '../../lib/common/github-teams';
-import {BUILD_VERIFICATION_STATUS, BuildVerifier} from '../../lib/upload-server/build-verifier';
-import {expectToBeUploadError} from './helpers';
-
-// Tests
-describe('BuildVerifier', () => {
-  const defaultConfig = {
-    allowedTeamSlugs: ['team1', 'team2'],
-    githubToken: 'githubToken',
-    organization: 'organization',
-    repoSlug: 'repo/slug',
-    secret: 'secret',
-    trustedPrLabel: 'trusted: pr-label',
-  };
-  let bv: BuildVerifier;
-
-  // Helpers
-  const createBuildVerifier = (partialConfig: Partial<typeof defaultConfig> = {}) => {
-    const cfg = {...defaultConfig, ...partialConfig} as typeof defaultConfig;
-    return new BuildVerifier(cfg.secret, cfg.githubToken, cfg.repoSlug, cfg.organization,
-                             cfg.allowedTeamSlugs, cfg.trustedPrLabel);
-  };
-
-  beforeEach(() => bv = createBuildVerifier());
-
-
-  describe('constructor()', () => {
-
-    ['secret', 'githubToken', 'repoSlug', 'organization', 'allowedTeamSlugs', 'trustedPrLabel'].
-      forEach(param => {
-        it(`should throw if '${param}' is missing or empty`, () => {
-          expect(() => createBuildVerifier({[param]: ''})).
-            toThrowError(`Missing or empty required parameter '${param}'!`);
-        });
-      });
-
-
-    it('should throw if \'allowedTeamSlugs\' is an empty array', () => {
-      expect(() => createBuildVerifier({allowedTeamSlugs: []})).
-        toThrowError('Missing or empty required parameter \'allowedTeamSlugs\'!');
-    });
-
-  });
-
-
-  describe('getPrIsTrusted()', () => {
-    const pr = 9;
-    let mockPrInfo: PullRequest;
-    let prsFetchSpy: jasmine.Spy;
-    let teamsIsMemberBySlugSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      mockPrInfo = {
-        labels: [
-          {name: 'foo'},
-          {name: 'bar'},
-        ],
-        number: 9,
-        user: {login: 'username'},
-      };
-
-      prsFetchSpy = spyOn(GithubPullRequests.prototype, 'fetch').
-        and.returnValue(Promise.resolve(mockPrInfo));
-
-      teamsIsMemberBySlugSpy = spyOn(GithubTeams.prototype, 'isMemberBySlug').
-        and.returnValue(Promise.resolve(true));
-    });
-
-
-    it('should return a promise', done => {
-      const promise = bv.getPrIsTrusted(pr);
-      promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                            // to avoid running the actual `GithubTeams#isMemberBySlug()`.
-
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should fetch the corresponding PR', done => {
-      bv.getPrIsTrusted(pr).then(() => {
-        expect(prsFetchSpy).toHaveBeenCalledWith(pr);
-        done();
-      });
-    });
-
-
-    it('should fail if fetching the PR errors', done => {
-      prsFetchSpy.and.callFake(() => Promise.reject('Test'));
-      bv.getPrIsTrusted(pr).catch(err => {
-        expect(err).toBe('Test');
-        done();
-      });
-    });
-
-
-    describe('when the PR has the "trusted PR" label', () => {
-
-      beforeEach(() => mockPrInfo.labels.push({name: 'trusted: pr-label'}));
-
-
-      it('should resolve to true', done => {
-        bv.getPrIsTrusted(pr).then(isTrusted => {
-          expect(isTrusted).toBe(true);
-          done();
-        });
-      });
-
-
-      it('should not try to verify the author\'s membership status', done => {
-        bv.getPrIsTrusted(pr).then(() => {
-          expect(teamsIsMemberBySlugSpy).not.toHaveBeenCalled();
-          done();
-        });
-      });
-
-    });
-
-
-    describe('when the PR does not have the "trusted PR" label', () => {
-
-      it('should verify the PR author\'s membership in the specified teams', done => {
-        bv.getPrIsTrusted(pr).then(() => {
-          expect(teamsIsMemberBySlugSpy).toHaveBeenCalledWith('username', ['team1', 'team2']);
-          done();
-        });
-      });
-
-
-      it('should fail if verifying membership errors', done => {
-        teamsIsMemberBySlugSpy.and.callFake(() => Promise.reject('Test'));
-        bv.getPrIsTrusted(pr).catch(err => {
-          expect(err).toBe('Test');
-          done();
-        });
-      });
-
-
-      it('should resolve to true if the PR\'s author is a member', done => {
-        teamsIsMemberBySlugSpy.and.returnValue(Promise.resolve(true));
-
-        bv.getPrIsTrusted(pr).then(isTrusted => {
-          expect(isTrusted).toBe(true);
-          done();
-        });
-      });
-
-
-      it('should resolve to false if the PR\'s author is not a member', done => {
-        teamsIsMemberBySlugSpy.and.returnValue(Promise.resolve(false));
-
-        bv.getPrIsTrusted(pr).then(isTrusted => {
-          expect(isTrusted).toBe(false);
-          done();
-        });
-      });
-
-    });
-
-  });
-
-
-  describe('verify()', () => {
-    const pr = 9;
-    const defaultJwt = {
-      'exp': Math.floor(Date.now() / 1000) + 30,
-      'iat': Math.floor(Date.now() / 1000) - 30,
-      'iss': 'Travis CI, GmbH',
-      'pull-request': pr,
-      'slug': defaultConfig.repoSlug,
-    };
-    let bvGetPrIsTrusted: jasmine.Spy;
-
-    // Heleprs
-    const createAuthHeader = (partialJwt: Partial<typeof defaultJwt> = {}, secret: string = defaultConfig.secret) =>
-      `Token ${jwt.sign({...defaultJwt, ...partialJwt}, secret)}`;
-
-    beforeEach(() => {
-      bvGetPrIsTrusted = spyOn(bv, 'getPrIsTrusted').and.returnValue(Promise.resolve(true));
-    });
-
-
-    it('should return a promise', done => {
-      const promise = bv.verify(pr, createAuthHeader());
-      promise.then(done);   // Do not complete the test (and release the spies) synchronously
-                            // to avoid running the actual `bvGetPrIsTrusted()`.
-
-      expect(promise).toEqual(jasmine.any(Promise));
-    });
-
-
-    it('should fail if the authorization header is invalid', done => {
-      bv.verify(pr, 'foo').catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: jwt malformed';
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should fail if the secret is invalid', done => {
-      bv.verify(pr, createAuthHeader({}, 'foo')).catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: invalid signature';
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should fail if the issuer is invalid', done => {
-      bv.verify(pr, createAuthHeader({iss: 'not valid'})).catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: ' +
-                             `jwt issuer invalid. expected: ${defaultJwt.iss}`;
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should fail if the token has expired', done => {
-      bv.verify(pr, createAuthHeader({exp: 0})).catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: jwt expired';
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should fail if the repo slug does not match', done => {
-      bv.verify(pr, createAuthHeader({slug: 'foo/bar'})).catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: ' +
-                             `jwt slug invalid. expected: ${defaultConfig.repoSlug}`;
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should fail if the PR does not match', done => {
-      bv.verify(pr, createAuthHeader({'pull-request': 1337})).catch(err => {
-        const errorMessage = 'Error while verifying upload for PR 9: ' +
-                             `jwt pull-request invalid. expected: ${pr}`;
-
-        expectToBeUploadError(err, 403, errorMessage);
-        done();
-      });
-    });
-
-
-    it('should not fail if the token is valid', done => {
-      bv.verify(pr, createAuthHeader()).then(done);
-    });
-
-
-    it('should not fail even if the token has been issued in the future', done => {
-      const in30s = Math.floor(Date.now() / 1000) + 30;
-      bv.verify(pr, createAuthHeader({iat: in30s})).then(done);
-    });
-
-
-    it('should call \'getPrIsTrusted()\' if the token is valid', done => {
-      bv.verify(pr, createAuthHeader()).then(() => {
-        expect(bvGetPrIsTrusted).toHaveBeenCalledWith(pr);
-        done();
-      });
-    });
-
-
-    it('should fail if \'getPrIsTrusted()\' rejects', done => {
-      bvGetPrIsTrusted.and.callFake(() => Promise.reject('Test'));
-      bv.verify(pr, createAuthHeader()).catch(err => {
-        expectToBeUploadError(err, 403, `Error while verifying upload for PR ${pr}: Test`);
-        done();
-      });
-    });
-
-
-    it('should resolve to `verifiedNotTrusted` if \'getPrIsTrusted()\' returns false', done => {
-      bvGetPrIsTrusted.and.returnValue(Promise.resolve(false));
-      bv.verify(pr, createAuthHeader()).then(value => {
-        expect(value).toBe(BUILD_VERIFICATION_STATUS.verifiedNotTrusted);
-        done();
-      });
-    });
-
-
-    it('should resolve to `verifiedAndTrusted` if \'getPrIsTrusted()\' returns true', done => {
-      bv.verify(pr, createAuthHeader()).then(value => {
-        expect(value).toBe(BUILD_VERIFICATION_STATUS.verifiedAndTrusted);
-        done();
-      });
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/helpers.ts

@@ -1,11 +0,0 @@
-import {UploadError} from '../../lib/upload-server/upload-error';
-
-export const expectToBeUploadError = (actual: UploadError, status?: number, message?: string) => {
-  expect(actual).toEqual(jasmine.any(UploadError));
-  if (status != null) {
-    expect(actual.status).toBe(status);
-  }
-  if (message != null) {
-    expect(actual.message).toBe(message);
-  }
-};

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/upload-error.spec.ts

@@ -1,39 +0,0 @@
-// Imports
-import {UploadError} from '../../lib/upload-server/upload-error';
-
-// Tests
-describe('UploadError', () => {
-  let err: UploadError;
-
-  beforeEach(() => err = new UploadError(999, 'message'));
-
-
-  it('should extend Error', () => {
-    expect(err).toEqual(jasmine.any(UploadError));
-    expect(err).toEqual(jasmine.any(Error));
-
-    expect(Object.getPrototypeOf(err)).toBe(UploadError.prototype);
-  });
-
-
-  it('should have a \'status\' property', () => {
-    expect(err.status).toBe(999);
-  });
-
-
-  it('should have a \'message\' property', () => {
-    expect(err.message).toBe('message');
-  });
-
-
-  it('should have a 500 \'status\' by default', () => {
-    expect(new UploadError().status).toBe(500);
-  });
-
-
-  it('should have an empty \'message\' by default', () => {
-    expect(new UploadError().message).toBe('');
-    expect(new UploadError(999).message).toBe('');
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/test/upload-server/upload-server-factory.spec.ts

@@ -1,603 +0,0 @@
-// Imports
-import * as express from 'express';
-import * as http from 'http';
-import * as supertest from 'supertest';
-import {GithubPullRequests} from '../../lib/common/github-pull-requests';
-import {BuildCreator} from '../../lib/upload-server/build-creator';
-import {ChangedPrVisibilityEvent, CreatedBuildEvent} from '../../lib/upload-server/build-events';
-import {BUILD_VERIFICATION_STATUS, BuildVerifier} from '../../lib/upload-server/build-verifier';
-import {uploadServerFactory as usf} from '../../lib/upload-server/upload-server-factory';
-
-// Tests
-describe('uploadServerFactory', () => {
-  const defaultConfig = {
-    buildsDir: 'builds/dir',
-    domainName: 'domain.name',
-    githubOrganization: 'organization',
-    githubTeamSlugs: ['team1', 'team2'],
-    githubToken: '12345',
-    repoSlug: 'repo/slug',
-    secret: 'secret',
-    trustedPrLabel: 'trusted: pr-label',
-  };
-
-  // Helpers
-  const createUploadServer = (partialConfig: Partial<typeof defaultConfig> = {}) =>
-    usf.create({...defaultConfig, ...partialConfig} as typeof defaultConfig);
-
-
-  describe('create()', () => {
-    let usfCreateMiddlewareSpy: jasmine.Spy;
-
-    beforeEach(() => {
-      usfCreateMiddlewareSpy = spyOn(usf as any, 'createMiddleware').and.callThrough();
-    });
-
-
-    it('should throw if \'buildsDir\' is missing or empty', () => {
-      expect(() => createUploadServer({buildsDir: ''})).
-        toThrowError('Missing or empty required parameter \'buildsDir\'!');
-    });
-
-
-    it('should throw if \'domainName\' is missing or empty', () => {
-      expect(() => createUploadServer({domainName: ''})).
-        toThrowError('Missing or empty required parameter \'domainName\'!');
-    });
-
-
-    it('should throw if \'githubToken\' is missing or empty', () => {
-      expect(() => createUploadServer({githubToken: ''})).
-        toThrowError('Missing or empty required parameter \'githubToken\'!');
-    });
-
-
-    it('should throw if \'githubOrganization\' is missing or empty', () => {
-      expect(() => createUploadServer({githubOrganization: ''})).
-        toThrowError('Missing or empty required parameter \'organization\'!');
-    });
-
-
-    it('should throw if \'githubTeamSlugs\' is missing or empty', () => {
-      expect(() => createUploadServer({githubTeamSlugs: []})).
-        toThrowError('Missing or empty required parameter \'allowedTeamSlugs\'!');
-    });
-
-
-    it('should throw if \'repoSlug\' is missing or empty', () => {
-      expect(() => createUploadServer({repoSlug: ''})).
-        toThrowError('Missing or empty required parameter \'repoSlug\'!');
-    });
-
-
-    it('should throw if \'secret\' is missing or empty', () => {
-      expect(() => createUploadServer({secret: ''})).
-        toThrowError('Missing or empty required parameter \'secret\'!');
-    });
-
-
-    it('should throw if \'trustedPrLabel\' is missing or empty', () => {
-      expect(() => createUploadServer({trustedPrLabel: ''})).
-        toThrowError('Missing or empty required parameter \'trustedPrLabel\'!');
-    });
-
-
-    it('should return an http.Server', () => {
-      const httpCreateServerSpy = spyOn(http, 'createServer').and.callThrough();
-      const server = createUploadServer();
-
-      expect(server).toBe(httpCreateServerSpy.calls.mostRecent().returnValue);
-    });
-
-
-    it('should create and use an appropriate BuildCreator', () => {
-      const usfCreateBuildCreatorSpy = spyOn(usf as any, 'createBuildCreator').and.callThrough();
-
-      createUploadServer();
-      const buildCreator: BuildCreator = usfCreateBuildCreatorSpy.calls.mostRecent().returnValue;
-
-      expect(usfCreateMiddlewareSpy).toHaveBeenCalledWith(jasmine.any(BuildVerifier), buildCreator);
-      expect(usfCreateBuildCreatorSpy).toHaveBeenCalledWith('builds/dir', '12345', 'repo/slug', 'domain.name');
-    });
-
-
-    it('should create and use an appropriate middleware', () => {
-      const httpCreateServerSpy = spyOn(http, 'createServer').and.callThrough();
-
-      createUploadServer();
-      const middleware: express.Express = usfCreateMiddlewareSpy.calls.mostRecent().returnValue;
-      const buildVerifier = jasmine.any(BuildVerifier);
-      const buildCreator = jasmine.any(BuildCreator);
-
-      expect(httpCreateServerSpy).toHaveBeenCalledWith(middleware);
-      expect(usfCreateMiddlewareSpy).toHaveBeenCalledWith(buildVerifier, buildCreator);
-    });
-
-
-    it('should log the server address info on \'listening\'', () => {
-      const consoleInfoSpy = spyOn(console, 'info');
-      const server = createUploadServer();
-      server.address = () => ({address: 'foo', family: '', port: 1337});
-
-      expect(consoleInfoSpy).not.toHaveBeenCalled();
-
-      server.emit('listening');
-      expect(consoleInfoSpy).toHaveBeenCalledWith('Up and running (and listening on foo:1337)...');
-    });
-
-  });
-
-
-  // Protected methods
-
-  describe('createBuildCreator()', () => {
-    let buildCreator: BuildCreator;
-
-    beforeEach(() => {
-      buildCreator = (usf as any).createBuildCreator(
-        defaultConfig.buildsDir,
-        defaultConfig.githubToken,
-        defaultConfig.repoSlug,
-        defaultConfig.domainName,
-      );
-    });
-
-
-    it('should pass the \'buildsDir\' to the BuildCreator', () => {
-      expect((buildCreator as any).buildsDir).toBe('builds/dir');
-    });
-
-
-    describe('on \'build.created\'', () => {
-      let prsAddCommentSpy: jasmine.Spy;
-
-      beforeEach(() => prsAddCommentSpy = spyOn(GithubPullRequests.prototype, 'addComment'));
-
-
-      it('should post a comment on GitHub for public previews', () => {
-        const commentBody = 'You can preview 1234567890 at https://pr42-1234567890.domain.name/.';
-
-        buildCreator.emit(CreatedBuildEvent.type, {pr: 42, sha: '1234567890', isPublic: true});
-        expect(prsAddCommentSpy).toHaveBeenCalledWith(42, commentBody);
-      });
-
-
-      it('should not post a comment on GitHub for non-public previews', () => {
-        buildCreator.emit(CreatedBuildEvent.type, {pr: 42, sha: '1234567890', isPublic: false});
-        expect(prsAddCommentSpy).not.toHaveBeenCalled();
-      });
-
-    });
-
-
-    describe('on \'pr.changedVisibility\'', () => {
-      let prsAddCommentSpy: jasmine.Spy;
-
-      beforeEach(() => prsAddCommentSpy = spyOn(GithubPullRequests.prototype, 'addComment'));
-
-
-      it('should post a comment on GitHub (for all SHAs) for PRs made public', () => {
-        const commentBody = 'You can preview 12345 at https://pr42-12345.domain.name/.\n' +
-                            'You can preview 67890 at https://pr42-67890.domain.name/.';
-
-        buildCreator.emit(ChangedPrVisibilityEvent.type, {pr: 42, shas: ['12345', '67890'], isPublic: true});
-        expect(prsAddCommentSpy).toHaveBeenCalledWith(42, commentBody);
-      });
-
-
-      it('should not post a comment on GitHub if no SHAs were affected', () => {
-        buildCreator.emit(ChangedPrVisibilityEvent.type, {pr: 42, shas: [], isPublic: true});
-        expect(prsAddCommentSpy).not.toHaveBeenCalled();
-      });
-
-
-      it('should not post a comment on GitHub for PRs made non-public', () => {
-        buildCreator.emit(ChangedPrVisibilityEvent.type, {pr: 42, shas: ['12345', '67890'], isPublic: false});
-        expect(prsAddCommentSpy).not.toHaveBeenCalled();
-      });
-
-    });
-
-
-    it('should pass the correct \'githubToken\' and \'repoSlug\' to GithubPullRequests', () => {
-      const prsAddCommentSpy = spyOn(GithubPullRequests.prototype, 'addComment');
-
-      buildCreator.emit(CreatedBuildEvent.type, {pr: 42, sha: '1234567890', isPublic: true});
-      buildCreator.emit(ChangedPrVisibilityEvent.type, {pr: 42, shas: ['12345', '67890'], isPublic: true});
-
-      const allCalls = prsAddCommentSpy.calls.all();
-      const prs = allCalls[0].object;
-
-      expect(prsAddCommentSpy).toHaveBeenCalledTimes(2);
-      expect(prs).toBe(allCalls[1].object);
-      expect(prs).toEqual(jasmine.any(GithubPullRequests));
-      expect(prs.repoSlug).toBe('repo/slug');
-      expect(prs.requestHeaders.Authorization).toContain('12345');
-    });
-
-  });
-
-
-  describe('createMiddleware()', () => {
-    let buildVerifier: BuildVerifier;
-    let buildCreator: BuildCreator;
-    let agent: supertest.SuperTest<supertest.Test>;
-
-    // Helpers
-    const promisifyRequest = (req: supertest.Request) =>
-      new Promise((resolve, reject) => req.end(err => err ? reject(err) : resolve()));
-    const verifyRequests = (reqs: supertest.Request[], done: jasmine.DoneFn) =>
-      Promise.all(reqs.map(promisifyRequest)).then(done, done.fail);
-
-    beforeEach(() => {
-      buildVerifier = new BuildVerifier(
-        defaultConfig.secret,
-        defaultConfig.githubToken,
-        defaultConfig.repoSlug,
-        defaultConfig.githubOrganization,
-        defaultConfig.githubTeamSlugs,
-        defaultConfig.trustedPrLabel,
-      );
-      buildCreator = new BuildCreator(defaultConfig.buildsDir);
-      agent = supertest.agent((usf as any).createMiddleware(buildVerifier, buildCreator));
-
-      spyOn(console, 'error');
-    });
-
-
-    describe('GET /create-build/<pr>/<sha>', () => {
-      const pr = '9';
-      const sha = '9'.repeat(40);
-      let buildVerifierVerifySpy: jasmine.Spy;
-      let buildCreatorCreateSpy: jasmine.Spy;
-
-      beforeEach(() => {
-        const verStatus = BUILD_VERIFICATION_STATUS.verifiedAndTrusted;
-        buildVerifierVerifySpy = spyOn(buildVerifier, 'verify').and.returnValue(Promise.resolve(verStatus));
-        buildCreatorCreateSpy = spyOn(buildCreator, 'create').and.returnValue(Promise.resolve());
-      });
-
-
-      it('should respond with 404 for non-GET requests', done => {
-        verifyRequests([
-          agent.put(`/create-build/${pr}/${sha}`).expect(404),
-          agent.post(`/create-build/${pr}/${sha}`).expect(404),
-          agent.patch(`/create-build/${pr}/${sha}`).expect(404),
-          agent.delete(`/create-build/${pr}/${sha}`).expect(404),
-        ], done);
-      });
-
-
-      it('should respond with 401 for requests without an \'AUTHORIZATION\' header', done => {
-        const url = `/create-build/${pr}/${sha}`;
-        const responseBody = `Missing or empty 'AUTHORIZATION' header in request: GET ${url}`;
-
-        verifyRequests([
-          agent.get(url).expect(401, responseBody),
-          agent.get(url).set('AUTHORIZATION', '').expect(401, responseBody),
-        ], done);
-      });
-
-
-      it('should respond with 400 for requests without an \'X-FILE\' header', done => {
-        const url = `/create-build/${pr}/${sha}`;
-        const responseBody = `Missing or empty 'X-FILE' header in request: GET ${url}`;
-
-        const request1 = agent.get(url).set('AUTHORIZATION', 'foo');
-        const request2 = agent.get(url).set('AUTHORIZATION', 'foo').set('X-FILE', '');
-
-        verifyRequests([
-          request1.expect(400, responseBody),
-          request2.expect(400, responseBody),
-        ], done);
-      });
-
-
-      it('should respond with 404 for unknown paths', done => {
-        verifyRequests([
-          agent.get(`/foo/create-build/${pr}/${sha}`).expect(404),
-          agent.get(`/foo-create-build/${pr}/${sha}`).expect(404),
-          agent.get(`/fooncreate-build/${pr}/${sha}`).expect(404),
-          agent.get(`/create-build/foo/${pr}/${sha}`).expect(404),
-          agent.get(`/create-build-foo/${pr}/${sha}`).expect(404),
-          agent.get(`/create-buildnfoo/${pr}/${sha}`).expect(404),
-          agent.get(`/create-build/pr${pr}/${sha}`).expect(404),
-          agent.get(`/create-build/${pr}/${sha}42`).expect(404),
-        ], done);
-      });
-
-
-      it('should call \'BuildVerifier#verify()\' with the correct arguments', done => {
-        const req = agent.
-          get(`/create-build/${pr}/${sha}`).
-          set('AUTHORIZATION', 'foo').
-          set('X-FILE', 'bar');
-
-        promisifyRequest(req).
-          then(() => expect(buildVerifierVerifySpy).toHaveBeenCalledWith(9, 'foo')).
-          then(done, done.fail);
-      });
-
-
-      it('should propagate errors from BuildVerifier', done => {
-        buildVerifierVerifySpy.and.callFake(() => Promise.reject('Test'));
-
-        const req = agent.
-          get(`/create-build/${pr}/${sha}`).
-          set('AUTHORIZATION', 'foo').
-          set('X-FILE', 'bar').
-          expect(500, 'Test');
-
-        promisifyRequest(req).
-          then(() => {
-            expect(buildVerifierVerifySpy).toHaveBeenCalledWith(9, 'foo');
-            expect(buildCreatorCreateSpy).not.toHaveBeenCalled();
-          }).
-          then(done, done.fail);
-      });
-
-
-      it('should call \'BuildCreator#create()\' with the correct arguments', done => {
-        buildVerifierVerifySpy.and.returnValues(
-            Promise.resolve(BUILD_VERIFICATION_STATUS.verifiedAndTrusted),
-            Promise.resolve(BUILD_VERIFICATION_STATUS.verifiedNotTrusted));
-
-        const req1 = agent.get(`/create-build/${pr}/${sha}`).set('AUTHORIZATION', 'foo').set('X-FILE', 'bar');
-        const req2 = agent.get(`/create-build/${pr}/${sha}`).set('AUTHORIZATION', 'foo').set('X-FILE', 'bar');
-
-        Promise.all([
-          promisifyRequest(req1).then(() => expect(buildCreatorCreateSpy).toHaveBeenCalledWith(pr, sha, 'bar', true)),
-          promisifyRequest(req2).then(() => expect(buildCreatorCreateSpy).toHaveBeenCalledWith(pr, sha, 'bar', false)),
-        ]).then(done, done.fail);
-      });
-
-
-      it('should propagate errors from BuildCreator', done => {
-        buildCreatorCreateSpy.and.callFake(() => Promise.reject('Test'));
-        const req = agent.
-          get(`/create-build/${pr}/${sha}`).
-          set('AUTHORIZATION', 'foo').
-          set('X-FILE', 'bar').
-          expect(500, 'Test');
-
-        verifyRequests([req], done);
-      });
-
-
-      it('should respond with 201 on successful upload (for public builds)', done => {
-        const req = agent.
-          get(`/create-build/${pr}/${sha}`).
-          set('AUTHORIZATION', 'foo').
-          set('X-FILE', 'bar').
-          expect(201, http.STATUS_CODES[201]);
-
-        verifyRequests([req], done);
-      });
-
-
-      it('should respond with 202 on successful upload (for hidden builds)', done => {
-        buildVerifierVerifySpy.and.returnValue(Promise.resolve(BUILD_VERIFICATION_STATUS.verifiedNotTrusted));
-        const req = agent.
-          get(`/create-build/${pr}/${sha}`).
-          set('AUTHORIZATION', 'foo').
-          set('X-FILE', 'bar').
-          expect(202, http.STATUS_CODES[202]);
-
-        verifyRequests([req], done);
-      });
-
-
-      it('should reject PRs with leading zeros', done => {
-        verifyRequests([agent.get(`/create-build/0${pr}/${sha}`).expect(404)], done);
-      });
-
-
-      it('should accept SHAs with leading zeros (but not trim the zeros)', done => {
-        const sha40 = '0'.repeat(40);
-        const sha41 = `0${sha40}`;
-
-        const request40 = agent.get(`/create-build/${pr}/${sha40}`).set('AUTHORIZATION', 'foo').set('X-FILE', 'bar');
-        const request41 = agent.get(`/create-build/${pr}/${sha41}`).set('AUTHORIZATION', 'baz').set('X-FILE', 'qux');
-
-        Promise.all([
-          promisifyRequest(request40.expect(201)),
-          promisifyRequest(request41.expect(404)),
-        ]).then(done, done.fail);
-      });
-
-    });
-
-
-    describe('GET /health-check', () => {
-
-      it('should respond with 200', done => {
-        verifyRequests([
-          agent.get('/health-check').expect(200),
-          agent.get('/health-check/').expect(200),
-         ], done);
-      });
-
-
-      it('should respond with 404 for non-GET requests', done => {
-        verifyRequests([
-          agent.put('/health-check').expect(404),
-          agent.post('/health-check').expect(404),
-          agent.patch('/health-check').expect(404),
-          agent.delete('/health-check').expect(404),
-        ], done);
-      });
-
-
-      it('should respond with 404 if the path does not match exactly', done => {
-        verifyRequests([
-          agent.get('/health-check/foo').expect(404),
-          agent.get('/health-check-foo').expect(404),
-          agent.get('/health-checknfoo').expect(404),
-          agent.get('/foo/health-check').expect(404),
-          agent.get('/foo-health-check').expect(404),
-          agent.get('/foonhealth-check').expect(404),
-        ], done);
-      });
-
-    });
-
-
-    describe('POST /pr-updated', () => {
-      const pr = '9';
-      const url = '/pr-updated';
-      let bvGetPrIsTrustedSpy: jasmine.Spy;
-      let bcUpdatePrVisibilitySpy: jasmine.Spy;
-
-      // Helpers
-      const createRequest = (num: number, action?: string) =>
-        agent.post(url).send({number: num, action});
-
-      beforeEach(() => {
-        bvGetPrIsTrustedSpy = spyOn(buildVerifier, 'getPrIsTrusted');
-        bcUpdatePrVisibilitySpy = spyOn(buildCreator, 'updatePrVisibility');
-      });
-
-
-      it('should respond with 404 for non-POST requests', done => {
-        verifyRequests([
-          agent.get(url).expect(404),
-          agent.put(url).expect(404),
-          agent.patch(url).expect(404),
-          agent.delete(url).expect(404),
-        ], done);
-      });
-
-
-      it('should respond with 400 for requests without a payload', done => {
-        const responseBody = `Missing or empty 'number' field in request: POST ${url} {}`;
-
-        const request1 = agent.post(url);
-        const request2 = agent.post(url).send();
-
-        verifyRequests([
-          request1.expect(400, responseBody),
-          request2.expect(400, responseBody),
-        ], done);
-      });
-
-
-      it('should respond with 400 for requests without a \'number\' field', done => {
-        const responseBodyPrefix = `Missing or empty 'number' field in request: POST ${url}`;
-
-        const request1 = agent.post(url).send({});
-        const request2 = agent.post(url).send({number: null});
-
-        verifyRequests([
-          request1.expect(400, `${responseBodyPrefix} {}`),
-          request2.expect(400, `${responseBodyPrefix} {"number":null}`),
-        ], done);
-      });
-
-
-      it('should call \'BuildVerifier#gtPrIsTrusted()\' with the correct arguments', done => {
-        const req = createRequest(+pr);
-
-        promisifyRequest(req).
-          then(() => expect(bvGetPrIsTrustedSpy).toHaveBeenCalledWith(9)).
-          then(done, done.fail);
-      });
-
-
-      it('should propagate errors from BuildVerifier', done => {
-        bvGetPrIsTrustedSpy.and.callFake(() => Promise.reject('Test'));
-
-        const req = createRequest(+pr).expect(500, 'Test');
-
-        promisifyRequest(req).
-          then(() => {
-            expect(bvGetPrIsTrustedSpy).toHaveBeenCalledWith(9);
-            expect(bcUpdatePrVisibilitySpy).not.toHaveBeenCalled();
-          }).
-          then(done, done.fail);
-      });
-
-
-      it('should call \'BuildCreator#updatePrVisibility()\' with the correct arguments', done => {
-        bvGetPrIsTrustedSpy.and.callFake((pr2: number) => Promise.resolve(pr2 === 42));
-
-        const req1 = createRequest(24);
-        const req2 = createRequest(42);
-
-        Promise.all([
-          promisifyRequest(req1).then(() => expect(bcUpdatePrVisibilitySpy).toHaveBeenCalledWith('24', false)),
-          promisifyRequest(req2).then(() => expect(bcUpdatePrVisibilitySpy).toHaveBeenCalledWith('42', true)),
-        ]).then(done, done.fail);
-      });
-
-
-      it('should propagate errors from BuildCreator', done => {
-        bcUpdatePrVisibilitySpy.and.callFake(() => Promise.reject('Test'));
-
-        const req = createRequest(+pr).expect(500, 'Test');
-        verifyRequests([req], done);
-      });
-
-
-      describe('on success', () => {
-
-        it('should respond with 200 (action: undefined)', done => {
-          bvGetPrIsTrustedSpy.and.returnValues(Promise.resolve(true), Promise.resolve(false));
-
-          const reqs = [4, 2].map(num => createRequest(num).expect(200, http.STATUS_CODES[200]));
-          verifyRequests(reqs, done);
-        });
-
-
-        it('should respond with 200 (action: labeled)', done => {
-          bvGetPrIsTrustedSpy.and.returnValues(Promise.resolve(true), Promise.resolve(false));
-
-          const reqs = [4, 2].map(num => createRequest(num, 'labeled').expect(200, http.STATUS_CODES[200]));
-          verifyRequests(reqs, done);
-        });
-
-
-        it('should respond with 200 (action: unlabeled)', done => {
-          bvGetPrIsTrustedSpy.and.returnValues(Promise.resolve(true), Promise.resolve(false));
-
-          const reqs = [4, 2].map(num => createRequest(num, 'unlabeled').expect(200, http.STATUS_CODES[200]));
-          verifyRequests(reqs, done);
-        });
-
-
-        it('should respond with 200 (and do nothing) if \'action\' implies no visibility change', done => {
-          const promises = ['foo', 'notlabeled'].
-            map(action => createRequest(+pr, action).expect(200, http.STATUS_CODES[200])).
-            map(promisifyRequest);
-
-          Promise.all(promises).
-            then(() => {
-              expect(bvGetPrIsTrustedSpy).not.toHaveBeenCalled();
-              expect(bcUpdatePrVisibilitySpy).not.toHaveBeenCalled();
-            }).
-            then(done, done.fail);
-        });
-
-      });
-
-    });
-
-
-    describe('ALL *', () => {
-
-      it('should respond with 404', done => {
-        const responseFor = (method: string) => `Unknown resource in request: ${method.toUpperCase()} /some/url`;
-
-        verifyRequests([
-          agent.get('/some/url').expect(404, responseFor('get')),
-          agent.put('/some/url').expect(404, responseFor('put')),
-          agent.post('/some/url').expect(404, responseFor('post')),
-          agent.patch('/some/url').expect(404, responseFor('patch')),
-          agent.delete('/some/url').expect(404, responseFor('delete')),
-        ], done);
-      });
-
-    });
-
-  });
-
-});

aio/aio-builds-setup/dockerbuild/scripts-js/tsconfig.json

@@ -1,69 +0,0 @@
-{
-  "compilerOptions": {
-    /* Basic Options */
-    "target": "es5",                             /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
-    "module": "commonjs",                        /* Specify module code generation: 'none', commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
-    "lib": [
-      "es2015",
-      "es2016.array.include"
-    ],                                        /* Specify library files to be included in the compilation:  */
-    // "allowJs": true,                          /* Allow javascript files to be compiled. */
-    // "checkJs": true,                          /* Report errors in .js files. */
-    // "jsx": "preserve",                        /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
-    // "declaration": true,                      /* Generates corresponding '.d.ts' file. */
-    // "sourceMap": true,                        /* Generates corresponding '.map' file. */
-    // "outFile": "./",                          /* Concatenate and emit output to single file. */
-    "outDir": "dist",                         /* Redirect output structure to the directory. */
-    // "rootDir": "./",                          /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
-    // "removeComments": true,                   /* Do not emit comments to output. */
-    // "noEmit": true,                           /* Do not emit outputs. */
-    "importHelpers": true,                    /* Import emit helpers from 'tslib'. */
-    // "downlevelIteration": true,               /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
-    // "isolatedModules": true,                  /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
-
-    /* Strict Type-Checking Options */
-    "strict": true,                              /* Enable all strict type-checking options. */
-    // "noImplicitAny": true,                    /* Raise error on expressions and declarations with an implied 'any' type. */
-    // "strictNullChecks": true,                 /* Enable strict null checks. */
-    // "noImplicitThis": true,                   /* Raise error on 'this' expressions with an implied 'any' type. */
-    // "alwaysStrict": true,                     /* Parse in strict mode and emit "use strict" for each source file. */
-
-    /* Additional Checks */
-    "noUnusedLocals": true,                   /* Report errors on unused locals. */
-    "noUnusedParameters": true,               /* Report errors on unused parameters. */
-    "noImplicitReturns": true,                /* Report error when not all code paths in function return a value. */
-    // "noFallthroughCasesInSwitch": true,       /* Report errors for fallthrough cases in switch statement. */
-
-    /* Module Resolution Options */
-    // "moduleResolution": "node",               /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
-    // "baseUrl": "./",                          /* Base directory to resolve non-absolute module names. */
-    // "paths": {},                              /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
-    // "rootDirs": [],                           /* List of root folders whose combined content represents the structure of the project at runtime. */
-    "typeRoots": [
-      "node_modules/@types"
-    ],                                        /* List of folders to include type definitions from. */
-    // "types": [],                              /* Type declaration files to be included in compilation. */
-    // "allowSyntheticDefaultImports": true,     /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
-    // "preserveSymlinks": true,                 /* Do not resolve the real path of symlinks. */
-
-    /* Source Map Options */
-    // "sourceRoot": "./",                       /* Specify the location where debugger should locate TypeScript files instead of source locations. */
-    // "mapRoot": "./",                          /* Specify the location where debugger should locate map files instead of generated locations. */
-    "inlineSourceMap": true,                  /* Emit a single file with source maps instead of having a separate file. */
-    // "inlineSources": true,                    /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
-
-    /* Experimental Options */
-    // "experimentalDecorators": true,           /* Enables experimental support for ES7 decorators. */
-    // "emitDecoratorMetadata": true,            /* Enables experimental support for emitting type metadata for decorators. */
-
-    /* Other */
-    "forceConsistentCasingInFileNames": true, /* Disallow inconsistently-cased references to the same file. */
-    "newLine": "LF",                          /* Use the specified end of line sequence to be used when emitting files: "crlf" (windows) or "lf" (unix). */
-    "pretty": true,                           /* Stylize errors and messages using color and context. */
-    "skipLibCheck": true                      /* Skip type checking of all declaration files (*.d.ts). */
-  },
-  "include": [
-    "lib/**/*",
-    "test/**/*"
-  ]
-}

aio/aio-builds-setup/dockerbuild/scripts-js/tslint.json

@@ -1,24 +0,0 @@
-{
-  "defaultSeverity": "error",
-  "extends": [
-    "tslint:recommended"
-  ],
-  "jsRules": {},
-  "rules": {
-    "array-type": [true, "array"],
-    "arrow-parens": [true, "ban-single-arg-parens"],
-    "interface-name": [true, "never-prefix"],
-    "max-classes-per-file": [true, 4],
-    "no-consecutive-blank-lines": [true, 2],
-    "no-console": [false],
-    "no-focused-test": true,
-    "no-namespace": [true, "allow-declarations"],
-    "no-skipped-test": true,
-    "no-string-literal": false,
-    "quotemark": [true, "single"],
-    "variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore"]
-  },
-  "rulesDirectory": [
-    "node_modules/tslint-jasmine-noSkipOrFocus"
-  ]
-}

aio/aio-builds-setup/dockerbuild/scripts-sh/clean-up.sh

@@ -1,8 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-# Set up env variables
-export AIO_GITHUB_TOKEN=$(head -c -1 /aio-secrets/GITHUB_TOKEN 2>/dev/null)
-
-# Run the clean-up
-node $AIO_SCRIPTS_JS_DIR/dist/lib/clean-up >> /var/log/aio/clean-up.log 2>&1

aio/aio-builds-setup/dockerbuild/scripts-sh/health-check.sh

@@ -1,54 +0,0 @@
-#!/bin/bash
-# Using `+e` so that all checks are run and we get a complete report (even if some checks failed).
-set +e -u -o pipefail
-
-
-# Variables
-exitCode=0
-
-
-# Helpers
-function reportStatus {
-  local lastExitCode=$?
-  echo "$1: $([[ $lastExitCode -eq 0 ]] && echo OK || echo NOT OK)"
-  [[ $lastExitCode -eq 0 ]] || exitCode=1
-}
-
-
-# Check services
-services=(
-  rsyslog
-  cron
-  nginx
-  pm2-root
-)
-for s in ${services[@]}; do
-  service $s status > /dev/null
-  reportStatus "Service '$s'"
-done
-
-
-# Check servers
-origins=(
-  http://$AIO_UPLOAD_HOSTNAME:$AIO_UPLOAD_PORT
-  http://$AIO_NGINX_HOSTNAME:$AIO_NGINX_PORT_HTTP
-  https://$AIO_NGINX_HOSTNAME:$AIO_NGINX_PORT_HTTPS
-)
-for o in ${origins[@]}; do
-  curl --fail --silent $o/health-check > /dev/null
-  reportStatus "Server '$o'"
-done
-
-
-# Check resolution of external URLs
-origins=(
-  https://google.com
-)
-for o in ${origins[@]}; do
-  curl --fail --silent $o > /dev/null
-  reportStatus "External URL '$o'"
-done
-
-
-# Exit
-exit $exitCode

aio/aio-builds-setup/dockerbuild/scripts-sh/init.sh

@@ -1,18 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-exec >> /var/log/aio/init.log
-exec 2>&1
-
-# Start the services
-echo [`date`] - Starting services...
-mkdir -p $AIO_NGINX_LOGS_DIR
-mkdir -p $TEST_AIO_NGINX_LOGS_DIR
-
-service rsyslog start
-service cron start
-service dnsmasq start
-service nginx start
-service pm2-root start
-aio-upload-server-prod start
-echo [`date`] - Services started successfully.

aio/aio-builds-setup/dockerbuild/scripts-sh/upload-server-prod.sh

@@ -1,14 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-# Set up env variables for production
-export AIO_GITHUB_TOKEN=$(head -c -1 /aio-secrets/GITHUB_TOKEN 2>/dev/null || echo "MISSING_GITHUB_TOKEN")
-export AIO_PREVIEW_DEPLOYMENT_TOKEN=$(head -c -1 /aio-secrets/PREVIEW_DEPLOYMENT_TOKEN 2>/dev/null || echo "MISSING_PREVIEW_DEPLOYMENT_TOKEN")
-
-# Start the upload-server instance
-action=$([ "$1" == "stop" ] && echo "stop" || echo "start")
-pm2 $action $AIO_SCRIPTS_JS_DIR/dist/lib/upload-server \
-  --uid $AIO_WWW_USER \
-  --log /var/log/aio/upload-server-prod.log \
-  --name aio-upload-server-prod \
-  ${@:2}

aio/aio-builds-setup/dockerbuild/scripts-sh/upload-server-test.sh

@@ -1,28 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-# Set up env variables for testing
-export AIO_BUILDS_DIR=$TEST_AIO_BUILDS_DIR
-export AIO_DOMAIN_NAME=$TEST_AIO_DOMAIN_NAME
-export AIO_GITHUB_ORGANIZATION=$TEST_AIO_GITHUB_ORGANIZATION
-export AIO_GITHUB_TEAM_SLUGS=$TEST_AIO_GITHUB_TEAM_SLUGS
-export AIO_REPO_SLUG=$TEST_AIO_REPO_SLUG
-export AIO_TRUSTED_PR_LABEL=$TEST_AIO_TRUSTED_PR_LABEL
-export AIO_UPLOAD_HOSTNAME=$TEST_AIO_UPLOAD_HOSTNAME
-export AIO_UPLOAD_PORT=$TEST_AIO_UPLOAD_PORT
-
-export AIO_GITHUB_TOKEN=$(head -c -1 /aio-secrets/TEST_GITHUB_TOKEN 2>/dev/null || echo "TEST_GITHUB_TOKEN")
-export AIO_PREVIEW_DEPLOYMENT_TOKEN=$(head -c -1 /aio-secrets/TEST_PREVIEW_DEPLOYMENT_TOKEN 2>/dev/null || echo "TEST_PREVIEW_DEPLOYMENT_TOKEN")
-
-# Start the upload-server instance
-appName=aio-upload-server-test
-if [[ "$1" == "stop" ]]; then
-  pm2 delete $appName
-else
-  pm2 start $AIO_SCRIPTS_JS_DIR/dist/lib/verify-setup/start-test-upload-server.js \
-    --uid $AIO_WWW_USER \
-    --log /var/log/aio/upload-server-test.log \
-    --name $appName \
-    --no-autorestart \
-    ${@:2}
-fi

aio/aio-builds-setup/dockerbuild/scripts-sh/verify-setup.sh

@@ -1,40 +0,0 @@
-#!/bin/bash
-set -eu -o pipefail
-
-logFile=/var/log/aio/verify-setup.log
-uploadServerLogFile=/var/log/aio/upload-server-verify-setup.log
-
-exec 3>&1
-exec >> $logFile
-exec 2>&1
-
-echo "[`date`] - Starting verification..."
-
-# Helpers
-function countdown {
-  message=$1
-  secs=$2
-  while [ $secs -gt 0 ]; do
-    echo -ne "$message in $secs...\033[0K\r"
-    sleep 1
-    : $((secs--))
-  done
-  echo -ne "\033[0K\r"
-}
-
-function onExit {
-  aio-upload-server-test stop
-  echo -e "Full logs in '$logFile'.\n" > /dev/fd/3
-}
-
-# Setup EXIT trap
-trap 'onExit' EXIT
-
-# Start an upload-server instance for testing
-aio-upload-server-test start --log $uploadServerLogFile
-
-# Give the upload-server some time to start :(
-countdown "Starting" 5 > /dev/fd/3
-
-# Run the tests
-node $AIO_SCRIPTS_JS_DIR/dist/lib/verify-setup | tee /dev/fd/3

aio/aio-builds-setup/docs/_TOC.md

@@ -1,33 +0,0 @@
-# VM Setup Instructions
-
-
-## Overview
-- [General overview](overview--general.md)
-- [Security model](overview--security-model.md)
-- [Available scripts and commands](overview--scripts-and-commands.md)
-- [HTTP status codes](overview--http-status-codes.md)
-
-
-## Setting up the VM
-- [Set up secrets](vm-setup--set-up-secrets.md)
-- [Set up docker](vm-setup--set-up-docker.md)
-- [Attach persistent disk](vm-setup--attach-persistent-disk.md)
-- [Create host directories and files](vm-setup--create-host-dirs-and-files.md)
-- [Create docker image](vm-setup--create-docker-image.md)
-
-
-## Configuring the docker image
-- [Available environment variables](image-config--environment-variables.md)
-
-
-## Starting the docker container
-- [Start docker container](vm-setup--start-docker-container.md)
-
-
-## Updating the docker container
-- [Update docker container](vm-setup--update-docker-container.md)
-
-
-## Miscellaneous
-- [Debug docker container](misc--debug-docker-container.md)
-- [Integrate with CI](misc--integrate-with-ci.md)

aio/aio-builds-setup/docs/image-config--environment-variables.md

@@ -1,57 +0,0 @@
-# Image config - Environment variables
-
-
-Below is a list of environment variables that can be configured when creating the docker image (as
-described [here](vm-setup--create-docker-image.md)). An up-to-date list of the configurable
-environment variables and their default values can be found in the
-[Dockerfile](../dockerbuild/Dockerfile).
-
-**Note:**
-Each variable has a `TEST_` prefixed counterpart, which is used for testing purposes. In most cases
-you don't need to specify values for those.
-
-- `AIO_BUILDS_DIR`:
-  The directory (inside the container) where the uploaded build artifacts are kept.
-
-- `AIO_DOMAIN_NAME`:
-  The domain name of the server.
-
-- `AIO_GITHUB_ORGANIZATION`:
-  The GitHub organization whose teams are whitelisted for accepting uploads.
-  See also `AIO_GITHUB_TEAM_SLUGS`.
-
-- `AIO_GITHUB_TEAM_SLUGS`:
-  A comma-separated list of teams, whose authors are allowed to upload PRs.
-  See also `AIO_GITHUB_ORGANIZATION`.
-
-- `AIO_NGINX_HOSTNAME`:
-  The internal hostname for accessing the nginx server. This is mostly used for performing a
-  periodic health-check.
-
-- `AIO_NGINX_PORT_HTTP`:
-  The port number on which nginx listens for HTTP connections. This should be mapped to the
-  corresponding port on the host VM (as described [here](vm-setup--start-docker-container.md)).
-
-- `AIO_NGINX_PORT_HTTPS`:
-  The port number on which nginx listens for HTTPS connections. This should be mapped to the
-  corresponding port on the host VM (as described [here](vm-setup--start-docker-container.md)).
-
-- `AIO_REPO_SLUG`:
-  The repository slug (in the form `<user>/<repo>`) for which PRs will be uploaded.
-
-- `AIO_TRUSTED_PR_LABEL`:
-  The PR whose presence indicates the PR has been manually verified and is allowed to have its
-  build artifacts publicly served. This is useful for enabling previews for any PR (not only those
-  from trusted authors).
-
-- `AIO_UPLOAD_HOSTNAME`:
-  The internal hostname for accessing the Node.js upload-server. This is used by nginx for
-  delegating upload requests and also for performing a periodic health-check.
-
-- `AIO_UPLOAD_MAX_SIZE`:
-  The maximum allowed size for the uploaded gzip archive containing the build artifacts. Files
-  larger than this will be rejected.
-
-- `AIO_UPLOAD_PORT`:
-  The port number on which the Node.js upload-server listens for HTTP connections. This is used by
-  nginx for delegating upload requests and also for performing a periodic health-check.

aio/aio-builds-setup/docs/misc--debug-docker-container.md

@@ -1,12 +0,0 @@
-# Miscellaneous - Debug docker container
-
-
-TODO (gkalpak): Add docs. Mention:
-- `aio-health-check`
-- `aio-verify-setup`
-- Test nginx accessible at:
-  - `http://$TEST_AIO_NGINX_HOTNAME:$TEST_AIO_NGINX_PORT_HTTP`
-  - `https://$TEST_AIO_NGINX_HOTNAME:$TEST_AIO_NGINX_PORT_HTTPS`
-- Test upload-server accessible at:
-  - `http://$TEST_AIO_UPLOAD_HOTNAME:$TEST_AIO_UPLOAD_PORT`
-- Local DNS (via dnsmasq) maps the above hostnames to 127.0.0.1

aio/aio-builds-setup/docs/misc--integrate-with-ci.md

@@ -1,11 +0,0 @@
-# Miscellaneous - Integrate with CI
-
-
-TODO (gkalpak): Add docs. Mention:
-- Travis' JWT addon (+ limitations).
-  Relevant files: `.travis.yml`, `scripts/ci/env.sh`
-- Testing on CI.
-  Relevant files: `scripts/ci/test-aio.sh`, `aio/aio-builds-setup/scripts/test.sh`
-- Deploying from CI.
-  Relevant files: `scripts/ci/deploy.sh`, `aio/scripts/deploy-preview.sh`,
-                  `aio/scripts/deploy-to-firebase.sh`

aio/aio-builds-setup/docs/overview--general.md

@@ -1,120 +0,0 @@
-# Overview - General
-
-
-## Objective
-Whenever a PR job is run on Travis, we want to build `angular.io` and upload the build artifacts to
-a publicly accessible server so that collaborators (developers, designers, authors, etc) can preview
-the changes without having to checkout and build the app locally.
-
-
-## Source code
-In order to make it easier to administer the server and version-control the setup, we are using
-[docker](https://www.docker.com) to run a container on a VM. The Dockerfile and all other files
-necessary for creating the docker container are stored (and versioned) along with the angular.io
-project's source code (currently part of the angular/angular repo) in the `aio-builds-setup/`
-directory.
-
-
-## Setup
-The VM is hosted on [Google Compute Engine](https://cloud.google.com/compute/). The host OS is
-debian:jessie. For more info how to set up the host VM take a look at the "Setting up the VM"
-section in [TOC](_TOC.md).
-
-
-## Security model
-Since we are managing a public server, it is important to take appropriate measures in order to
-prevent abuse. For more details on the challenges and the chosen approach take a look at the
-[security model](overview--security-model.md).
-
-
-## The 10000 feet view
-This section gives a brief summary of the several operations performed on CI and by the docker
-container:
-
-
-### On CI (Travis)
-- Build job completes successfully.
-- The CI script checks whether the build job was initiated by a PR against the angular/angular
-  master branch.
-- The CI script checks whether the PR has touched any files that might affect the angular.io app
-  (currently the `aio/` or `packages/` directories, ignoring spec files).
-- Optionally, the CI script can check whether the PR can be automatically verified (i.e. if the
-  author of the PR is a member of one of the whitelisted GitHub teams or the PR has the specified
-  "trusted PR" label).
-  **Note:**
-  For security reasons, the same checks will be performed on the server as well. This is an optional
-  step that can be used in case one wants to apply special logic depending on the outcome of the
-  pre-verification. For example:
-  1. One might want to deploy automatically verified PRs only. In that case, the pre-verification
-     helps avoid the wasted overhead associated with uploads that are going to be rejected (e.g.
-     building the artifacts, sending them to the server, running checks on the server, detecting the
-     reasons of deployment failure and whether to fail the build, etc).
-  2. One might want to apply additional logic (e.g. different tests) depending on whether the PR is
-     automatically verified or not).
-- The CI script gzips and uploads the build artifacts to the server.
-
-More info on how to set things up on CI can be found [here](misc--integrate-with-ci.md).
-
-
-### Uploading build artifacts
-- nginx receives the upload request.
-- nginx checks that the uploaded gzip archive does not exceed the specified max file size, stores it
-  in a temporary location and passes the filepath to the Node.js upload-server.
-- The upload-server runs several checks to determine whether the request should be accepted and
-  whether it should be publicly accessible or stored for later verification (more details can be
-  found [here](overview--security-model.md)).
-- The upload-server changes the "visibility" of the associated PR, if necessary. For example, if
-  builds for the same PR had been previously deployed as non-public and the current build has been
-  automatically verified, all previous builds are made public as well.
-  If the PR transitions from "non-public" to "public", the upload-server posts a comment on the
-  corresponding PR on GitHub mentioning the SHAs and the links where the previews can be found.
-- The upload-server verifies that the uploaded file is not trying to overwrite an existing build.
-- The upload-server deploys the artifacts to a sub-directory named after the PR number and the first
-  few characters of the SHA: `<PR>/<SHA>/`
-  (Non-publicly accessible PRs will be stored in a different location, but again derived from the PR
-  number and SHA.)
-- If the PR is publicly accessible, the upload-server posts a comment on the corresponding PR on
-  GitHub mentioning the SHA and the link where the preview can be found.
-
-More info on the possible HTTP status codes and their meaning can be found
-[here](overview--http-status-codes.md).
-
-
-### Updating PR visibility
-- nginx receives a natification that a PR has been updated and passes it through to the
-  upload-server. This could, for example, be sent by a GitHub webhook every time a PR's labels
-  change.
-  E.g.: `ngbuilds.io/pr-updated` (payload: `{"number":<PR>,"action":"labeled"}`)
-- The request contains the PR number (as `number`) and optionally the action that triggered the
-  request (as `action`) in the payload.
-- The upload-server verifies the payload and determines whether the `action` (if specified) could
-  have led to PR visibility changes. Only requests that omit the `action` field altogether or
-  specify an action that can affect visibility are further processed.
-  (Currently, the only actions that are considered capable of affecting visibility are `labeled` and
-  `unlabeled`.)
-- The upload-server re-checks and if necessary updates the PR's visibility.
-
-More info on the possible HTTP status codes and their meaning can be found
-[here](overview--http-status-codes.md).
-
-
-### Serving build artifacts
-- nginx receives a request for an uploaded resource on a subdomain corresponding to the PR and SHA.
-  E.g.: `pr<PR>-<SHA>.ngbuilds.io/path/to/resource`
-- nginx maps the subdomain to the correct sub-directory and serves the resource.
-  E.g.: `/<PR>/<SHA>/path/to/resource`
-
-More info on the possible HTTP status codes and their meaning can be found
-[here](overview--http-status-codes.md).
-
-
-### Removing obsolete artifacts
-In order to avoid flooding the disk with unnecessary build artifacts, there is a cronjob that runs a
-clean-up tasks once a day. The task retrieves all open PRs from GitHub and removes all directories
-that do not correspond with an open PR.
-
-
-### Health-check
-The docker service runs a periodic health-check that verifies the running conditions of the
-container. This includes verifying the status of specific system services, the responsiveness of
-nginx and the upload-server and internet connectivity.

aio/aio-builds-setup/docs/overview--http-status-codes.md

@@ -1,85 +0,0 @@
-# Overview - HTTP Status Codes
-
-
-This is a list of all the possible HTTP status codes returned by the nginx anf upload servers, along
-with a bried explanation of what they mean:
-
-
-## `http://*.ngbuilds.io/*`
-
-- **307 (Temporary Redirect)**:
-  All non-HTTPS requests. 308 (Permanent Redirect) would be more appropriate, but is not supported
-  by all agents (e.g. cURL).
-
-
-## `https://pr<pr>-<sha>.ngbuilds.io/*`
-
-- **200 (OK)**:
-  File was found or URL was rewritten to `/index.html` (i.e. all paths that have no `.` in final
-  segment).
-
-- **403 (Forbidden)**:
-  Trying to access a sub-directory.
-
-- **404 (Not Found)**:
-  File not found.
-
-
-## `https://ngbuilds.io/create-build/<pr>/<sha>`
-
-- **201 (Created)**:
-  Build deployed successfully and is publicly available.
-
-- **202 (Accepted)**:
-  Build not automatically verifiable. Stored for later deployment (after re-verification).
-
-- **400 (Bad Request)**:
-  No payload.
-
-- **401 (Unauthorized)**:
-  No `AUTHORIZATION` header.
-
-- **403 (Forbidden)**:
-  Unable to verify build (e.g. invalid JWT token, or unable to talk to 3rd-party APIs, etc).
-
-- **405 (Method Not Allowed)**:
-  Request method other than POST.
-
-- **409 (Conflict)**:
-  Request to overwrite existing (public or non-public) directory (e.g. deploy existing build or
-  change PR visibility when the destination directory does already exist).
-
-- **413 (Payload Too Large)**:
-  Payload larger than size specified in `AIO_UPLOAD_MAX_SIZE`.
-
-
-## `https://ngbuilds.io/health-check`
-
-- **200 (OK)**:
-  The server is healthy (i.e. up and running and processing requests).
-
-
-## `https://ngbuilds.io/pr-updated`
-
-- **200 (OK)**:
-  Request processed successfully. Processing may or may not have resulted in further actions.
-
-- **400 (Bad Request)**:
-  No payload or no `number` field in payload.
-
-- **405 (Method Not Allowed)**:
-  Request method other than POST.
-
-- **409 (Conflict)**:
-  Request to overwrite existing (public or non-public) directory (i.e. directories for both
-  visibilities exist).
-  (Normally, this should not happen.)
-
-
-## `https://*.ngbuilds.io/*`
-
-- **404 (Not Found)**:
-  Request not matched by the above rules.
-
-- **500 (Internal Server Error)**:
-  Error while processing a request matched by the above rules.

aio/aio-builds-setup/docs/overview--scripts-and-commands.md

@@ -1,53 +0,0 @@
-# Overview - Scripts and Commands
-
-
-This is an overview of the available scripts and commands.
-
-
-## Scripts
-The scripts are located inside `<aio-builds-setup-dir>/scripts/`. The following scripts are
-available:
-
-- `create-image.sh`:
-  Can be used for creating a preconfigured docker image.
-  See [here](vm-setup--create-docker-image.md) for more info.
-
-- `test.sh`:
-  Can be used for running the tests for `<aio-builds-setup-dir>/dockerbuild/scripts-js/`. This is
-  useful for CI integration. See [here](misc--integrate-with-ci.md) for more info.
-
-- `update-preview-server.sh`:
-  Can be used for updating the docker container (and image) based on the latest changes checked out
-  from a git repository. See [here](vm-setup--update-docker-container.md) for more info.
-
-
-## Commands
-The following commands are available globally from inside the docker container. They are either used
-by the container to perform its various operations or can be used ad-hoc, mainly for testing
-purposes. Each command is backed by a corresponding script inside
-`<aio-builds-setup-dir>/dockerbuild/scripts-sh/`.
-
-- `aio-clean-up`:
-  Cleans up the builds directory by removing the artifacts that do not correspond to an open PR.
-  _It is run as a daily cronjob._
-
-- `aio-health-check`:
-  Runs a basic health-check, verifying that the necessary services are running, the servers are
-  responding and there is a working internet connection.
-  _It is used periodically by docker for determining the container's health status._
-
-- `aio-init`:
-  Initializes the container (mainly by starting the necessary services).
-  _It is run (by default) when starting the container._
-
-- `aio-upload-server-prod`:
-  Spins up a Node.js upload-server instance.
-  _It is used in `aio-init` (see above) during initialization._
-
-- `aio-upload-server-test`:
-  Spins up a Node.js upload-server instance for tests.
-  _It is used in `aio-verify-setup` (see below) for running tests._
-
-- `aio-verify-setup`:
-  Runs a suite of e2e-like tests, mainly verifying the correct (inter)operation of nginx and the
-  Node.js upload-server.

aio/aio-builds-setup/docs/overview--security-model.md

@@ -1,138 +0,0 @@
-# Overview - Security model
-
-
-Whenever a PR job is run on Travis, we want to build `angular.io` and upload the build artifacts to
-a publicly accessible server so that collaborators (developers, designers, authors, etc) can preview
-the changes without having to checkout and build the app locally.
-
-This document discusses the security considerations associated with uploading build artifacts as
-part of the CI setup and serving them publicly.
-
-
-## Security objectives
-
-- **Prevent uploading arbitrary content to our servers.**
-  Since there is no restriction on who can submit a PR, we cannot allow any PR's build artifacts to
-  be uploaded.
-
-- **Prevent overwriting other peoples uploaded content.**
-  There needs to be a mechanism in place to ensure that the uploaded content does indeed correspond
-  to the PR indicated by its URL.
-
-- **Prevent arbitrary access on the server.**
-  Since the PR author has full access over the build artifacts that would be uploaded, we must
-  ensure that the uploaded files will not enable arbitrary access to the server or expose sensitive
-  info.
-
-
-## Issues / Caveats
-
-- Because the PR author can change the scripts run on CI, any security mechanisms must be immune to
-  such changes.
-
-- For security reasons, encrypted Travis variables are not available to PRs, so we can't rely on
-  them to implement security.
-
-
-## Implemented approach
-
-
-### In a nutshell
-The implemented approach can be broken up to the following sub-tasks:
-
-1. Verify which PR the uploaded artifacts correspond to.
-2. Fetch the PR's metadata, including author and labels.
-3. Check whether the PR can be automatically verified as "trusted" (based on its author or labels).
-4. If necessary, update the corresponding PR's verification status.
-5. Deploy the artifacts to the corresponding PR's directory.
-6. Prevent overwriting previously deployed artifacts (which ensures that the guarantees established
-   during deployment will remain valid until the artifacts are removed).
-7. Prevent uploaded files from accessing anything outside their directory.
-
-
-### Implementation details
-This section describes how each of the aforementioned sub-tasks is accomplished:
-
-1. **Verify which PR the uploaded artifacts correspond to.**
-
-   We are taking advantage of Travis' [JWT addon](https://docs.travis-ci.com/user/jwt). By sharing
-   a secret between Travis (which keeps it private but uses it to sign a JWT) and the server (which
-   uses it to verify the authenticity of the JWT), we can accomplish the following:
-   a. Verify that the upload request comes from Travis.
-   b. Determine the PR that these artifacts correspond to (since Travis puts that information into
-      the JWT, without the PR author being able to modify it).
-
-   _Note:_
-   _There are currently certain limitation in the implementation of the JWT addon._
-   _See the next section for more details._
-
-2. **Fetch the PR's metadata, including author and labels**.
-
-   Once we have securely associated the uploaded artifacts to a PR, we retrieve the PR's metadata -
-   including the author's username and the labels - using the
-   [GitHub API](https://developer.github.com/v3/).
-   To avoid rate-limit restrictions, we use a Personal Access Token (issued by
-   [@mary-poppins](https://github.com/mary-poppins)).
-
-3. **Check whether the PR can be automatically verified as "trusted"**.
-
-   "Trusted" means that we are confident that the build artifacts are suitable for being deployed
-   and publicly accessible on the preview server. There are two ways to check that:
-   1. We can verify that the PR has a pre-determined label, which marks it as "safe for preview".
-      Such a label can only have been added by a maintainer (with the necessary rights) and
-      designates that they have manually verified the PR contents.
-   2. We can verify (again using the GitHub API) the author's membership in one of the
-      whitelisted/trusted GitHub teams. For this operation, we need a Personal Access Token with the
-      `read:org` scope issued by a user that can "see" the specified GitHub organization.
-      Here too, we use the token by @mary-poppins.
-
-4. **If necessary update the corresponding PR's verification status**.
-
-   Once we have determined whether the PR is considered "trusted", we update its "visibility" (i.e.
-   whether it is publicly accessible or not), based on the new verification status. For example, if
-   a PR was initially considered "not trusted" but the check triggered by a new build determined
-   otherwise, the PR (and all the previously uploaded previews) are made public. It works the same
-   way if a PR has gone from "trusted" to "not trusted".
-
-5. **Deploy the artifacts to the corresponding PR's directory.**
-
-   With the preceding steps, we have verified that the uploaded artifacts have been uploaded by
-   Travis. Additionally, we have determined whether the PR can be trusted to have its previews
-   publicly accessible or whether further verification is necessary. The artifacts will be stored to
-   the PR's directory, but will not be publicly accessible unless the PR has been verified.
-   Essentially, as long as sub-tasks 1, 2 and 3 can be securely accomplished, it is possible to
-   "project" the trust we have in a team's members through the PR and Travis to the build artifacts.
-
-6. **Prevent overwriting previously deployed artifacts**.
-
-   In order to enforce this restriction (and ensure that the deployed artifacts' validity is
-   preserved throughout their "lifetime"), the server that handles the upload (currently a Node.js
-   Express server) rejects uploads that target an existing directory.
-   _Note: A PR can contain multiple uploads; one for each SHA that was built on Travis._
-
-7. **Prevent uploaded files from accessing anything outside their directory.**
-
-   Nginx (which is used to serve the uploaded artifacts) has been configured to not follow symlinks
-   outside of the directory where the build artifacts are stored.
-
-
-## Assumptions / Things to keep in mind
-
-- Each trusted PR author has full control over the content that is uploaded for their PRs. Part of
-  the security model relies on the trustworthiness of these authors.
-
-- Adding the specified label on a PR and marking it as trusted, gives the author full control over
-  the content that is uploaded for the specific PR (e.g. by pushing more commits to it). The user
-  adding the label is responsible for ensuring that this control is not abused and that the PR is
-  either closed (one way of another) or the access is revoked.
-
-- If anyone gets access to the `PREVIEW_DEPLOYMENT_TOKEN` (a.k.a. `NGBUILDS_IO_KEY` on
-  angular/angular) variable generated for each Travis job, they will be able to impersonate the
-  corresponding PR's author on the preview server for as long as the token is valid (currently 90
-  mins). Because of this, the value of the `PREVIEW_DEPLOYMENT_TOKEN` should not be made publicly
-  accessible (e.g. by printing it on the Travis job log).
-
-- Travis does only allow specific whitelisted property names to be used with the JWT addon. The only
-  known such property at the time is `SAUCE_ACCESS_KEY` (used for integration with SauceLabs). In
-  order to be able to actually use the JWT addon we had to name the encrypted variable
-  `SAUCE_ACCESS_KEY` (which we later re-assign to `NGBUILDS_IO_KEY`).

aio/aio-builds-setup/docs/vm-setup--attach-persistent-disk.md

@@ -1,20 +0,0 @@
-# VM setup - Attach persistent disk
-
-
-## Create `aio-builds` persistent disk (if not already exists)
-- Follow instructions [here](https://cloud.google.com/compute/docs/disks/add-persistent-disk#create_disk).
-- `sudo mkfs.ext4 -F -E lazy_itable_init=0,lazy_journal_init=0,discard /dev/disk/by-id/google-aio-builds`
-
-
-## Mount disk
-- `sudo mkdir -p /mnt/disks/aio-builds`
-- `sudo mount -o discard,defaults /dev/disk/by-id/google-aio-builds /mnt/disks/aio-builds`
-- `sudo chmod a+w /mnt/disks/aio-builds`
-
-
-## Mount disk on boot
-- Run:
-  ```
-  echo UUID=`sudo blkid -s UUID -o value /dev/disk/by-id/google-aio-builds` \
-    /mnt/disks/aio-builds ext4 discard,defaults,nofail 0 2 | sudo tee -a /etc/fstab
-  ```

aio/aio-builds-setup/docs/vm-setup--create-docker-image.md

@@ -1,32 +0,0 @@
-# VM setup - Create docker image
-
-
-## Checkout repository
-- `git clone <repo-url>`
-
-
-## Build docker image
-- `<aio-builds-setup-dir>/scripts/create-image.sh [<name>[:<tag>] [--build-arg <NAME>=<value> ...]]`
-- You can overwrite the default environment variables inside the image, by passing new values using
-  `--build-arg`.
-
-**Note:** The script has to execute docker commands with `sudo`.
-
-
-## Example
-The following commands would create a docker image from GitHub repo `foo/bar` to be deployed on the
-`foobar-builds.io` domain and accepting PR deployments from authors that are members of the
-`bar-core` and `bar-docs-authors` teams of organization `foo`:
-
-- `git clone https://github.com/foo/bar.git foobar`
-- Run:
-  ```
-  ./foobar/aio-builds-setup/scripts/build.sh foobar-builds \
-    --build-arg AIO_REPO_SLUG=foo/bar \
-    --build-arg AIO_DOMAIN_NAME=foobar-builds.io \
-    --build-arg AIO_GITHUB_ORGANIZATION=foo \
-    --build-arg AIO_GITHUB_TEAM_SLUGS=bar-core,bar-docs-authors
-  ```
-
-A full list of the available environment variables can be found
-[here](image-config--environment-variables.md).

aio/aio-builds-setup/docs/vm-setup--create-host-dirs-and-files.md

@@ -1,75 +0,0 @@
-# VM setup - Create host directories and files
-
-
-## Create directory with secrets
-For security reasons, sensitive info (such as tokens and passwords) are not hardcoded into the
-docker image, nor passed as environment variables at runtime. They are passed to the docker
-container from the host VM as files inside a directory. Each file's name is the name of the variable
-and the file content is the value. These are read from inside the running container when necessary.
-
-More info on how to create `secrets` directory and files can be found
-[here](vm-setup--set-up-secrets.md).
-
-
-## Create directory for build artifacts
-The uploaded build artifacts should be kept on a directory outside the docker container, so it is
-easier to replace the container without losing the uploaded builds. For portability across VMs a
-persistent disk can be used (as described [here](vm-setup--attach-persistent-disk.md)).
-
-**Note:** The directories created inside that directory will be owned by user `www-data`.
-
-
-## Create SSL certificates (Optional for dev)
-The host VM can attach a directory containing the SSL certificate and key to be used by the nginx
-server for serving the uploaded build artifacts. More info on how to attach the directory when
-starting the container can be found [here](vm-setup--start-docker-container.md).
-
-In order for the container to be able to find the certificate and key, they should be named
-`<DOMAIN_NAME>.crt` and `<DOMAIN_NAME>.key` respectively. For example, for a domain name
-`ngbuild.io`, nginx will look for files `ngbuilds.io.crt` and `ngbuilds.io.key`. More info on how to
-specify the domain name see [here](vm-setup--create-docker-image.md).
-
-If no directory is attached, nginx will use an internal self-signed certificate. This is convenient
-during development, but is not suitable for production.
-
-**Note:**
-Since nginx needs to be able to serve requests for both the main domain as well as any subdomain
-(e.g. `ngbuilds.io/` and `foo-bar.ngbuilds.io/`), the provided certificate needs to be a wildcard
-certificate covering both the domain and subdomains.
-
-
-## Create directory for logs (Optional)
-Optionally, a logs directory can pe passed to the docker container for storing non-system-related
-logs. If not provided, the logs are kept locally on the container and will be lost whenever the
-container is replaced (e.g. when updating to use a newer version of the docker image). Log files are
-rotated and retained for 6 months.
-
-The following log files are kept in this directory:
-
-- `clean-up.log`:
-  Output of the `aio-clean-up` command, run as a cronjob for cleaning up the build artifacts of
-  closed PRs.
-
-- `init.log`:
-  Output of the `aio-init` command, run (by default) when starting the container.
-
-- `nginx/{access,error}.log`:
-  The access and error logs produced by the nginx server while serving "production" files.
-
-- `nginx-test/{access,error}.log`:
-  The access and error logs produced by the nginx server while serving "test" files. This is only
-  used when running tests locally from inside the container, e.g. with the `aio-verify-setup`
-  command. (See [here](overview--scripts-and-commands.md) for more info.)
-
-- `upload-server-{prod,test,verify-setup}-*.log`:
-  The logs produced by the Node.js upload-server while serving either:
-  - `-prod`: "Production" files (g.g during normal operation).
-  - `-test`: "Test" files (e.g. when a test instance is started with the `aio-upload-server-test`
-             command).
-  - `-verify-setup`: "Test" files, but while running `aio-verify-setup`.
-
-  (See [here](overview--scripts-and-commands.md) for more info the commands mentioned above.)
-
-- `verify-setup.log`:
-  The output of the `aio-verify-setup` command (e.g. Jasmine output), except for upload-server
-  output which is logged to `upload-server-verify-setup-*.log` (see above).

aio/aio-builds-setup/docs/vm-setup--set-up-docker.md

@@ -1,35 +0,0 @@
-# VM Setup - Set up docker
-
-
-## Install docker
-
-_Debian (jessie):_
-- `sudo apt-get update`
-- `sudo apt-get install -y apt-transport-https ca-certificates curl git software-properties-common`
-- `curl -fsSL https://apt.dockerproject.org/gpg | sudo apt-key add -`
-- `apt-key fingerprint 58118E89F3A912897C070ADBF76221572C52609D`
-- `sudo add-apt-repository "deb https://apt.dockerproject.org/repo/ debian-$(lsb_release -cs) main"`
-- `sudo apt-get update`
-- `sudo apt-get -y install docker-engine`
-
-_Ubuntu (16.04):_
-- `sudo apt-get update`
-- `sudo apt-get install -y curl git linux-image-extra-$(uname -r) linux-image-extra-virtual`
-- `sudo apt-get install -y apt-transport-https ca-certificates`
-- `curl -fsSL https://yum.dockerproject.org/gpg | sudo apt-key add -`
-- `apt-key fingerprint 58118E89F3A912897C070ADBF76221572C52609D`
-- `sudo add-apt-repository "deb https://apt.dockerproject.org/repo/ ubuntu-$(lsb_release -cs) main"`
-- `sudo apt-get update`
-- `sudo apt-get -y install docker-engine`
-
-
-## Start the docker
-- `sudo service docker start`
-
-
-## Test docker
-- `sudo docker run hello-world`
-
-
-## Start docker on boot
-- `sudo systemctl enable docker`

aio/aio-builds-setup/docs/vm-setup--set-up-secrets.md

@@ -1,52 +0,0 @@
-# VM Setup - Set up secrets
-
-
-## Overview
-
-Necessary secrets:
-
-1. `GITHUB_TOKEN`
-   - Used for:
-     - Retrieving open PRs without rate-limiting.
-     - Retrieving PR author.
-     - Retrieving members of the `angular-core` team.
-     - Posting comments with preview links on PRs.
-
-2. `PREVIEW_DEPLOYMENT_TOKEN`
-   - Used for:
-     - Decoding the JWT tokens received with `/create-build` requests.
-
-**Note:**
-`TEST_GITHUB_TOKEN` and `TEST_PREVIEW_DEPLOYMENT_TOKEN` can also be created similar to their
-non-TEST counterparts and they will be loaded when running `aio-verify-setup`, but it is currently
-not clear if/how they can be used in tests.
-
-
-## Create secrets
-
-1. `GITHUB_TOKEN`
-   - Visit https://github.com/settings/tokens.
-   - Generate new token with the `public_repo` scope.
-
-2. `PREVIEW_DEPLOYMENT_TOKEN`
-   - Just generate a hard-to-guess character sequence.
-   - Add it to `.travis.yml` under `addons -> jwt -> secure`.
-     Can be added automatically with: `travis encrypt --add addons.jwt PREVIEW_DEPLOYMENT_TOKEN=<access-key>`
-
-**Note:**
-Due to [travis-ci/travis-ci#7223](https://github.com/travis-ci/travis-ci/issues/7223) it is not
-currently possible to use the JWT addon (as described above) for anything other than the
-`SAUCE_ACCESS_KEY` variable. You can get creative, though...
-
-**WARNING**
-TO avoid arbitrary uploads, make sure the `PREVIEW_DEPLOYMENT_TOKEN` is NOT printed in the Travis log.
-
-
-## Save secrets on the VM
-
-- `sudo mkdir /aio-secrets`
-- `sudo touch /aio-secrets/GITHUB_TOKEN`
-- Insert `<github-token>` into `/aio-secrets/GITHUB_TOKEN`.
-- `sudo touch /aio-secrets/PREVIEW_DEPLOYMENT_TOKEN`
-- Insert `<access-token>` into `/aio-secrets/PREVIEW_DEPLOYMENT_TOKEN`.
-- `sudo chmod 400 /aio-secrets/*`

aio/aio-builds-setup/docs/vm-setup--start-docker-container.md

@@ -1,92 +0,0 @@
-# VM setup - Start docker container
-
-
-## The `docker run` command
-Once everything has been setup and configured, a docker container can be started with the following
-command:
-
-```
-sudo docker run \
-  --detach \
-  --dns 127.0.0.1 \
-  --name <instance-name> \
-  --publish 80:80 \
-  --publish 443:443 \
-  --restart unless-stopped \
- [--volume <host-cert-dir>:/etc/ssl/localcerts:ro] \
-  --volume <host-secrets-dir>:/aio-secrets:ro \
-  --volume <host-builds-dir>:/var/www/aio-builds \
- [--volume <host-logs-dir>:/var/log/aio] \
-  <name>[:<tag>]
-```
-
-Below is the same command with inline comments explaining each option. The aPI docs for `docker run`
-can be found [here](https://docs.docker.com/engine/reference/run/).
-
-```
-sudo docker run \
-
-  # Start as a daemon.
-  --detach \
-
-  # Use the local DNS server.
-  # (This is necessary for mapping internal URLs, e.g. for the Node.js upload-server.)
-  --dns 127.0.0.1 \
-
-  # USe `<instance-name>` as an alias for the container.
-  # Useful for running `docker` commands, e.g.: `docker stop <instance-name>`
-  --name <instance-name> \
-
-  # Map ports of the host VM (left) to ports of the docker container (right)
-  --publish 80:80 \
-  --publish 443:443 \
-
-  # Automatically restart the container (unless it was explicitly stopped by the user).
-  # (This ensures that the container will be automatically started on boot.)
-  --restart unless-stopped \
-
-  # The directory the contains the SSL certificates.
-  # (See [here](vm-setup--create-host-dirs-and-files.md) for more info.)
-  # If not provided, the container will use self-signed certificates.
- [--volume <host-cert-dir>:/etc/ssl/localcerts:ro] \
-
-  # The directory the contains the secrets (e.g. GitHub token, JWT secret, etc).
-  # (See [here](vm-setup--set-up-secrets.md) for more info.)
-  --volume <host-secrets-dir>:/aio-secrets:ro \
-
-  # The uploaded build artifacts will stored to and served from this directory.
-  # (If you are using a persistent disk - as described [here](vm-setup--attach-persistent-disk.md) -
-  #  this will be a directory inside the disk.)
-  --volume <host-builds-dir>:/var/www/aio-builds \
-
-  # The directory where the logs are being kept.
-  # (See [here](vm-setup--create-host-dirs-and-files.md) for more info.)
-  # If not provided, the logs will be kept inside the container, which means they will be lost
-  # whenever a new container is created.
- [--volume <host-logs-dir>:/var/log/aio] \
-
-  # The name of the docker image to use (and an optional tag; defaults to `latest`).
-  # (See [here](vm-setup--create-docker-image.md) for instructions on how to create the iamge.)
-  <name>[:<tag>]
-```
-
-
-## Example
-The following command would start a docker container based on the previously created `foobar-builds`
-docker image, alias it as 'foobar-builds-1' and map predefined directories on the host VM to be used
-by the container for accesing secrets and SSL certificates and keeping the build artifacts and logs.
-
-```
-sudo docker run \
-  --detach \
-  --dns 127.0.0.1 \
-  --name foobar-builds-1 \
-  --publish 80:80 \
-  --publish 443:443 \
-  --restart unless-stopped \
-  --volume /etc/ssl/localcerts:/etc/ssl/localcerts:ro \
-  --volume /foobar-secrets:/aio-secrets:ro \
-  --volume /mnt/disks/foobar-builds:/var/www/aio-builds \
-  --volume /foobar-logs:/var/log/aio \
-  foobar-builds
-```

aio/aio-builds-setup/docs/vm-setup--update-docker-container.md

@@ -1,52 +0,0 @@
-# VM setup - Update docker container
-
-
-## Overview
-Assuming you have cloned the repository containing the preview server code (as described
-[here](vm-setup--create-docker-image.md)), you can use the `update-preview-server.sh` script on the
-VM host to update the preview server based on changes in the source code.
-
-The script will pull the latest changes from the origin's master branch and examine if there have
-been any changes in files inside the preview server source code directory (see below). If there are,
-it will create a new image and verify that is works as expected. Finally, it will stop and remove
-the old docker container and image, create a new container based on the new image and start it.
-
-The script assumes that the preview server source code is in the repository's
-`aio/aio-builds-setup/` directory and expects the following inputs:
-
-- **$1**: `HOST_REPO_DIR`
-- **$2**: `HOST_LOCALCERTS_DIR`
-- **$3**: `HOST_SECRETS_DIR`
-- **$4**: `HOST_BUILDS_DIR`
-- **$5**: `HOST_LOGS_DIR`
-
-See [here](vm-setup--create-host-dirs-and-files.md) for more info on what each input directory is
-used for.
-
-**Note 1:** The script has to execute docker commands with `sudo`.
-
-**Note 2:** Make sure the user that executes the script has access to update the repository
-
-
-## Run the script manually
-You may choose to manually run the script, when necessary. Example:
-
-```
-update-preview-server.sh \
-    /path/to/repo \
-    /path/to/localcerts \
-    /path/to/secrets \
-    /path/to/builds \
-    /path/to/logs
-```
-
-
-## Run the script automatically
-You may choose to automatically trigger the script, e.g. using a cronjob. For example, the following
-cronjob entry would run the script every hour and update the preview server (assuming the user has
-the necessary permissions):
-
-```
-# Periodically check for changes and update the preview server (if necessary)
-*/30 *  * * *   /path/to/update-preview-server.sh /path/to/repo /path/to/localcerts /path/to/secrets /path/to/builds /path/to/logs
-```

aio/aio-builds-setup/scripts/_env.sh

@@ -1,5 +0,0 @@
-#!/bin/bash
-
-readonly THIS_DIR=$(cd $(dirname $0); pwd)
-readonly DOCKERBUILD_DIR="$THIS_DIR/../dockerbuild"
-readonly SCRIPTS_JS_DIR="$DOCKERBUILD_DIR/scripts-js"

aio/aio-builds-setup/scripts/create-image.sh

@@ -1,18 +0,0 @@
-#!/bin/bash
-set -eux -o pipefail
-
-# Set up env
-source "`dirname $0`/_env.sh"
-readonly defaultImageNameAndTag="aio-builds:latest"
-
-# Build `scripts-js/`
-# (Necessary, because only `scripts-js/dist/` is copied to the docker image.)
-(
-  cd "$SCRIPTS_JS_DIR"
-  yarn install --freeze-lockfile --non-interactive
-  yarn build
-)
-
-# Create docker image
-readonly nameAndOptionalTag=${1:-$defaultImageNameAndTag}
-sudo docker build --tag $nameAndOptionalTag ${@:2} $DOCKERBUILD_DIR

aio/aio-builds-setup/scripts/test.sh

@@ -1,12 +0,0 @@
-#!/bin/bash
-set -eux -o pipefail
-
-# Set up env
-source "`dirname $0`/_env.sh"
-
-# Test `scripts-js/`
-(
-  cd "$SCRIPTS_JS_DIR"
-  yarn install --freeze-lockfile --non-interactive
-  yarn test
-)

aio/aio-builds-setup/scripts/update-preview-server.sh

@@ -1,70 +0,0 @@
-#!/usr/bin/env bash
-
-set -eux -o pipefail
-exec 3>&1
-
-echo "[`date`] - Updating the preview server..."
-
-# Input
-readonly HOST_REPO_DIR=$1
-readonly HOST_LOCALCERTS_DIR=$2
-readonly HOST_SECRETS_DIR=$3
-readonly HOST_BUILDS_DIR=$4
-readonly HOST_LOGS_DIR=$5
-
-# Constants
-readonly PROVISIONAL_IMAGE_NAME=aio-builds:provisional
-readonly LATEST_IMAGE_NAME=aio-builds:latest
-readonly CONTAINER_NAME=aio
-
-# Run
-(
-  cd "$HOST_REPO_DIR"
-
-  readonly lastDeployedCommit=$(git rev-parse HEAD)
-  echo "Currently at commit $lastDeployedCommit."
-
-  # Pull latest master from origin.
-  git pull origin master
-
-  # Do not update the server unless files inside `aio-builds-setup/` have changed
-  # or the last attempt failed (identified by the provisional image still being around).
-  readonly relevantChangedFilesCount=$(git diff --name-only $lastDeployedCommit...HEAD | grep -P "^aio/aio-builds-setup/" | wc -l)
-  readonly lastAttemptFailed=$(sudo docker rmi "$PROVISIONAL_IMAGE_NAME" >> /dev/fd/3 && echo "true" || echo "false")
-  if [[ $relevantChangedFilesCount -eq 0 ]] && [[ "$lastAttemptFailed" != "true" ]]; then
-    echo "Skipping update because no relevant files have been touched."
-    exit 0
-  fi
-
-  # Create and verify a new docker image.
-  aio/aio-builds-setup/scripts/create-image.sh "$PROVISIONAL_IMAGE_NAME"
-  readonly imageVerified=$(sudo docker run --dns 127.0.0.1 --rm --volume $HOST_SECRETS_DIR:/aio-secrets:ro "$PROVISIONAL_IMAGE_NAME" /bin/bash -c "aio-init && aio-health-check && aio-verify-setup" >> /dev/fd/3 && echo "true" || echo "false")
-
-  if [[ "$imageVerified" != "true" ]]; then
-    echo "Failed to verify new docker image. Aborting update!"
-    exit 1
-  fi
-
-  # Remove the old container and replace the docker image.
-  sudo docker stop "$CONTAINER_NAME" || true
-  sudo docker rm "$CONTAINER_NAME" || true
-  sudo docker rmi "$LATEST_IMAGE_NAME" || true
-  sudo docker tag "$PROVISIONAL_IMAGE_NAME" "$LATEST_IMAGE_NAME"
-  sudo docker rmi "$PROVISIONAL_IMAGE_NAME"
-
-  # Create and start a docker container based on the new image.
-  sudo docker run \
-      --detach \
-      --dns 127.0.0.1 \
-      --name "$CONTAINER_NAME" \
-      --publish 80:80 \
-      --publish 443:443 \
-      --restart unless-stopped \
-      --volume $HOST_LOCALCERTS_DIR:/etc/ssl/localcerts:ro \
-      --volume $HOST_SECRETS_DIR:/aio-secrets:ro \
-      --volume $HOST_BUILDS_DIR:/var/www/aio-builds \
-      --volume $HOST_LOGS_DIR:/var/log/aio \
-      "$LATEST_IMAGE_NAME"
-
-  echo "The new docker image has been successfully deployed."
-)

aio/content/examples/.gitignore

@@ -1,66 +0,0 @@
-# boilerplate files
-**/src/styles.css
-**/src/systemjs-angular-loader.js
-**/src/systemjs.config.js
-**/src/tsconfig.json
-**/bs-config.e2e.json
-**/bs-config.json
-**/package.json
-**/tslint.json
-**/karma.conf.js
-**/karma-test-shim.js
-**/browser-test-shim.js
-**/node_modules
-
-# built files
-*.map
-_test-output
-protractor-helpers.js
-*/e2e-spec.js
-**/*.js
-**/ts/**/*.js
-**/js-es6*/**/*.js
-dist/
-
-
-# special
-!/*
-!*.1.*
-!*.2.*
-!*.3.*
-*.1.js
-*.2.js
-*.3.js
-*.1.js.map
-*.2.js.map
-*.3.js.map
-!systemjs.config.*.js
-!karma-test-shim.*.js
-!copy-dist-files.js
-
-# AngularJS files
-!**/*.ajs.js
-**/app/**/*.ajs.js
-
-# aot
-*/aot/**/*
-!*/aot/bs-config.json
-!*/aot/index.html
-!rollup-config.js
-
-# i18n
-!i18n/src/systemjs-text-plugin.js
-
-# testing
-!testing/src/browser-test-shim.js
-!testing/karma*.js
-
-# webpack
-!webpack/**/config/*.js
-!webpack/**/*webpack*.js
-
-# styleguide
-!styleguide/src/systemjs.custom.js
-
-# plunkers
-*plnkr.no-link.html

aio/content/examples/ajs-quick-reference/e2e-spec.ts

@@ -1,115 +0,0 @@
-'use strict'; // necessary for es6 output in node
-
-import { browser, element, by } from 'protractor';
-
-describe('AngularJS to Angular Quick Reference Tests', function () {
-
-  beforeAll(function () {
-    browser.get('');
-  });
-
-  it('should display no poster images after bootstrap', function () {
-    testImagesAreDisplayed(false);
-  });
-
-  it('should display proper movie data', function () {
-    // We check only a few samples
-    let expectedSamples: any[] = [
-      {row: 0, column: 0, element: 'img', attr: 'src', value: 'images/hero.png', contains: true},
-      {row: 0, column: 2, value: 'Celeritas'},
-      {row: 1, column: 3, matches: /Dec 1[678], 2015/}, // absorb timezone dif; we care about date format
-      {row: 1, column: 5, value: '$14.95'},
-      {row: 2, column: 4, value: 'PG-13'},
-      {row: 2, column: 7, value: '100%'},
-      {row: 2, column: 0, element: 'img', attr: 'src', value: 'images/ng-logo.png', contains: true},
-    ];
-
-    // Go through the samples
-    let movieRows = getMovieRows();
-    for (let i = 0; i < expectedSamples.length; i++) {
-      let sample = expectedSamples[i];
-      let tableCell = movieRows.get(sample.row)
-        .all(by.tagName('td')).get(sample.column);
-      // Check the cell or its nested element
-      let elementToCheck = sample.element
-        ? tableCell.element(by.tagName(sample.element))
-        : tableCell;
-
-      // Check element attribute or text
-      let valueToCheck = sample.attr
-        ? elementToCheck.getAttribute(sample.attr)
-        : elementToCheck.getText();
-
-      // Test for equals/contains/match
-      if (sample.contains) {
-        expect(valueToCheck).toContain(sample.value);
-      } else if (sample.matches) {
-        expect(valueToCheck).toMatch(sample.matches);
-      } else {
-        expect(valueToCheck).toEqual(sample.value);
-      }
-    }
-  });
-
-  it('should display images after Show Poster', function () {
-    testPosterButtonClick('Show Poster', true);
-  });
-
-  it('should hide images after Hide Poster', function () {
-    testPosterButtonClick('Hide Poster', false);
-  });
-
-  it('should display no movie when no favorite hero is specified', function () {
-    testFavoriteHero(null, 'Please enter your favorite hero.');
-  });
-
-  it('should display no movie for Magneta', function () {
-    testFavoriteHero('Magneta', 'No movie, sorry!');
-  });
-
-  it('should display a movie for Mr. Nice', function () {
-    testFavoriteHero('Mr. Nice', 'Excellent choice!');
-  });
-
-  function testImagesAreDisplayed(isDisplayed: boolean) {
-    let expectedMovieCount = 3;
-
-    let movieRows = getMovieRows();
-    expect(movieRows.count()).toBe(expectedMovieCount);
-    for (let i = 0; i < expectedMovieCount; i++) {
-      let movieImage = movieRows.get(i).element(by.css('td > img'));
-      expect(movieImage.isDisplayed()).toBe(isDisplayed);
-    }
-  }
-
-  function testPosterButtonClick(expectedButtonText: string, isDisplayed: boolean) {
-    let posterButton = element(by.css('movie-list tr > th > button'));
-    expect(posterButton.getText()).toBe(expectedButtonText);
-
-    posterButton.click().then(function () {
-      testImagesAreDisplayed(isDisplayed);
-    });
-  }
-
-  function getMovieRows() {
-    return element.all(by.css('movie-list tbody > tr'));
-  }
-
-  function testFavoriteHero(heroName: string, expectedLabel: string) {
-    let movieListComp = element(by.tagName('movie-list'));
-    let heroInput = movieListComp.element(by.tagName('input'));
-    let favoriteHeroLabel = movieListComp.element(by.tagName('h3'));
-    let resultLabel = movieListComp.element(by.css('span > p'));
-
-    heroInput.clear().then(function () {
-      heroInput.sendKeys(heroName || '');
-      expect(resultLabel.getText()).toBe(expectedLabel);
-      if (heroName) {
-        expect(favoriteHeroLabel.isDisplayed()).toBe(true);
-        expect(favoriteHeroLabel.getText()).toContain(heroName);
-      } else {
-        expect(favoriteHeroLabel.isDisplayed()).toBe(false);
-      }
-    });
-  }
-});