release: cut the v6.0.3 release

PR Close #23656

.circleci/config.yml

@@ -12,8 +12,8 @@
 ## IMPORTANT
 # If you change the `docker_image` version, also change the `cache_key` suffix and the version of
 # `com_github_bazelbuild_buildtools` in the `/WORKSPACE` file.
-var_1: &docker_image angular/ngcontainer:0.3.1
-var_2: &cache_key v2-angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.3.1
+var_1: &docker_image angular/ngcontainer:0.3.0
+var_2: &cache_key v2-angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-0.3.0
 
 # Define common ENV vars
 var_3: &define_env_vars
@@ -80,12 +80,12 @@ jobs:
 
       - run: ls /home/circleci/bazel_repository_cache || true
       - run: bazel info release
-      - run: bazel run @nodejs//:yarn
+      - run: bazel run @yarn//:yarn
       # Use bazel query so that we explicitly ask for all buildable targets to be built as well
       # This avoids waiting for the slowest build target to finish before running the first test
       # See https://github.com/bazelbuild/bazel/issues/4257
       # NOTE: Angular developers should typically just bazel build //packages/... or bazel test //packages/...
-      - run: bazel query --output=label //... | xargs bazel test --build_tag_filters=-ivy-only --test_tag_filters=-manual,-ivy-only
+      - run: bazel query --output=label //... | xargs bazel test
 
       # CircleCI will allow us to go back and view/download these artifacts from past builds.
       # Also we can use a service like https://buildsize.org/ to automatically track binary size of these artifacts.
@@ -111,42 +111,6 @@ jobs:
           paths:
             - "node_modules"
             - "~/bazel_repository_cache"
-  # Temporary job to test what will happen when we flip the Ivy flag to true
-  test_ivy_jit:
-    <<: *job_defaults
-    resource_class: xlarge
-    steps:
-      - *define_env_vars
-      - checkout:
-          <<: *post_checkout
-      # See remote cache documentation in /docs/BAZEL.md
-      - run: .circleci/setup_cache.sh
-      - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
-      - *setup-bazel-remote-cache
-
-      - restore_cache:
-          key: *cache_key
-
-      - run: bazel run @yarn//:yarn
-      - run: bazel query --output=label //... | xargs bazel test --define=compile=jit --build_tag_filters=ivy-jit --test_tag_filters=-manual,ivy-jit
-
-  test_ivy_aot:
-    <<: *job_defaults
-    resource_class: xlarge
-    steps:
-      - *define_env_vars
-      - checkout:
-          <<: *post_checkout
-      # See remote cache documentation in /docs/BAZEL.md
-      - run: .circleci/setup_cache.sh
-      - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
-      - *setup-bazel-remote-cache
-
-      - restore_cache:
-          key: *cache_key
-
-      - run: bazel run @yarn//:yarn
-      - run: bazel query --output=label //... | xargs bazel test --define=compile=local --build_tag_filters=ivy-local --test_tag_filters=-manual,ivy-local
 
   # This job exists only for backwards-compatibility with old scripts and tests
   # that rely on the pre-Bazel dist/packages-dist layout.
@@ -167,7 +131,7 @@ jobs:
       - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
       - *setup-bazel-remote-cache
 
-      - run: bazel run @nodejs//:yarn
+      - run: bazel run @yarn//:yarn
       - run: scripts/build-packages-dist.sh
 
       # Save the npm packages from //packages/... for other workflow jobs to read
@@ -176,8 +140,6 @@ jobs:
           root: dist
           paths:
             - packages-dist
-            - packages-dist-ivy-jit
-            - packages-dist-ivy-local
 
   # We run the integration tests outside of Bazel for now.
   # They are a separate workflow job so that they can be easily re-run.
@@ -238,8 +200,6 @@ workflows:
     jobs:
       - lint
       - test
-      - test_ivy_jit
-      - test_ivy_aot
       - build-packages-dist
       - integration_test:
           requires:
@@ -252,8 +212,6 @@ workflows:
           requires:
             # Only publish if tests and integration tests pass
             - test
-            - test_ivy_jit
-            - test_ivy_aot
             - integration_test
             # Get the artifacts to publish from the build-packages-dist job
             # since the publishing script expects the legacy outputs layout.

.github/angular-robot.yml

@@ -45,12 +45,10 @@ merge:
       - "packages/language-service/**"
       - "**/.gitignore"
       - "**/.gitkeep"
-      - "**/package.json"
       - "**/tsconfig-build.json"
       - "**/tsconfig.json"
       - "**/rollup.config.js"
       - "**/BUILD.bazel"
-      - "packages/**/integrationtest/**"
       - "packages/**/test/**"
 
   # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable

.pullapprove.yml

@@ -163,7 +163,7 @@ groups:
       files:
         - "packages/compiler/*"
     users:
-      - alxhub #primary
+      - chuckjaz #primary
       - vicb
       - mhevery
       - IgorMinar #fallback

BUILD.bazel

@@ -11,7 +11,7 @@ exports_files([
 # This ensures that package.json in subdirectories get installed as well.
 alias(
     name = "install",
-    actual = "@nodejs//:yarn",
+    actual = "@yarn//:yarn",
 )
 
 node_modules_filegroup(
@@ -44,16 +44,14 @@ filegroup(
         "//:node_modules/zone.js/dist/zone.js",
         "//:node_modules/zone.js/dist/zone-testing.js",
         "//:node_modules/zone.js/dist/task-tracking.js",
-        "//:test-events.js",
     ],
 )
 
 filegroup(
-    name = "angularjs_scripts",
+    name = "angularjs",
+    # do not sort
     srcs = [
-        "//:node_modules/angular-1.5/angular.js",
-        "//:node_modules/angular-mocks-1.5/angular-mocks.js",
-        "//:node_modules/angular-mocks/angular-mocks.js",
         "//:node_modules/angular/angular.js",
+        "//:node_modules/angular-mocks/angular-mocks.js",
     ],
 )

CHANGELOG.md

@@ -1,105 +1,3 @@
-<a name="6.1.0-beta.1"></a>
-# [6.1.0-beta.1](https://github.com/angular/angular/compare/6.1.0-beta.0...6.1.0-beta.1) (2018-06-13)
-
-
-### Bug Fixes
-
-* **animations:** always render end-state styles for orphaned DOM nodes ([#24236](https://github.com/angular/angular/issues/24236)) ([dc4a3d0](https://github.com/angular/angular/commit/dc4a3d0))
-* **bazel:** Allow ng_module to depend on targets w no deps ([#24446](https://github.com/angular/angular/issues/24446)) ([282d351](https://github.com/angular/angular/commit/282d351))
-* **docs-infra:** use script nomodule to load IE polyfills, skip other polyfills ([#24317](https://github.com/angular/angular/issues/24317)) ([8be6892](https://github.com/angular/angular/commit/8be6892)), closes [#23647](https://github.com/angular/angular/issues/23647)
-* **ivy:** compute transitive scopes from NgModuleDef only ([#24334](https://github.com/angular/angular/issues/24334)) ([1135563](https://github.com/angular/angular/commit/1135563))
-* **ivy:** correctly handle queries with embedded views ([#24418](https://github.com/angular/angular/issues/24418)) ([014949f](https://github.com/angular/angular/commit/014949f))
-* **ivy:** remove debugger statement ([#24480](https://github.com/angular/angular/issues/24480)) ([70ef061](https://github.com/angular/angular/commit/70ef061))
-* **ivy:** special case [style] and [class] bindings for future use ([#23232](https://github.com/angular/angular/issues/23232)) ([1b253e1](https://github.com/angular/angular/commit/1b253e1))
-* **router:** fix lazy loading of aux routes ([#23459](https://github.com/angular/angular/issues/23459)) ([5731d07](https://github.com/angular/angular/commit/5731d07)), closes [#10981](https://github.com/angular/angular/issues/10981)
-* **service-worker:** fix `SwPush.unsubscribe()` ([#24162](https://github.com/angular/angular/issues/24162)) ([3ed2d75](https://github.com/angular/angular/commit/3ed2d75)), closes [#24095](https://github.com/angular/angular/issues/24095)
-
-
-### Features
-
-* **common:** introduce KeyValuePipe ([#24319](https://github.com/angular/angular/issues/24319)) ([2b49bf7](https://github.com/angular/angular/commit/2b49bf7))
-* **core:** export defaultKeyValueDiffers to private api ([#24319](https://github.com/angular/angular/issues/24319)) ([92b278c](https://github.com/angular/angular/commit/92b278c))
-* **core:** expose a Compiler API for accessing module ids from NgModule types ([#24258](https://github.com/angular/angular/issues/24258)) ([bd02b27](https://github.com/angular/angular/commit/bd02b27))
-* **core:** KeyValueDiffer#diff allows null values ([#24319](https://github.com/angular/angular/issues/24319)) ([52ce9d5](https://github.com/angular/angular/commit/52ce9d5))
-* **ivy:** a generic visitor which allows prefixing nodes for ngtsc ([#24230](https://github.com/angular/angular/issues/24230)) ([ca79e11](https://github.com/angular/angular/commit/ca79e11))
-* **ivy:** add support of ApplicationRef.bootstrapModuleFactory ([#23811](https://github.com/angular/angular/issues/23811)) ([e3759f7](https://github.com/angular/angular/commit/e3759f7))
-* **ivy:** namespaced attributes added to output instructions ([#24386](https://github.com/angular/angular/issues/24386)) ([82c5313](https://github.com/angular/angular/commit/82c5313))
-* **ivy:** now supports SVG and MathML elements ([#24377](https://github.com/angular/angular/issues/24377)) ([8c1ac28](https://github.com/angular/angular/commit/8c1ac28))
-* **router:** implement scrolling restoration service ([#20030](https://github.com/angular/angular/issues/20030)) ([49c5234](https://github.com/angular/angular/commit/49c5234)), closes [#13636](https://github.com/angular/angular/issues/13636) [#10929](https://github.com/angular/angular/issues/10929) [#7791](https://github.com/angular/angular/issues/7791) [#6595](https://github.com/angular/angular/issues/6595)
-
-
-
-<a name="6.0.5"></a>
-## [6.0.5](https://github.com/angular/angular/compare/6.0.4...6.0.5) (2018-06-13)
-
-* **animations:** always render end-state styles for orphaned DOM nodes ([#24236](https://github.com/angular/angular/issues/24236)) ([0139173](https://github.com/angular/angular/commit/0139173))
-* **bazel:** Allow ng_module to depend on targets w no deps ([#24446](https://github.com/angular/angular/issues/24446)) ([ea3669e](https://github.com/angular/angular/commit/ea3669e))
-* **docs-infra:** use script nomodule to load IE polyfills, skip other polyfills ([#24317](https://github.com/angular/angular/issues/24317)) ([e876535](https://github.com/angular/angular/commit/e876535)), closes [#23647](https://github.com/angular/angular/issues/23647)
-* **router:** fix lazy loading of aux routes ([#23459](https://github.com/angular/angular/issues/23459)) ([d20877b](https://github.com/angular/angular/commit/d20877b)), closes [#10981](https://github.com/angular/angular/issues/10981)
-* **service-worker:** fix `SwPush.unsubscribe()` ([#24162](https://github.com/angular/angular/issues/24162)) ([ea2987c](https://github.com/angular/angular/commit/ea2987c)), closes [#24095](https://github.com/angular/angular/issues/24095)
-
-
-
-<a name="6.1.0-beta.0"></a>
-## [6.1.0-beta.0](https://github.com/angular/angular/compare/6.0.0-rc.5...6.1.0-beta.0) (2018-06-06)
-
-
-### Bug Fixes
-
-* **animations:** do not throw errors when a destroyed component is animated ([#23836](https://github.com/angular/angular/issues/23836)) ([d2a8687](https://github.com/angular/angular/commit/d2a8687))
-* **animations:** Fix browser detection logic ([#24188](https://github.com/angular/angular/issues/24188)) ([b492b9e](https://github.com/angular/angular/commit/b492b9e))
-* **animations:** properly clean up queried element styles in safari/edge ([#23633](https://github.com/angular/angular/issues/23633)) ([da9ff25](https://github.com/angular/angular/commit/da9ff25))
-* **animations:** retain state styling for nodes that are moved around ([#23534](https://github.com/angular/angular/issues/23534)) ([65211f4](https://github.com/angular/angular/commit/65211f4))
-* **animations:** retain trigger-state for nodes that are moved around ([#24238](https://github.com/angular/angular/issues/24238)) ([8db928d](https://github.com/angular/angular/commit/8db928d))
-* **benchpress:** Fix promise chain in chrome_driver_extension. ([#23458](https://github.com/angular/angular/issues/23458)) ([d4b6c41](https://github.com/angular/angular/commit/d4b6c41))
-* **compiler:** avoid a crash in ngc-wrapped. ([#23468](https://github.com/angular/angular/issues/23468)) ([e1c4930](https://github.com/angular/angular/commit/e1c4930))
-* **compiler:** generate constant array for i18n attributes ([#23837](https://github.com/angular/angular/issues/23837)) ([cfde36d](https://github.com/angular/angular/commit/cfde36d))
-* **compiler:** generate core-compliant hostBindings property ([#24087](https://github.com/angular/angular/issues/24087)) ([01b5acd](https://github.com/angular/angular/commit/01b5acd)), closes [#24013](https://github.com/angular/angular/issues/24013)
-* **compiler:** handle undefined annotation metadata ([#23349](https://github.com/angular/angular/issues/23349)) ([ca776c5](https://github.com/angular/angular/commit/ca776c5))
-* **compiler-cli:** don't rely on incompatible TS method ([#23550](https://github.com/angular/angular/issues/23550)) ([b1f040f](https://github.com/angular/angular/commit/b1f040f))
-* **core:** avoid eager providers re-initialization ([#23559](https://github.com/angular/angular/issues/23559)) ([0c6dc45](https://github.com/angular/angular/commit/0c6dc45))
-* **core:** call ngOnDestroy on all services that have it ([#23755](https://github.com/angular/angular/issues/23755)) ([fc03427](https://github.com/angular/angular/commit/fc03427)), closes [#22466](https://github.com/angular/angular/issues/22466) [#22240](https://github.com/angular/angular/issues/22240) [#14818](https://github.com/angular/angular/issues/14818)
-* **elements:** always check to create strategy ([#23825](https://github.com/angular/angular/issues/23825)) ([b1cda36](https://github.com/angular/angular/commit/b1cda36))
-* **elements:** prevent closure renaming of platform properties ([#23843](https://github.com/angular/angular/issues/23843)) ([d4b8b24](https://github.com/angular/angular/commit/d4b8b24))
-* **forms:** properly handle special properties in FormGroup.get ([#22249](https://github.com/angular/angular/issues/22249)) ([9367e91](https://github.com/angular/angular/commit/9367e91)), closes [#17195](https://github.com/angular/angular/issues/17195)
-* **platform-server:** avoid clash between server and client style encapsulation attributes ([#24158](https://github.com/angular/angular/issues/24158)) ([b96a3c8](https://github.com/angular/angular/commit/b96a3c8))
-* **platform-server:** avoid dependency cycle when using http interceptor ([#24229](https://github.com/angular/angular/issues/24229)) ([60aa943](https://github.com/angular/angular/commit/60aa943)), closes [#23023](https://github.com/angular/angular/issues/23023)
-* **platform-server:** don't reflect innerHTML property to attibute ([#24213](https://github.com/angular/angular/issues/24213)) ([6a663a4](https://github.com/angular/angular/commit/6a663a4)), closes [#19278](https://github.com/angular/angular/issues/19278)
-* **platform-server:** provide Domino DOM types globally ([#24116](https://github.com/angular/angular/issues/24116)) ([c73196e](https://github.com/angular/angular/commit/c73196e)), closes [#23280](https://github.com/angular/angular/issues/23280) [#23133](https://github.com/angular/angular/issues/23133)
-* **router:** avoid freezing queryParams in-place ([#22663](https://github.com/angular/angular/issues/22663)) ([89f64e5](https://github.com/angular/angular/commit/89f64e5)), closes [#22617](https://github.com/angular/angular/issues/22617)
-* **router:** cache route handle if found ([#22475](https://github.com/angular/angular/issues/22475)) ([4cfa571](https://github.com/angular/angular/commit/4cfa571)), closes [#22474](https://github.com/angular/angular/issues/22474)
-* **router:** correct the segment parsing so it won't break on ampersand ([#23684](https://github.com/angular/angular/issues/23684)) ([553a680](https://github.com/angular/angular/commit/553a680))
-* **service-worker:** add badge to NOTIFICATION_OPTION_NAMES ([#23241](https://github.com/angular/angular/issues/23241)) ([fb59b2d](https://github.com/angular/angular/commit/fb59b2d)), closes [#23196](https://github.com/angular/angular/issues/23196)
-* **service-worker:** check platformBrowser before accessing navigator.serviceWorker ([#21231](https://github.com/angular/angular/issues/21231)) ([0bdd30e](https://github.com/angular/angular/commit/0bdd30e))
-* **service-worker:** correctly handle requests with empty `clientId` ([#23625](https://github.com/angular/angular/issues/23625)) ([e0ed59e](https://github.com/angular/angular/commit/e0ed59e)), closes [#23526](https://github.com/angular/angular/issues/23526)
-* **service-worker:** deprecate `versionedFiles` in asset-group resources ([#23584](https://github.com/angular/angular/issues/23584)) ([1d378e2](https://github.com/angular/angular/commit/1d378e2))
-
-
-### Features
-
-* **compiler:** support `// ...` and `// TODO` in mock compiler expectations ([#23441](https://github.com/angular/angular/issues/23441)) ([c6b206e](https://github.com/angular/angular/commit/c6b206e))
-* **compiler-cli:** update `tsickle` to `0.29.x` ([#24233](https://github.com/angular/angular/issues/24233)) ([f69ac67](https://github.com/angular/angular/commit/f69ac67))
-* **platform-browser:** add HammerJS lazy-loader symbols to public API ([#23943](https://github.com/angular/angular/issues/23943)) ([26fbf1d](https://github.com/angular/angular/commit/26fbf1d))
-* **platform-browser:** allow lazy-loading HammerJS ([#23906](https://github.com/angular/angular/issues/23906)) ([313bdce](https://github.com/angular/angular/commit/313bdce))
-* **platform-server:** use EventManagerPlugin on the server ([#24132](https://github.com/angular/angular/issues/24132)) ([d6595eb](https://github.com/angular/angular/commit/d6595eb))
-* **router:** add navigation execution context info to activation hooks ([#24204](https://github.com/angular/angular/issues/24204)) ([20c463e](https://github.com/angular/angular/commit/20c463e)), closes [#24202](https://github.com/angular/angular/issues/24202)
-
-
-<a name="6.0.4"></a>
-## [6.0.4](https://github.com/angular/angular/compare/6.0.3...6.0.4) (2018-06-06)
-
-
-### Bug Fixes
-
-* **animations:** Fix browser detection logic ([#24188](https://github.com/angular/angular/issues/24188)) ([c9eb491](https://github.com/angular/angular/commit/c9eb491))
-* **animations:** retain trigger-state for nodes that are moved around ([#24238](https://github.com/angular/angular/issues/24238)) ([19deca1](https://github.com/angular/angular/commit/19deca1))
-* **forms:** properly handle special properties in FormGroup.get ([#22249](https://github.com/angular/angular/issues/22249)) ([dc3e8aa](https://github.com/angular/angular/commit/dc3e8aa)), closes [#17195](https://github.com/angular/angular/issues/17195)
-* **platform-server:** avoid clash between server and client style encapsulation attributes ([#24158](https://github.com/angular/angular/issues/24158)) ([e9f2203](https://github.com/angular/angular/commit/e9f2203))
-* **platform-server:** avoid dependency cycle when using http interceptor ([#24229](https://github.com/angular/angular/issues/24229)) ([2991b1b](https://github.com/angular/angular/commit/2991b1b)), closes [#23023](https://github.com/angular/angular/issues/23023)
-* **platform-server:** don't reflect innerHTML property to attibute ([#24213](https://github.com/angular/angular/issues/24213)) ([c17098d](https://github.com/angular/angular/commit/c17098d)), closes [#19278](https://github.com/angular/angular/issues/19278)
-* **platform-server:** provide Domino DOM types globally ([#24116](https://github.com/angular/angular/issues/24116)) ([906b3ec](https://github.com/angular/angular/commit/906b3ec)), closes [#23280](https://github.com/angular/angular/issues/23280) [#23133](https://github.com/angular/angular/issues/23133)
-
-
 <a name="6.0.3"></a>
 ## [6.0.3](https://github.com/angular/angular/compare/6.0.2...6.0.3) (2018-05-22)
 
@@ -144,7 +42,7 @@
 
 Angular v6 is the first release of Angular that unifies the Framework, Material and CLI.
 
-To learn about the release highlights and our new CLI-powered update workflow for your projects please check out the [v6 release announcement](https://blog.angular.io/version-6-0-0-of-angular-now-available-cc56b0efa7a4).
+To learn about the release highlights and our new CLI-powered update workflow for your projects please check out the [v6 release announcement](https://blog.angular.io/version-6-0-0-of-angular-now-available-cc56b0efa7a4). 
 
 
 
@@ -295,10 +193,10 @@ To learn about the release highlights and our new CLI-powered update workflow fo
   This change removes support for `<template>`. `<ng-template>` should be used instead.
 
   BEFORE:
-
+  
       <!-- html template -->
       <template>some template content</template>
-
+  
       # tsconfig.json
       {
         # ...
@@ -308,12 +206,12 @@ To learn about the release highlights and our new CLI-powered update workflow fo
           "enableLegacyTemplate": [true|false]
         }
       }
-
+  
   AFTER:
-
+  
       <!-- html template -->
       <ng-template>some template content</ng-template>
-
+      
 * **core:** it is no longer possible to import animation-related functions from @angular/core. All animation symbols must now be imported from @angular/animations.
 
 
@@ -326,35 +224,35 @@ To learn about the release highlights and our new CLI-powered update workflow fo
 
   Previously, ngModelChange was emitted before its underlying control was updated.
   This was fine if you passed through the value directly through the $event keyword, e.g.
-
+  
   ```
   <input [(ngModel)]="name" (ngModelChange)="onChange($event)">
-
+  
   onChange(value) {
      console.log(value);               // would log updated value
   }
   ```
-
+  
   However, if you had a handler for the ngModelChange event that checked the value through the control,
   you would get the old value rather than the updated value. e.g:
-
+  
   ```
   <input #modelDir="ngModel" [(ngModel)]="name" (ngModelChange)="onChange(modelDir)">
-
+  
   onChange(ngModel: NgModel) {
     console.log(ngModel.value);        // would log old value, not updated value
   }
   ```
-
+  
   Now the value and validity will be updated before the ngModelChange event is emitted,
   so the same setup will log the updated value.
-
+  
   ```
   onChange(ngModel: NgModel) {
      console.log(ngModel.value);       // will log updated value
   }
   ```
-
+  
   We think this order will be less confusing when the control is checked directly.
   You will only need to update your app if it has relied on this bug to keep track of the old control value.
   If that is the case, you should be able to track the old value directly by saving it on your component.

CONTRIBUTING.md

@@ -227,15 +227,10 @@ The following is the list of supported scopes:
 
 There are currently a few exceptions to the "use package name" rule:
 
-* **packaging**: used for changes that change the npm package layout in all of our packages, e.g.
-  public path changes, package.json changes done to all packages, d.ts file/format changes, changes
-  to bundles, etc.
+* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc.
 * **changelog**: used for updating the release notes in CHANGELOG.md
-* **docs-infra**: used for docs-app (angular.io) related changes within the /aio directory of the
-  repo
-* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all
-  packages (e.g. `style: add missing semicolons`) and for docs changes that are not related to a
-  specific package (e.g. `docs: fix typo in tutorial`).
+* **aio**: used for docs-app (angular.io) related changes within the /aio directory of the repo
+* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`)
 
 ### Subject
 The subject contains a succinct description of the change:
@@ -274,7 +269,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
   * https://help.github.com/articles/about-commit-email-addresses/
   * https://help.github.com/articles/blocking-command-line-pushes-that-expose-your-personal-email-address/
 
-  Note that if you have more than one Git identity, it is important to verify that you are logged in with the same ID with which you signed the CLA, before you commit changes. If not, your PR will fail the CLA check.
+  Note that if you have more than one Git identity, it is important to verify that you are logged in with the same ID with which you signed the CLA, before you commit changes. If not, your PR will fail the CLA check.  
 
 <hr>
 

WORKSPACE

@@ -6,23 +6,23 @@ workspace(name = "angular")
 
 http_archive(
     name = "build_bazel_rules_nodejs",
-    url = "https://github.com/bazelbuild/rules_nodejs/archive/0.9.1.zip",
-    strip_prefix = "rules_nodejs-0.9.1",
-    sha256 = "6139762b62b37c1fd171d7f22aa39566cb7dc2916f0f801d505a9aaf118c117f",
+    url = "https://github.com/bazelbuild/rules_nodejs/archive/0.8.0.zip",
+    strip_prefix = "rules_nodejs-0.8.0",
+    sha256 = "4e40dd49ae7668d245c3107645f2a138660fcfd975b9310b91eda13f0c973953",
 )
 
 http_archive(
     name = "io_bazel_rules_webtesting",
-    url = "https://github.com/bazelbuild/rules_webtesting/archive/v0.2.0.zip",
-    strip_prefix = "rules_webtesting-0.2.0",
-    sha256 = "cecc12f07e95740750a40d38e8b14b76fefa1551bef9332cb432d564d693723c",
+    url = "https://github.com/bazelbuild/rules_webtesting/archive/cfcaaf98553fee8e7063b5f5c11fd1b77e43d683.zip",
+    strip_prefix = "rules_webtesting-cfcaaf98553fee8e7063b5f5c11fd1b77e43d683",
+    sha256 = "636c7a9ac2ca13a04d982c2f9c874876ecc90a7b9ccfe4188156122b26ada7b3",
 )
 
 http_archive(
     name = "build_bazel_rules_typescript",
-    url = "https://github.com/bazelbuild/rules_typescript/archive/0.15.0.zip",
-    strip_prefix = "rules_typescript-0.15.0",
-    sha256 = "1aa75917330b820cb239b3c10a936a10f0a46fe215063d4492dd76dc6e1616f4",
+    url = "https://github.com/bazelbuild/rules_typescript/archive/v0.13.0.zip",
+    strip_prefix = "rules_typescript-0.13.0",
+    sha256 = "8f2767ff56ad68c80c62e9a1cdc2ba2c2ba0b19d350f713365e5333045df02e3",
 )
 
 http_archive(
@@ -34,13 +34,13 @@ http_archive(
 # This commit matches the version of buildifier in angular/ngcontainer
 # If you change this, also check if it matches the version in the angular/ngcontainer
 # version in /.circleci/config.yml
-BAZEL_BUILDTOOLS_VERSION = "82b21607e00913b16fe1c51bec80232d9d6de31c"
+BAZEL_BUILDTOOLS_VERSION = "fd9878fd5de921e0bbab3dcdcb932c2627812ee1"
 
 http_archive(
     name = "com_github_bazelbuild_buildtools",
     url = "https://github.com/bazelbuild/buildtools/archive/%s.zip" % BAZEL_BUILDTOOLS_VERSION,
     strip_prefix = "buildtools-%s" % BAZEL_BUILDTOOLS_VERSION,
-    sha256 = "edb24c2f9c55b10a820ec74db0564415c0cf553fa55e9fc709a6332fb6685eff",
+    sha256 = "27bb461ade23fd44ba98723ad98f84ee9c83cd3540b773b186a1bc5037f3d862",
 )
 
 # Fetching the Bazel source code allows us to compile the Skylark linter
@@ -66,9 +66,9 @@ http_archive(
 
 http_archive(
     name = "org_brotli",
-    url = "https://github.com/google/brotli/archive/f9b8c02673c576a3e807edbf3a9328e9e7af6d7c.zip",
-    strip_prefix = "brotli-f9b8c02673c576a3e807edbf3a9328e9e7af6d7c",
-    sha256 = "8a517806d2b7c8505ba5c53934e7d7c70d341b68ffd268e9044d35b564a48828",
+    url = "https://github.com/google/brotli/archive/c6333e1e79fb62ea088443f192293f964409b04e.zip",
+    strip_prefix = "brotli-c6333e1e79fb62ea088443f192293f964409b04e",
+    sha256 = "3f781988dee7dd3bcce2bf238294663cfaaf3b6433505bdb762e24d0a284d1dc",
 )
 
 #
@@ -77,7 +77,7 @@ http_archive(
 
 load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_repositories", "yarn_install")
 
-check_bazel_version("0.14.0")
+check_bazel_version("0.13.0")
 node_repositories(package_json = ["//:package.json"])
 
 load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")

aio/aio-builds-setup/dockerbuild/scripts-js/lib/clean-up/build-cleaner.ts

@@ -52,7 +52,8 @@ export class BuildCleaner {
   protected removeDir(dir: string) {
     try {
       if (shell.test('-d', dir)) {
-        shell.chmod('-R', 'a+w', dir);
+        // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
+        (shell as any).chmod('-R', 'a+w', dir);
         shell.rm('-rf', dir);
       }
     } catch (err) {

aio/aio-builds-setup/dockerbuild/scripts-js/lib/upload-server/build-creator.ts

@@ -106,7 +106,8 @@ export class BuildCreator extends EventEmitter {
         }
 
         try {
-          shell.chmod('-R', 'a-w', outputDir);
+          // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
+          (shell as any).chmod('-R', 'a-w', outputDir);
           shell.rm('-f', inputFile);
           resolve();
         } catch (err) {

aio/aio-builds-setup/dockerbuild/scripts-js/lib/verify-setup/helper.ts

@@ -98,7 +98,8 @@ class Helper {
     const prDir = this.getPrDir(pr, isPublic);
 
     if (fs.existsSync(prDir)) {
-      shell.chmod('-R', 'a+w', prDir);
+      // Undocumented signature (see https://github.com/shelljs/shelljs/pull/663).
+      (shell as any).chmod('-R', 'a+w', prDir);
       shell.rm('-rf', prDir);
     }
   }

aio/aio-builds-setup/dockerbuild/scripts-js/package.json

@@ -8,7 +8,7 @@
   "scripts": {
     "prebuild": "yarn clean-dist",
     "build": "tsc",
-    "build-watch": "yarn build --watch",
+    "build-watch": "yarn tsc --watch",
     "clean-dist": "node --eval \"require('shelljs').rm('-rf', 'dist')\"",
     "dev": "concurrently --kill-others --raw --success first \"yarn build-watch\" \"yarn test-watch\"",
     "lint": "tslint --project tsconfig.json",
@@ -33,7 +33,7 @@
     "@types/jasmine": "^2.6.0",
     "@types/jsonwebtoken": "^7.2.3",
     "@types/node": "^8.0.30",
-    "@types/shelljs": "^0.8.0",
+    "@types/shelljs": "^0.7.4",
     "@types/supertest": "^2.0.3",
     "concurrently": "^3.5.0",
     "nodemon": "^1.12.1",

aio/aio-builds-setup/dockerbuild/scripts-js/yarn.lock

@@ -69,9 +69,9 @@
     "@types/express-serve-static-core" "*"
     "@types/mime" "*"
 
-"@types/shelljs@^0.8.0":
-  version "0.8.0"
-  resolved "https://registry.yarnpkg.com/@types/shelljs/-/shelljs-0.8.0.tgz#0caa56b68baae4f68f44e0dd666ab30b098e3632"
+"@types/shelljs@^0.7.4":
+  version "0.7.4"
+  resolved "https://registry.yarnpkg.com/@types/shelljs/-/shelljs-0.7.4.tgz#137b5f31306eaff4de120ffe5b9d74b297809cfc"
   dependencies:
     "@types/glob" "*"
     "@types/node" "*"

aio/aio-builds-setup/scripts/update-preview-server.sh

@@ -3,7 +3,7 @@
 set -eux -o pipefail
 exec 3>&1
 
-echo -e "\n\n[`date`] - Updating the preview server..."
+echo "\n\n[`date`] - Updating the preview server..."
 
 # Input
 readonly HOST_REPO_DIR=$1

aio/content/examples/form-validation/src/app/shared/forbidden-name.directive.ts

@@ -5,7 +5,7 @@ import { AbstractControl, NG_VALIDATORS, Validator, ValidatorFn, Validators } fr
 // #docregion custom-validator
 /** A hero's name can't match the given regular expression */
 export function forbiddenNameValidator(nameRe: RegExp): ValidatorFn {
-  return (control: AbstractControl): {[key: string]: any} | null => {
+  return (control: AbstractControl): {[key: string]: any} => {
     const forbidden = nameRe.test(control.value);
     return forbidden ? {'forbiddenName': {value: control.value}} : null;
   };
@@ -22,7 +22,7 @@ export function forbiddenNameValidator(nameRe: RegExp): ValidatorFn {
 export class ForbiddenValidatorDirective implements Validator {
   @Input('appForbiddenName') forbiddenName: string;
 
-  validate(control: AbstractControl): {[key: string]: any} | null {
+  validate(control: AbstractControl): {[key: string]: any} {
     return this.forbiddenName ? forbiddenNameValidator(new RegExp(this.forbiddenName, 'i'))(control)
                               : null;
   }

aio/content/examples/router/src/app/compose-message.component.ts

@@ -15,7 +15,6 @@ export class ComposeMessageComponent {
   @HostBinding('style.position')  position = 'absolute';
 
   details: string;
-  message: string;
   sending = false;
 
   constructor(private router: Router) {}

aio/content/examples/toh-pt5/src/app/app.component.css

@@ -18,11 +18,11 @@ nav a {
   border-radius: 4px;
 }
 nav a:visited, a:link {
-  color: #607d8b;
+  color: #607D8B;
 }
 nav a:hover {
   color: #039be5;
-  background-color: #cfd8dc;
+  background-color: #CFD8DC;
 }
 nav a.active {
   color: #039be5;

aio/content/examples/toh-pt5/src/app/dashboard/dashboard.component.css

@@ -33,11 +33,11 @@ h4 {
   color: #eee;
   max-height: 120px;
   min-width: 120px;
-  background-color: #607d8b;
+  background-color: #607D8B;
   border-radius: 2px;
 }
 .module:hover {
-  background-color: #eee;
+  background-color: #EEE;
   cursor: pointer;
   color: #607d8b;
 }

aio/content/guide/dependency-injection.md

@@ -32,7 +32,7 @@ from the [The Tour of Heroes](tutorial/).
 </code-tabs>
 
 The `HeroesComponent` is the top-level heroes component.
-Its only purpose is to display the `HeroListComponent`
+It's only purpose is to display the `HeroListComponent`
 which displays a list of hero names.
 
 This version of the `HeroListComponent` gets its `heroes` from the `HEROES` array, an in-memory collection

aio/content/guide/frequent-ngmodules.md

@@ -44,25 +44,25 @@ of some of the things they contain:
  <tr>
    <td><code>FormsModule</code></td>
    <td><code>@angular/forms</code></td>
-   <td>When you want to build template driven forms (includes <code>NgModel</code>)</td>
+   <td>When you build template driven forms (includes <code>NgModel</code>)</td>
  </tr>
 
  <tr>
    <td><code>ReactiveFormsModule</code></td>
    <td><code>@angular/forms</code></td>
-   <td>When you want to build reactive forms</td>
+   <td>When building reactive forms</td>
  </tr>
 
  <tr>
    <td><code>RouterModule</code></td>
    <td><code>@angular/router</code></td>
-   <td>When you want to use <code>RouterLink</code>, <code>.forRoot()</code>, and <code>.forChild()</code></td>
+   <td>For Routing and when you want to use <code>RouterLink</code>,<code>.forRoot()</code>, and <code>.forChild()</code></td>
  </tr>
 
  <tr>
    <td><code>HttpClientModule</code></td>
    <td><code>@angular/common/http</code></td>
-   <td>When you want to talk to a server</td>
+   <td>When you to talk to a server</td>
  </tr>
 
 </table>

aio/content/guide/http.md

@@ -450,7 +450,7 @@ Here is a `searchHeroes` method that queries for heroes whose names contain the
 
 If there is a search term, the code constructs an options object with an HTML URL-encoded search parameter. If the term were "foo", the GET request URL would be `api/heroes/?name=foo`.
 
-The `HttpParams` are immutable so you'll have to use the `set()` method to update the options.
+The `HttpParms` are immutable so you'll have to use the `set()` method to update the options.
 
 ### Debouncing requests
 
@@ -1044,4 +1044,4 @@ Alternatively, you can call `request.error()` with an `ErrorEvent`.
   path="http/src/testing/http-client.spec.ts"
   region="network-error"
   linenums="false">
-</code-example>
+</code-example>

aio/content/guide/releases.md

@@ -74,58 +74,22 @@ The following table contains our current target release dates for the next two m
 
 
 {@a lts}
-{@a support}
-## Support policy
+## Long-term support
 
-All of our major releases are supported for 18 months. 
+All of our releases are supported actively for about 6 months (until the next major release), and then they are supported through long-term support (LTS) for another 12 months.
 
-* 6 months of active support, during which regularly-scheduled updates and patches are released, as described above in [Release frequency](#frequency "Release frequency").
+During the LTS period, only critical fixes and security patches will be merged and released.
 
-* 12 months of long-term support (LTS). During the LTS period, only critical fixes and security patches will be released.
+The LTS state of one major version starts on the day of the next major release. LTS status ends approximately one year later, when we release another major version. 
 
-The following table provides the support status and key dates for Angular version 4.0.0 and higher. 
 
-<style>
 
-    td, th {vertical-align: top}
+ Version     | LTS Start Date | LTS End Date
+ ----------- | -------------- | ------------
+ ^4.0.0      | October 2017   | October 2018
+ ^5.0.0      | April 2018     | April 2019
+ ^6.0.0      | October 2018   | October 2019
 
-</style>
-
-<table>
-
-    <tr>
-        <th>Version</th>
-        <th>Status</th>
-        <th>Release Date</th>
-        <th>LTS Start Date</th>
-        <th>LTS End Date</th>
-    </tr>
-
-    <tr>
-        <td>^4.0.0</td>
-        <td>LTS</td>
-        <td>March 23, 2017</td>
-        <td>September 23, 2017</td>
-        <td>September 23, 2018</td>
-    </tr>
-
-    <tr>
-        <td>^5.0.0</td>
-        <td>LTS</td>
-        <td>November 1, 2017</td>
-        <td>May 1, 2018</td>
-        <td>May 1, 2019</td>
-    </tr>
-
-    <tr>
-        <td>^6.0.0</td>
-        <td>Active</td>
-        <td>May 3, 2018</td>
-        <td>November 3, 2018</td>
-        <td>November 3, 2019</td>
-    </tr>
-
-</table>
 
 
 
@@ -142,7 +106,7 @@ To make these transitions as easy as possible, we make two commitments to you:
 
 To help ensure that you have sufficient time and a clear path to update, this is our deprecation policy:
 
-* We announce deprecated features in the [change log](https://github.com/angular/angular/blob/master/CHANGELOG.md "Angular change log").
+* When announce deprecated features in the [change log](https://github.com/angular/angular/blob/master/CHANGELOG.md "Angular change log").
 
 * When we announce a deprecation, we also announce a recommended update path.
 
@@ -163,6 +127,8 @@ Any changes to the public API surface will be done using the versioning, support
 {@a labs}
 ## Angular Labs
 
-Angular Labs is an initiative to cultivate new features and iterate on them quickly. Angular Labs provides a safe place for exploration and experimentation by the Angular team.
+Angular Labs is an initiative to cultivate new features and iterate on them quickly. Angular Labs provides a safe place for exploration and experimentation by the Angular team. 
 
-Angular Labs projects are not ready for production use, and no commitment is made to bring them to production. The policies and practices that are described in this document do not apply to Angular Labs projects.
+Angular Labs projects are not ready for production use, and no commitment is made to bring them to production. The policies and practices that are described in this document do not apply to Angular Labs projects. 
+
+Angular Labs projects typically are in separate branches in the Angular repo, clearly separated from the main Angular codebase. 

aio/content/guide/styleguide.md

@@ -933,18 +933,29 @@ As always, strive for consistency.
 
 <a href="#toc">Back to top</a>
 
-{@a 05-02}
+{@a 02-06}
 
-### Component selectors
+### Directive selectors
 
-#### Style 05-02
+#### Style 02-06
 
 
 <div class="s-rule do">
 
 
 
-**Do** use _dashed-case_ or _kebab-case_ for naming the element selectors of components.
+**Do** Use lower camel case for naming the selectors of directives.
+
+
+</div>
+
+
+
+<div class="s-why">
+
+
+
+**Why?** Keeps the names of the properties defined in the directives that are bound to the view consistent with the attribute names.
 
 
 </div>
@@ -955,40 +966,16 @@ As always, strive for consistency.
 
 
 
-**Why?** Keeps the element names consistent with the specification for [Custom Elements](https://www.w3.org/TR/custom-elements/).
+**Why?** The Angular HTML parser is case sensitive and recognizes lower camel case.
 
 
 </div>
 
-
-
-<code-example path="styleguide/src/05-02/app/heroes/shared/hero-button/hero-button.component.avoid.ts" region="example" title="app/heroes/shared/hero-button/hero-button.component.ts">
-
-</code-example>
-
-
-
-
-
-<code-tabs>
-
-  <code-pane title="app/heroes/shared/hero-button/hero-button.component.ts" path="styleguide/src/05-02/app/heroes/shared/hero-button/hero-button.component.ts" region="example">
-
-  </code-pane>
-
-  <code-pane title="app/app.component.html" path="styleguide/src/05-02/app/app.component.html">
-
-  </code-pane>
-
-</code-tabs>
-
-
-
 <a href="#toc">Back to top</a>
 
 {@a 02-07}
 
-### Component custom prefix
+### Custom prefix for components
 
 #### Style 02-07
 
@@ -1091,51 +1078,11 @@ For example, the prefix `toh` represents from **T**our **o**f **H**eroes and the
 
 
 
-<a href="#toc">Back to top</a>
 
-{@a 02-06}
-
-### Directive selectors
-
-#### Style 02-06
-
-
-<div class="s-rule do">
-
-
-
-**Do** Use lower camel case for naming the selectors of directives.
-
-
-</div>
-
-
-
-<div class="s-why">
-
-
-
-**Why?** Keeps the names of the properties defined in the directives that are bound to the view consistent with the attribute names.
-
-
-</div>
-
-
-
-<div class="s-why-last">
-
-
-
-**Why?** The Angular HTML parser is case sensitive and recognizes lower camel case.
-
-
-</div>
-
-<a href="#toc">Back to top</a>
 
 {@a 02-08}
 
-### Directive custom prefix
+### Custom prefix for directives
 
 #### Style 02-08
 
@@ -3109,9 +3056,9 @@ module are referenced across the entire application.
 
 
 
-**Consider** _not_ providing services in shared modules. Services are usually
+**Avoid** providing services in shared modules. Services are usually
 singletons that are provided once for the entire application or
-in a particular feature module. There are exceptions, however. For example, in the sample code that follows, notice that the `SharedModule` provides `FilterTextService`. This is acceptable here because the service is stateless;that is, the consumers of the service aren't impacted by new instances.
+in a particular feature module.
 
 
 </div>
@@ -3763,6 +3710,59 @@ A typical *lazy loaded folder* contains a *routing component*, its child compone
 
 ## Components
 
+{@a 05-02}
+
+### Component selector names
+
+#### Style 05-02
+
+
+<div class="s-rule do">
+
+
+
+**Do** use _dashed-case_ or _kebab-case_ for naming the element selectors of components.
+
+
+</div>
+
+
+
+<div class="s-why-last">
+
+
+
+**Why?** Keeps the element names consistent with the specification for [Custom Elements](https://www.w3.org/TR/custom-elements/).
+
+
+</div>
+
+
+
+<code-example path="styleguide/src/05-02/app/heroes/shared/hero-button/hero-button.component.avoid.ts" region="example" title="app/heroes/shared/hero-button/hero-button.component.ts">
+
+</code-example>
+
+
+
+
+
+<code-tabs>
+
+  <code-pane title="app/heroes/shared/hero-button/hero-button.component.ts" path="styleguide/src/05-02/app/heroes/shared/hero-button/hero-button.component.ts" region="example">
+
+  </code-pane>
+
+  <code-pane title="app/app.component.html" path="styleguide/src/05-02/app/app.component.html">
+
+  </code-pane>
+
+</code-tabs>
+
+
+
+<a href="#toc">Back to top</a>
+
 {@a 05-03}
 
 ### Components as elements

aio/content/guide/testing-observables.md

@@ -0,0 +1,3 @@
+# Testing
+
+TBD. Original content [here](https://docs.google.com/document/d/1gGP5sqWNCHAWWV_GLdZQ1XyMO4K-CHksUxux0BFtVxk/edit#heading=h.ohqykkhzdhb2).

aio/content/guide/testing.md

@@ -204,7 +204,8 @@ The test consumes that spy in the same way it did earlier.
 Most test suites in this guide call `beforeEach()` to set the preconditions for each `it()` test
 and rely on the `TestBed` to create classes and inject services.
 
-There's another school of testing that never calls `beforeEach()` and prefers to create classes explicitly rather than use the `TestBed`.
+There's another school of testing that never calls `beforeEach()` and
+and prefers to create classes explicitly rather than use the `TestBed`.
 
 Here's how you might rewrite one of the `MasterService` tests in that style.
 
@@ -346,7 +347,7 @@ It appears within the template of a parent component,
 which binds a _hero_ to the `@Input` property and
 listens for an event raised through the _selected_ `@Output` property.
 
-You can test that the class code works without creating the `DashboardHeroComponent`
+You can test that the class code works without creating the the `DashboardHeroComponent`
 or its parent component.
 
 <code-example 
@@ -398,7 +399,7 @@ But a component is more than just its class.
 A component interacts with the DOM and with other components.
 The _class-only_ tests can tell you about class behavior.
 They cannot tell you if the component is going to render properly,
-respond to user input and gestures, or integrate with its parent and child components.
+respond to user input and gestures, or integrate with its parent and and child components.
 
 None of the _class-only_ tests above can answer key questions about how the
 components actually behave on screen.
@@ -2366,9 +2367,9 @@ The [override metadata object](#metadata-override-object) is a generic defined a
 
 <code-example format="." language="javascript">
   type MetadataOverride<T> = {
-    add?: Partial<T>;
-    remove?: Partial<T>;
-    set?: Partial<T>;
+    add?: T;
+    remove?: T;
+    set?: T;
   };
 </code-example>
 
@@ -2724,9 +2725,9 @@ appropriate to the method, that is, the parameter of an `@NgModule`,
 
 <code-example format="." language="javascript">
   type MetadataOverride<T> = {
-    add?: Partial<T>;
-    remove?: Partial<T>;
-    set?: Partial<T>;
+    add?: T;
+    remove?: T;
+    set?: T;
   };
 </code-example>
 
@@ -3378,11 +3379,11 @@ next to their corresponding helper files.
 {@a q-e2e}
 #### Why not rely on E2E tests of DOM integration?
 
-The component DOM tests described in this guide often require extensive setup and 
-advanced techniques whereas the [unit tests](#component-class-testing)
-are comparatively simple.
+The component DOM tests describe in this guide often require extensive setup and 
+advanced techniques where as the [class-only test](#component-class-testing)
+were comparatively simple.
 
-#### Why not defer DOM integration tests to end-to-end (E2E) testing?
+Why not defer DOM integration tests to end-to-end (E2E) testing?
 
 E2E tests are great for high-level validation of the entire system.
 But they can't give you the comprehensive test coverage that you'd expect from unit tests.
@@ -3399,4 +3400,4 @@ accidental corruption of remote resources.
 It can even be hard to navigate to the component you want to test.
 
 Because of these many obstacles, you should test DOM interaction
-with unit testing techniques as much as possible.
+with unit testing techniques as much as possible.

aio/content/marketing/announcements.json

@@ -12,19 +12,5 @@
     "message": "Watch ng-conf live stream <br/>Apr 18th-20th, 2018",
     "imageUrl": "generated/images/marketing/home/ng-conf.png",
     "linkUrl": "https://www.ng-conf.org/livestream/"
-  },
-  {
-    "startDate": "2018-06-01",
-    "endDate": "2018-08-15",
-    "message": "Join us for Angular Mix<br/>October 10th-12th, 2018",
-    "imageUrl": "generated/images/marketing/home/angular-mix.png",
-    "linkUrl": "https://angularmix.com/"
-  },
-  {
-    "startDate": "2018-08-15",
-    "endDate": "2018-11-06",
-    "message": "Join us for Angular Connect<br/>November 6th-7th, 2018",
-    "imageUrl": "generated/images/marketing/home/angular-connect.png",
-    "linkUrl": "https://angularconnect.com/"
   }
 ]

aio/content/marketing/contributors.json

@@ -618,32 +618,5 @@
     "website": "https://mhartington.io",
     "bio": "Mike is a Developer Advocate for the Ionic Framework and a GDE in Angular. He spends most of his time making fast PWAs and exploring emerging web standards. When not behind a keyboard, you'll probably find him with a guitar and beer.",
     "group": "GDE"
-  },
-
-  "juristr": {
-    "name": "Juri Strumpflohner",
-    "picture": "juristr.jpg",
-    "twitter": "juristr",
-    "website": "https://juristr.com",
-    "bio": "Juri is a software engineer and freelance trainer and consultant currently mostly focusing on the frontend side using JavaScript, TypeScript and Angular. He has a passion for teaching and sharing his knowledge and experiences with others. This mostly happens by writing tech articles for his personal blog, by creating video courses for Egghead.io, during on-site workshops at companies or by speaking at conferences. In his free time he enjoys practicing Yoseikan Budo, a martial art where he currently owns the 3rd DAN black belt.",
-    "group": "GDE"
-  },
-
-  "mashhoodr": {
-    "name": "Mashhood Rastgar",
-    "picture": "mashhood.jpg",
-    "twitter": "mashhoodr",
-    "website": "http://imars.info/",
-    "bio": "Mashhood is the principal technical consultant at Recurship and a Google Developer Expert. He  works with different startups in US and EU to helps them crawl through the technical maze and quickly build amazing products focused around the problems they are trying to solve. He specializes in using the latest web technologies available to execute the best possible solutions.",
-    "group": "GDE"
-  },
-
-  "kimmaida": {
-    "name": "Kim Maida",
-    "picture": "kimmaida.jpg",
-    "twitter": "KimMaida",
-    "website": "https://kmaida.io/",
-    "bio": "Kim is an an Angular consultant, developer, speaker, writer, and Google Developer Expert. She is passionate about learning from and sharing knowledge with other developers through blogging, speaking, workshops, and open source.",
-    "group": "GDE"
   }
 }

aio/content/marketing/resources.json

@@ -160,7 +160,7 @@
             "desc": "Lightweight yet powerful IDE, perfectly equipped for complex client-side development and server-side development with Node.js",
             "logo": "",
             "rev": true,
-            "title": "WebStorm",
+            "title": "Webstorm",
             "url": "https://www.jetbrains.com/webstorm/"
           },
           "ab3": {
@@ -175,13 +175,7 @@
             "rev": true,
             "title": "Angular IDE by Webclipse",
             "url": "https://www.genuitec.com/products/angular-ide"
-          },
-          "amexio-canvas": {
-             "desc": "Amexio Canvas is Drag and Drop Environment to create Fully Responsive Web and Smart Device HTML5/Angular Apps. Code will be auto generated and hot deployed by the Canvas for live testing. Out of the box 50+ Material Design Theme support. Commit your code to GitHub public or private repository.",
-            "rev": true,
-            "title": "Amexio Canvas Web Based Drag and Drop IDE by MetaMagic",
-            "url": "https://amexio.tech/"
-          }	
+          }
         }
       },
       "Tooling": {
@@ -351,13 +345,6 @@
             "title": "Angular Material",
             "url": "https://github.com/angular/material2"
           },
-          "mcc": {
-            "desc": "Material components made by the community",
-            "logo": "",
-            "rev": true,
-            "title": "Material Community Components",
-            "url": "https://github.com/tiaguinho/material-community-components"
-          },
           "ngzorro": {
             "desc": "A set of enterprise-class UI components based on Ant Design and Angular",
             "rev": true,
@@ -383,13 +370,6 @@
             "url": "http://www.amexio.tech/",
             "logo": "http://www.amexio.org/amexio-logo.png"
           },
-          "bm": {
-            "desc": "A lightweight Material Design library for Angular, based upon Google's Material Components for the Web",
-            "logo": "https://blox.src.zone/assets/bloxmaterial.03ecfe4fa0147a781487749dc1cc4580.svg",
-            "rev": true,
-            "title": "Blox Material",
-            "url": "https://github.com/src-zone/material"
-          },
           "essentialjs2": {
             "desc": "Essential JS 2 for Angular is a collection modern TypeScript based true Angular Components. It has support for Ahead Of Time (AOT) compilation and Tree-Shaking. All the components are developed from the ground up to be lightweight, responsive, modular and touch friendly.",
             "rev": true,
@@ -548,6 +528,13 @@
             "title": "Pluralsight",
             "url": "https://www.pluralsight.com/search?q=angular+2&categories=all"
           },
+          "ab": {
+            "desc": "Take this introduction to Angular course, to learn the fundamentals in just two days, free of charge.",
+            "logo": "",
+            "rev": true,
+            "title": "Rangle.io",
+            "url": "https://rangle.io/services/javascript-training/training-angular1-angular2-with-ngupgrade/"
+          },
           "ab3": {
             "desc": "Angular courses hosted by  Udemy",
             "logo": "",

aio/content/tutorial/toh-pt1.md

@@ -175,7 +175,7 @@ This information is called _metadata_
 Some of the metadata is in the `@Component` decorators that you added to your component classes.
 Other critical metadata is in [`@NgModule`](guide/ngmodules) decorators.
 
-The most important `@NgModule` decorator annotates the top-level **AppModule** class.
+The most important `@NgModule`decorator annotates the top-level **AppModule** class.
 
 The Angular CLI generated an `AppModule` class in `src/app/app.module.ts` when it created the project.
 This is where you _opt-in_ to the `FormsModule`.

aio/scripts/_payload-limits.json

@@ -2,11 +2,11 @@
   "aio": {
     "master": {
       "uncompressed": {
-        "runtime": 2768,
-        "main": 475855,
+        "runtime": 2689,
+        "main": 478529,
         "polyfills": 38453,
         "prettify": 14913
       }
     }
   }
-}
+}

aio/src/app/app.component.html

@@ -58,7 +58,7 @@
 </mat-sidenav-container>
 
 <div *ngIf="hasFloatingToc" class="toc-container no-print" [style.max-height.px]="tocMaxHeight" (mousewheel)="restrainScrolling($event)">
-  <aio-lazy-ce selector="aio-toc"></aio-lazy-ce>
+  <aio-toc></aio-toc>
 </div>
 
 <footer class="no-print">

aio/src/app/app.component.spec.ts

@@ -6,7 +6,7 @@ import { HttpClient } from '@angular/common/http';
 import { MatProgressBar, MatSidenav } from '@angular/material';
 import { By } from '@angular/platform-browser';
 
-import { of, timer } from 'rxjs';
+import { timer } from 'rxjs';
 import { first, mapTo } from 'rxjs/operators';
 
 import { AppComponent } from './app.component';
@@ -14,7 +14,6 @@ import { AppModule } from './app.module';
 import { DocumentService } from 'app/documents/document.service';
 import { DocViewerComponent } from 'app/layout/doc-viewer/doc-viewer.component';
 import { Deployment } from 'app/shared/deployment.service';
-import { ElementsLoader } from 'app/custom-elements/elements-loader';
 import { GaService } from 'app/shared/ga.service';
 import { LocationService } from 'app/shared/location.service';
 import { Logger } from 'app/shared/logger.service';
@@ -27,6 +26,7 @@ import { SearchBoxComponent } from 'app/search/search-box/search-box.component';
 import { SearchResultsComponent } from 'app/shared/search-results/search-results.component';
 import { SearchService } from 'app/search/search.service';
 import { SelectComponent } from 'app/shared/select/select.component';
+import { TocComponent } from 'app/layout/toc/toc.component';
 import { TocItem, TocService } from 'app/shared/toc.service';
 
 const sideBySideBreakPoint = 992;
@@ -92,11 +92,11 @@ describe('AppComponent', () => {
     });
 
     describe('hasFloatingToc', () => {
-      it('should initially be false', () => {
+      it('should initially be true', () => {
         const fixture2 = TestBed.createComponent(AppComponent);
         const component2 = fixture2.componentInstance;
 
-        expect(component2.hasFloatingToc).toBe(false);
+        expect(component2.hasFloatingToc).toBe(true);
       });
 
       it('should be false on narrow screens', () => {
@@ -621,65 +621,55 @@ describe('AppComponent', () => {
     });
 
     describe('aio-toc', () => {
-      let tocContainer: HTMLElement|null;
-      let toc: HTMLElement|null;
+      let tocDebugElement: DebugElement;
+      let tocContainer: DebugElement|null;
 
       const setHasFloatingToc = (hasFloatingToc: boolean) => {
         component.hasFloatingToc = hasFloatingToc;
         fixture.detectChanges();
 
-        tocContainer = fixture.debugElement.nativeElement.querySelector('.toc-container');
-        toc = tocContainer && tocContainer.querySelector('aio-toc');
+        tocDebugElement = fixture.debugElement.query(By.directive(TocComponent));
+        tocContainer = tocDebugElement && tocDebugElement.parent;
       };
 
+      beforeEach(() => setHasFloatingToc(true));
+
 
       it('should show/hide `<aio-toc>` based on `hasFloatingToc`', () => {
-        expect(tocContainer).toBeFalsy();
-        expect(toc).toBeFalsy();
-
-        setHasFloatingToc(true);
+        expect(tocDebugElement).toBeTruthy();
         expect(tocContainer).toBeTruthy();
-        expect(toc).toBeTruthy();
 
         setHasFloatingToc(false);
+        expect(tocDebugElement).toBeFalsy();
         expect(tocContainer).toBeFalsy();
-        expect(toc).toBeFalsy();
+
+        setHasFloatingToc(true);
+        expect(tocDebugElement).toBeTruthy();
+        expect(tocContainer).toBeTruthy();
       });
 
       it('should have a non-embedded `<aio-toc>` element', () => {
-        setHasFloatingToc(true);
-        expect(toc!.classList.contains('embedded')).toBe(false);
+        expect(tocDebugElement.classes['embedded']).toBeFalsy();
       });
 
       it('should update the TOC container\'s `maxHeight` based on `tocMaxHeight`', () => {
-        setHasFloatingToc(true);
-
-        expect(tocContainer!.style['max-height']).toBe('');
+        expect(tocContainer!.styles['max-height']).toBeNull();
 
         component.tocMaxHeight = '100';
         fixture.detectChanges();
 
-        expect(tocContainer!.style['max-height']).toBe('100px');
+        expect(tocContainer!.styles['max-height']).toBe('100px');
       });
 
       it('should restrain scrolling inside the ToC container', () => {
         const restrainScrolling = spyOn(component, 'restrainScrolling');
-        const evt = new MouseEvent('mousewheel');
+        const evt = {};
 
-        setHasFloatingToc(true);
         expect(restrainScrolling).not.toHaveBeenCalled();
 
-        tocContainer!.dispatchEvent(evt);
+        tocContainer!.triggerEventHandler('mousewheel', evt);
         expect(restrainScrolling).toHaveBeenCalledWith(evt);
       });
-
-      it('should not be loaded/registered until necessary', () => {
-        const loader: TestElementsLoader = fixture.debugElement.injector.get(ElementsLoader);
-        expect(loader.loadCustomElement).not.toHaveBeenCalled();
-
-        setHasFloatingToc(true);
-        expect(loader.loadCustomElement).toHaveBeenCalledWith('aio-toc');
-      });
     });
 
     describe('footer', () => {
@@ -1290,7 +1280,6 @@ function createTestingModule(initialUrl: string, mode: string = 'stable') {
     imports: [ AppModule ],
     providers: [
       { provide: APP_BASE_HREF, useValue: '/' },
-      { provide: ElementsLoader, useClass: TestElementsLoader },
       { provide: GaService, useClass: TestGaService },
       { provide: HttpClient, useClass: TestHttpClient },
       { provide: LocationService, useFactory: () => mockLocationService },
@@ -1305,14 +1294,6 @@ function createTestingModule(initialUrl: string, mode: string = 'stable') {
   });
 }
 
-class TestElementsLoader {
-  loadContainedCustomElements = jasmine.createSpy('loadContainedCustomElements')
-      .and.returnValue(of(undefined));
-
-  loadCustomElement = jasmine.createSpy('loadCustomElement')
-      .and.returnValue(Promise.resolve());
-}
-
 class TestGaService {
   locationChanged = jasmine.createSpy('locationChanged');
 }
@@ -1387,7 +1368,7 @@ class TestHttpClient {
       const id = match[1]!;
       // Make up a title for test purposes
       const title = id.split('/').pop()!.replace(/^([a-z])/, (_, letter) => letter.toUpperCase());
-      const h1 = (id === 'no-title') ? '' : `<h1 class="no-toc">${title}</h1>`;
+      const h1 = (id === 'no-title') ? '' : `<h1>${title}</h1>`;
       const contents = `${h1}<h2 id="#somewhere">Some heading</h2>`;
       data = { id, contents };
     }

aio/src/app/app.component.ts

@@ -69,7 +69,7 @@ export class AppComponent implements OnInit {
   topMenuNodes: NavigationNode[];
   topMenuNarrowNodes: NavigationNode[];
 
-  hasFloatingToc = false;
+  hasFloatingToc = true;
   private showFloatingToc = new BehaviorSubject(false);
   private showFloatingTocWidth = 800;
   tocMaxHeight: string;

aio/src/app/app.module.ts

@@ -32,6 +32,7 @@ import { ScrollService } from 'app/shared/scroll.service';
 import { ScrollSpyService } from 'app/shared/scroll-spy.service';
 import { SearchBoxComponent } from 'app/search/search-box/search-box.component';
 import { NotificationComponent } from 'app/layout/notification/notification.component';
+import { TocComponent } from 'app/layout/toc/toc.component';
 import { TocService } from 'app/shared/toc.service';
 import { CurrentDateToken, currentDateProvider } from 'app/shared/current-date';
 import { WindowToken, windowProvider } from 'app/shared/window';
@@ -110,6 +111,7 @@ export const svgIconProviders = [
     NavItemComponent,
     SearchBoxComponent,
     NotificationComponent,
+    TocComponent,
     TopMenuComponent,
   ],
   providers: [
@@ -131,6 +133,7 @@ export const svgIconProviders = [
     { provide: CurrentDateToken, useFactory: currentDateProvider },
     { provide: WindowToken, useFactory: windowProvider },
   ],
+  entryComponents: [ TocComponent ],
   bootstrap: [ AppComponent ]
 })
 export class AppModule { }

aio/src/app/custom-elements/code/code-tabs.component.ts

@@ -25,22 +25,20 @@ export interface TabInfo {
     <!-- Use content projection so that the provided HTML's code-panes can be split into tabs -->
     <div #content style="display: none"><ng-content></ng-content></div>
 
-    <mat-card>
-      <mat-tab-group class="code-tab-group" disableRipple>
-        <mat-tab style="overflow-y: hidden;" *ngFor="let tab of tabs">
-          <ng-template mat-tab-label>
-            <span class="{{ tab.class }}">{{ tab.title }}</span>
-          </ng-template>
-          <aio-code class="{{ tab.class }}"
-                    [language]="tab.language"
-                    [linenums]="tab.linenums"
-                    [path]="tab.path"
-                    [region]="tab.region"
-                    [title]="tab.title">
-          </aio-code>
-        </mat-tab>
-      </mat-tab-group>
-    </mat-card>
+    <mat-tab-group class="code-tab-group" disableRipple>
+      <mat-tab style="overflow-y: hidden;" *ngFor="let tab of tabs">
+        <ng-template mat-tab-label>
+          <span class="{{ tab.class }}">{{ tab.title }}</span>
+        </ng-template>
+        <aio-code class="{{ tab.class }}"
+                  [language]="tab.language"
+                  [linenums]="tab.linenums"
+                  [path]="tab.path"
+                  [region]="tab.region"
+                  [title]="tab.title">
+        </aio-code>
+      </mat-tab>
+    </mat-tab-group>
   `,
 })
 export class CodeTabsComponent implements OnInit, AfterViewInit {

aio/src/app/custom-elements/code/code-tabs.module.ts

@@ -1,12 +1,12 @@
 import { NgModule, Type } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { CodeTabsComponent } from './code-tabs.component';
-import { MatCardModule, MatTabsModule } from '@angular/material';
+import { MatTabsModule } from '@angular/material';
 import { CodeModule } from './code.module';
 import { WithCustomElementComponent } from '../element-registry';
 
 @NgModule({
-  imports: [ CommonModule, MatCardModule, MatTabsModule, CodeModule ],
+  imports: [ CommonModule, MatTabsModule, CodeModule ],
   declarations: [ CodeTabsComponent ],
   exports: [ CodeTabsComponent ],
   entryComponents: [ CodeTabsComponent ]

aio/src/app/custom-elements/custom-elements.module.ts

@@ -6,11 +6,8 @@ import {
   ELEMENT_MODULE_PATHS_AS_ROUTES,
   ELEMENT_MODULE_PATHS_TOKEN
 } from './element-registry';
-import { LazyCustomElementComponent } from './lazy-custom-element.component';
 
 @NgModule({
-  declarations: [ LazyCustomElementComponent ],
-  exports: [ LazyCustomElementComponent ],
   providers: [
     ElementsLoader,
     { provide: NgModuleFactoryLoader, useClass: SystemJsNgModuleLoader },

aio/src/app/custom-elements/element-registry.ts

@@ -13,8 +13,8 @@ export const ELEMENT_MODULE_PATHS_AS_ROUTES = [
     loadChildren: './api/api-list.module#ApiListModule'
   },
   {
-    selector: 'aio-contributor-list',
-    loadChildren: './contributor/contributor-list.module#ContributorListModule'
+    selector: 'live-example',
+    loadChildren: './live-example/live-example.module#LiveExampleModule'
   },
   {
     selector: 'aio-file-not-found-search',
@@ -25,29 +25,25 @@ export const ELEMENT_MODULE_PATHS_AS_ROUTES = [
     loadChildren: './resource/resource-list.module#ResourceListModule'
   },
   {
-    selector: 'aio-toc',
-    loadChildren: './toc/toc.module#TocModule'
+    selector: 'current-location',
+    loadChildren: './current-location/current-location.module#CurrentLocationModule'
   },
   {
-    selector: 'code-example',
-    loadChildren: './code/code-example.module#CodeExampleModule'
+    selector: 'aio-contributor-list',
+    loadChildren: './contributor/contributor-list.module#ContributorListModule'
   },
   {
     selector: 'code-tabs',
     loadChildren: './code/code-tabs.module#CodeTabsModule'
   },
   {
-    selector: 'current-location',
-    loadChildren: './current-location/current-location.module#CurrentLocationModule'
+    selector: 'code-example',
+    loadChildren: './code/code-example.module#CodeExampleModule'
   },
   {
     selector: 'expandable-section',
     loadChildren: './expandable-section/expandable-section.module#ExpandableSectionModule'
-  },
-  {
-    selector: 'live-example',
-    loadChildren: './live-example/live-example.module#LiveExampleModule'
-  },
+  }
 ];
 
 /**

aio/src/app/custom-elements/elements-loader.spec.ts

@@ -4,19 +4,49 @@ import {
   NgModuleRef,
   Type
 } from '@angular/core';
-import { TestBed, fakeAsync, flushMicrotasks } from '@angular/core/testing';
+import {TestBed, fakeAsync, tick} from '@angular/core/testing';
 
 import { ElementsLoader } from './elements-loader';
 import { ELEMENT_MODULE_PATHS_TOKEN, WithCustomElementComponent } from './element-registry';
 
+class FakeComponentFactory extends ComponentFactory<any> {
+  selector: string;
+  componentType: Type<any>;
+  ngContentSelectors: string[];
+  inputs = [{propName: this.identifyingInput, templateName: this.identifyingInput}];
+  outputs = [];
 
-interface Deferred {
-  resolve(): void;
-  reject(err: any): void;
+  constructor(private identifyingInput: string) { super(); }
+
+  create(injector: Injector,
+         projectableNodes?: any[][],
+         rootSelectorOrNode?: string | any,
+         ngModule?: NgModuleRef<any>): ComponentRef<any> {
+    return (jasmine.createSpy('ComponentRef') as any) as ComponentRef<any>;
+  };
 }
 
+const FAKE_COMPONENT_FACTORIES = new Map([
+  ['element-a-module-path', new FakeComponentFactory('element-a-input')],
+  ['element-b-module-path', new FakeComponentFactory('element-b-input')],
+]);
+
 describe('ElementsLoader', () => {
   let elementsLoader: ElementsLoader;
+  let actualCustomElementsDefine;
+  let fakeCustomElementsDefine;
+
+  // ElementsLoader uses the window's customElements API. Provide a fake for this test.
+  beforeEach(() => {
+    actualCustomElementsDefine = window.customElements.define;
+
+    fakeCustomElementsDefine = jasmine.createSpy('define');
+
+    window.customElements.define = fakeCustomElementsDefine;
+  });
+  afterEach(() => {
+    window.customElements.define = actualCustomElementsDefine;
+  });
 
   beforeEach(() => {
     const injector = TestBed.configureTestingModule({
@@ -33,196 +63,63 @@ describe('ElementsLoader', () => {
     elementsLoader = injector.get(ElementsLoader);
   });
 
-  describe('loadContainedCustomElements()', () => {
-    let loadCustomElementSpy: jasmine.Spy;
+  it('should be able to register an element', fakeAsync(() => {
+    // Verify that the elements loader considered `element-a-selector` to be unregistered.
+    expect(elementsLoader.elementsToLoad.has('element-a-selector')).toBeTruthy();
 
-    beforeEach(() => loadCustomElementSpy = spyOn(elementsLoader, 'loadCustomElement'));
+    const hostEl = document.createElement('div');
+    hostEl.innerHTML = `<element-a-selector></element-a-selector>`;
 
-    it('should attempt to load and register all contained elements', fakeAsync(() => {
-      expect(loadCustomElementSpy).not.toHaveBeenCalled();
+    elementsLoader.loadContainingCustomElements(hostEl);
+    tick();
 
-      const hostEl = document.createElement('div');
-      hostEl.innerHTML = `
-        <element-a-selector></element-a-selector>
-        <element-b-selector></element-b-selector>
-      `;
+    const defineArgs = fakeCustomElementsDefine.calls.argsFor(0);
+    expect(defineArgs[0]).toBe('element-a-selector');
 
-      elementsLoader.loadContainedCustomElements(hostEl);
-      flushMicrotasks();
+    // Verify the right component was loaded/created
+    expect(defineArgs[1].observedAttributes[0]).toBe('element-a-input');
 
-      expect(loadCustomElementSpy).toHaveBeenCalledTimes(2);
-      expect(loadCustomElementSpy).toHaveBeenCalledWith('element-a-selector');
-      expect(loadCustomElementSpy).toHaveBeenCalledWith('element-b-selector');
-    }));
+    expect(elementsLoader.elementsToLoad.has('element-a-selector')).toBeFalsy();
+  }));
 
-    it('should attempt to load and register only contained elements', fakeAsync(() => {
-      expect(loadCustomElementSpy).not.toHaveBeenCalled();
+  it('should be able to register multiple elements', fakeAsync(() => {
+    // Verify that the elements loader considered `element-a-selector` to be unregistered.
+    expect(elementsLoader.elementsToLoad.has('element-a-selector')).toBeTruthy();
 
-      const hostEl = document.createElement('div');
-      hostEl.innerHTML = `
-        <element-b-selector></element-b-selector>
-      `;
+    const hostEl = document.createElement('div');
+    hostEl.innerHTML = `
+      <element-a-selector></element-a-selector>
+      <element-b-selector></element-b-selector>
+    `;
 
-      elementsLoader.loadContainedCustomElements(hostEl);
-      flushMicrotasks();
+    elementsLoader.loadContainingCustomElements(hostEl);
+    tick();
 
-      expect(loadCustomElementSpy).toHaveBeenCalledTimes(1);
-      expect(loadCustomElementSpy).toHaveBeenCalledWith('element-b-selector');
-    }));
+    const defineElementA = fakeCustomElementsDefine.calls.argsFor(0);
+    expect(defineElementA[0]).toBe('element-a-selector');
+    expect(defineElementA[1].observedAttributes[0]).toBe('element-a-input');
+    expect(elementsLoader.elementsToLoad.has('element-a-selector')).toBeFalsy();
 
-    it('should wait for all contained elements to load and register', fakeAsync(() => {
-      const deferreds = returnPromisesFromSpy(loadCustomElementSpy);
+    const defineElementB = fakeCustomElementsDefine.calls.argsFor(1);
+    expect(defineElementB[0]).toBe('element-b-selector');
+    expect(defineElementB[1].observedAttributes[0]).toBe('element-b-input');
+    expect(elementsLoader.elementsToLoad.has('element-b-selector')).toBeFalsy();
+  }));
 
-      const hostEl = document.createElement('div');
-      hostEl.innerHTML = `
-        <element-a-selector></element-a-selector>
-        <element-b-selector></element-b-selector>
-      `;
+  it('should only register an element one time', fakeAsync(() => {
+    const hostEl = document.createElement('div');
+    hostEl.innerHTML = `<element-a-selector></element-a-selector>`;
 
-      const log: any[] = [];
-      elementsLoader.loadContainedCustomElements(hostEl).subscribe(
-        v => log.push(`emitted: ${v}`),
-        e => log.push(`errored: ${e}`),
-        () => log.push('completed'),
-      );
+    elementsLoader.loadContainingCustomElements(hostEl);
+    tick(); // Tick for the module factory loader's async `load` function
 
-      flushMicrotasks();
-      expect(log).toEqual([]);
+    // Call again to to check how many times customElements.define was called.
+    elementsLoader.loadContainingCustomElements(hostEl);
+    tick(); // Tick for the module factory loader's async `load` function
 
-      deferreds[0].resolve();
-      flushMicrotasks();
-      expect(log).toEqual([]);
-
-      deferreds[1].resolve();
-      flushMicrotasks();
-      expect(log).toEqual(['emitted: undefined', 'completed']);
-    }));
-
-    it('should fail if any of the contained elements fails to load and register', fakeAsync(() => {
-      const deferreds = returnPromisesFromSpy(loadCustomElementSpy);
-
-      const hostEl = document.createElement('div');
-      hostEl.innerHTML = `
-        <element-a-selector></element-a-selector>
-        <element-b-selector></element-b-selector>
-      `;
-
-      const log: any[] = [];
-      elementsLoader.loadContainedCustomElements(hostEl).subscribe(
-        v => log.push(`emitted: ${v}`),
-        e => log.push(`errored: ${e}`),
-        () => log.push('completed'),
-      );
-
-      flushMicrotasks();
-      expect(log).toEqual([]);
-
-      deferreds[0].resolve();
-      flushMicrotasks();
-      expect(log).toEqual([]);
-
-      deferreds[1].reject('foo');
-      flushMicrotasks();
-      expect(log).toEqual(['errored: foo']);
-    }));
-  });
-
-  describe('loadCustomElement()', () => {
-    let definedSpy: jasmine.Spy;
-    let whenDefinedSpy: jasmine.Spy;
-    let whenDefinedDeferreds: Deferred[];
-
-    beforeEach(() => {
-      // `loadCustomElement()` uses the `window.customElements` API. Provide mocks for these tests.
-      definedSpy = spyOn(window.customElements, 'define');
-      whenDefinedSpy = spyOn(window.customElements, 'whenDefined');
-      whenDefinedDeferreds = returnPromisesFromSpy(whenDefinedSpy);
-    });
-
-    it('should be able to load and register an element', fakeAsync(() => {
-      elementsLoader.loadCustomElement('element-a-selector');
-      flushMicrotasks();
-
-      expect(definedSpy).toHaveBeenCalledTimes(1);
-      expect(definedSpy).toHaveBeenCalledWith('element-a-selector', jasmine.any(Function));
-
-      // Verify the right component was loaded/registered.
-      const Ctor = definedSpy.calls.argsFor(0)[1];
-      expect(Ctor.observedAttributes).toEqual(['element-a-module-path']);
-    }));
-
-    it('should wait until the element is defined', fakeAsync(() => {
-      let state = 'pending';
-      elementsLoader.loadCustomElement('element-b-selector').then(() => state = 'resolved');
-      flushMicrotasks();
-
-      expect(state).toBe('pending');
-      expect(whenDefinedSpy).toHaveBeenCalledTimes(1);
-      expect(whenDefinedSpy).toHaveBeenCalledWith('element-b-selector');
-
-      whenDefinedDeferreds[0].resolve();
-      flushMicrotasks();
-      expect(state).toBe('resolved');
-    }));
-
-    it('should not load and register the same element more than once', fakeAsync(() => {
-      elementsLoader.loadCustomElement('element-a-selector');
-      flushMicrotasks();
-      expect(definedSpy).toHaveBeenCalledTimes(1);
-
-      definedSpy.calls.reset();
-
-      // While loading/registering is still in progress:
-      elementsLoader.loadCustomElement('element-a-selector');
-      flushMicrotasks();
-      expect(definedSpy).not.toHaveBeenCalled();
-
-      definedSpy.calls.reset();
-      whenDefinedDeferreds[0].resolve();
-
-      // Once loading/registering is already completed:
-      let state = 'pending';
-      elementsLoader.loadCustomElement('element-a-selector').then(() => state = 'resolved');
-      flushMicrotasks();
-      expect(state).toBe('resolved');
-      expect(definedSpy).not.toHaveBeenCalled();
-    }));
-
-    it('should fail if defining the the custom element fails', fakeAsync(() => {
-      let state = 'pending';
-      elementsLoader.loadCustomElement('element-b-selector').catch(e => state = `rejected: ${e}`);
-      flushMicrotasks();
-      expect(state).toBe('pending');
-
-      whenDefinedDeferreds[0].reject('foo');
-      flushMicrotasks();
-      expect(state).toBe('rejected: foo');
-    }));
-
-    it('should be able to load and register an element again if previous attempt failed',
-      fakeAsync(() => {
-        elementsLoader.loadCustomElement('element-a-selector');
-        flushMicrotasks();
-        expect(definedSpy).toHaveBeenCalledTimes(1);
-
-        definedSpy.calls.reset();
-
-        // While loading/registering is still in progress:
-        elementsLoader.loadCustomElement('element-a-selector').catch(() => undefined);
-        flushMicrotasks();
-        expect(definedSpy).not.toHaveBeenCalled();
-
-        whenDefinedDeferreds[0].reject('foo');
-        flushMicrotasks();
-        expect(definedSpy).not.toHaveBeenCalled();
-
-        // Once loading/registering has already failed:
-        elementsLoader.loadCustomElement('element-a-selector');
-        flushMicrotasks();
-        expect(definedSpy).toHaveBeenCalledTimes(1);
-      })
-    );
-  });
+    // Should have only been called once, since the second load would not query for element-a
+    expect(window.customElements.define).toHaveBeenCalledTimes(1);
+  }));
 });
 
 // TEST CLASSES/HELPERS
@@ -231,28 +128,11 @@ class FakeCustomElementModule implements WithCustomElementComponent {
   customElementComponent: Type<any>;
 }
 
-class FakeComponentFactory extends ComponentFactory<any> {
-  selector: string;
-  componentType: Type<any>;
-  ngContentSelectors: string[];
-  inputs = [{propName: this.identifyingInput, templateName: this.identifyingInput}];
-  outputs = [];
-
-  constructor(private identifyingInput: string) { super(); }
-
-  create(injector: Injector,
-         projectableNodes?: any[][],
-         rootSelectorOrNode?: string | any,
-         ngModule?: NgModuleRef<any>): ComponentRef<any> {
-    return jasmine.createSpy('ComponentRef') as any;
-  };
-}
-
 class FakeComponentFactoryResolver extends ComponentFactoryResolver {
   constructor(private modulePath) { super(); }
 
   resolveComponentFactory(component: Type<any>): ComponentFactory<any> {
-    return new FakeComponentFactory(this.modulePath);
+    return FAKE_COMPONENT_FACTORIES.get(this.modulePath)!;
   }
 }
 
@@ -288,9 +168,3 @@ class FakeModuleFactoryLoader extends NgModuleFactoryLoader {
     return Promise.resolve(fakeModuleFactory);
   }
 }
-
-function returnPromisesFromSpy(spy: jasmine.Spy): Deferred[] {
-  const deferreds: Deferred[] = [];
-  spy.and.callFake(() => new Promise((resolve, reject) => deferreds.push({resolve, reject})));
-  return deferreds;
-}

aio/src/app/custom-elements/elements-loader.ts

@@ -11,13 +11,11 @@ import { createCustomElement } from '@angular/elements';
 @Injectable()
 export class ElementsLoader {
   /** Map of unregistered custom elements and their respective module paths to load. */
-  private elementsToLoad: Map<string, string>;
-  /** Map of custom elements that are in the process of being loaded and registered. */
-  private elementsLoading = new Map<string, Promise<void>>();
+  elementsToLoad: Map<string, string>;
 
   constructor(private moduleFactoryLoader: NgModuleFactoryLoader,
               private moduleRef: NgModuleRef<any>,
-              @Inject(ELEMENT_MODULE_PATHS_TOKEN) elementModulePaths: Map<string, string>) {
+              @Inject(ELEMENT_MODULE_PATHS_TOKEN) elementModulePaths) {
     this.elementsToLoad = new Map(elementModulePaths);
   }
 
@@ -26,57 +24,31 @@ export class ElementsLoader {
    * the browser. Custom elements that are registered will be removed from the list of unregistered
    * elements so that they will not be queried in subsequent calls.
    */
-  loadContainedCustomElements(element: HTMLElement): Observable<void> {
-    const unregisteredSelectors = Array.from(this.elementsToLoad.keys())
+  loadContainingCustomElements(element: HTMLElement): Observable<void> {
+    const selectors: any[] = Array.from(this.elementsToLoad.keys())
         .filter(s => element.querySelector(s));
 
-    if (!unregisteredSelectors.length) { return of(undefined); }
+    if (!selectors.length) { return of(undefined); }
 
     // Returns observable that completes when all discovered elements have been registered.
-    const allRegistered = Promise.all(unregisteredSelectors.map(s => this.loadCustomElement(s)));
-    return fromPromise(allRegistered.then(() => undefined));
+    return fromPromise(Promise.all(selectors.map(s => this.register(s))).then(result => undefined));
   }
 
-  /** Loads and registers the custom element defined on the `WithCustomElement` module factory. */
-  loadCustomElement(selector: string): Promise<void> {
-    if (this.elementsLoading.has(selector)) {
-      // The custom element is in the process of being loaded and registered.
-      return this.elementsLoading.get(selector)!;
-    }
+  /** Registers the custom element defined on the WithCustomElement module factory. */
+  private register(selector: string) {
+    const modulePath = this.elementsToLoad.get(selector)!;
+    return this.moduleFactoryLoader.load(modulePath).then(elementModuleFactory => {
+      if (!this.elementsToLoad.has(selector)) { return; }
 
-    if (this.elementsToLoad.has(selector)) {
-      // Load and register the custom element (for the first time).
-      const modulePath = this.elementsToLoad.get(selector)!;
-      const loadedAndRegistered = this.moduleFactoryLoader
-          .load(modulePath)
-          .then(elementModuleFactory => {
-            const elementModuleRef = elementModuleFactory.create(this.moduleRef.injector);
-            const injector = elementModuleRef.injector;
-            const CustomElementComponent = elementModuleRef.instance.customElementComponent;
-            const CustomElement = createCustomElement(CustomElementComponent, {injector});
+      const elementModuleRef = elementModuleFactory.create(this.moduleRef.injector);
+      const CustomElementComponent = elementModuleRef.instance.customElementComponent;
+      const CustomElement =
+          createCustomElement(CustomElementComponent, {injector: elementModuleRef.injector});
 
-            customElements!.define(selector, CustomElement);
-            return customElements.whenDefined(selector);
-          })
-          .then(() => {
-            // The custom element has been successfully loaded and registered.
-            // Remove from `elementsLoading` and `elementsToLoad`.
-            this.elementsLoading.delete(selector);
-            this.elementsToLoad.delete(selector);
-          })
-          .catch(err => {
-            // The custom element has failed to load and register.
-            // Remove from `elementsLoading`.
-            // (Do not remove from `elementsToLoad` in case it was a temporary error.)
-            this.elementsLoading.delete(selector);
-            return Promise.reject(err);
-          });
+      customElements!.define(selector, CustomElement);
+      this.elementsToLoad.delete(selector);
 
-      this.elementsLoading.set(selector, loadedAndRegistered);
-      return loadedAndRegistered;
-    }
-
-    // The custom element has already been loaded and registered.
-    return Promise.resolve();
+      return customElements.whenDefined(selector);
+    });
   }
 }

aio/src/app/custom-elements/lazy-custom-element.component.spec.ts

@@ -1,67 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { Logger } from 'app/shared/logger.service';
-import { MockLogger } from 'testing/logger.service';
-import { LazyCustomElementComponent } from './lazy-custom-element.component';
-import { ElementsLoader } from './elements-loader';
-
-describe('LazyCustomElementComponent', () => {
-  let mockElementsLoader: jasmine.SpyObj<ElementsLoader>;
-  let mockLogger: MockLogger;
-  let fixture: ComponentFixture<LazyCustomElementComponent>;
-
-  beforeEach(() => {
-    mockElementsLoader = jasmine.createSpyObj<ElementsLoader>('ElementsLoader', [
-      'loadContainedCustomElements',
-      'loadCustomElement',
-    ]);
-
-    const injector = TestBed.configureTestingModule({
-      declarations: [ LazyCustomElementComponent ],
-      providers: [
-        { provide: ElementsLoader, useValue: mockElementsLoader },
-        { provide: Logger, useClass: MockLogger },
-      ],
-    });
-
-    mockLogger = injector.get(Logger);
-    fixture = TestBed.createComponent(LazyCustomElementComponent);
-  });
-
-  it('should set the HTML content based on the selector', () => {
-    const elem = fixture.nativeElement;
-
-    expect(elem.innerHTML).toBe('');
-
-    fixture.componentInstance.selector = 'foo-bar';
-    fixture.detectChanges();
-
-    expect(elem.innerHTML).toBe('<foo-bar></foo-bar>');
-  });
-
-  it('should load the specified custom element', () => {
-    expect(mockElementsLoader.loadCustomElement).not.toHaveBeenCalled();
-
-    fixture.componentInstance.selector = 'foo-bar';
-    fixture.detectChanges();
-
-    expect(mockElementsLoader.loadCustomElement).toHaveBeenCalledWith('foo-bar');
-  });
-
-  it('should log an error (and abort) if the selector is empty', () => {
-    fixture.detectChanges();
-
-    expect(mockElementsLoader.loadCustomElement).not.toHaveBeenCalled();
-    expect(mockLogger.output.error).toEqual([[jasmine.any(Error)]]);
-    expect(mockLogger.output.error[0][0].message).toBe('Invalid selector for \'aio-lazy-ce\': ');
-  });
-
-  it('should log an error (and abort) if the selector is invalid', () => {
-    fixture.componentInstance.selector = 'foo-bar><script></script><foo-bar';
-    fixture.detectChanges();
-
-    expect(mockElementsLoader.loadCustomElement).not.toHaveBeenCalled();
-    expect(mockLogger.output.error).toEqual([[jasmine.any(Error)]]);
-    expect(mockLogger.output.error[0][0].message).toBe(
-        'Invalid selector for \'aio-lazy-ce\': foo-bar><script></script><foo-bar');
-  });
-});

aio/src/app/custom-elements/lazy-custom-element.component.ts

@@ -1,27 +0,0 @@
-import { Component, ElementRef, Input, OnInit } from '@angular/core';
-import { Logger } from 'app/shared/logger.service';
-import { ElementsLoader } from './elements-loader';
-
-@Component({
-  selector: 'aio-lazy-ce',
-  template: '',
-})
-export class LazyCustomElementComponent implements OnInit {
-  @Input() selector = '';
-
-  constructor(
-    private elementRef: ElementRef,
-    private elementsLoader: ElementsLoader,
-    private logger: Logger,
-  ) {}
-
-  ngOnInit() {
-    if (!this.selector || /[^\w-]/.test(this.selector)) {
-      this.logger.error(new Error(`Invalid selector for 'aio-lazy-ce': ${this.selector}`));
-      return;
-    }
-
-    this.elementRef.nativeElement.innerHTML = `<${this.selector}></${this.selector}>`;
-    this.elementsLoader.loadCustomElement(this.selector);
-  }
-}

aio/src/app/custom-elements/toc/toc.module.ts

@@ -1,14 +0,0 @@
-import { NgModule, Type } from '@angular/core';
-import { CommonModule } from '@angular/common';
-import { MatIconModule } from '@angular/material/icon';
-import { WithCustomElementComponent } from '../element-registry';
-import { TocComponent } from './toc.component';
-
-@NgModule({
-  imports: [ CommonModule, MatIconModule ],
-  declarations: [ TocComponent ],
-  entryComponents: [ TocComponent ],
-})
-export class TocModule implements WithCustomElementComponent {
-  customElementComponent: Type<any> = TocComponent;
-}

aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts

@@ -300,7 +300,7 @@ describe('DocViewerComponent', () => {
 
     beforeEach(() => {
       const elementsLoader = TestBed.get(ElementsLoader) as MockElementsLoader;
-      loadElementsSpy = elementsLoader.loadContainedCustomElements.and.returnValue(of(undefined));
+      loadElementsSpy = elementsLoader.loadContainingCustomElements.and.returnValue(of(undefined));
       prepareTitleAndTocSpy = spyOn(docViewer, 'prepareTitleAndToc');
       swapViewsSpy = spyOn(docViewer, 'swapViews').and.returnValue(of(undefined));
     });

aio/src/app/layout/doc-viewer/doc-viewer.component.ts

@@ -136,7 +136,7 @@ export class DocViewerComponent implements OnDestroy {
         //           and is considered to be safe.
         tap(() => this.nextViewContainer.innerHTML = doc.contents || ''),
         tap(() => addTitleAndToc = this.prepareTitleAndToc(this.nextViewContainer, doc.id)),
-        switchMap(() => this.elementsLoader.loadContainedCustomElements(this.nextViewContainer)),
+        switchMap(() => this.elementsLoader.loadContainingCustomElements(this.nextViewContainer)),
         tap(() => this.docReady.emit()),
         switchMap(() => this.swapViews(addTitleAndToc)),
         tap(() => this.docRendered.emit()),

aio/src/app/layout/toc/toc.component.spec.ts

@@ -4,8 +4,8 @@ import { By } from '@angular/platform-browser';
 import { asapScheduler as asap, BehaviorSubject } from 'rxjs';
 
 import { ScrollService } from 'app/shared/scroll.service';
-import { TocItem, TocService } from 'app/shared/toc.service';
 import { TocComponent } from './toc.component';
+import { TocItem, TocService } from 'app/shared/toc.service';
 
 describe('TocComponent', () => {
   let tocComponentDe: DebugElement;

aio/src/index.html

@@ -82,7 +82,31 @@
     };
   </script>
 
-  <script nomodule src="generated/ie-polyfills.min.js"></script>
+  <script>
+    if (window.document.documentMode) {
+      // polyfill IE11 in a blocking way
+      var s = document.createElement('script');
+      s.src = 'generated/ie-polyfills.min.js';
+      document.head.appendChild(s);
+    } else if (!Object.assign) {
+      // polyfill other non-evergreen browsers in a blocking way
+      var polyfillUrl = "https://cdn.polyfill.io/v2/polyfill.min.js?features=default,Array.prototype.find&flags=gated&unknown=polyfill";
+
+      // send a blocking XHR to fetch the polyfill
+      // then append it to the document so that its eval-ed synchronously
+      // this is required because the method used for IE is not reliable with other non-evergreen browsers
+      var xhr = new XMLHttpRequest();
+      xhr.addEventListener("load", function() {
+        var s = document.createElement('script');
+        s.type = 'text/javascript';
+        var code = this.responseText;
+        s.appendChild(document.createTextNode(code));
+        document.head.appendChild(s);
+      });
+      xhr.open("GET", polyfillUrl, false);
+      xhr.send();
+    }
+  </script>
 
   <script>
     //load CE polyfill

aio/src/styles/1-layouts/_content-layout.scss

@@ -27,7 +27,7 @@ aio-shell.page-docs {
 }
 
 .sidenav-content button {
-  min-width: 24px;
+  min-width: 50px;
 }
 
 #guide-change-log h2::before {

aio/src/styles/1-layouts/_top-menu.scss

@@ -93,21 +93,15 @@ aio-shell.folder-tutorial mat-toolbar.mat-toolbar {
 
 
 // HOME NAV-LINK
-.nav-link.home {
-  cursor: pointer;
-  margin: 0 16px 0 0;
-  padding: 21px 0;
+.nav-link.home img {
+  position: relative;
+  margin-top: -21px;
+  top: 12px;
+  height: 40px;
 
-  img {
-    position: relative;
-    margin-top: -21px;
-    top: 12px;
-    height: 40px;
-
-    @media(max-width: 992px) {
-      &:hover {
-        transform: scale(1.1);
-      }
+  @media(max-width: 992px) {
+    &:hover {
+      transform: scale(1.1);
     }
   }
 }
@@ -149,6 +143,10 @@ aio-top-menu {
     padding: 24px 16px;
     cursor: pointer;
 
+    &.home{
+      margin-right: 20px;
+    }
+    
     &:focus {
       background: rgba($white, 0.15);
       border-radius: 4px;

aio/src/styles/2-modules/_code.scss

@@ -3,9 +3,8 @@ code-example, code-tabs {
     display: block;
 }
 
-code-example {
-
-
+code-example,
+code-tabs mat-tab-body {
   &:not(.no-box) {
     background-color: rgba($backgroundgray, 0.2);
     border: 0.5px solid $lightgray;
@@ -28,16 +27,6 @@ code-example {
   }
 }
 
-code-example, code-tabs {
-  .mat-card {
-    padding: 0;
-    border-radius: 5px;
-  }
-  code {
-    overflow: auto;
-  }
-}
-
 // TERMINAL / SHELL TEXT STYLES
 
 code-example.code-shell, code-example[language=sh], code-example[language=bash] {
@@ -97,9 +86,8 @@ aio-code pre {
 
 .copy-button {
   position: absolute;
-  top: -7px;
-  right: -19px;
-  padding: 0;
+  top: -8px;
+  right: -32px;
 
   color: $blue-grey-200;
   background-color: transparent;
@@ -118,9 +106,6 @@ aio-code pre {
 }
 
 .code-tab-group .mat-tab-label {
-  &:hover {
-    background: rgba(black, 0.04);
-  }
   white-space: nowrap;
 }
 

aio/src/testing/doc-viewer-utils.ts

@@ -56,8 +56,8 @@ export class MockTocService {
 }
 
 export class MockElementsLoader {
-  loadContainedCustomElements =
-      jasmine.createSpy('MockElementsLoader#loadContainedCustomElements');
+  loadContainingCustomElements =
+      jasmine.createSpy('MockElementsLoader#loadContainingCustomElements');
 }
 
 @NgModule({

aio/tools/transforms/angular-api-package/index.js

@@ -119,17 +119,6 @@ module.exports = new Package('angular-api', [basePackage, typeScriptPackage])
     addNotYetDocumentedProperty.docTypes = API_DOC_TYPES;
   })
 
-  .config(function(mergeDecoratorDocs) {
-    mergeDecoratorDocs.propertiesToMerge = [
-      'shortDescription',
-      'description',
-      'security',
-      'deprecated',
-      'see',
-      'usageNotes',
-    ];
-  })
-
   .config(function(checkContentRules, EXPORT_DOC_TYPES) {
     // Min length rules
     const createMinLengthRule = require('./content-rules/minLength');

aio/tools/transforms/angular-api-package/processors/generateApiListDoc.js

@@ -1,7 +1,7 @@
 module.exports = function generateApiListDoc() {
 
   return {
-    $runAfter: ['extra-docs-added', 'computeStability'],
+    $runAfter: ['extra-docs-added'],
     $runBefore: ['rendering-docs'],
     outputFolder: null,
     $validate: {outputFolder: {presence: true}},

aio/tools/transforms/angular-api-package/processors/generateApiListDoc.spec.js

@@ -13,7 +13,7 @@ describe('generateApiListDoc processor', () => {
 
   it('should run after the correct processor', () => {
     const processor = processorFactory();
-    expect(processor.$runAfter).toEqual(['extra-docs-added', 'computeStability']);
+    expect(processor.$runAfter).toEqual(['extra-docs-added']);
   });
 
   it('should run before the correct processor', () => {

aio/tools/transforms/angular-api-package/processors/mergeDecoratorDocs.js

@@ -1,5 +1,3 @@
-const {mergeProperties} = require('../../helpers/utils');
-
 /**
  * Decorators in the Angular code base are made up from three code items:
  *
@@ -49,7 +47,6 @@ module.exports = function mergeDecoratorDocs(log) {
   return {
     $runAfter: ['processing-docs'],
     $runBefore: ['docs-processed'],
-    propertiesToMerge: [],
     makeDecoratorCalls: [
       {type: '', description: 'toplevel', functionName: 'makeDecorator'},
       {type: 'Prop', description: 'property', functionName: 'makePropDecorator'},
@@ -58,7 +55,6 @@ module.exports = function mergeDecoratorDocs(log) {
     $process: function(docs) {
 
       var makeDecoratorCalls = this.makeDecoratorCalls;
-      var propertiesToMerge = this.propertiesToMerge;
       var docsToMerge = Object.create(null);
 
       docs.forEach(function(doc) {
@@ -92,9 +88,9 @@ module.exports = function mergeDecoratorDocs(log) {
           log.debug(
               'mergeDecoratorDocs: merging', doc.name, 'into', decoratorDoc.name,
               callMember.description.substring(0, 50));
-
           // Merge the documentation found in this call signature into the original decorator
-          mergeProperties(decoratorDoc, callMember, propertiesToMerge);
+          decoratorDoc.description = callMember.description;
+          decoratorDoc.usageNotes = callMember.usageNotes;
 
           // remove doc from its module doc's exports
           doc.moduleDoc.exports =

aio/tools/transforms/angular-api-package/processors/mergeDecoratorDocs.spec.js

@@ -9,21 +9,17 @@ describe('mergeDecoratorDocs processor', () => {
     const injector = dgeni.configureInjector();
     processor = injector.get('mergeDecoratorDocs');
 
-    // Note that we do not include usageNotes in the tests.
-    processor.propertiesToMerge = ['description', 'shortDescription'];
-
     moduleDoc = {};
 
     decoratorDoc = {
       name: 'Component',
       docType: 'const',
-      shortDescription: 'decorator - short description',
-      description: 'decorator - description',
+      description: 'A description of the metadata for the Component decorator',
       symbol: {
         valueDeclaration: { initializer: { expression: { text: 'makeDecorator' }, arguments: [{ text: 'X' }] } }
       },
       members: [
-        { name: 'templateUrl', description: 'templateUrl - description' }
+        { name: 'templateUrl', description: 'A description of the templateUrl property' }
       ],
       moduleDoc
     };
@@ -31,15 +27,15 @@ describe('mergeDecoratorDocs processor', () => {
     metadataDoc = {
       name: 'ComponentDecorator',
       docType: 'interface',
-      description: 'call interface - description',
+      description: 'A description of the interface for the call signature for the Component decorator',
       members: [
         {
           isCallMember: true,
-          description: 'call interface - call member - description',
-          usageNotes: 'call interface - call member - usageNotes',
+          description: 'The actual description of the call signature',
+          usageNotes: 'Use it like this...'
         },
         {
-          description: 'call interface - non call member - description'
+          description: 'Some other member'
         }
       ],
       moduleDoc
@@ -69,13 +65,10 @@ describe('mergeDecoratorDocs processor', () => {
     expect(decoratorDoc.decoratorType).toEqual('X');
   });
 
-  it('should copy across specified properties from the call signature doc', () => {
+  it('should copy across properties from the call signature doc', () => {
     processor.$process([decoratorDoc, metadataDoc, otherDoc]);
-    expect(decoratorDoc.description).toEqual('call interface - call member - description');
-    // Since usageNotes is not in `propertiesToMerge` it will not get copied over in these tests.
-    expect(decoratorDoc.usageNotes).toBeUndefined();
-    // Since `shortDescription` does not exist on the call-member this will not get overridden.
-    expect(decoratorDoc.shortDescription).toEqual('decorator - short description');
+    expect(decoratorDoc.description).toEqual('The actual description of the call signature');
+    expect(decoratorDoc.usageNotes).toEqual('Use it like this...');
   });
 
   it('should remove the metadataDoc from the module exports', () => {

aio/tools/transforms/angular-base-package/processors/checkContentRules.js

@@ -34,7 +34,6 @@ module.exports = function checkContentRules(log, createDocMessage) {
     $runAfter: ['tags-extracted'],
     $runBefore: ['processing-docs'],
     $process(docs) {
-      const logMessage = this.failOnContentErrors ? log.error.bind(log) : log.warn.bind(log);
       const errors = [];
       docs.forEach(doc => {
         const docErrors = [];
@@ -56,10 +55,10 @@ module.exports = function checkContentRules(log, createDocMessage) {
       });
 
       if (errors.length) {
-        logMessage('Content contains errors');
+        log.error('Content contains errors');
         errors.forEach(docError => {
           const errors = docError.errors.join('\n        ');
-          logMessage(createDocMessage(errors + '\n        ', docError.doc));
+          log.error(createDocMessage(errors + '\n        ', docError.doc));
         });
         if (this.failOnContentErrors) {
           throw new Error('Stopping due to content errors.');

aio/tools/transforms/angular-base-package/processors/checkContentRules.spec.js

@@ -67,11 +67,10 @@ describe('checkContentRules processor', function() {
     expect(descriptionSpy3).toHaveBeenCalledWith(docs[0], 'description', 'test doc 1');
   });
 
-  it('should log warnings if the rule returns error messages and `failOnContentErrors` is false', () => {
+  it('should log errors if the rule returns error messages', () => {
     const nameSpy1 = jasmine.createSpy('name 1').and.returnValue('name error message');
     const descriptionSpy1 = jasmine.createSpy('description 1').and.returnValue('description error message');
 
-    processor.failOnContentErrors = false;
     processor.docTypeRules = {
       'test1': {
         name: [nameSpy1],
@@ -86,32 +85,6 @@ describe('checkContentRules processor', function() {
 
     processor.$process(docs);
 
-    expect(logger.warn).toHaveBeenCalledTimes(2);
-    expect(logger.warn).toHaveBeenCalledWith('Content contains errors');
-    expect(logger.warn).toHaveBeenCalledWith(`name error message
-        description error message
-         - doc "test-1" (test1) `);
-  });
-
-  it('should log errors and then throw if `failOnContentErrors` is true and errors are found', () => {
-    const nameSpy1 = jasmine.createSpy('name 1').and.returnValue('name error message');
-    const descriptionSpy1 = jasmine.createSpy('description 1').and.returnValue('description error message');
-
-    processor.failOnContentErrors = true;
-    processor.docTypeRules = {
-      'test1': {
-        name: [nameSpy1],
-        description: [descriptionSpy1]
-      }
-    };
-
-    const docs = [
-      { docType: 'test1', description: 'test doc 1', name: 'test-1' },
-      { docType: 'test2', description: 'test doc 2', name: 'test-2' }
-    ];
-
-    expect(() => processor.$process(docs)).toThrowError('Stopping due to content errors.');
-
     expect(logger.error).toHaveBeenCalledTimes(2);
     expect(logger.error).toHaveBeenCalledWith('Content contains errors');
     expect(logger.error).toHaveBeenCalledWith(`name error message
@@ -119,4 +92,17 @@ describe('checkContentRules processor', function() {
          - doc "test-1" (test1) `);
   });
 
+  it('should throw an error if `failOnContentErrors` is true and errors are found', () => {
+    const errorRule = jasmine.createSpy('error rule').and.returnValue('some error');
+    processor.docTypeRules = {
+      'test': { description: [errorRule] }
+    };
+    processor.failOnContentErrors = true;
+
+    const docs = [
+      { docType: 'test', description: 'test doc' },
+    ];
+    expect(() => processor.$process(docs)).toThrowError('Stopping due to content errors.');
+  });
+
 });

aio/tools/transforms/helpers/utils.js

@@ -96,19 +96,5 @@ module.exports = {
       attrMap[key] === false ? '' :
       attrMap[key] === true ? ` ${key}` :
       ` ${key}="${attrMap[key].replace(/"/g, '"')}"`).join('');
-  },
-
-  /**
-   * Merge the specified properties from the source to the target document
-   * @param {Document} target The document to receive the properties from the source
-   * @param {Document} source The document from which to get the properties to merge
-   * @param {string[]} properties A collection of the names of the properties to merge
-   */
-  mergeProperties(target, source, properties) {
-    properties.forEach(property => {
-      if (source.hasOwnProperty(property)) {
-        target[property] = source[property];
-      }
-    });
-  },
+  }
 };

aio/tools/transforms/helpers/utils.spec.js

@@ -1,4 +1,4 @@
-const { mergeProperties, mapObject, parseAttributes, renderAttributes } = require('./utils');
+const { mapObject, parseAttributes, renderAttributes } = require('./utils');
 
 describe('utils', () => {
   describe('mapObject', () => {
@@ -96,34 +96,4 @@ describe('utils', () => {
       expect(renderAttributes({ })).toEqual('');
     });
   });
-
-  describe('mergeProperties', () => {
-    it('should write specified properties from the source to the target', () => {
-      const source = { a: 1, b: 2, c: 3 };
-      const target = { };
-      mergeProperties(target, source, ['a', 'b']);
-      expect(target).toEqual({ a: 1, b: 2 });
-    });
-
-    it('should not overwrite target properties that are not specified', () => {
-      const source = { a: 1, b: 2, c: 3 };
-      const target = { b: 10 };
-      mergeProperties(target, source, ['a']);
-      expect(target).toEqual({ a: 1, b: 10 });
-    });
-
-    it('should not overwrite target properties that are specified but do not exist in the source', () => {
-      const source = { a: 1 };
-      const target = { b: 10 };
-      mergeProperties(target, source, ['a', 'b']);
-      expect(target).toEqual({ a: 1, b: 10 });
-    });
-
-    it('should overwrite target properties even if they are `undefined` in the source', () => {
-      const source = { a: undefined };
-      const target = { a: 10 };
-      mergeProperties(target, source, ['a']);
-      expect(target).toEqual({ a: undefined });
-    });
-  });
 });

docs/BAZEL.md

@@ -37,7 +37,7 @@ That repository defines dependencies on specific versions of
 all the tools. You can run the tools Bazel installed, for
 example rather than `yarn install` (which depends on whatever
 version you have installed on your machine), you can
-`bazel run @nodejs//:yarn`.
+`bazel run @yarn//:yarn`.
 
 Bazel accepts a lot of options. We check in some options in the
 `.bazelrc` file. See the [bazelrc doc]. For example, if you don't

docs/DEVELOPER.md

@@ -123,16 +123,6 @@ You can automatically format your code by running:
 $ gulp format
 ```
 
-There is a handy [clang-format extension](https://marketplace.visualstudio.com/items?itemName=xaver.clang-format)
-for Visual Studio Code. Use the following settings to format your code when you save a file:
-
-```json
-{
-    "editor.formatOnSave": true,
-    "clang-format.executable": "${workspaceRoot}/node_modules/.bin/clang-format"
-}
-```
-
 ## Linting/verifying your source code
 
 You can check that your code is properly formatted and adheres to coding style by running:

docs/PUBLIC_API.md

@@ -1,13 +1,10 @@
 # Supported Public API Surface of Angular
 
-Our semver, timed-release cycle and deprecation policy currently applies to these npm packages:
+Our SemVer, timed-release cycle and deprecation policy currently applies to these npm packages:
 
 - `@angular/animations`
 - `@angular/core`
 - `@angular/common`
-- `@angular/elements`
-- `@angular/forms`
-- `@angular/http`
 - `@angular/platform-browser`
 - `@angular/platform-browser-dynamic`
 - `@angular/platform-server`
@@ -15,13 +12,12 @@ Our semver, timed-release cycle and deprecation policy currently applies to thes
 - `@angular/platform-webworker-dynamic`
 - `@angular/upgrade`
 - `@angular/router`
-- `@angular/service-worker`
+- `@angular/forms`
+- `@angular/http`
 
 
 One intentional omission from this list is `@angular/compiler`, which is currently considered a low level api and is subject to internal changes. These changes will not affect any applications or libraries using the higher-level apis (the command line interface or JIT compilation via `@angular/platform-browser-dynamic`). Only very specific use-cases require direct access to the compiler API (mostly tooling integration for IDEs, linters, etc). If you are working on this kind of integration, please reach out to us first.
 
-Package `@angular/bazel` is currently an Angular Labs project and not covered by the public API guarantees.
-
 Additionally only the command line usage (not direct use of APIs) of `@angular/compiler-cli` is covered.
 
 Other projects developed by the Angular team like angular-cli, Angular Material, will be covered by these or similar guarantees in the future as they mature.
@@ -35,7 +31,7 @@ Within the supported packages, we provide guarantees for:
 
 We explicitly don't consider the following to be our public API surface:
 
-- any file/import paths within our package except for the `/`, `/testing` and `/bundles/*` and other documented package entry-points.
+- any file/import paths within our package except for the `/`, `/testing` and `/bundles/*`
 - constructors of injectable classes (services and directives) - please use DI to obtain instances of these classes
 - any class members or symbols marked as `private`, or prefixed with underscore (`_`) and [barred latin o](https://en.wikipedia.org/wiki/%C6%9F) (`ɵ`)
 - extending any of our classes unless the support for this is specifically documented in the API docs

docs/TRIAGE_AND_LABELS.md

@@ -12,7 +12,7 @@ The owner of the component is then responsible for the secondary / component-lev
 The caretaker should be able to determine which component the issue belongs to.
 The components have a clear piece of source code associated with it within the `/packages/` folder of this repo.
 
-* `comp: docs-infra` - the angular.io application
+* `comp: aio` - the angular.io application
 * `comp: animations`
 * `comp: bazel` - @angular/bazel rules
 * `comp: benchpress`

integration/bazel/.bazelrc

@@ -0,0 +1,3 @@
+# Workaround https://github.com/bazelbuild/bazel/issues/3645
+# Limit Bazel to consuming 3072K of RAM
+build --local_resources=3072,2.0,1.0

integration/bazel/BUILD.bazel

@@ -17,25 +17,3 @@ filegroup(
         ],
     ),
 )
-
-ANGULAR_TESTING = [
-    "node_modules/@angular/*/bundles/*-testing.umd.js",
-    # We use AOT, so the compiler and the dynamic platform-browser should be
-    # visible only in tests
-    "node_modules/@angular/compiler/bundles/*.umd.js",
-    "node_modules/@angular/platform-browser-dynamic/bundles/*.umd.js",
-]
-
-filegroup(
-    name = "angular_bundles",
-    srcs = glob(
-        ["node_modules/@angular/*/bundles/*.umd.js"],
-        exclude = ANGULAR_TESTING,
-    ),
-)
-
-filegroup(
-    name = "angular_test_bundles",
-    testonly = 1,
-    srcs = glob(ANGULAR_TESTING),
-)

integration/bazel/WORKSPACE

@@ -1,77 +1,24 @@
 workspace(name = "bazel_integration_test")
 
-#
-# Download Bazel toolchain dependencies as needed by build actions
-#
-
 http_archive(
     name = "build_bazel_rules_nodejs",
-    url = "https://github.com/bazelbuild/rules_nodejs/archive/0.9.1.zip",
-    strip_prefix = "rules_nodejs-0.9.1",
-    sha256 = "6139762b62b37c1fd171d7f22aa39566cb7dc2916f0f801d505a9aaf118c117f",
+    url = "https://github.com/bazelbuild/rules_nodejs/archive/0.8.0.zip",
+    strip_prefix = "rules_nodejs-0.8.0",
+    sha256 = "4e40dd49ae7668d245c3107645f2a138660fcfd975b9310b91eda13f0c973953",
 )
 
-http_archive(
-    name = "io_bazel_rules_webtesting",
-    url = "https://github.com/bazelbuild/rules_webtesting/archive/v0.2.0.zip",
-    strip_prefix = "rules_webtesting-0.2.0",
-    sha256 = "cecc12f07e95740750a40d38e8b14b76fefa1551bef9332cb432d564d693723c",
-)
-
-http_archive(
-    name = "build_bazel_rules_typescript",
-    url = "https://github.com/bazelbuild/rules_typescript/archive/0.15.0.zip",
-    strip_prefix = "rules_typescript-0.15.0",
-    sha256 = "1aa75917330b820cb239b3c10a936a10f0a46fe215063d4492dd76dc6e1616f4",
-)
-
-http_archive(
-    name = "io_bazel_rules_go",
-    url = "https://github.com/bazelbuild/rules_go/releases/download/0.11.0/rules_go-0.11.0.tar.gz",
-    sha256 = "f70c35a8c779bb92f7521ecb5a1c6604e9c3edd431e50b6376d7497abc8ad3c1",
-)
-
-http_archive(
-    name = "io_bazel_rules_sass",
-    url = "https://github.com/bazelbuild/rules_sass/archive/0.1.0.zip",
-    strip_prefix = "rules_sass-0.1.0",
-    sha256 = "b243c4d64f054c174051785862ab079050d90b37a1cef7da93821c6981cb9ad4",
-)
-
-#
-# Load and install our dependencies downloaded above.
-#
-
-load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_repositories")
-
-check_bazel_version("0.14.0")
+load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories")
 node_repositories(package_json = ["//:package.json"])
 
-load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")
-
-go_rules_dependencies()
-go_register_toolchains()
-
-load("@io_bazel_rules_webtesting//web:repositories.bzl", "browser_repositories", "web_test_repositories")
-
-web_test_repositories()
-browser_repositories(
-    chromium = True,
-    firefox = True,
+local_repository(
+    name = "build_bazel_rules_typescript",
+    path = "node_modules/@bazel/typescript",
 )
 
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_setup_workspace")
 
 ts_setup_workspace()
 
-load("@io_bazel_rules_sass//sass:sass_repositories.bzl", "sass_repositories")
-
-sass_repositories()
-
-#
-# Point Bazel to WORKSPACEs that live in subdirectories
-#
-
 local_repository(
     name = "angular",
     path = "node_modules/@angular/bazel",
@@ -81,3 +28,14 @@ local_repository(
     name = "rxjs",
     path = "node_modules/rxjs/src",
 )
+
+http_archive(
+    name = "io_bazel_rules_sass",
+    url = "https://github.com/bazelbuild/rules_sass/archive/0.0.3.zip",
+    strip_prefix = "rules_sass-0.0.3",
+    sha256 = "8fa98e7b48a5837c286a1ea254b5a5c592fced819ee9fe4fdd759768d97be868",
+)
+
+load("@io_bazel_rules_sass//sass:sass.bzl", "sass_repositories")
+
+sass_repositories()

integration/bazel/package.json

@@ -9,26 +9,17 @@
     "@angular/compiler": "file:../../dist/packages-dist/compiler",
     "@angular/core": "file:../../dist/packages-dist/core",
     "@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
-    "@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic",
     "rxjs": "file:../../node_modules/rxjs",
     "zone.js": "file:../../node_modules/zone.js"
   },
   "devDependencies": {
     "@angular/bazel": "file:../../dist/packages-dist/bazel",
     "@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
-    "@types/jasmine": "2.8.7",
-    "@types/source-map": "0.5.1",
-    "concurrently": "3.5.1",
-    "http-server": "0.11.1",
-    "protractor": "file:../../node_modules/protractor",
-    "typescript": "file:../../node_modules/typescript"
+    "typescript": "file:../../node_modules/typescript",
+    "@types/source-map": "0.5.1"
   },
   "scripts": {
-    "postinstall": "concurrently \"webdriver-manager update $CHROMEDRIVER_VERSION_ARG\" \"ngc -p angular.tsconfig.json\"",
-    "test": "bazel build //... --noshow_progress && yarn e2e",
-    "pree2e": "bazel build test/...",
-    "e2e": "yarn e2e-prodserver && yarn e2e-devserver",
-    "e2e-prodserver": "concurrently \"bazel run //src:prodserver\" \"while ! nc -z 127.0.0.1 5432; do sleep 1; done && protractor\" --kill-others --success first",
-    "e2e-devserver": "concurrently \"bazel run //src:devserver\" \"while ! nc -z 127.0.0.1 5432; do sleep 1; done && protractor\" --kill-others --success first"
+    "postinstall": "ngc -p angular.tsconfig.json",
+    "test": "bazel build //... --noshow_progress"
   }
 }

integration/bazel/protractor.conf.js

@@ -1,9 +0,0 @@
-exports.config = {
-  specs: ['bazel-bin/test/e2e/*.spec.js'],
-  capabilities: {browserName: 'chrome', chromeOptions: {args: ['--no-sandbox']}},
-  directConnect: true,
-  baseUrl: 'http://localhost:5432/',
-  framework: 'jasmine',
-  getPageTimeout: 60 * 1000,
-  allScriptsTimeout: 60 * 1000,
-};

integration/bazel/src/BUILD.bazel

@@ -9,52 +9,3 @@ ng_module(
     tsconfig = ":tsconfig.json",
     deps = ["//src/hello-world"],
 )
-
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
-
-ts_devserver(
-    name = "devserver",
-    additional_root_paths = [
-        "bazel_integration_test/node_modules/zone.js/dist",
-    ],
-    entry_module = "bazel_integration_test/src/main",
-    scripts = ["//:angular_bundles"],
-    serving_path = "/bundle.min.js",
-    static_files = [
-        "//:node_modules/zone.js/dist/zone.min.js",
-        "index.html",
-    ],
-    deps = ["//src"],
-)
-
-load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "rollup_bundle")
-
-rollup_bundle(
-    name = "bundle",
-    entry_point = "src/main",
-    deps = ["//src"],
-)
-
-# Needed because the prodserver only loads static files that appear under this
-# package.
-genrule(
-    name = "zone.js",
-    srcs = ["//:node_modules/zone.js/dist/zone.min.js"],
-    outs = ["zone.min.js"],
-    cmd = "cp $< $@",
-)
-
-nodejs_binary(
-    name = "prodserver",
-    args = [
-        "./src",
-        "-p",
-        "5432",
-    ],
-    data = [
-        "index.html",
-        ":bundle",
-        ":zone.js",
-    ],
-    entry_point = "http-server/bin/http-server",
-)

integration/bazel/src/app.component.ts

@@ -1,19 +0,0 @@
-import {Component} from '@angular/core';
-import {HttpClient} from '@angular/common/http';
-import {Observable} from 'rxjs';
-import {map, startWith} from 'rxjs/operators';
-
-@Component({
-  selector: 'app-component',
-  template: `
-    <hello-world-app></hello-world-app>
-    <div>The current time is {{ time$ | async }}</div>
-  `})
-export class AppComponent {
-  constructor(private http: HttpClient) {
-  }
-
-  time$ = this.http.get('http://worldclockapi.com/api/json/pst/now').pipe(
-    map((result: any) => result.currentDateTime),
-    startWith(['...']));
-}

integration/bazel/src/app.module.ts

@@ -1,14 +1,9 @@
-import {NgModule} from '@angular/core';
-import {BrowserModule} from '@angular/platform-browser';
-import {HttpClientModule} from '@angular/common/http';
-import {CommonModule} from '@angular/common';
-
-import {AppComponent} from './app.component';
 import {HelloWorldModule} from './hello-world/hello-world.module';
 
+import {NgModule} from '@angular/core';
+import {BrowserModule} from '@angular/platform-browser';
+
 @NgModule({
-  imports: [CommonModule, BrowserModule, HttpClientModule, HelloWorldModule],
-  declarations: [AppComponent],
-  bootstrap: [AppComponent],
+  imports: [BrowserModule, HelloWorldModule]
 })
 export class AppModule {}

integration/bazel/src/hello-world/BUILD.bazel

@@ -2,7 +2,6 @@ package(default_visibility = ["//visibility:public"])
 
 load("@angular//:index.bzl", "ng_module", "ng_package")
 load("@io_bazel_rules_sass//sass:sass.bzl", "sass_binary")
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test_suite")
 
 sass_binary(
     name = "hello-world-styles",
@@ -11,11 +10,8 @@ sass_binary(
 
 ng_module(
     name = "hello-world",
-    srcs = glob(
-        ["*.ts"],
-        exclude = ["*.spec.ts"],
-    ),
-    assets = [":hello-world-styles"],
+    srcs = glob(["*.ts"]),
+    assets = [":hello-world-styles.css"],
     tsconfig = "//src:tsconfig.json",
     # FIXME(alexeagle): the rxjs dep should come from Angular, but if we use the
     # npm distro of angular there is no ts_library rule to propagate the dep.
@@ -27,24 +23,3 @@ ng_package(
     entry_point = "src/hello-world/index.js",
     deps = [":hello-world"],
 )
-
-ts_library(
-    name = "test_lib",
-    testonly = 1,
-    srcs = glob(["*.spec.ts"]),
-    deps = [":hello-world"],
-)
-
-ts_web_test_suite(
-    name = "test",
-    bootstrap = ["//:node_modules/zone.js/dist/zone-testing-bundle.js"],
-    browsers = [
-        "@io_bazel_rules_webtesting//browsers:chromium-local",
-        "@io_bazel_rules_webtesting//browsers:firefox-local",
-    ],
-    deps = [
-        ":test_lib",
-        "//:angular_bundles",
-        "//:angular_test_bundles",
-    ],
-)

integration/bazel/src/hello-world/hello-world.component.spec.ts

@@ -1,45 +0,0 @@
-import {DebugElement} from '@angular/core';
-import {async, ComponentFixture, TestBed} from '@angular/core/testing';
-import {By} from '@angular/platform-browser';
-import {BrowserDynamicTestingModule, platformBrowserDynamicTesting} from '@angular/platform-browser-dynamic/testing';
-
-import {HelloWorldComponent} from './hello-world.component';
-import {HelloWorldModuleNgSummary} from './hello-world.module.ngsummary';
-
-// TODO(alexeagle): this helper should be in @angular/platform-browser-dynamic/testing
-try {
-  TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
-} catch {
-  // Ignore exceptions when calling it multiple times.
-}
-
-describe('BannerComponent (inline template)', () => {
-  let comp: HelloWorldComponent;
-  let fixture: ComponentFixture<HelloWorldComponent>;
-  let el: HTMLElement;
-
-  beforeEach(async(() => {
-    TestBed.configureTestingModule({
-      declarations: [HelloWorldComponent],  // declare the test component
-      aotSummaries: HelloWorldModuleNgSummary,
-    });
-    TestBed.compileComponents();
-  }));
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(HelloWorldComponent);
-    comp = fixture.componentInstance;
-    el = fixture.debugElement.query(By.css('div')).nativeElement;
-  });
-
-  it('should display original title', () => {
-    fixture.detectChanges();
-    expect(el.textContent).toContain(comp.name);
-  });
-
-  it('should display a different test title', () => {
-    comp.name = 'Test';
-    fixture.detectChanges();
-    expect(el.textContent).toContain('Test');
-  });
-});

integration/bazel/src/hello-world/hello-world.component.ts

@@ -8,7 +8,7 @@ import {Component, NgModule} from '@angular/core';
     <input type="text" [value]="name" (input)="name = $event.target.value"/>
   `,
   // TODO: might be better to point to .scss so this looks valid at design-time
-  styleUrls: ['./hello-world.component.css'],
+  styleUrls: ['./hello-world-styles.css'],
 })
 export class HelloWorldComponent {
   name: string = 'world';

integration/bazel/src/hello-world/hello-world.module.ts

@@ -3,6 +3,6 @@ import {NgModule} from '@angular/core';
 
 @NgModule({
   declarations: [HelloWorldComponent],
-  exports: [HelloWorldComponent],
+  bootstrap: [HelloWorldComponent],
 })
 export class HelloWorldModule {}

integration/bazel/src/index.html

@@ -1,12 +0,0 @@
-<!doctype html>
-
-<html>
-  <head>
-    <title>Bazel Integration Test</title>
-  </head>
-  <body>
-    <app-component></app-component>
-    <script src="/zone.min.js"></script>
-    <script src="/bundle.min.js"></script>
-  </body>
-</html>

integration/bazel/test/e2e/BUILD.bazel

@@ -1,7 +0,0 @@
-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
-
-ts_library(
-    name = "e2e",
-    testonly = 1,
-    srcs = glob(["*.ts"]),
-)

integration/bazel/test/e2e/app.spec.ts

@@ -1,12 +0,0 @@
-import {browser, by, element, ExpectedConditions} from 'protractor';
-
-describe('angular example application', () => {
-  it('should display: Hello World!', (done) => {
-    browser.get('');
-    const div = element(by.css('div'));
-    div.getText().then(t => expect(t).toEqual(`Hello world!`));
-    element(by.css('input')).sendKeys('!');
-    div.getText().then(t => expect(t).toEqual(`Hello world!!`));
-    done();
-  });
-});

integration/bazel/tools/bazel.rc

@@ -1,10 +0,0 @@
-# Make TypeScript and Angular compilation fast, by keeping a few copies of the
-# compiler running as daemons, and cache SourceFile AST's to reduce parse time.
-build --strategy=TypeScriptCompile=worker
-build --strategy=AngularTemplateCompile=worker
-
-test --test_output=errors
-
-# Workaround https://github.com/bazelbuild/bazel/issues/3645
-# Limit Bazel to consuming 3072K of RAM
-build --local_resources=3072,2.0,1.0

integration/cli-hello-world/package.json

@@ -3,13 +3,13 @@
   "version": "0.0.0",
   "license": "MIT",
   "scripts": {
+    "ng": "ng",
+    "start": "ng serve",
     "build": "ng build --prod --progress false",
     "e2e": "ng e2e",
+    "test": "ng test && ng e2e --webdriver-update=false && ng e2e --prod --webdriver-update=false",
     "lint": "ng lint",
-    "ng": "ng",
-    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG",
-    "start": "ng serve",
-    "test": "ng test && ng e2e --webdriver-update=false && ng e2e --prod --webdriver-update=false"
+    "postinstall": "webdriver-manager update --gecko false --standalone false $CHROMEDRIVER_VERSION_ARG"
   },
   "private": true,
   "dependencies": {

integration/cli-hello-world/yarn.lock

@@ -128,7 +128,7 @@
     chokidar "^1.4.2"
     minimist "^1.2.0"
     reflect-metadata "^0.1.2"
-    tsickle "^0.29.0"
+    tsickle "^0.27.2"
 
 "@angular/compiler@file:../../dist/packages-dist/compiler":
   version "6.0.0-rc.5"
@@ -5599,8 +5599,14 @@ run-queue@^1.0.0, run-queue@^1.0.3:
   dependencies:
     aproba "^1.1.1"
 
-rxjs@^6.0.0-beta.3, rxjs@^6.0.0-turbo-rc.4, "rxjs@file:../../node_modules/rxjs":
+rxjs@^6.0.0-beta.3, rxjs@^6.0.0-turbo-rc.4:
   version "6.0.0"
+  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.0.0.tgz#d647e029b5854617f994c82fe57a4c6747b352da"
+  dependencies:
+    tslib "^1.9.0"
+
+"rxjs@file:../../node_modules/rxjs":
+  version "6.0.0-uncanny-rc.7"
   dependencies:
     tslib "^1.9.0"
 
@@ -6532,9 +6538,9 @@ tsconfig@^7.0.0:
     strip-bom "^3.0.0"
     strip-json-comments "^2.0.0"
 
-tsickle@^0.29.0:
-  version "0.29.0"
-  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.29.0.tgz#812806554bb46c1aa16eb0fe2a051da95ca8f5a4"
+tsickle@^0.27.2:
+  version "0.27.2"
+  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.27.2.tgz#f33d46d046f73dd5c155a37922e422816e878736"
   dependencies:
     minimist "^1.2.0"
     mkdirp "^0.5.1"

integration/dynamic-compiler/yarn.lock

@@ -3,45 +3,45 @@
 
 
 "@angular/animations@file:../../dist/packages-dist/animations":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/common@file:../../dist/packages-dist/common":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/compiler-cli@file:../../dist/packages-dist/compiler-cli":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     chokidar "^1.4.2"
     minimist "^1.2.0"
     reflect-metadata "^0.1.2"
-    tsickle "^0.29.0"
+    tsickle "^0.27.2"
 
 "@angular/compiler@file:../../dist/packages-dist/compiler":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/core@file:../../dist/packages-dist/core":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/platform-browser-dynamic@file:../../dist/packages-dist/platform-browser-dynamic":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/platform-browser@file:../../dist/packages-dist/platform-browser":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/platform-server@file:../../dist/packages-dist/platform-server":
-  version "6.0.0-rc.5"
+  version "6.0.0-beta.7-54970933bb"
   dependencies:
     domino "^2.0.1"
     tslib "^1.9.0"
@@ -1881,9 +1881,7 @@ rx@4.1.0:
   resolved "https://registry.yarnpkg.com/rx/-/rx-4.1.0.tgz#a5f13ff79ef3b740fe30aa803fb09f98805d4782"
 
 "rxjs@file:../../node_modules/rxjs":
-  version "6.0.0"
-  dependencies:
-    tslib "^1.9.0"
+  version "6.0.0-alpha.3"
 
 safe-buffer@^5.0.1, safe-buffer@^5.1.1, safe-buffer@~5.1.0, safe-buffer@~5.1.1:
   version "5.1.1"
@@ -2225,9 +2223,9 @@ tree-kill@^1.1.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/tree-kill/-/tree-kill-1.2.0.tgz#5846786237b4239014f05db156b643212d4c6f36"
 
-tsickle@^0.29.0:
-  version "0.29.0"
-  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.29.0.tgz#812806554bb46c1aa16eb0fe2a051da95ca8f5a4"
+tsickle@^0.27.2:
+  version "0.27.2"
+  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.27.2.tgz#f33d46d046f73dd5c155a37922e422816e878736"
   dependencies:
     minimist "^1.2.0"
     mkdirp "^0.5.1"
@@ -2249,7 +2247,7 @@ tweetnacl@^0.14.3, tweetnacl@~0.14.0:
   resolved "https://registry.yarnpkg.com/tweetnacl/-/tweetnacl-0.14.5.tgz#5ae68177f192d4456269d108afa93ff8743f4f64"
 
 "typescript@file:../../node_modules/typescript":
-  version "2.7.2"
+  version "2.6.2"
 
 ua-parser-js@0.7.12:
   version "0.7.12"
@@ -2456,4 +2454,4 @@ yeast@0.1.2:
   resolved "https://registry.yarnpkg.com/yeast/-/yeast-0.1.2.tgz#008e06d8094320c372dbc2f8ed76a0ca6c8ac419"
 
 "zone.js@file:../../node_modules/zone.js":
-  version "0.8.26"
+  version "0.8.20"

integration/hello_world__closure/yarn.lock

@@ -3,40 +3,40 @@
 
 
 "@angular/animations@file:../../dist/packages-dist/animations":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/common@file:../../dist/packages-dist/common":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/compiler-cli@file:../../dist/packages-dist/compiler-cli":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     chokidar "^1.4.2"
     minimist "^1.2.0"
     reflect-metadata "^0.1.2"
-    tsickle "^0.29.0"
+    tsickle "^0.27.2"
 
 "@angular/compiler@file:../../dist/packages-dist/compiler":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/core@file:../../dist/packages-dist/core":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/platform-browser@file:../../dist/packages-dist/platform-browser":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     tslib "^1.9.0"
 
 "@angular/platform-server@file:../../dist/packages-dist/platform-server":
-  version "6.0.0-rc.5"
+  version "6.0.0-rc.1-461a08bdc1"
   dependencies:
     domino "^2.0.1"
     tslib "^1.9.0"
@@ -1835,7 +1835,7 @@ rx@4.1.0:
   resolved "https://registry.yarnpkg.com/rx/-/rx-4.1.0.tgz#a5f13ff79ef3b740fe30aa803fb09f98805d4782"
 
 "rxjs@file:../../node_modules/rxjs":
-  version "6.0.0"
+  version "6.0.0-rc.0"
   dependencies:
     tslib "^1.9.0"
 
@@ -2180,9 +2180,9 @@ tree-kill@^1.1.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/tree-kill/-/tree-kill-1.2.0.tgz#5846786237b4239014f05db156b643212d4c6f36"
 
-tsickle@^0.29.0:
-  version "0.29.0"
-  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.29.0.tgz#812806554bb46c1aa16eb0fe2a051da95ca8f5a4"
+tsickle@^0.27.2:
+  version "0.27.2"
+  resolved "https://registry.yarnpkg.com/tsickle/-/tsickle-0.27.2.tgz#f33d46d046f73dd5c155a37922e422816e878736"
   dependencies:
     minimist "^1.2.0"
     mkdirp "^0.5.1"
@@ -2424,4 +2424,4 @@ yeast@0.1.2:
   resolved "https://registry.yarnpkg.com/yeast/-/yeast-0.1.2.tgz#008e06d8094320c372dbc2f8ed76a0ca6c8ac419"
 
 "zone.js@file:../../node_modules/zone.js":
-  version "0.8.26"
+  version "0.8.20"

integration/typings_test_ts27/package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-integration",
-  "description": "Assert that users with TypeScript 2.7 can type-check an Angular application",
+  "description": "Assert that users with TypeScript 2.6 can type-check an Angular application",
   "version": "0.0.0",
   "license": "MIT",
   "dependencies": {

integration/typings_test_ts28/include-all.ts

@@ -1,47 +0,0 @@
-/**
- * @license
- * Copyright Google Inc. All Rights Reserved.
- *
- * Use of this source code is governed by an MIT-style license that can be
- * found in the LICENSE file at https://angular.io/license
- */
-
-import * as compiler from '@angular/compiler';
-import * as compilerTesting from '@angular/compiler/testing';
-import * as core from '@angular/core';
-import * as coreTesting from '@angular/core/testing';
-import * as forms from '@angular/forms';
-import * as http from '@angular/http';
-import * as httpTesting from '@angular/http/testing';
-import * as platformBrowser from '@angular/platform-browser';
-import * as platformBrowserTesting from '@angular/platform-browser/testing';
-import * as platformBrowserDynamic from '@angular/platform-browser-dynamic';
-import * as platformServer from '@angular/platform-server';
-import * as platformServerTesting from '@angular/platform-server/testing';
-import * as platformWebworker from '@angular/platform-webworker';
-import * as platformWebworkerDynamic from '@angular/platform-webworker-dynamic';
-import * as router from '@angular/router';
-import * as routerTesting from '@angular/router/testing';
-import * as serviceWorker from '@angular/service-worker';
-import * as upgrade from '@angular/upgrade';
-
-export default {
-  compiler,
-  compilerTesting,
-  core,
-  coreTesting,
-  forms,
-  http,
-  httpTesting,
-  platformBrowser,
-  platformBrowserTesting,
-  platformBrowserDynamic,
-  platformServer,
-  platformServerTesting,
-  platformWebworker,
-  platformWebworkerDynamic,
-  router,
-  routerTesting,
-  serviceWorker,
-  upgrade,
-};

integration/typings_test_ts28/package.json

@@ -1,30 +0,0 @@
-{
-  "name": "angular-integration",
-  "description": "Assert that users with TypeScript 2.8 can type-check an Angular application",
-  "version": "0.0.0",
-  "license": "MIT",
-  "dependencies": {
-    "@angular/animations": "file:../../dist/packages-dist/animations",
-    "@angular/common": "file:../../dist/packages-dist/common",
-    "@angular/compiler": "file:../../dist/packages-dist/compiler",
-    "@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
-    "@angular/core": "file:../../dist/packages-dist/core",
-    "@angular/forms": "file:../../dist/packages-dist/forms",
-    "@angular/http": "file:../../dist/packages-dist/http",
-    "@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
-    "@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic",
-    "@angular/platform-server": "file:../../dist/packages-dist/platform-server",
-    "@angular/platform-webworker": "file:../../dist/packages-dist/platform-webworker",
-    "@angular/platform-webworker-dynamic": "file:../../dist/packages-dist/platform-webworker-dynamic",
-    "@angular/router": "file:../../dist/packages-dist/router",
-    "@angular/service-worker": "file:../../dist/packages-dist/service-worker",
-    "@angular/upgrade": "file:../../dist/packages-dist/upgrade",
-    "@types/jasmine": "2.5.41",
-    "rxjs": "file:../../node_modules/rxjs",
-    "typescript": "2.8.x",
-    "zone.js": "file:../../node_modules/zone.js"
-  },
-  "scripts": {
-    "test": "tsc"
-  }
-}

integration/typings_test_ts28/tsconfig.json

@@ -1,24 +0,0 @@
-{
-  "compilerOptions": {
-    "emitDecoratorMetadata": true,
-    "experimentalDecorators": true,
-    "module": "commonjs",
-    "moduleResolution": "node",
-    "outDir": "../../dist/typings_test_ts28/",
-    "rootDir": ".",
-    "target": "es5",
-    "lib": [
-      "es5",
-      "dom",
-      "es2015.collection",
-      "es2015.iterable",
-      "es2015.promise"
-    ],
-    "types": [],
-    "strictNullChecks": true
-  },
-  "files": [
-    "include-all.ts",
-    "node_modules/@types/jasmine/index.d.ts"
-  ]
-}

karma-js.conf.js

@@ -65,8 +65,6 @@ module.exports = function(config) {
       'dist/all/@angular/**/*node_only_spec.js',
       'dist/all/@angular/benchpress/**',
       'dist/all/@angular/compiler-cli/**',
-      'dist/all/@angular/compiler-cli/src/ngtsc/**',
-      'dist/all/@angular/compiler-cli/test/ngtsc/**',
       'dist/all/@angular/compiler/test/aot/**',
       'dist/all/@angular/compiler/test/render3/**',
       'dist/all/@angular/core/test/bundling/**',
@@ -94,16 +92,6 @@ module.exports = function(config) {
       '**/*.js': ['sourcemap'],
     },
 
-    // Bazel inter-op: Allow tests to request resources from either
-    //   /base/node_modules/path/to/thing
-    // or
-    //   /base/angular/node_modules/path/to/thing
-    // This can be removed when all karma tests are run under Bazel, then we
-    // don't need this entire config file.
-    proxies: {
-      '/base/angular/': '/base/',
-    },
-
     reporters: ['internal-angular'],
     sauceLabs: {
       testName: 'Angular2',

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-srcs",
-  "version": "6.1.0-beta.1",
+  "version": "6.0.3",
   "private": true,
   "branchPattern": "2.0.*",
   "description": "Angular - a web framework for modern web apps",
@@ -110,11 +110,11 @@
     "source-map": "0.5.7",
     "source-map-support": "0.4.18",
     "systemjs": "0.18.10",
-    "tsickle": "^0.29.0",
+    "tsickle": "^0.27.2",
     "tslint": "5.7.0",
     "tslint-eslint-rules": "4.1.1",
     "tsutils": "2.20.0",
-    "typescript": "2.8.x",
+    "typescript": "2.7.x",
     "uglify-es": "^3.3.9",
     "universal-analytics": "0.4.15",
     "vlq": "0.2.2",

packages/animations/BUILD.bazel

@@ -24,10 +24,7 @@ ng_package(
         "//packages/animations/browser/testing:package.json",
     ],
     entry_point = "packages/animations/index.js",
-    tags = [
-        "ivy-jit",
-        "release-with-framework",
-    ],
+    tags = ["release-with-framework"],
     deps = [
         ":animations",
         "//packages/animations/browser",

packages/animations/browser/src/dsl/animation_transition_factory.ts

@@ -38,8 +38,8 @@ export class AnimationTransitionFactory {
   build(
       driver: AnimationDriver, element: any, currentState: any, nextState: any,
       enterClassName: string, leaveClassName: string, currentOptions?: AnimationOptions,
-      nextOptions?: AnimationOptions, subInstructions?: ElementInstructionMap,
-      skipAstBuild?: boolean): AnimationTransitionInstruction {
+      nextOptions?: AnimationOptions,
+      subInstructions?: ElementInstructionMap): AnimationTransitionInstruction {
     const errors: any[] = [];
 
     const transitionAnimationParams = this.ast.options && this.ast.options.params || EMPTY_OBJECT;
@@ -55,10 +55,9 @@ export class AnimationTransitionFactory {
 
     const animationOptions = {params: {...transitionAnimationParams, ...nextAnimationParams}};
 
-    const timelines = skipAstBuild ? [] : buildAnimationTimelines(
-                                              driver, element, this.ast.animation, enterClassName,
-                                              leaveClassName, currentStateStyles, nextStateStyles,
-                                              animationOptions, subInstructions, errors);
+    const timelines = buildAnimationTimelines(
+        driver, element, this.ast.animation, enterClassName, leaveClassName, currentStateStyles,
+        nextStateStyles, animationOptions, subInstructions, errors);
 
     let totalTime = 0;
     timelines.forEach(tl => { totalTime = Math.max(tl.duration + tl.delay, totalTime); });

packages/animations/browser/src/render/css_keyframes/css_keyframes_player.ts

@@ -15,7 +15,12 @@ const DEFAULT_FILL_MODE = 'forwards';
 const DEFAULT_EASING = 'linear';
 const ANIMATION_END_EVENT = 'animationend';
 
-export const enum AnimatorControlState {INITIALIZED = 1, STARTED = 2, FINISHED = 3, DESTROYED = 4}
+export enum AnimatorControlState {
+  INITIALIZED = 1,
+  STARTED = 2,
+  FINISHED = 3,
+  DESTROYED = 4
+}
 
 export class CssKeyframesPlayer implements AnimationPlayer {
   private _onDoneFns: Function[] = [];
@@ -29,8 +34,7 @@ export class CssKeyframesPlayer implements AnimationPlayer {
   public readonly totalTime: number;
   public readonly easing: string;
   public currentSnapshot: {[key: string]: string} = {};
-
-  private _state: AnimatorControlState = 0;
+  public state = 0;
 
   constructor(
       public readonly element: any, public readonly keyframes: {[key: string]: string | number}[],
@@ -50,8 +54,8 @@ export class CssKeyframesPlayer implements AnimationPlayer {
 
   destroy() {
     this.init();
-    if (this._state >= AnimatorControlState.DESTROYED) return;
-    this._state = AnimatorControlState.DESTROYED;
+    if (this.state >= AnimatorControlState.DESTROYED) return;
+    this.state = AnimatorControlState.DESTROYED;
     this._styler.destroy();
     this._flushStartFns();
     this._flushDoneFns();
@@ -71,8 +75,8 @@ export class CssKeyframesPlayer implements AnimationPlayer {
 
   finish() {
     this.init();
-    if (this._state >= AnimatorControlState.FINISHED) return;
-    this._state = AnimatorControlState.FINISHED;
+    if (this.state >= AnimatorControlState.FINISHED) return;
+    this.state = AnimatorControlState.FINISHED;
     this._styler.finish();
     this._flushStartFns();
     this._flushDoneFns();
@@ -82,10 +86,10 @@ export class CssKeyframesPlayer implements AnimationPlayer {
 
   getPosition(): number { return this._styler.getPosition(); }
 
-  hasStarted(): boolean { return this._state >= AnimatorControlState.STARTED; }
+  hasStarted(): boolean { return this.state >= AnimatorControlState.STARTED; }
   init(): void {
-    if (this._state >= AnimatorControlState.INITIALIZED) return;
-    this._state = AnimatorControlState.INITIALIZED;
+    if (this.state >= AnimatorControlState.INITIALIZED) return;
+    this.state = AnimatorControlState.INITIALIZED;
     const elm = this.element;
     this._styler.apply();
     if (this._delay) {
@@ -97,7 +101,7 @@ export class CssKeyframesPlayer implements AnimationPlayer {
     this.init();
     if (!this.hasStarted()) {
       this._flushStartFns();
-      this._state = AnimatorControlState.STARTED;
+      this.state = AnimatorControlState.STARTED;
     }
     this._styler.resume();
   }
@@ -133,7 +137,7 @@ export class CssKeyframesPlayer implements AnimationPlayer {
     this.init();
     const styles: {[key: string]: string} = {};
     if (this.hasStarted()) {
-      const finished = this._state >= AnimatorControlState.FINISHED;
+      const finished = this.state >= AnimatorControlState.FINISHED;
       Object.keys(this._finalStyles).forEach(prop => {
         if (prop != 'offset') {
           styles[prop] = finished ? this._finalStyles[prop] : computeStyle(this.element, prop);

packages/animations/browser/src/render/shared.ts

@@ -10,10 +10,6 @@ import {AUTO_STYLE, AnimationEvent, AnimationPlayer, NoopAnimationPlayer, ɵAnim
 import {AnimationStyleNormalizer} from '../../src/dsl/style_normalization/animation_style_normalizer';
 import {AnimationDriver} from '../../src/render/animation_driver';
 
-export function isBrowser() {
-  return (typeof window !== 'undefined' && typeof window.document !== 'undefined');
-}
-
 export function optimizeGroupPlayer(players: AnimationPlayer[]): AnimationPlayer {
   switch (players.length) {
     case 0:
@@ -142,7 +138,7 @@ let _query: (element: any, selector: string, multi: boolean) => any[] =
       return [];
     };
 
-if (isBrowser()) {
+if (typeof Element != 'undefined') {
   // this is well supported in all browsers
   _contains = (elm1: any, elm2: any) => { return elm1.contains(elm2) as boolean; };
 

packages/animations/browser/src/render/transition_animation_engine.ts

@@ -104,6 +104,7 @@ export class StateValue {
 
 export const VOID_VALUE = 'void';
 export const DEFAULT_STATE_VALUE = new StateValue(VOID_VALUE);
+export const DELETED_STATE_VALUE = new StateValue('DELETED');
 
 export class AnimationTransitionNamespace {
   public players: TransitionAnimationPlayer[] = [];
@@ -207,6 +208,8 @@ export class AnimationTransitionNamespace {
 
     if (!fromState) {
       fromState = DEFAULT_STATE_VALUE;
+    } else if (fromState === DELETED_STATE_VALUE) {
+      return player;
     }
 
     const isRemoval = toState.value === VOID_VALUE;
@@ -740,10 +743,10 @@ export class TransitionAnimationEngine {
 
   private _buildInstruction(
       entry: QueueInstruction, subTimelines: ElementInstructionMap, enterClassName: string,
-      leaveClassName: string, skipBuildAst?: boolean) {
+      leaveClassName: string) {
     return entry.transition.build(
         this.driver, entry.element, entry.fromState.value, entry.toState.value, enterClassName,
-        leaveClassName, entry.fromState.options, entry.toState.options, subTimelines, skipBuildAst);
+        leaveClassName, entry.fromState.options, entry.toState.options, subTimelines);
   }
 
   destroyInnerAnimations(containerElement: any) {
@@ -770,6 +773,10 @@ export class TransitionAnimationEngine {
         }
       });
     }
+    const stateMap = this.statesByElement.get(element);
+    if (stateMap) {
+      Object.keys(stateMap).forEach(triggerName => stateMap[triggerName] = DELETED_STATE_VALUE);
+    }
   }
 
   finishActiveQueriedAnimationOnElement(element: any) {
@@ -962,24 +969,17 @@ export class TransitionAnimationEngine {
           }
         }
 
-        const nodeIsOrphaned = !bodyNode || !this.driver.containsElement(bodyNode, element);
-        const leaveClassName = leaveNodeMapIds.get(element) !;
-        const enterClassName = enterNodeMapIds.get(element) !;
-        const instruction = this._buildInstruction(
-            entry, subTimelines, enterClassName, leaveClassName, nodeIsOrphaned) !;
-        if (instruction.errors && instruction.errors.length) {
-          erroneousTransitions.push(instruction);
+        if (!bodyNode || !this.driver.containsElement(bodyNode, element)) {
+          player.destroy();
           return;
         }
 
-        // even though the element may not be apart of the DOM, it may
-        // still be added at a later point (due to the mechanics of content
-        // projection and/or dynamic component insertion) therefore it's
-        // important we still style the element.
-        if (nodeIsOrphaned) {
-          player.onStart(() => eraseStyles(element, instruction.fromStyles));
-          player.onDestroy(() => setStyles(element, instruction.toStyles));
-          skippedPlayers.push(player);
+        const leaveClassName = leaveNodeMapIds.get(element) !;
+        const enterClassName = enterNodeMapIds.get(element) !;
+        const instruction =
+            this._buildInstruction(entry, subTimelines, enterClassName, leaveClassName) !;
+        if (instruction.errors && instruction.errors.length) {
+          erroneousTransitions.push(instruction);
           return;
         }