release: cut the v7.1.2 release

build: introduce remote bazel caching (#27358 )
This PR introduces: 1. Google Cloud Store bucket which contains build artifacts 2. Documentation on how to enable remote caching in development Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts. PR Close #27358
2018-12-06 15:08:57 -08:00 · 2018-12-06 11:25:03 -08:00 · 2018-12-06 09:24:53 -08:00 · 2018-12-06 09:17:21 -08:00 · 2018-12-06 09:17:21 -08:00 · 2018-12-05 20:55:33 -08:00
1402 changed files with 34341 additions and 200706 deletions
--- a/.bazelignore
+++ b/.bazelignore
@ -1,6 +1,3 @@
 node_modules
 dist
-aio/content
 aio/node_modules
-aio/tools/examples/shared/node_modules
-integration/bazel
--- a/.bazelrc
+++ b/.bazelrc
@ -22,14 +22,8 @@ test:debug --test_arg=--node_options=--inspect-brk --test_output=streamed --test
 # Filesystem interactions     #
 ###############################

-# Create symlinks in the project:
-# - dist/bin for outputs
-# - dist/testlogs, dist/genfiles
-# - bazel-out
-# NB: bazel-out should be excluded from the editor configuration.
-# The checked-in /.vscode/settings.json does this for VSCode.
-# Other editors may require manual config to ignore this directory.
-# In the past, we say a problem where VSCode traversed a massive tree, opening file handles and
+# Don't create symlinks like bazel-out in the project.
+# These cause VSCode to traverse a massive tree, opening file handles and
 # eventually a surprising failure with auto-discovery of the C++ toolchain in
 # MacOS High Sierra.
 # See https://github.com/bazelbuild/bazel/issues/4603
@ -42,16 +36,6 @@ build --watchfs
 run --nolegacy_external_runfiles
 test --nolegacy_external_runfiles

-# Turn on --incompatible_strict_action_env which was on by default
-# in Bazel 0.21.0 but turned off again in 0.22.0. Follow
-# https://github.com/bazelbuild/bazel/issues/7026 for more details.
-# This flag is needed to so that the bazel cache is not invalidated
-# when running bazel via `yarn bazel`.
-# See https://github.com/angular/angular/issues/27514.
-build --incompatible_strict_action_env
-run --incompatible_strict_action_env
-test --incompatible_strict_action_env
-
 ###############################
 # Release support             #
 # Turn on these settings with #
@ -87,33 +71,6 @@ test --experimental_ui
 ################################
 # Temporary Settings for Ivy   #
 ################################
-# to determine if the compiler used should be Ivy or ViewEngine one can use `--define=compile=aot` on
+# to determine if the compiler used should be Ivy or ViewEngine one can use `--define=compile=local` on
 # any bazel target. This is a temporary flag until codebase is permanently switched to Ivy.
 build --define=compile=legacy
-
-###############################
-# Remote Build Execution support
-# Turn on these settings with
-#  --config=remote
-###############################
-
-# Load default settings for Remote Build Execution
-# When updating, the URLs of bazel_toolchains in packages/bazel/package.bzl
-# may also need to be updated (see https://github.com/angular/angular/pull/27935)
-import %workspace%/third_party/github.com/bazelbuild/bazel-toolchains/bazelrc/bazel-0.21.0.bazelrc
-
-# Increase the default number of jobs by 50% because our build has lots of
-# parallelism
-build:remote --jobs=150
-
-# Point to our custom execution platform; see tools/BUILD.bazel
-build:remote --extra_execution_platforms=//tools:rbe_ubuntu1604-angular
-build:remote --host_platform=//tools:rbe_ubuntu1604-angular
-build:remote --platforms=//tools:rbe_ubuntu1604-angular
-
-# Remote instance.
-build:remote --remote_instance_name=projects/internal-200822/instances/default_instance
-
-# Do not accept remote cache.
-# We need to understand the security risks of using prior build artifacts.
-build:remote --remote_accept_cached=false
--- a/.bowerrc
+++ b/.bowerrc
@ -0,0 +1,3 @@
+{
+  "directory" : "bower_components"
+}
--- a/.circleci/bazel.rc
+++ b/.circleci/bazel.rc
@ -1,10 +1,6 @@
 # These options are enabled when running on CI
 # We do this by copying this file to /etc/bazel.bazelrc at the start of the build.
-# See documentation in /docs/BAZEL.md
-
-# Save downloaded repositories in a location that can be cached by CircleCI. This helps us
-# speeding up the analysis time significantly with Bazel managed node dependencies on the CI.
-build --repository_cache=/home/circleci/bazel_repository_cache
+# See remote cache documentation in /docs/BAZEL.md

 # Don't be spammy in the logs
 # TODO(gmagolan): Hide progress again once build performance improves
@ -12,6 +8,9 @@ build --repository_cache=/home/circleci/bazel_repository_cache
 # error: Too long with no output (exceeded 10m0s)
 # build --noshow_progress

+# Don't run manual tests
+test --test_tag_filters=-manual
+
 # Print all the options that apply to the build.
 # This helps us diagnose which options override others
 # (e.g. /etc/bazel.bazelrc vs. tools/bazel.rc)
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@ -11,51 +11,21 @@
 # needed for jobs that run tests without Bazel. Bazel runs tests with browsers that will be
 # fetched by the Webtesting rules. Therefore for jobs that run tests with Bazel, we don't need a
 # docker image with browsers pre-installed.
-# **NOTE 1**: If you change the version of the `*-browsers` docker image, make sure the
-#             `CI_CHROMEDRIVER_VERSION_ARG` env var (in `.circleci/env.sh`) points to a ChromeDriver
-#             version that is compatible with the Chrome version in the image.
-# **NOTE 2**: If you change the version of the docker images, also change the `cache_key` suffix.
+# **NOTE**: If you change the version of the docker images, also change the `cache_key` suffix.
 var_1: &default_docker_image circleci/node:10.12
 var_2: &browsers_docker_image circleci/node:10.12-browsers
-# We don't want to include the current branch name in the cache key because that would prevent
-# PRs from being able to restore the cache since the branch names are always different for PRs.
-# The cache key should only consist of dynamic values that change whenever something in the
-# cache changes. For example:
-# 1) yarn lock file changes --> cached "node_modules" are different.
-# 2) bazel repository definitions change --> cached bazel repositories are different.
-# **NOTE 1 **: If you change the cache key prefix, also sync the restore_cache fallback to match.
-# **NOTE 2 **: Keep the static part of the cache key as prefix to enable correct fallbacks.
-# See https://circleci.com/docs/2.0/caching/#restoring-cache for how prefixes work in CircleCI.
-var_3: &cache_key v3-angular-node-10.12-{{ checksum "yarn.lock" }}-{{ checksum "WORKSPACE" }}-{{ checksum "packages/bazel/package.bzl" }}-{{ checksum "aio/yarn.lock" }}
+var_3: &cache_key v2-angular-{{ .Branch }}-{{ checksum "yarn.lock" }}-node-10.12

-# Initializes the CI environment by setting up common environment variables.
-var_4: &init_environment
+# Define common ENV vars
+var_4: &define_env_vars
  run:
-    name: Initializing environment (setting up variables, overwriting Yarn)
-    # Overwrite the yarn installed in the docker container with our own version.
-    command: |
-      ./.circleci/env.sh
-      ourYarn=$(realpath ./third_party/github.com/yarnpkg/yarn/releases/download/v1.13.0/bin/yarn.js)
-      sudo chmod a+x $ourYarn
-      sudo ln -fs $ourYarn /usr/local/bin/yarn
-      echo "Yarn version: $(yarn --version)"
-
-      # Add GitHub to known hosts.
-      mkdir -p ~/.ssh
-      echo 'github.com ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==' >> ~/.ssh/known_hosts
-
-      # use git+ssh instead of https
-      git config --global url."ssh://git@github.com".insteadOf "https://github.com" || true
-      git config --global gc.auto 0 || true
-
+    name: Define environment variables
+    command: ./.circleci/env.sh

 var_5: &setup_bazel_remote_execution
  run:
    name: "Setup bazel RBE remote execution"
-    command: |
-      openssl aes-256-cbc -d -in .circleci/gcp_token -k "$CI_REPO_NAME" -out /home/circleci/.gcp_credentials
-      echo "export GOOGLE_APPLICATION_CREDENTIALS=/home/circleci/.gcp_credentials" >> $BASH_ENV
-      sudo bash -c "echo 'build --config=remote' >> /etc/bazel.bazelrc"
+    command: openssl aes-256-cbc -d -in .circleci/gcp_token -k "$CI_REPO_NAME" -out /home/circleci/.gcp_credentials && echo "export GOOGLE_APPLICATION_CREDENTIALS=/home/circleci/.gcp_credentials" >> $BASH_ENV && sudo bash -c "cat .circleci/rbe-bazel.rc >> /etc/bazel.bazelrc"

 # Settings common to each job
 var_6: &job_defaults
@ -67,113 +37,51 @@ var_6: &job_defaults
 # Similar to travis behavior, but not quite the same.
 # See https://discuss.circleci.com/t/1662
 var_7: &post_checkout
-  run:
-    name: Post checkout step
-    command: >
-      if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then
-        # Fetch the head and merge commits for this PR.
-        git fetch origin +refs/pull/$CIRCLE_PR_NUMBER/head:pr/$CIRCLE_PR_NUMBER/head
-        git fetch origin +refs/pull/$CIRCLE_PR_NUMBER/merge:pr/$CIRCLE_PR_NUMBER/merge
-        # Checkout the merged PR for testing as CircleCI will just use the PR head otherwise.
-        git checkout -qf pr/$CIRCLE_PR_NUMBER/merge
-        # Reset the merge commit into its PR head.
-        git reset pr/$CIRCLE_PR_NUMBER/head
-        # Commit the merge changes into the head of the PR.
-        # This way we keep the last commit message.
-        git config user.name "angular-ci"
-        git config user.email "angular-ci"
-        git commit . --amend --no-edit
-      fi
+  post: git pull --ff-only origin "refs/pull/${CI_PULL_REQUEST//*pull\//}/merge"

 var_8: &yarn_install
  run:
    name: Running Yarn install
-    command: |
-      # Yarn's requests sometimes take more than 10mins to complete.
-      # Print something to stdout, to prevent CircleCI from failing due to not output.
-      while true; do sleep 60; echo "[`date`] Keeping alive..."; done &
-      KEEP_ALIVE_PID=$!
-      yarn install --frozen-lockfile --non-interactive
-      kill $KEEP_ALIVE_PID
+    command: yarn install --frozen-lockfile --non-interactive

 var_9: &setup_circleci_bazel_config
  run:
    name: Setting up CircleCI bazel configuration
    command: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc

-var_10: &restore_cache
-  restore_cache:
-    keys:
-      - *cache_key
-      # This fallback should be the cache_key without variables.
-      - v3-angular-node-10.12-
-
-# Branch filter that can be specified for jobs that should only run on publish branches
-# (e.g. master or the patch branch)
-var_12: &publish_branches_filter
-  branches:
-    only:
-      - master
-      # e.g. 7.0.x, 7.1.x, etc.
-      - /\d+\.\d+\.x/
-
-# Workspace initially persisted by the `install` job, and then enhanced by `test_aio` and
-# `build-npm-packages`.
-# https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
-# https://circleci.com/blog/deep-diving-into-circleci-workspaces/
-var_13: &attach_workspace
-  attach_workspace:
-    at: ~/
-
 version: 2
 jobs:
-  setup:
-    <<: *job_defaults
-    steps:
-      - checkout
-      - *post_checkout
-      # This cache is saved in the build-npm-packages so that Bazel cache is also included.
-      - *restore_cache
-      - *init_environment
-      - *yarn_install
-      - run: yarn --cwd aio install --frozen-lockfile --non-interactive
-      # Make the bazel directories and add a file to them if they don't exist already so that
-      # persist_to_workspace does not fail.
-      - run: |
-          if [ ! -d ~/bazel_repository_cache ]; then
-            mkdir ~/bazel_repository_cache
-            touch ~/bazel_repository_cache/MARKER
-          fi
-      # Persist any changes at this point to be reused by further jobs.
-      # **NOTE 1 **: Folders persisted here should be kept in sync with `var_13: &attach_workspace`.
-      # **NOTE 2 **: To add new content to the workspace, always persist on the same root.
-      - persist_to_workspace:
-          root: ~/
-          paths:
-            - ./ng
-            - ./bazel_repository_cache
-
  lint:
    <<: *job_defaults
+    resource_class: xlarge
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
+      - *setup_circleci_bazel_config
+      - *yarn_install

-      - run: 'yarn bazel:format -mode=check ||
-              (echo "BUILD files not formatted. Please run ''yarn bazel:format''" ; exit 1)'
+      - run: 'yarn buildifier -mode=check ||
+              (echo "BUILD files not formatted. Please run ''yarn buildifier''" ; exit 1)'
      # Run the skylark linter to check our Bazel rules
-      - run: 'yarn bazel:lint ||
-              (echo -e "\n.bzl files have lint errors. Please run ''yarn bazel:lint-fix''"; exit 1)'
+      - run: 'yarn skylint ||
+              (echo -e "\n.bzl files have lint errors. Please run ''yarn skylint''"; exit 1)'

-      - run: yarn gulp lint
+      - run: ./node_modules/.bin/gulp lint

  test:
    <<: *job_defaults
    resource_class: xlarge
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
      - *setup_circleci_bazel_config
+      - *yarn_install

      # Setup remote execution and run RBE-compatible tests.
      - *setup_bazel_remote_execution
@ -182,14 +90,24 @@ jobs:
      - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
      - run: yarn bazel test //... --build_tag_filters=-ivy-only,local --test_tag_filters=-ivy-only,local

+      - save_cache:
+          key: *cache_key
+          paths:
+            - "node_modules"
+            - "~/bazel_repository_cache"
+
  # Temporary job to test what will happen when we flip the Ivy flag to true
  test_ivy_aot:
    <<: *job_defaults
    resource_class: xlarge
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
      - *setup_circleci_bazel_config
+      - *yarn_install
      - *setup_bazel_remote_execution

        # We need to explicitly specify the --symlink_prefix option because otherwise we would
@ -222,8 +140,11 @@ jobs:
      # Needed because the AIO tests and the PWA score test depend on Chrome being available.
      - image: *browsers_docker_image
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
        # Build aio
      - run: yarn --cwd aio build --progress=false
        # Lint the code
@ -235,9 +156,9 @@ jobs:
        # (Run before unit and e2e tests, which destroy the `dist/` directory.)
      - run: yarn --cwd aio payload-size
        # Run unit tests
-      - run: yarn --cwd aio test --progress=false --watch=false
+      - run: yarn --cwd aio test --watch=false
        # Run e2e tests
-      - run: yarn --cwd aio e2e --configuration=ci
+      - run: yarn --cwd aio e2e
        # Run unit tests for Firebase redirects
      - run: yarn --cwd aio redirects-test

@ -247,8 +168,11 @@ jobs:
    # Needed because before deploying the deploy-production script runs the PWA score tests.
    - image: *browsers_docker_image
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
        # Deploy angular.io to production (if necessary)
      - run: setPublicVar CI_STABLE_BRANCH "$(npm info @angular/core dist-tags.latest | sed -r 's/^\s*([0-9]+\.[0-9]+)\.[0-9]+.*$/\1.x/')"
      - run: yarn --cwd aio deploy-production
@ -259,31 +183,33 @@ jobs:
      # Needed because the AIO tests and the PWA score test depend on Chrome being available.
      - image: *browsers_docker_image
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
        # Build aio (with local Angular packages)
      - run: yarn --cwd aio build-local --progress=false
        # Run PWA-score tests
        # (Run before unit and e2e tests, which destroy the `dist/` directory.)
      - run: yarn --cwd aio test-pwa-score-localhost $CI_AIO_MIN_PWA_SCORE
        # Run unit tests
-      - run: yarn --cwd aio test --progress=false --watch=false
+      - run: yarn --cwd aio test --watch=false
        # Run e2e tests
-      - run: yarn --cwd aio e2e --configuration=ci
-
-  test_aio_local_ivy:
-    <<: *job_defaults
-    steps:
-      - *attach_workspace
-      - *init_environment
-        # Build aio with Ivy (using local Angular packages)
-      - run: yarn --cwd aio build-with-ivy --progress=false
+      - run: yarn --cwd aio e2e

  test_aio_tools:
    <<: *job_defaults
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
        # Install
      - run: yarn --cwd aio install --frozen-lockfile --non-interactive
      - run: yarn --cwd aio extract-cli-command-docs
@ -291,37 +217,45 @@ jobs:
      - run: yarn --cwd aio tools-test
      - run: ./aio/aio-builds-setup/scripts/test.sh

-  test_docs_examples:
+  test_docs_examples_0:
    <<: *job_defaults
    docker:
      # Needed because the example e2e tests depend on Chrome.
      - image: *browsers_docker_image
-    parallelism: 3
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
+        # Install root
+      - *yarn_install
        # Install aio
      - run: yarn --cwd aio install --frozen-lockfile --non-interactive
-        # Run examples tests. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled.
-        # Since the parallelism is set to "3", there will be three parallel CircleCI containers
-        # with either "0", "1" or "2" as node index. This can be passed to the "--shard" argument.
-      - run: yarn --cwd aio example-e2e --setup --local --shard=${CIRCLE_NODE_INDEX}/${CIRCLE_NODE_TOTAL}
+        # Run examples tests
+      - run: yarn --cwd aio example-e2e --setup --local --shard=0/2

-  test_docs_examples_ivy:
+  test_docs_examples_1:
    <<: *job_defaults
    docker:
      # Needed because the example e2e tests depend on Chrome.
      - image: *browsers_docker_image
-    parallelism: 3
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
+        # Install root
+      - *yarn_install
        # Install aio
      - run: yarn --cwd aio install --frozen-lockfile --non-interactive
-        # Run examples tests with ivy. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled.
-        # Since the parallelism is set to "3", there will be three parallel CircleCI containers
-        # with either "0", "1" or "2" as node index. This can be passed to the "--shard" argument.
-      - run: yarn --cwd aio example-e2e --setup --local --ivy --shard=${CIRCLE_NODE_INDEX}/${CIRCLE_NODE_TOTAL}
+        # Run examples tests
+      - run: yarn --cwd aio example-e2e --setup --local --shard=1/2

  # This job should only be run on PR builds, where `CI_PULL_REQUEST` is not `false`.
  aio_preview:
@ -329,8 +263,12 @@ jobs:
    environment:
       AIO_SNAPSHOT_ARTIFACT_PATH: &aio_preview_artifact_path 'aio/tmp/snapshot.tgz'
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
+      - *yarn_install
      - run: ./aio/scripts/build-artifacts.sh $AIO_SNAPSHOT_ARTIFACT_PATH $CI_PULL_REQUEST $CI_COMMIT
      - store_artifacts:
          path: *aio_preview_artifact_path
@ -346,64 +284,46 @@ jobs:
      # Needed because the test-preview script runs e2e tests and the PWA score test with Chrome.
      - image: *browsers_docker_image
    steps:
-      - *attach_workspace
-      - *init_environment
-      - run: yarn --cwd aio install --frozen-lockfile --non-interactive
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
+      - run: yarn install --cwd aio --frozen-lockfile --non-interactive
      - run:
          name: Wait for preview and run tests
          command: node aio/scripts/test-preview.js $CI_PULL_REQUEST $CI_COMMIT $CI_AIO_MIN_PWA_SCORE

-
-  # The `build-npm-packages` tasks exist for backwards-compatibility with old scripts and
-  # tests that rely on the pre-Bazel `dist/packages-dist` output structure (build.sh).
-  # Having multiple jobs that independently build in this manner duplicates some work; we build
-  # the bazel packages more than once. Even though we have a remote cache, these jobs will
-  # typically run in parallel so up-to-date outputs will not be available at the time the build
+  # This job exists only for backwards-compatibility with old scripts and tests
+  # that rely on the pre-Bazel dist/packages-dist layout.
+  # It duplicates some work with the job above: we build the bazel packages
+  # twice. Even though we have a remote cache, these jobs will typically run in
+  # parallel so up-to-date outputs will not be available at the time the build
  # starts.
-
-  # Build the view engine npm packages. No new jobs should depend on this.
-  build-npm-packages:
+  # No new jobs should depend on this one.
+  build-packages-dist:
    <<: *job_defaults
    resource_class: xlarge
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
      - *setup_circleci_bazel_config
+      - *yarn_install
      - *setup_bazel_remote_execution

      - run: scripts/build-packages-dist.sh

      # Save the npm packages from //packages/... for other workflow jobs to read
+      # https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
      - persist_to_workspace:
-          root: ~/
+          root: dist
          paths:
-            - ng/dist/packages-dist
-
-      # Save dependencies and bazel repository cache to use on subsequent runs.
-      - save_cache:
-          key: *cache_key
-          paths:
-            - "node_modules"
-            - "aio/node_modules"
-            - "~/bazel_repository_cache"
-
-  # Build the ivy npm packages.
-  build-ivy-npm-packages:
-    <<: *job_defaults
-    resource_class: xlarge
-    steps:
-      - *attach_workspace
-      - *init_environment
-      - *setup_circleci_bazel_config
-      - *setup_bazel_remote_execution
-
-      - run: scripts/build-ivy-npm-packages.sh
-
-      # Save the npm packages from //packages/... for other workflow jobs to read
-      - persist_to_workspace:
-          root: ~/
-          paths:
-            - ng/dist/packages-dist-ivy-aot
+            - packages-dist
+            - packages-dist-ivy-jit
+            - packages-dist-ivy-aot

  # We run the integration tests outside of Bazel for now.
  # They are a separate workflow job so that they can be easily re-run.
@ -413,7 +333,6 @@ jobs:
  # See comments inside the integration/run_tests.sh script.
  integration_test:
    <<: *job_defaults
-    parallelism: 4
    docker:
      # Needed because the integration tests expect Chrome to be installed (e.g cli-hello-world)
      - image: *browsers_docker_image
@ -422,19 +341,23 @@ jobs:
    # on a 4G worker so we use a larger machine here too.
    resource_class: xlarge
    steps:
-      - *attach_workspace
-      - *init_environment
-      # Runs the integration tests in parallel across multiple CircleCI container instances. The
-      # amount of container nodes for this job is controlled by the "parallelism" option.
-      - run: ./integration/run_tests.sh ${CIRCLE_NODE_INDEX} ${CIRCLE_NODE_TOTAL}
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - attach_workspace:
+          at: dist
+      - *define_env_vars
+      - run: ./integration/run_tests.sh

  # This job updates the content of repos like github.com/angular/core-builds
  # for every green build on angular/angular.
  publish_snapshot:
    <<: *job_defaults
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - *define_env_vars
      # See below - ideally this job should not trigger for non-upstream builds.
      # But since it does, we have to check this condition.
      - run:
@ -445,6 +368,8 @@ jobs:
              || "$CI_REPO_OWNER" != "angular"
              || "$CI_REPO_NAME" != "angular"
          ]] && circleci step halt || true'
+      - attach_workspace:
+          at: dist
      # CircleCI has a config setting to force SSH for all github connections
      # This is not compatible with our mechanism of using a Personal Access Token
      # Clear the global setting
@ -461,98 +386,44 @@ jobs:
      # which does not load the browser through the Bazel webtesting rules.
      - image: *browsers_docker_image
    steps:
-      - *attach_workspace
-      - *init_environment
+      - checkout:
+          <<: *post_checkout
+      - restore_cache:
+          key: *cache_key
+      - *define_env_vars
      - run:
          name: Run tests against the deployed apps
          command: ./aio/scripts/test-production.sh $CI_AIO_MIN_PWA_SCORE
      - run:
          name: Notify caretaker about failure
-          # `$SLACK_CARETAKER_WEBHOOK_URL` is a secret env var defined in CircleCI project settings.
-          # The URL comes from https://angular-team.slack.com/apps/A0F7VRE7N-circleci.
-          command: 'curl --request POST --header "Content-Type: application/json" --data "{\"text\":\":x: \`$CIRCLE_JOB\` job failed on build $CIRCLE_BUILD_NUM: $CIRCLE_BUILD_URL :scream:\"}" $SLACK_CARETAKER_WEBHOOK_URL'
+          command: 'curl --request POST --header "Content-Type: application/json" --data "{\"text\":\":x: \`$CIRCLE_JOB\` job failed on build $CIRCLE_BUILD_NUM: $CIRCLE_BUILD_URL :scream:\"}" $CI_SECRET_SLACK_CARETAKER_WEBHOOK_URL'
          when: on_fail

-  legacy-unit-tests-saucelabs:
-    <<: *job_defaults
-    # In order to avoid the bottleneck of having a slow host machine, we acquire a better
-    # container for this job. This is necessary because we launch a lot of browsers concurrently
-    # and therefore the tunnel and Karma need to process a lot of file requests and tests.
-    resource_class: xlarge
-    steps:
-      - *attach_workspace
-      - *init_environment
-      - run:
-          name: Preparing environment for running tests on Saucelabs.
-          command: |
-            setPublicVar KARMA_JS_BROWSERS $(node -e 'console.log(require("./browser-providers.conf").sauceAliases.CI_REQUIRED.join(","))')
-            setSecretVar SAUCE_ACCESS_KEY $(echo $SAUCE_ACCESS_KEY | rev)
-      - run:
-          name: Starting Saucelabs tunnel
-          command: ./scripts/saucelabs/start-tunnel.sh
-          background: true
-      - run: yarn tsc -p packages
-      - run: yarn tsc -p modules
-        # Waits for the Saucelabs tunnel to be ready. This ensures that we don't run tests
-        # too early without Saucelabs not being ready.
-      - run: ./scripts/saucelabs/wait-for-tunnel.sh
-      - run: yarn karma start ./karma-js.conf.js --single-run --browsers=${KARMA_JS_BROWSERS}
-      - run: ./scripts/saucelabs/stop-tunnel.sh
-
-  legacy-misc-tests:
-    <<: *job_defaults
-    steps:
-      - *attach_workspace
-      - *init_environment
-      - run: yarn gulp check-cycle
-      # TODO: disabled because the Bazel packages-dist does not seem to have map files for
-      # the ESM5/ES2015 output. See: https://github.com/angular/angular/issues/27966
-      # - run: yarn gulp source-map-test
-
 workflows:
  version: 2
  default_workflow:
    jobs:
-      - setup
-      - lint:
-          requires:
-          - setup
-      - test:
-          requires:
-          - setup
-      - test_ivy_aot:
-          requires:
-          - setup
-      - build-npm-packages:
-          requires:
-          - setup
-      - test_aio:
-          requires:
-          - setup
+      - lint
+      - test
+      - test_ivy_aot
+      - build-packages-dist
+      - test_aio
      - deploy_aio:
          requires:
            - test_aio
-      - legacy-misc-tests:
-          requires:
-            - build-npm-packages
      - test_aio_local:
          requires:
-            - build-npm-packages
-      # - test_aio_local_ivy:
-      #     requires:
-      #       - build-npm-packages
+            - build-packages-dist
      - test_aio_tools:
          requires:
-            - build-npm-packages
-      - test_docs_examples:
+            - build-packages-dist
+      - test_docs_examples_0:
          requires:
-            - build-npm-packages
-      # - test_docs_examples_ivy:
-      #     requires:
-      #       - build-npm-packages
+            - build-packages-dist
+      - test_docs_examples_1:
+          requires:
+            - build-packages-dist
      - aio_preview:
-          requires:
-            - setup
          # Only run on PR builds. (There can be no previews for non-PR builds.)
          filters:
            branches:
@ -562,7 +433,7 @@ workflows:
            - aio_preview
      - integration_test:
          requires:
-            - build-npm-packages
+            - build-packages-dist
      - publish_snapshot:
          # Note: no filters on this job because we want it to run for all upstream branches
          # We'd really like to filter out pull requests here, but not yet available:
@ -575,44 +446,19 @@ workflows:
            - integration_test
            # Only publish if `aio`/`docs` tests using the locally built Angular packages pass
            - test_aio_local
-            # - test_aio_local_ivy
-            - test_docs_examples
-            # - test_docs_examples_ivy
+            - test_docs_examples_0
+            - test_docs_examples_1
            # Get the artifacts to publish from the build-packages-dist job
            # since the publishing script expects the legacy outputs layout.
-            - build-npm-packages
-            - legacy-misc-tests
-
-  saucelabs_tests:
-    jobs:
-      - setup
-      - legacy-unit-tests-saucelabs:
-          requires:
-            - setup
-    triggers:
-      - schedule:
-          # Runs the Saucelabs legacy tests every hour. We still want to run Saucelabs
-          # frequently as the caretaker needs up-to-date results when merging PRs or creating
-          # a new release. Also we primarily moved the Saucelabs job into a cronjob that doesn't
-          # run for PRs, in order to ensure that PRs are not affected by Saucelabs flakiness or
-          # incidents. This is still guaranteed (even if we run the job every hour).
-          cron: "0 * * * *"
-          filters: *publish_branches_filter
+            - build-packages-dist

  aio_monitoring:
    jobs:
      - aio_monitoring
    triggers:
      - schedule:
-          # Runs AIO monitoring job at 00:00AM every day.
          cron: "0 0 * * *"
          filters:
            branches:
              only:
                - master
-
-# TODO:
-# - don't build the g3 branch
-# - verify that we are bootstrapping with the right yarn version coming from the docker image
-# - check local chrome version pulled from docker image
-# - remove /tools/ngcontainer
--- a/.circleci/env-helpers.inc.sh
+++ b/.circleci/env-helpers.inc.sh
@ -15,7 +15,7 @@
 #
 # Usage: `setPublicVar <name> <value>`
 function setPublicVar() {
-  setSecretVar $1 "$2";
+  setSecretVar $1 $2;
  echo "$1=$2";
 }

--- a/.circleci/env.sh
+++ b/.circleci/env.sh
@ -1,11 +1,7 @@
 #!/usr/bin/env bash

-# Variables
-readonly projectDir=$(realpath "$(dirname ${BASH_SOURCE[0]})/..")
-readonly envHelpersPath="$projectDir/.circleci/env-helpers.inc.sh";
-readonly getCommitRangePath="$projectDir/.circleci/get-commit-range.js";
-
 # Load helpers and make them available everywhere (through `$BASH_ENV`).
+readonly envHelpersPath="`dirname $0`/env-helpers.inc.sh";
 source $envHelpersPath;
 echo "source $envHelpersPath;" >> $BASH_ENV;

@ -13,22 +9,14 @@ echo "source $envHelpersPath;" >> $BASH_ENV;
 ####################################################################################################
 # Define PUBLIC environment variables for CircleCI.
 ####################################################################################################
-# See https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables for more info.
-####################################################################################################
-setPublicVar PROJECT_ROOT "$projectDir";
+setPublicVar PROJECT_ROOT "$(pwd)";
 setPublicVar CI_AIO_MIN_PWA_SCORE "95";
 # This is the branch being built; e.g. `pull/12345` for PR builds.
 setPublicVar CI_BRANCH "$CIRCLE_BRANCH";
-# ChromeDriver version compatible with the Chrome version included in the docker image used in
-# `.circleci/config.yml`. See http://chromedriver.chromium.org/downloads for a list of versions.
-# This variable is intended to be passed as an arg to the `webdriver-manager update` command (e.g.
-# `"postinstall": "webdriver-manager update $CI_CHROMEDRIVER_VERSION_ARG"`).
-setPublicVar CI_CHROMEDRIVER_VERSION_ARG "--versions.chrome 2.45";
 setPublicVar CI_COMMIT "$CIRCLE_SHA1";
-# `CI_COMMIT_RANGE` will only be available when `CIRCLE_COMPARE_URL` is also available (or can be
-# retrieved via `get-compare-url.js`), i.e. on push builds (a.k.a. non-PR, non-scheduled builds and
-# rerun workflows of such builds). That is fine, since we only need it in push builds.
-setPublicVar CI_COMMIT_RANGE "`[[ ${CIRCLE_PR_NUMBER:-false} != false ]] && echo "" || node $getCommitRangePath "$CIRCLE_BUILD_NUM" "$CIRCLE_COMPARE_URL"`";
+# `CI_COMMIT_RANGE` will only be available when `CIRCLE_COMPARE_URL` is also available,
+# i.e. on push builds (a.k.a. non-PR builds). That is fine, since we only need it in push builds.
+setPublicVar CI_COMMIT_RANGE "$(sed -r 's|^.*/([0-9a-f]+\.\.\.[0-9a-f]+)$|\1|i' <<< ${CIRCLE_COMPARE_URL:-})";
 setPublicVar CI_PULL_REQUEST "${CIRCLE_PR_NUMBER:-false}";
 setPublicVar CI_REPO_NAME "$CIRCLE_PROJECT_REPONAME";
 setPublicVar CI_REPO_OWNER "$CIRCLE_PROJECT_USERNAME";
@ -39,27 +27,8 @@ setPublicVar CI_REPO_OWNER "$CIRCLE_PROJECT_USERNAME";
 ####################################################################################################
 setSecretVar CI_SECRET_AIO_DEPLOY_FIREBASE_TOKEN "$AIO_DEPLOY_TOKEN";
 setSecretVar CI_SECRET_PAYLOAD_FIREBASE_TOKEN "$ANGULAR_PAYLOAD_TOKEN";
-
-
-####################################################################################################
-# Define SauceLabs environment variables for CircleCI.
-####################################################################################################
-# In order to have a meaningful SauceLabs badge on the repo page,
-# the angular2-ci account is used only when pushing commits to master;
-# in all other cases, the regular angular-ci account is used.
-if [ "${CI_PULL_REQUEST}" = "false" ] && [ "${CI_REPO_OWNER}" = "angular" ] && [ "${CI_BRANCH}" = "master" ]; then
-  setPublicVar SAUCE_USERNAME "angular2-ci";
-  setSecretVar SAUCE_ACCESS_KEY "693ebc16208a-0b5b-1614-8d66-a2662f4e";
-else
-  setPublicVar SAUCE_USERNAME "angular-ci";
-  setSecretVar SAUCE_ACCESS_KEY "9b988f434ff8-fbca-8aa4-4ae3-35442987";
-fi
-setPublicVar SAUCE_READY_FILE /tmp/angular/sauce-connect-ready-file.lock
-setPublicVar SAUCE_PID_FILE /tmp/angular/sauce-connect-pid-file.lock
-setPublicVar SAUCE_TUNNEL_IDENTIFIER "angular-${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}"
-# Amount of seconds we wait for sauceconnect to establish a tunnel instance. In order to not
-# acquire CircleCI instances for too long if sauceconnect failed, we need a connect timeout.
-setPublicVar SAUCE_READY_FILE_TIMEOUT 120
+# Defined in https://angular-team.slack.com/apps/A0F7VRE7N-circleci.
+setSecretVar CI_SECRET_SLACK_CARETAKER_WEBHOOK_URL "$SLACK_CARETAKER_WEBHOOK_URL";


 # Source `$BASH_ENV` to make the variables available immediately.
--- a/.circleci/get-commit-range.js
+++ b/.circleci/get-commit-range.js
@ -1,159 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * **Usage:**
- * ```
- * node get-commit-range <build-number> [<compare-url> [<circle-token>]]
- * ```
- *
- * Returns the value of the `CIRCLE_COMPARE_URL` environment variable (if defined) or, if this is
- * not a PR build (i.e. `CIRCLE_PR_NUMBER` is not defined), retrieves the equivalent of
- * `CIRCLE_COMPARE_URL` for jobs that are part of a rerun workflow.
- *
- * **Context:**
- * CircleCI sets the `CIRCLE_COMPARE_URL` environment variable (from which we can extract the commit
- * range) on push builds (a.k.a. non-PR, non-scheduled builds). Yet, when a workflow is rerun
- * (either from the beginning or from failed jobs) - e.g. when a job flakes - CircleCI does not set
- * the `CIRCLE_COMPARE_URL`.
- *
- * **Implementation details:**
- * This script relies on the fact that all rerun workflows share the same CircleCI workspace and the
- * (undocumented) fact that the workspace ID happens to be the same as the workflow ID that first
- * created it.
- *
- * For example, for a job on push build workflow, the CircleCI API will return data that look like:
- * ```js
- * {
- *   compare: 'THE_COMPARE_URL_WE_ARE_LOOKING_FOR',
- *   //...
- *   previous: {
- *     // ...
- *     build_num: 12345,
- *   },
- *   //...
- *   workflows: {
- *     //...
- *     workflow_id: 'SOME_ID_A',
- *     workspace_id: 'SOME_ID_A',  // Same as `workflow_id`.
- *   }
- * }
- * ```
- *
- * If the workflow is rerun, the data for jobs on the new workflow will look like:
- * ```js
- * {
- *   compare: null,  // ¯\_(ツ)_/¯
- *   //...
- *   previous: {
- *     // ...
- *     build_num: 23456,
- *   },
- *   //...
- *   workflows: {
- *     //...
- *     workflow_id: 'SOME_ID_B',
- *     workspace_id: 'SOME_ID_A',  // Different from current `workflow_id`.
- *                                 // Same as original `workflow_id`. \o/
- *   }
- * }
- * ```
- *
- * This script uses the `previous.build_num` (which points to the previous build number on the same
- * branch) to traverse the jobs backwards, until it finds a job from the original workflow. Such a
- * job (if found) should also contain the compare URL.
- *
- * **NOTE 1:**
- * This is only useful on workflows which are created by rerunning a workflow for which
- * `CIRCLE_COMPARE_URL` was defined.
- *
- * **NOTE 2:**
- * The `circleToken` will be used for CircleCI API requests if provided, but it is not needed for
- * accessing the read-only endpoints that we need (as long as the current project is FOSS and the
- * corresponding setting is turned on in "Advanced Settings" in the project dashboard).
- *
- * ---
- * Inspired by https://circleci.com/orbs/registry/orb/iynere/compare-url
- * (source code: https://github.com/iynere/compare-url-orb).
- *
- * We are not using the `compare-url` orb for the following reasons:
- * 1. (By looking at the code) it would only work if the rerun workflow is the latest workflow on
- *    the branch (which is not guaranteed to be true).
- * 2. It is less efficient (e.g. makes unnecessary CircleCI API requests for builds on different
- *    branches, installs extra dependencies, persists files to the workspace (as a means of passing
- *    the result to the calling job), etc.).
- * 3. It is slightly more complicated to setup and consume than our own script.
- * 4. Its implementation is more complicated than needed for our usecase (e.g. handles different git
- *    providers, handles newly created branches, etc.).
- */
-
-// Imports
-const {get: httpsGet} = require('https');
-
-// Constants
-const API_URL_BASE = 'https://circleci.com/api/v1.1/project/github/angular/angular';
-const COMPARE_URL_RE = /^.*\/([0-9a-f]+\.\.\.[0-9a-f]+)$/i;
-
-// Run
-_main(process.argv.slice(2));
-
-// Helpers
-async function _main([buildNumber, compareUrl = '', circleToken = '']) {
-  try {
-    if (!buildNumber || isNaN(buildNumber)) {
-      throw new Error(
-          'Missing or invalid arguments.\n' +
-          'Expected: buildNumber (number), compareUrl? (string), circleToken? (string)');
-    }
-
-    if (!compareUrl) {
-      compareUrl = await getCompareUrl(buildNumber, circleToken);
-    }
-
-    const commitRangeMatch = COMPARE_URL_RE.exec(compareUrl)
-    const commitRange = commitRangeMatch ? commitRangeMatch[1] : '';
-
-    console.log(commitRange);
-  } catch (err) {
-    console.error(err);
-    process.exit(1);
-  }
-}
-
-function getBuildInfo(buildNumber, circleToken) {
-  console.error(`BUILD ${buildNumber}`);
-  const url = `${API_URL_BASE}/${buildNumber}?circle-token=${circleToken}`;
-  return getJson(url);
-}
-
-async function getCompareUrl(buildNumber, circleToken) {
-  let info = await getBuildInfo(buildNumber, circleToken);
-  const targetWorkflowId = info.workflows.workspace_id;
-
-  while (info.workflows.workflow_id !== targetWorkflowId) {
-    info = await getBuildInfo(info.previous.build_num, circleToken);
-  }
-
-  return info.compare || '';
-}
-
-function getJson(url) {
-  return new Promise((resolve, reject) => {
-    const opts = {headers: {Accept: 'application/json'}};
-    const onResponse = res => {
-      const statusCode = res.statusCode || -1;
-      const isSuccess = (200 <= statusCode) && (statusCode <= 400);
-      let responseText = '';
-
-      res.
-        on('error', reject).
-        on('data', d => responseText += d).
-        on('end', () => isSuccess ?
-          resolve(JSON.parse(responseText)) :
-          reject(`Error getting '${url}' (status ${statusCode}):\n${responseText}`));
-    };
-
-    httpsGet(url, opts, onResponse).
-      on('error', reject).
-      end();
-  });
-}
--- a/.circleci/rbe-bazel.rc
+++ b/.circleci/rbe-bazel.rc
@ -0,0 +1,77 @@
+# These options are enabled when running on CI with Remote Build Execution.
+
+################################################################
+# Toolchain related flags for remote build execution.          #
+################################################################
+# Remote Build Execution requires a strong hash function, such as SHA256.
+startup --host_jvm_args=-Dbazel.DigestFunction=SHA256
+
+# Depending on how many machines are in the remote execution instance, setting
+# this higher can make builds faster by allowing more jobs to run in parallel.
+# Setting it too high can result in jobs that timeout, however, while waiting
+# for a remote machine to execute them.
+build --jobs=150
+
+# Set several flags related to specifying the platform, toolchain and java
+# properties.
+# These flags are duplicated rather than imported from (for example)
+# %workspace%/configs/ubuntu16_04_clang/1.0/toolchain.bazelrc to make this
+# bazelrc a standalone file that can be copied more easily.
+# These flags should only be used as is for the rbe-ubuntu16-04 container
+# and need to be adapted to work with other toolchain containers.
+build --host_javabase=@bazel_toolchains//configs/ubuntu16_04_clang/1.0:jdk8
+build --javabase=@bazel_toolchains//configs/ubuntu16_04_clang/1.0:jdk8
+build --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8
+build --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8
+build --crosstool_top=@bazel_toolchains//configs/ubuntu16_04_clang/1.0/bazel_0.15.0/default:toolchain
+build --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+# Platform flags:
+# The toolchain container used for execution is defined in the target indicated
+# by "extra_execution_platforms", "host_platform" and "platforms".
+# If you are using your own toolchain container, you need to create a platform
+# target with "constraint_values" that allow for the toolchain specified with
+# "extra_toolchains" to be selected (given constraints defined in
+# "exec_compatible_with").
+# More about platforms: https://docs.bazel.build/versions/master/platforms.html
+build --extra_toolchains=@bazel_toolchains//configs/ubuntu16_04_clang/1.0/bazel_0.15.0/cpp:cc-toolchain-clang-x86_64-default
+build --extra_execution_platforms=//tools:rbe_ubuntu1604-angular
+build --host_platform=//tools:rbe_ubuntu1604-angular
+build --platforms=//tools:rbe_ubuntu1604-angular
+
+# Set various strategies so that all actions execute remotely. Mixing remote
+# and local execution will lead to errors unless the toolchain and remote
+# machine exactly match the host machine.
+build --spawn_strategy=remote
+build --strategy=Javac=remote
+build --strategy=Closure=remote
+build --genrule_strategy=remote
+build --define=EXECUTOR=remote
+
+# Enable the remote cache so action results can be shared across machines,
+# developers, and workspaces.
+build --remote_cache=remotebuildexecution.googleapis.com
+
+# Enable remote execution so actions are performed on the remote systems.
+build --remote_executor=remotebuildexecution.googleapis.com
+
+# Remote instance.
+build --remote_instance_name=projects/internal-200822/instances/default_instance
+
+# Enable encryption.
+build --tls_enabled=true
+
+# Enforce stricter environment rules, which eliminates some non-hermetic
+# behavior and therefore improves both the remote cache hit rate and the
+# correctness and repeatability of the build.
+build --experimental_strict_action_env=true
+
+# Set a higher timeout value, just in case.
+build --remote_timeout=3600
+
+# Enable authentication. This will pick up application default credentials by
+# default. You can use --auth_credentials=some_file.json to use a service
+# account credential instead.
+build --auth_enabled=true
+
+# Do not accept remote cache.
+build --remote_accept_cached=false
--- a/.editorconfig
+++ b/.editorconfig
@ -1,4 +1,4 @@
-# https://editorconfig.org
+# http://editorconfig.org

 root = true

--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@ -1,770 +0,0 @@
-# ==================================================================================
-# ==================================================================================
-#                                Angular CODEOWNERS
-# ==================================================================================
-# ==================================================================================
-#
-#  Configuration of code ownership and review approvals for the angular/angular repo.
-#
-#  More info: https://help.github.com/articles/about-codeowners/
-#
-
-
-# ================================================
-#  General rules / philosophy
-# ================================================
-#
-#  - we trust that people do the right thing and not approve changes they don't feel confident reviewing
-#  - we use github teams so that we funnel code reviews to the most appropriate reviewer, this is why the team structure is fine-grained
-#  - we enforce that only approved PRs get merged to ensure that unreviewed code doesn't get accidentally merged
-#  - we delegate approval rights as much as possible so that we can scale better
-#  - each group must have at least one person, but several people are preferable to avoid a single point of failure issues
-#  - most file groups have one or two global approvers groups as fallbacks:
-#    - @angular/fw-global-approvers: for approving minor changes, large-scale refactorings, and emergency situations.
-#    - @angular/fw-global-approvers-for-docs-only-changes: for approving minor documentation-only changes that don't require engineering review
-#  - a small number of file groups have very limited number of reviewers because incorrect changes to the files they guard would have serious consequences (e.g. security, public api)
-#
-#  Configuration nuances:
-#
-#  - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
-#  - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
-#  - Each codeowners team must have write access to the repo, otherwise their reviews won't count.
-#
-#  In the case of emergency, the repo administrators which include angular-caretaker can bypass this requirement.
-
-
-
-# ================================================
-#  GitHub username registry
-#  (just to make this file easier to understand)
-# ================================================
-
-#  alexeagle - Alex Eagle
-#  alxhub - Alex Rickabaugh
-#  AndrewKushnir - Andrew Kushnir
-#  andrewseguin - Andrew Seguin
-#  benlesh - Ben Lesh
-#  brandonroberts - Brandon Roberts
-#  filipesilva - Filipe Silva
-#  gkalpak - George Kalpakas
-#  hansl - Hans Larsen
-#  IgorMinar - Igor Minar
-#  jasonaden - Jason Aden
-#  jenniferfell - Jennifer Fell
-#  kara - Kara Erickson
-#  kyliau - Keen Yee Liau
-#  matsko - Matias Niemelä
-#  mgechev - Minko Gechev
-#  mhevery - Misko Hevery
-#  ocombe - Olivier Combe
-#  petebacondarwin - Pete Bacon Darwin
-#  pkozlowski-opensource - Pawel Kozlowski
-#  robwormald - Rob Wormald
-#  stephenfluin - Stephen Fluin
-#  vikerman - Vikram Subramanian
-
-
-
-######################################################################################################
-#
-#  Team structure and memberships
-#  ------------------------------
-#
-#  This section is here just because the GitHub UI is too hard to navigate and audit.
-#
-#  Any changes to team structure or memberships must first be made in this file and only then
-#  implemented in the GitHub UI.
-#######################################################################################################
-
-
-# ===========================================================
-#  @angular/framework-global-approvers
-# ===========================================================
-#  Used for approving minor changes, large-scale refactorings, and emergency situations.
-#  (secret team to avoid review requests, it also doesn't inherit from @angular/framework because nested teams can't be secret)
-#
-#   - IgorMinar
-#   - kara
-#   - mhevery
-
-
-# ===========================================================
-#  @angular/framework-global-approvers-for-docs-only-changes
-# ===========================================================
-#  Used for approving minor documentation-only changes that don't require engineering review.
-#  (secret team to avoid review requests, it also doesn't inherit from @angular/framework because nested teams can't be secret)
-#
-#   - brandonroberts
-#   - gkalpak
-#   - jenniferfell
-#   - petebacondarwin
-
-
-# ===========================================================
-#  @angular/fw-animations
-# ===========================================================
-#
-#   - matsko
-
-
-# ===========================================================
-#  @angular/tools-bazel
-# ===========================================================
-#
-#   - alexeagle
-#   - kyliau
-#   - IgorMinar
-#   - mgechev
-
-
-# ===========================================================
-#  @angular/tools-cli
-# ===========================================================
-#
-#   - alexeagle
-#   - filipesilva
-#   - hansl
-#   - mgechev
-
-
-# ===========================================================
-#  @angular/fw-compiler
-# ===========================================================
-#
-#   - alxhub
-
-
-# ===========================================================
-#  @angular/fw-ngcc
-# ===========================================================
-#
-#   - alxhub
-#   - gkalpak
-#   - petebacondarwin
-
-
-# ===========================================================
-#  @angular/fw-core
-# ===========================================================
-#
-#   - alxhub
-#   - AndrewKushnir
-#   - kara
-#   - mhevery
-#   - pkozlowski-opensource
-
-
-# ===========================================================
-#  @angular/fw-http
-# ===========================================================
-#
-#   - alxhub
-#   - IgorMinar
-
-
-# ===========================================================
-#  @angular/fw-elements
-# ===========================================================
-#
-#   - andrewseguin
-#   - gkalpak
-#   - robwormald
-
-
-# ===========================================================
-#  @angular/fw-forms
-# ===========================================================
-#
-#   - kara
-
-
-# ===========================================================
-#  @angular/tools-language-service
-# ===========================================================
-#
-#   - kyliau
-
-
-# ===========================================================
-#  @angular/fw-server
-# ===========================================================
-#
-#   - alxhub
-#   - vikerman
-
-
-# ===========================================================
-#  @angular/fw-router
-# ===========================================================
-#
-#   - jasonaden
-
-
-# ===========================================================
-#  @angular/fw-service-worker
-# ===========================================================
-#
-#   - alxhub
-#   - gkalpak
-#   - IgorMinar
-
-
-# ===========================================================
-#  @angular/fw-upgrade
-# ===========================================================
-#
-#   - gkalpak
-#   - petebacondarwin
-
-
-# ===========================================================
-#  @angular/fw-testing
-# ===========================================================
-#
-#   - vikerman
-
-
-# ===========================================================
-#  @angular/fw-i18n
-# ===========================================================
-#
-#   - AndrewKushnir
-#   - mhevery
-#   - ocombe
-#   - vikerman
-
-
-# ===========================================================
-#  @angular/fw-security
-# ===========================================================
-#
-#   - IgorMinar
-#   - mhevery
-
-
-# ===========================================================
-#  @angular/tools-benchpress
-# ===========================================================
-#
-#   - alxhub
-
-
-# ===========================================================
-#  @angular/fw-integration
-# ===========================================================
-#
-#   - alexeagle
-#   - IgorMinar
-#   - mhevery
-
-
-# ===========================================================
-#  @angular/docs-infra
-# ===========================================================
-#
-#   - brandonroberts
-#   - gkalpak
-#   - IgorMinar
-#   - petebacondarwin
-
-
-# ===========================================================
-#  @angular/fw-docs-intro
-# ===========================================================
-#
-#   - brandonroberts
-#   - IgorMinar
-#   - stephenfluin
-
-
-# ===========================================================
-#  @angular/fw-docs-observables
-# ===========================================================
-#
-#   - benlesh
-#   - jasonaden
-
-
-# ===========================================================
-#  @angular/fw-docs-packaging
-# ===========================================================
-#
-#   - alexeagle
-#   - IgorMinar
-
-
-# ===========================================================
-#  @angular/fw-docs-marketing
-# ===========================================================
-#
-#   - IgorMinar
-#   - stephenfluin
-
-
-# ===========================================================
-#  @angular/fw-public-api
-# ===========================================================
-#
-#   - IgorMinar
-
-
-# ===========================================================
-#  @angular/fw-dev-infra
-# ===========================================================
-#
-#   - alexeagle
-#   - filipesilva
-#   - gkalpak
-#   - IgorMinar
-
-
-
-
-
-######################################################################################################
-#
-# CODEOWNERS rules
-# -----------------
-#
-# All the following rules are applied in the order specified in this file.
-# The last rule that matches wins!
-#
-# See https://git-scm.com/docs/gitignore#_pattern_format for pattern syntax docs.
-#
-######################################################################################################
-
-
-# ================================================
-#  Default Owners
-# (in case no pattern matches a path in a PR - this should be treated as a bug and result in adding the path to CODEOWNERS)
-# ================================================
-
-* @IgorMinar @angular/framework-global-approvers
-
-
-
-# ================================================
-#  @angular/animations
-# ================================================
-
-/packages/animations/**                                         @angular/fw-animations @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/platform-browser/animations/**                        @angular/fw-animations @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/animations.md                                @angular/fw-animations @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/animations/**                             @angular/fw-animations @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/animations/**                         @angular/fw-animations @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/bazel
-# ================================================
-
-/packages/bazel/**                                              @angular/tools-bazel @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/compiler
-#  @angular/compiler-cli
-# ================================================
-
-/packages/compiler/**                                           @angular/fw-compiler @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/compiler-cli/**                                       @angular/fw-compiler @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/aot-compiler.md                              @angular/fw-compiler @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  packages/compiler-cli/src/ngcc/
-# ================================================
-
-/packages/compiler-cli/src/ngcc/**                              @angular/fw-ngcc @angular/framework-global-approvers
-
-
-
-# ================================================
-#  @angular/compiler-cli/ngtools
-#
-#  a rule to control API changes between @angular/compiler-cli and @angular/cli
-# ================================================
-
-/packages/compiler-cli/src/ngtools/**                           @angular/tools-cli @angular/framework-global-approvers
-
-
-
-# ================================================
-#  @angular/core
-#  @angular/common (except @angular/common/http)
-#  @angular/platform-browser
-#  @angular/platform-browser-dynamic
-#  @angular/platform-webworker
-#  @angular/platform-webworker-dynamic
-# ================================================
-
-/packages/core/**                                               @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/**                                             @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/platform-browser/**                                   @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/platform-browser-dynamic/**                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/platform-webworker/**                                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/platform-webworker-dynamic/**                         @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/attribute-directives.md                      @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/attribute-directives/**                   @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/attribute-directives/**               @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/bootstrapping.md                             @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/bootstrapping/**                          @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/component-interaction.md                     @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/component-interaction/**                  @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/component-interaction/**              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/component-styles.md                          @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/component-styles/**                       @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/dependency-injection.md                      @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/dependency-injection/**                   @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/dependency-injection/**               @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/dependency-injection-in-action.md            @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/dependency-injection-in-action/**         @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/dependency-injection-in-action/**     @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/dependency-injection-pattern.md              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/dynamic-component-loader.md                  @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/dynamic-component-loader/**               @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/dynamic-component-loader/**           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/entry-components.md                          @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/feature-modules.md                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/feature-modules/**                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/feature-modules/**                    @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/frequent-ngmodules.md                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/frequent-ngmodules/**                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/hierarchical-dependency-injection.md         @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/hierarchical-dependency-injection/**      @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/lazy-loading-ngmodules.md                    @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/lazy-loading-ngmodules/**                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/lazy-loading-ngmodules/**             @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/lifecycle-hooks.md                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/lifecycle-hooks/**                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/lifecycle-hooks/**                    @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/examples/ngcontainer/**                            @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/ngcontainer/**                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/ngmodules.md                                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/ngmodules/**                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/ngmodule/**                               @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/ngmodule/**                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/ngmodule-api.md                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/ngmodule-faq.md                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/ngmodule-faq/**                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/ngmodule-vs-jsmodule.md                      @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/module-types.md                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/template-syntax.md                           @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/template-syntax/**                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/template-syntax/**                    @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/pipes.md                                     @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/pipes/**                                  @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/pipes/**                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/providers.md                                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/providers/**                              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/singleton-services.md                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/set-document-title.md                        @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/set-document-title/**                     @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/set-document-title/**                 @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/sharing-ngmodules.md                         @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-/aio/content/guide/structural-directives.md                     @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/structural-directives/**                  @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/structural-directives/**              @angular/fw-core @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/common/http
-#  @angular/http
-# ================================================
-
-/packages/common/http/**                                        @angular/fw-http @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/http/**                                               @angular/fw-http @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/http.md                                      @angular/fw-http @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/http/**                                   @angular/fw-http @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/http/**                               @angular/fw-http @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/elements
-# ================================================
-
-/packages/elements/**                                           @angular/fw-elements @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/elements/**                               @angular/fw-elements @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/elements/**                           @angular/fw-elements @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/elements.md                                  @angular/fw-elements @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-# ================================================
-#  @angular/forms
-# ================================================
-
-/packages/forms/**                                              @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/forms.md                                     @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/forms/**                                  @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/forms/**                              @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/forms-overview.md                            @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/forms-overview/**                         @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/forms-overview/**                     @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/form-validation.md                           @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/form-validation/**                        @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/form-validation/**                    @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/dynamic-form.md                              @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/dynamic-form/**                           @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/dynamic-form/**                       @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/reactive-forms.md                            @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/reactive-forms/**                         @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/reactive-forms/**                     @angular/fw-forms @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/language-service
-# ================================================
-
-/packages/language-service/**                                   @angular/tools-language-service @angular/framework-global-approvers
-/aio/content/guide/language-service.md                          @angular/tools-language-service @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/language-service/**                   @angular/tools-language-service @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/platform-server
-# ================================================
-
-/packages/platform-server/**                                    @angular/fw-server @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/universal.md                                 @angular/fw-server @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/universal/**                              @angular/fw-server @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/router
-# ================================================
-
-/packages/router/**                                             @angular/fw-router @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/router.md                                    @angular/fw-router @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/router/**                                 @angular/fw-router @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/router/**                             @angular/fw-router @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/service-worker
-# ================================================
-
-/packages/service-worker/**                                     @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/service-worker-getting-started.md            @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/service-worker-getting-started/**         @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/service-worker-communications.md             @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/service-worker-config.md                     @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/service-worker-devops.md                     @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/service-worker-intro.md                      @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/service-worker/**                     @angular/fw-service-worker @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/upgrade
-# ================================================
-
-/packages/upgrade/**                                            @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/examples/upgrade/**                                   @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/upgrade.md                                   @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/upgrade-module/**                         @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/upgrade/**                            @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/upgrade-phonecat-1-typescript/**          @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/upgrade-phonecat-2-hybrid/**              @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/upgrade-phonecat-3-final/**               @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/upgrade-performance.md                       @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/ajs-quick-reference.md                       @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/ajs-quick-reference/**                    @angular/fw-upgrade @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular/**/testing
-# ================================================
-
-testing/**                                                      @angular/fw-testing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/testing.md                                   @angular/fw-testing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/testing/**                                @angular/fw-testing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/testing/**                            @angular/fw-testing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular i18n
-# ================================================
-
-/packages/core/src/i18n/**                                      @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/core/src/render3/i18n.ts                              @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/core/src/render3/i18n.md                              @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/core/src/render3/interfaces/i18n.ts                   @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/locales/**                                     @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/src/i18n/**                                    @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/src/pipes/date_pipe.ts                         @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/src/pipes/i18n_plural_pipe.ts                  @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/src/pipes/i18n_select_pipe.ts                  @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/common/src/pipes/number_pipe.ts                       @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/compiler/src/i18n/**                                  @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/compiler/src/render3/view/i18n/**                     @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/packages/compiler-cli/src/extract_i18n.ts                      @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/i18n.md                                      @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/i18n/**                                   @angular/fw-i18n @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  @angular security
-# ================================================
-
-/packages/core/src/sanitization/**                              @angular/fw-security
-/packages/core/test/linker/security_integration_spec.ts         @angular/fw-security
-/packages/compiler/src/schema/**                                @angular/fw-security
-/packages/platform-browser/src/security/**                      @angular/fw-security
-/aio/content/guide/security.md                                  @angular/fw-security @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/security/**                               @angular/fw-security @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  benchpress
-# ================================================
-
-/packages/benchpress/**                                         @angular/tools-benchpress @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  /integration/*
-# ================================================
-
-/integration/**                                                 @angular/fw-integration @angular/framework-global-approvers
-
-
-
-# ================================================
-#  docs-infra
-# ================================================
-
-/aio/*                                                          @angular/docs-infra @angular/framework-global-approvers
-/aio/aio-builds-setup/**                                        @angular/docs-infra @angular/framework-global-approvers
-/aio/scripts/**                                                 @angular/docs-infra @angular/framework-global-approvers
-/aio/src/**                                                     @angular/docs-infra @angular/framework-global-approvers
-/aio/tests/**                                                   @angular/docs-infra @angular/framework-global-approvers
-/aio/tools/**                                                   @angular/docs-infra @angular/framework-global-approvers
-
-
-
-# ================================================
-#  Docs: getting started & tutorial
-# ================================================
-
-/aio/content/guide/quickstart.md                                @angular/fw-docs-intro @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/tutorial/**                                        @angular/fw-docs-intro @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  Docs: observables
-# ================================================
-
-/aio/content/examples/observables/**                            @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/observables/**                        @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/observables.md                               @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/comparing-observables.md                     @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/observables-in-angular/**                 @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/guide/observables-in-angular/**             @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/observables-in-angular.md                    @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/practical-observable-usage/**             @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/practical-observable-usage.md                @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/rx-library/**                             @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/rx-library.md                                @angular/fw-docs-observables @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  Docs: packaging, tooling, releasing
-# ================================================
-
-/aio/content/guide/npm-packages.md                              @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/browser-support.md                           @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/typescript-configuration.md                  @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/setup-systemjs-anatomy.md                    @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/setup.md                                     @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/examples/setup/**                                  @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/deployment.md                                @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/releases.md                                  @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/guide/updating.md                                  @angular/fw-docs-packaging @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  Docs: marketing
-# ================================================
-
-/aio/content/marketing/**                                       @angular/fw-docs-marketing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/bios/**                                     @angular/fw-docs-marketing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/images/marketing/**                                @angular/fw-docs-marketing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/navigation.json                                    @angular/fw-docs-marketing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-/aio/content/license.md                                         @angular/fw-docs-marketing @angular/framework-global-approvers @angular/framework-global-approvers-for-docs-only-changes
-
-
-
-# ================================================
-#  Build & CI Owners
-# ================================================
-
-/*                                                              @angular/fw-dev-infra
-/.buildkite/**                                                  @angular/fw-dev-infra
-/.circleci/**                                                   @angular/fw-dev-infra
-/.github/**                                                     @angular/fw-dev-infra
-/docs/BAZEL.md                                                  @angular/fw-dev-infra
-/packages/*                                                     @angular/fw-dev-infra
-/scripts/**                                                     @angular/fw-dev-infra
-/third_party/**                                                 @angular/fw-dev-infra
-/tools/**                                                       @angular/fw-dev-infra
-*.bzl                                                           @angular/fw-dev-infra
-
-
-
-# ================================================
-#  Public API
-# ================================================
-
-/tools/public_api_guard/**                                      @angular/fw-public-api
-
-
-
-# ================================================
-#  CODEOWNERS Owners owners ...
-# ================================================
-
-/.github/CODEOWNERS                                             @IgorMinar @angular/framework-global-approvers
--- a/.github/ISSUE_TEMPLATE/1-bug-report.md
+++ b/.github/ISSUE_TEMPLATE/1-bug-report.md
@ -4,7 +4,7 @@ about: Report a bug in the Angular Framework
 ---
 <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

-Oh hi there! 😄
+Oh hi there! 😄 

 To expedite issue processing please search open and closed issues before submitting a new one.
 Existing issues often contain information about workarounds, resolution, or progress updates.
@ -38,10 +38,6 @@ Please create and share minimal reproduction of the issue starting with this tem

 <!--
 If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
-
-Issues that don't have enough info and can't be reproduced will be closed.
-
-You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
 -->

 ## 🔥 Exception or Error
--- a/.github/angular-robot.yml
+++ b/.github/angular-robot.yml
@ -39,30 +39,18 @@ merge:
      - "packages/**"
    # list of patterns to ignore for the files changed by the PR
    exclude:
-      - "packages/*"
-      - "packages/bazel/*"
-      - "packages/bazel/src/builders/**"
-      - "packages/bazel/src/ng_package/**"
-      - "packages/bazel/src/protractor/**"
-      - "packages/bazel/src/schematics/**"
-      - "packages/compiler-cli/src/ngcc/**"
-      - "packages/docs/**"
-      - "packages/elements/schematics/**"
-      - "packages/examples/**"
+      - "packages/bazel/*.bzl"
      - "packages/language-service/**"
-      - "packages/private/**"
-      - "packages/service-worker/**"
      - "**/.gitignore"
      - "**/.gitkeep"
-      - "**/yarn.lock"
      - "**/package.json"
-      - "**/third_party/**"
      - "**/tsconfig-build.json"
      - "**/tsconfig.json"
+      - "**/rollup.config.js"
      - "**/BUILD.bazel"
-      - "**/*.md"
      - "packages/**/integrationtest/**"
      - "packages/**/test/**"
+      - "packages/compiler-cli/src/ngcc/**"

  # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable
  mergeConflictComment: "Hi @{{PRAuthor}}! This PR has merge conflicts due to recent upstream merges.
@ -71,17 +59,13 @@ merge:
  # label to monitor
  mergeLabel: "PR action: merge"

-  # adding any of these labels will also add the merge label
-  mergeLinkedLabels:
-    - "PR action: merge-assistance"
-
  # list of checks that will determine if the merge label can be added
  checks:

    # require that the PR has reviews from all requested reviewers
    #
    # This enables us to request reviews from both eng and tech writers, or multiple eng folks, and prevents accidental merges.
-    # Rather than merging PRs with pending reviews, if all approvals are obtained and additional reviews are not needed, any pending reviewers should be removed via GitHub UI (this also leaves an audit trail behind these decisions).
+    # Rather than merging PRs with pending reviews, if all PullApprove requirements are satisfied and additional reviews are not needed pending reviewers should be removed via GitHub UI (this also leaves an audit trail behind these decisions).
    requireReviews: true,

    # whether the PR shouldn't have a conflict with the base branch
@ -101,13 +85,10 @@ merge:

    # list of PR statuses that need to be successful
    requiredStatuses:
+      - "continuous-integration/travis-ci/pr"
+      - "code-review/pullapprove"
      - "ci/circleci: build"
      - "ci/circleci: lint"
-      - "ci/circleci: publish_snapshot"
-      - "ci/angular: size"
-      - "cla/google"
-      - "google3"
-

  # the comment that will be added when the merge label is added despite failing checks, leave empty or set to false to disable
  # {{MERGE_LABEL}} will be replaced by the value of the mergeLabel option
--- a/.gitignore
+++ b/.gitignore
@ -1,7 +1,7 @@
 .DS_STORE

 /dist/
-/bazel-out/
+/bazel-*
 /integration/bazel/bazel-*
 e2e_test.*
 node_modules
@ -13,9 +13,9 @@ pubspec.lock
 .c9
 .idea/
 .settings/
-.vscode/launch.json
 *.swo
 modules/.settings
+.vscode
 modules/.vscode

 # Don't check in secret files
--- a/.pullapprove.yml
+++ b/.pullapprove.yml
@ -0,0 +1,542 @@
+# Configuration for pullapprove.com
+#
+# Approval access and primary role is determined by info in the project ownership spreadsheet:
+# https://docs.google.com/spreadsheets/d/1-HIlzfbPYGsPr9KuYMe6bLfc4LXzPjpoALqtYRYTZB0/edit?pli=1#gid=0&vpid=A5
+#
+# === GitHub username to Full name map ===
+#
+# alexeagle - Alex Eagle
+# alxhub - Alex Rickabaugh
+# andrewseguin - Andrew Seguin
+# benlesh - Ben Lesh
+# brandonroberts - Brandon Roberts
+# brocco - Mike Brocchi
+# filipesilva - Filipe Silva
+# gkalpak - George Kalpakas
+# hansl - Hans Larsen
+# IgorMinar - Igor Minar
+# jasonaden - Jason Aden
+# jenniferfell - Jennifer Fell
+# kara - Kara Erickson
+# kyliau - Keen Yee Liau
+# matsko - Matias Niemelä
+# mhevery - Misko Hevery
+# petebacondarwin - Pete Bacon Darwin
+# pkozlowski-opensource - Pawel Kozlowski
+# robwormald - Rob Wormald
+# vikerman - Vikram Subramanian
+
+
+version: 2
+
+group_defaults:
+  required: 1
+  reset_on_reopened:
+    enabled: true
+  approve_by_comment:
+    enabled: false
+  # see http://docs.pullapprove.com/groups/author_approval/
+  author_approval:
+    # If the author is a reviewer on the PR, they will automatically have an "approved" status.
+    auto: true
+
+groups:
+  # Require all PRs to have at least one approval from *someone*
+  all:
+    users: all
+    required: 1
+    rejection_value: -999
+    # In this group, your self-approval does not count
+    author_approval:
+      auto: false
+      ignored: true
+    files:
+      include:
+        - "*"
+
+  root:
+    conditions:
+      files:
+        include:
+          - "*"
+        exclude:
+          - "WORKSPACE"
+          - "BUILD.bazel"
+          - ".circleci/*"
+          - "aio/*"
+          - "integration/*"
+          - "modules/*"
+          - "packages/*"
+          - "tools/*"
+    users:
+      - alexeagle
+      - IgorMinar
+      - mhevery
+
+  public-api:
+    conditions:
+      files:
+        include:
+          - "tools/public_api_guard/*"
+    users:
+      - IgorMinar
+      - mhevery
+
+  bazel:
+    conditions:
+      files:
+        include:
+          - "WORKSPACE"
+          - ".bazel*"
+          - "*.bazel"
+          - "*.bzl"
+          - "packages/bazel/*"
+          - "/docs/BAZEL.md"
+    users:
+      - alexeagle #primary
+      - kyliau
+      - IgorMinar #fallback
+      - mhevery
+      - vikerman #fallback
+      - kara
+
+  build-and-ci:
+    conditions:
+      files:
+        include:
+          - "*.yml"
+          - "*.json"
+          - "*.lock"
+          - "tools/*"
+        exclude:
+          - "aio/*"
+          - "packages/core/test/bundling/*"
+          - "tools/public_api_guard/*"
+    users:
+      - IgorMinar #primary
+      - alexeagle
+      - jasonaden
+      - mhevery #fallback
+
+  integration:
+    conditions:
+      files:
+        - "integration/*"
+    users:
+      - alexeagle
+      - mhevery
+      - IgorMinar #fallback
+
+  core:
+    conditions:
+      files:
+        - "packages/core/*"
+        - "aio/content/guide/bootstrapping.md"
+        - "aio/content/examples/bootstrapping/*"
+        - "aio/content/guide/attribute-directives.md"
+        - "aio/content/examples/attribute-directives/*"
+        - "aio/content/images/guide/attribute-directives/*"
+        - "aio/content/guide/structural-directives.md"
+        - "aio/content/examples/structural-directives/*"
+        - "aio/content/images/guide/structural-directives/*"
+        - "aio/content/guide/dynamic-component-loader.md"
+        - "aio/content/examples/dynamic-component-loader/*"
+        - "aio/content/images/guide/dynamic-component-loader/*"
+        - "aio/content/guide/template-syntax.md"
+        - "aio/content/examples/template-syntax/*"
+        - "aio/content/images/guide/template-syntax/*"
+        - "aio/content/guide/dependency-injection.md"
+        - "aio/content/examples/dependency-injection/*"
+        - "aio/content/images/guide/dependency-injection/*"
+        - "aio/content/guide/dependency-injection-in-action.md"
+        - "aio/content/examples/dependency-injection-in-action/*"
+        - "aio/content/images/guide/dependency-injection-in-action/*"
+        - "aio/content/guide/hierarchical-dependency-injection.md"
+        - "aio/content/examples/hierarchical-dependency-injection/*"
+        - "aio/content/guide/singleton-services.md"
+        - "aio/content/guide/dependency-injection-pattern.md"
+        - "aio/content/guide/providers.md"
+        - "aio/content/examples/providers/*"
+        - "aio/content/guide/component-interaction.md"
+        - "aio/content/examples/component-interaction/*"
+        - "aio/content/images/guide/component-interaction/*"
+        - "aio/content/guide/component-styles.md"
+        - "aio/content/examples/component-styles/*"
+        - "aio/content/guide/lifecycle-hooks.md"
+        - "aio/content/examples/lifecycle-hooks/*"
+        - "aio/content/images/guide/lifecycle-hooks/*"
+        - "aio/content/examples/ngcontainer/*"
+        - "aio/content/images/guide/ngcontainer/*"
+        - "aio/content/guide/pipes.md"
+        - "aio/content/examples/pipes/*"
+        - "aio/content/images/guide/pipes/*"
+        - "aio/content/guide/entry-components.md"
+        - "aio/content/guide/set-document-title.md"
+        - "aio/content/examples/set-document-title/*"
+        - "aio/content/images/guide/set-document-title/*"
+        - "aio/content/guide/ngmodules.md"
+        - "aio/content/examples/ngmodules/*"
+        - "aio/content/examples/ngmodule/*"
+        - "aio/content/images/guide/ngmodule/*"
+        - "aio/content/guide/ngmodule-faq.md"
+        - "aio/content/examples/ngmodule-faq/*"
+        - "aio/content/guide/module-types.md"
+        - "aio/content/guide/sharing-ngmodules.md"
+        - "aio/content/guide/frequent-ngmodules.md"
+        - "aio/content/images/guide/frequent-ngmodules/*"
+        - "aio/content/guide/ngmodule-api.md"
+        - "aio/content/guide/ngmodule-vs-jsmodule.md"
+        - "aio/content/guide/feature-modules.md"
+        - "aio/content/examples/feature-modules/*"
+        - "aio/content/images/guide/feature-modules/*"
+        - "aio/content/guide/lazy-loading-ngmodules.md"
+        - "aio/content/examples/lazy-loading-ngmodules/*"
+        - "aio/content/images/guide/lazy-loading-ngmodules"
+    users:
+      - mhevery #primary
+      - jasonaden
+      - kara
+      - IgorMinar
+      - jenniferfell #docs only
+
+  animations:
+    conditions:
+      files:
+        - "packages/animations/*"
+        - "packages/platform-browser/animations/*"
+        - "aio/content/guide/animations.md"
+        - "aio/content/examples/animations/*"
+        - "aio/content/images/guide/animations/*"
+    users:
+      - matsko #primary
+      - mhevery #fallback
+      - IgorMinar #fallback
+      - jenniferfell #docs only
+      - kara
+
+  compiler/i18n:
+    conditions:
+      files:
+        - "packages/compiler/src/i18n/*"
+        - "aio/content/guide/i18n.md"
+        - "aio/content/examples/i18n/*"
+    users:
+      - alxhub #primary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+      - kara
+
+  compiler:
+    conditions:
+      files:
+        - "packages/compiler/*"
+        - "aio/content/guide/aot-compiler.md"
+    users:
+      - alxhub #primary
+      - mhevery
+      - IgorMinar #fallback
+      - jenniferfell #docs only
+      - kara
+
+  compiler-cli/ngtools:
+    conditions:
+      files:
+        - "packages/compiler-cli/src/ngtools*"
+    users:
+      - hansl
+      - filipesilva #fallback
+      - IgorMinar #fallback
+      - kara
+
+  compiler-cli:
+    conditions:
+      files:
+        include:
+          - "packages/compiler-cli/*"
+          - "packages/bazel/*"
+        exclude:
+          - "packages/compiler-cli/src/ngtools*"
+    users:
+      - alexeagle
+      - alxhub
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - kara
+
+  common:
+    conditions:
+      files:
+        include:
+          - "packages/common/*"
+        exclude:
+          - "packages/common/http/*"
+    users:
+      - pkozlowski-opensource #primary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - kara
+
+  forms:
+    conditions:
+      files:
+        - "packages/forms/*"
+        - "aio/content/guide/forms.md"
+        - "aio/content/examples/forms/*"
+        - "aio/content/images/guide/forms/*"
+        - "aio/content/guide/forms-overview.md"
+        - "aio/content/examples/forms-overview/*"
+        - "aio/content/images/guide/forms-overview/*"
+        - "aio/content/guide/form-validation.md"
+        - "aio/content/examples/form-validation/*"
+        - "aio/content/images/guide/form-validation/*"
+        - "aio/content/guide/dynamic-form.md"
+        - "aio/content/examples/dynamic-form/*"
+        - "aio/content/images/guide/dynamic-form/*"
+        - "aio/content/guide/reactive-forms.md"
+        - "aio/content/examples/reactive-forms/*"
+        - "aio/content/images/guide/reactive-forms/*"
+    users:
+      - kara #primary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  http:
+    conditions:
+      files:
+        - "packages/common/http/*"
+        - "packages/http/*"
+        - "aio/content/guide/http.md"
+        - "aio/content/examples/http/*"
+        - "aio/content/images/guide/http/*"
+    users:
+      - alxhub #primary
+      - IgorMinar
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  language-service:
+    conditions:
+      files:
+        - "packages/language-service/*"
+        - "aio/content/guide/language-service.md"
+        - "aio/content/images/guide/language-service/*"
+    users:
+      - kyliau #primary
+      # needs secondary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  router:
+    conditions:
+      files:
+        - "packages/router/*"
+        - "aio/content/guide/router.md"
+        - "aio/content/examples/router/*"
+        - "aio/content/images/guide/router/*"
+    users:
+      - jasonaden #primary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+      - kara
+
+  testing:
+    conditions:
+      files:
+        - "*/testing/*"
+        - "aio/content/guide/testing.md"
+        - "aio/content/examples/testing/*"
+        - "aio/content/images/guide/testing/*"
+    users:
+      - vikerman
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  upgrade:
+    conditions:
+      files:
+        - "packages/upgrade/*"
+        - "aio/content/guide/upgrade.md"
+        - "aio/content/examples/upgrade-module/*"
+        - "aio/content/images/guide/upgrade/*"
+        - "aio/content/examples/upgrade-phonecat-1-typescript/*"
+        - "aio/content/examples/upgrade-phonecat-2-hybrid/*"
+        - "aio/content/examples/upgrade-phonecat-3-final/*"
+        - "aio/content/guide/upgrade-performance.md"
+        - "aio/content/guide/ajs-quick-reference.md"
+        - "aio/content/examples/ajs-quick-reference/*"
+    users:
+      - petebacondarwin #primary
+      - gkalpak
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+      - kara
+
+  platform-browser:
+    conditions:
+      files:
+        - "packages/platform-browser/*"
+    users:
+      - mhevery #primary
+      # needs secondary
+      - IgorMinar #fallback
+      - kara
+
+  platform-server:
+    conditions:
+      files:
+        - "packages/platform-server/*"
+        - "aio/content/guide/universal.md"
+        - "aio/content/examples/universal/*"
+    users:
+      - vikerman #primary
+      - alxhub #secondary
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  platform-webworker:
+    conditions:
+      files:
+        - "packages/platform-webworker/*"
+    users:
+      - mhevery #primary
+      # needs secondary
+      - IgorMinar #fallback
+      - kara
+
+  service-worker:
+    conditions:
+      files:
+        - "packages/service-worker/*"
+        - "aio/content/guide/service-worker-getting-started.md"
+        - "aio/content/examples/service-worker-getting-started/*"
+        - "aio/content/guide/service-worker-communications.md"
+        - "aio/content/guide/service-worker-config.md"
+        - "aio/content/guide/service-worker-devops.md"
+        - "aio/content/guide/service-worker-intro.md"
+        - "aio/content/images/guide/service-worker/*"
+    users:
+      - gkalpak #primary
+      - alxhub
+      - IgorMinar
+      - mhevery #fallback
+      - jenniferfell #docs only
+
+  elements:
+    conditions:
+      files:
+        - "packages/elements/*"
+        - "aio/content/examples/elements/*"
+        - "aio/content/images/guide/elements/*"
+        - "aio/content/guide/elements.md"
+    users:
+      - andrewseguin #primary
+      - gkalpak
+      - robwormald
+      - IgorMinar #fallback
+      - mhevery #fallback
+      - jenniferfell #docs only
+      - kara
+
+  benchpress:
+    conditions:
+      files:
+        - "packages/benchpress/*"
+    users:
+      - alxhub # primary
+      # needs secondary
+      - IgorMinar #fallback
+      - mhevery #fallback
+
+  docs-infra:
+    conditions:
+      files:
+        include:
+          - "aio/*"
+        exclude:
+          - "aio/content/*"
+    users:
+      - petebacondarwin #primary
+      - IgorMinar
+      - gkalpak
+      - mhevery #fallback
+
+  docs/guide-and-tutorial:
+    conditions:
+      files:
+        include:
+          - "aio/content/*"
+        exclude:
+          - "aio/content/marketing/*"
+          - "aio/content/navigation.json"
+          - "aio/content/license.md"
+    users:
+      - stephenfluin
+      - jenniferfell
+      - brandonroberts
+      - petebacondarwin
+      - gkalpak
+      - IgorMinar
+      - mhevery #fallback
+
+  docs/marketing:
+    conditions:
+      files:
+        include:
+          - "aio/content/marketing/*"
+          - "aio/content/images/marketing/*"
+          - "aio/content/navigation.json"
+          - "aio/content/license.md"
+    users:
+      - stephenfluin
+      - petebacondarwin
+      - gkalpak
+      - IgorMinar
+      - robwormald
+      - mhevery #fallback
+
+  docs/observables:
+    conditions:
+      files:
+        - "aio/content/examples/observables/*"
+        - "aio/content/images/guide/observables/*"
+        - "aio/content/guide/observables.md"
+        - "aio/content/guide/comparing-observables.md"
+        - "aio/content/examples/observables-in-angular/*"
+        - "aio/content/images/guide/observables-in-angular/*"
+        - "aio/content/guide/observables-in-angular.md"
+        - "aio/content/examples/practical-observable-usage/*"
+        - "aio/content/guide/practical-observable-usage.md"
+        - "aio/content/examples/rx-library/*"
+        - "aio/content/guide/rx-library.md"
+    users:
+      - jasonaden
+      - benlesh
+      - IgorMinar
+      - mhevery
+      - jenniferfell #docs only
+
+  docs/packaging:
+    conditions:
+      files:
+        - "aio/content/guide/npm-packages.md"
+        - "aio/content/guide/browser-support.md"
+        - "aio/content/guide/typescript-configuration.md"
+        - "aio/content/guide/setup-systemjs-anatomy.md"
+        - "aio/content/examples/setup/*"
+        - "aio/content/guide/setup.md"
+        - "aio/content/guide/deployment.md"
+        - "aio/content/guide/releases.md"
+        - "aio/content/guide/updating.md"
+    users:
+      - IgorMinar #primary
+      - alexeagle
+      - hansl
+      - mhevery #fallback
+      - jenniferfell #docs only
--- a/.travis.yml
+++ b/.travis.yml
@ -0,0 +1,62 @@
+language: node_js
+sudo: false
+dist: trusty
+node_js:
+  - '10.9.0'
+
+addons:
+#  firefox: "38.0"
+  apt:
+    sources:
+      # needed to install g++ that is used by npms's native modules
+      - ubuntu-toolchain-r-test
+    packages:
+      # needed to install g++ that is used by npms's native modules
+      - g++-4.8
+
+branches:
+  except:
+    - g3
+
+cache:
+  yarn: true
+  directories:
+     - ./node_modules
+     - ./.chrome/chromium
+     - ./aio/node_modules
+
+env:
+  global:
+    # GITHUB_TOKEN_ANGULAR=<github token, a personal access token of the angular-builds account, account access in valentine>
+    # This is needed for the e2e Travis matrix task to publish packages to github for continuous packages delivery.
+    - secure: "aCdHveZuY8AT4Jr1JoJB4LxZsnGWRe/KseZh1YXYe5UtufFCtTVHvUcLn0j2aLBF0KpdyS+hWf0i4np9jthKu2xPKriefoPgCMpisYeC0MFkwbmv+XlgkUbgkgVZMGiVyX7DCYXVahxIoOUjVMEDCbNiHTIrfEuyq24U3ok2tHc="
+  matrix:
+    # Order: a slower build first, so that we don't occupy an idle travis worker waiting for others to complete.
+    - CI_MODE=e2e
+    - CI_MODE=js
+    - CI_MODE=saucelabs_required
+    # deactivated, see #19768
+    # - CI_MODE=browserstack_required
+    - CI_MODE=saucelabs_optional
+    - CI_MODE=browserstack_optional
+
+matrix:
+  fast_finish: true
+  allow_failures:
+    - env: "CI_MODE=saucelabs_optional"
+    - env: "CI_MODE=browserstack_optional"
+
+before_install:
+  # source the env.sh script so that the exported variables are available to other scripts later on
+  - source ./scripts/ci/env.sh print
+
+install:
+  - ./scripts/ci/install.sh
+
+script:
+  - ./scripts/ci/build.sh
+  - ./scripts/ci/test.sh
+  - ./scripts/ci/angular.sh
+  # all the scripts under this line will not quickly abort in case ${TRAVIS_TEST_RESULT} is 1 (job failure)
+  - ./scripts/ci/cleanup.sh
+  - ./scripts/ci/print-logs.sh
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@ -1,15 +0,0 @@
-{
-  "files.watcherExclude": {
-    "**/.git/objects/**": true,
-    "**/.git/subtree-cache/**": true,
-    "**/node_modules/**": true,
-    "**/bazel-out/**": true,
-    "**/dist/**": true,
-  },
-  "search.exclude": {
-    "**/node_modules": true,
-    "**/bower_components": true,
-    "**/bazel-out": true,
-    "**/dist": true,
-  },
-}
--- a/BUILD.bazel
+++ b/BUILD.bazel
@ -23,14 +23,9 @@ filegroup(
 filegroup(
    name = "angularjs_scripts",
    srcs = [
-        # We also declare the unminfied AngularJS files since these can be used for
-        # local debugging (e.g. see: packages/upgrade/test/common/test_helpers.ts)
        "@ngdeps//node_modules/angular:angular.js",
-        "@ngdeps//node_modules/angular:angular.min.js",
        "@ngdeps//node_modules/angular-1.5:angular.js",
-        "@ngdeps//node_modules/angular-1.5:angular.min.js",
        "@ngdeps//node_modules/angular-1.6:angular.js",
-        "@ngdeps//node_modules/angular-1.6:angular.min.js",
        "@ngdeps//node_modules/angular-mocks:angular-mocks.js",
        "@ngdeps//node_modules/angular-mocks-1.5:angular-mocks.js",
        "@ngdeps//node_modules/angular-mocks-1.6:angular-mocks.js",
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -1,199 +1,3 @@
-<a name="7.2.7"></a>
-## [7.2.7](https://github.com/angular/angular/compare/7.2.6...7.2.7) (2019-02-27)
-
-
-### Bug Fixes
-
-* **bazel:** pin browser repositories using [@npm](https://github.com/npm)_bazel_karma//:browser_repositories.bzl in bazel schematics ([#28896](https://github.com/angular/angular/issues/28896)) ([b686449](https://github.com/angular/angular/commit/b686449))
-* **core:** traverse and sanitize content of unsafe elements ([#28804](https://github.com/angular/angular/issues/28804)) ([fdcf877](https://github.com/angular/angular/commit/fdcf877)), closes [#25879](https://github.com/angular/angular/issues/25879) [#25879](https://github.com/angular/angular/issues/25879) [#26007](https://github.com/angular/angular/issues/26007) [#28427](https://github.com/angular/angular/issues/28427)
-* **language-service:** Fix completions for input/output with alias ([#28904](https://github.com/angular/angular/issues/28904)) ([d0018e6](https://github.com/angular/angular/commit/d0018e6)), closes [#27959](https://github.com/angular/angular/issues/27959)
-
-
-
-<a name="7.2.6"></a>
-## [7.2.6](https://github.com/angular/angular/compare/7.2.5...7.2.6) (2019-02-20)
-
-
-### Bug Fixes
-
-* **compiler-cli:** incorrect bundled metadata for static class member call expressions ([#28762](https://github.com/angular/angular/issues/28762)) ([ab69c31](https://github.com/angular/angular/commit/ab69c31)), closes [/github.com/angular/angular/blob/master/packages/core/src/change_detection/differs/keyvalue_differs.ts#L121](https://github.com//github.com/angular/angular/blob/master/packages/core/src/change_detection/differs/keyvalue_differs.ts/issues/L121) [#28741](https://github.com/angular/angular/issues/28741)
-
-
-
-<a name="7.2.5"></a>
-## [7.2.5](https://github.com/angular/angular/compare/7.2.4...7.2.5) (2019-02-15)
-
-
-### Bug Fixes
-
-* **compiler-cli:** diagnostics should respect "newLine" compiler option ([#28550](https://github.com/angular/angular/issues/28550)) ([ce750e6](https://github.com/angular/angular/commit/ce750e6))
-* **router:** redirect to root url when returned as UrlTree from guard ([#28271](https://github.com/angular/angular/issues/28271)) ([1e58a21](https://github.com/angular/angular/commit/1e58a21)), closes [#27845](https://github.com/angular/angular/issues/27845)
-* **router:** set href when routerLink is used on an 'area' element ([#28441](https://github.com/angular/angular/issues/28441)) ([d491a20](https://github.com/angular/angular/commit/d491a20)), closes [#28401](https://github.com/angular/angular/issues/28401)
-
-
-
-<a name="7.2.4"></a>
-## [7.2.4](https://github.com/angular/angular/compare/7.2.3...7.2.4) (2019-02-06)
-
-
-### Bug Fixes
-
-* **bazel:** Bazel builder resolves with require.resolve() ([#28478](https://github.com/angular/angular/issues/28478)) ([d85d396](https://github.com/angular/angular/commit/d85d396))
-* **bazel:** fix integration test for bazel-schematics ([#28460](https://github.com/angular/angular/issues/28460)) ([449da8c](https://github.com/angular/angular/commit/449da8c))
-
-
-### Performance Improvements
-
-* pngcrush all pngs ([#28479](https://github.com/angular/angular/issues/28479)) ([1a25144](https://github.com/angular/angular/commit/1a25144)), closes [#18243](https://github.com/angular/angular/issues/18243)
-
-
-
-<a name="7.2.3"></a>
-## [7.2.3](https://github.com/angular/angular/compare/7.2.2...7.2.3) (2019-01-30)
-
-
-### Bug Fixes
-
-* **bazel:** add [@npm](https://github.com/npm)//tslib dep to e2e ts_library target in bazel-workspace schematic ([#28358](https://github.com/angular/angular/issues/28358)) ([8cee56e](https://github.com/angular/angular/commit/8cee56e))
-* **bazel:** Bazel-workspace schematics should run in ScopedTree ([#28349](https://github.com/angular/angular/issues/28349)) ([260ac20](https://github.com/angular/angular/commit/260ac20))
-* **bazel:** Builder should invoke local bazel/iblaze ([#28303](https://github.com/angular/angular/issues/28303)) ([12b8a6e](https://github.com/angular/angular/commit/12b8a6e))
-* **bazel:** ng-new should run yarn install ([#28381](https://github.com/angular/angular/issues/28381)) ([a9d46e4](https://github.com/angular/angular/commit/a9d46e4))
-
-
-### Performance Improvements
-
-* yarn version upgrade ([#28360](https://github.com/angular/angular/issues/28360)) ([cc1b2a5](https://github.com/angular/angular/commit/cc1b2a5))
-
-
-
-<a name="7.2.2"></a>
-## [7.2.2](https://github.com/angular/angular/compare/7.2.1...7.2.2) (2019-01-22)
-
-
-### Bug Fixes
-
-* **bazel:** Fix integration test after v8 bump ([#28194](https://github.com/angular/angular/issues/28194)) ([7b772e9](https://github.com/angular/angular/commit/7b772e9)), closes [#28142](https://github.com/angular/angular/issues/28142)
-* **router:** `skipLocationChange` with named outlets ([#28301](https://github.com/angular/angular/issues/28301)) ([32737a6](https://github.com/angular/angular/commit/32737a6)), closes [#27680](https://github.com/angular/angular/issues/27680) [#28200](https://github.com/angular/angular/issues/28200)
-
-
-### Features
-
-* **bazel:** Add support for SASS ([#28167](https://github.com/angular/angular/issues/28167)) ([a4d9192](https://github.com/angular/angular/commit/a4d9192))
-* **compiler-cli:** resolve generated Sass/Less files to .css inputs ([#28166](https://github.com/angular/angular/issues/28166)) ([4c00059](https://github.com/angular/angular/commit/4c00059))
-
-
-
-<a name="7.2.1"></a>
-## [7.2.1](https://github.com/angular/angular/compare/7.2.0...7.2.1) (2019-01-16)
-
-
-### Bug Fixes
-
-* **bazel:** Add [@bazel](https://github.com/bazel)/bazel to dev deps ([#28032](https://github.com/angular/angular/issues/28032)) ([21093b9](https://github.com/angular/angular/commit/21093b9))
-* **bazel:** Add /bazel-out to .gitignore ([#27874](https://github.com/angular/angular/issues/27874)) ([e4fc8ba](https://github.com/angular/angular/commit/e4fc8ba))
-* **bazel:** Add ibazel to deps of Bazel project ([#28090](https://github.com/angular/angular/issues/28090)) ([28d34b6](https://github.com/angular/angular/commit/28d34b6))
-* **bazel:** Bazel schematics should add router package ([#28141](https://github.com/angular/angular/issues/28141)) ([02a852a](https://github.com/angular/angular/commit/02a852a))
-* **bazel:** flat module misses AMD module name on windows ([#27839](https://github.com/angular/angular/issues/27839)) ([c3d8e28](https://github.com/angular/angular/commit/c3d8e28))
-* **bazel:** incorrectly always uses ngc-wrapped from "npm" workspace ([#28137](https://github.com/angular/angular/issues/28137)) ([ca3965a](https://github.com/angular/angular/commit/ca3965a))
-* **bazel:** ng_package creates invalid typings reexport on windows ([#27829](https://github.com/angular/angular/issues/27829)) ([6b394f6](https://github.com/angular/angular/commit/6b394f6))
-* **bazel:** packager not properly removing amd directives on windows ([#27829](https://github.com/angular/angular/issues/27829)) ([fad4145](https://github.com/angular/angular/commit/fad4145))
-* **bazel:** protractor rule does not run spec files with underscore ([#28022](https://github.com/angular/angular/issues/28022)) ([f05c5f8](https://github.com/angular/angular/commit/f05c5f8))
-* **bazel:** protractor utils cannot start server on windows ([#27915](https://github.com/angular/angular/issues/27915)) ([0be8487](https://github.com/angular/angular/commit/0be8487))
-* **bazel:** replay compilation uses wrong compiler for building esm5 ([#28053](https://github.com/angular/angular/issues/28053)) ([fbbdaaa](https://github.com/angular/angular/commit/fbbdaaa))
-* **router:** ensure URL is updated after second redirect with UrlUpdateStrategy="eager" ([#27680](https://github.com/angular/angular/issues/27680)) ([6ae7aee](https://github.com/angular/angular/commit/6ae7aee)), closes [#27116](https://github.com/angular/angular/issues/27116)
-* **service-worker:** navigation urls backwards compatibility ([#27244](https://github.com/angular/angular/issues/27244)) ([585e871](https://github.com/angular/angular/commit/585e871))
-
-
-### Performance Improvements
-
-* **platform-server:** use shared `DomElementSchemaRegistry` instance ([#28150](https://github.com/angular/angular/issues/28150)) ([#28151](https://github.com/angular/angular/issues/28151)) ([6851581](https://github.com/angular/angular/commit/6851581))
-
-
-
-<a name="7.2.0"></a>
-# [7.2.0](https://github.com/angular/angular/compare/7.1.4...7.2.0) (2019-01-07)
-
-7.2.0 release also contains all the fixes released in 7.1.4.
-
-### Features
-
-* add support for typescript 3.2 ([#27536](https://github.com/angular/angular/issues/27536)) ([17e702b](https://github.com/angular/angular/commit/17e702b))
-* **bazel:** ng-new schematics with Bazel ([#27277](https://github.com/angular/angular/issues/27277)) ([06d4a0c](https://github.com/angular/angular/commit/06d4a0c))
-* **forms:** match getError and hasError to get method signature ([#20211](https://github.com/angular/angular/issues/20211)) ([1b0b36d](https://github.com/angular/angular/commit/1b0b36d))
-* **router:** add predicate function  mode for runGuardsAndResolvers ([#27682](https://github.com/angular/angular/issues/27682)) ([12c3176](https://github.com/angular/angular/commit/12c3176)), closes [#26861](https://github.com/angular/angular/issues/26861) [#18253](https://github.com/angular/angular/issues/18253) [#27464](https://github.com/angular/angular/issues/27464)
-* **router:** add a Navigation type available during navigation ([#27198](https://github.com/angular/angular/issues/27198)) ([d40af0c](https://github.com/angular/angular/commit/d40af0c))
-* **router:** add pathParamsOrQueryParamsChange mode for runGuardsAndResolvers ([#27464](https://github.com/angular/angular/issues/27464)) ([d70a7f3](https://github.com/angular/angular/commit/d70a7f3)), closes [#26861](https://github.com/angular/angular/issues/26861) [#18253](https://github.com/angular/angular/issues/18253)
-* **router:** allow passing `state` to routerLink directives ([#27198](https://github.com/angular/angular/issues/27198)) ([73f6ed9](https://github.com/angular/angular/commit/73f6ed9)), closes [#24617](https://github.com/angular/angular/issues/24617)
-* **router:** allow passing state to `NavigationExtras` ([#27198](https://github.com/angular/angular/issues/27198)) ([67f4a5d](https://github.com/angular/angular/commit/67f4a5d))
-* **router:** restore whole object when navigating back to a page managed by Angular router ([#27198](https://github.com/angular/angular/issues/27198)) ([2684249](https://github.com/angular/angular/commit/2684249))
-
-
-### Bug Fixes
-
-* **animations:** do not truncate decimals for delay ([#24455](https://github.com/angular/angular/issues/24455)) ([f1c9d6a](https://github.com/angular/angular/commit/f1c9d6a))
-* **animations:** mark actual descendant node as disabled ([#26180](https://github.com/angular/angular/issues/26180)) ([df123e0](https://github.com/angular/angular/commit/df123e0))
-* **bazel:** unable to launch protractor test on windows ([#27850](https://github.com/angular/angular/issues/27850)) ([1e6c9be](https://github.com/angular/angular/commit/1e6c9be))
-* **bazel:** devserver entry_module should have underscore name ([#27719](https://github.com/angular/angular/issues/27719)) ([f57916c](https://github.com/angular/angular/commit/f57916c))
-* **bazel:** emit full node stack traces when Angular compilation crashes ([#27678](https://github.com/angular/angular/issues/27678)) ([522919a](https://github.com/angular/angular/commit/522919a))
-* **bazel:** fix major/minor semver check between [@angular](https://github.com/angular)/bazel npm packager version and angular bazel repo version ([#27635](https://github.com/angular/angular/issues/27635)) ([1cc08b4](https://github.com/angular/angular/commit/1cc08b4))
-* **bazel:** Load http_archive and rules_nodejs dependencies ([#27609](https://github.com/angular/angular/issues/27609)) ([8313ffc](https://github.com/angular/angular/commit/8313ffc))
-* **bazel:** ng_package writes unrelevant definitions to bazel out ([#27519](https://github.com/angular/angular/issues/27519)) ([44dfa60](https://github.com/angular/angular/commit/44dfa60)), closes [/github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts#L105-L124](https://github.com//github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts/issues/L105-L124)
-* **bazel:** Set module_name and enable ng test ([#27715](https://github.com/angular/angular/issues/27715)) ([85866de](https://github.com/angular/angular/commit/85866de))
-* **bazel:** fix TS errors in the `schematics/bazel-workspace` files ([#27600](https://github.com/angular/angular/issues/27600)) ([3290fc3](https://github.com/angular/angular/commit/3290fc3))
-* **bazel:** Read latest versions from latest-versions.ts & use semver check ([#27526](https://github.com/angular/angular/issues/27526)) ([30a3b49](https://github.com/angular/angular/commit/30a3b49))
-* **bazel:** tsickle dependency not working with typescript 3.1.x ([#27402](https://github.com/angular/angular/issues/27402)) ([f034114](https://github.com/angular/angular/commit/f034114))
-* **bazel:** do not throw error when writing tsickle externs ([#27200](https://github.com/angular/angular/issues/27200)) ([20a2bae](https://github.com/angular/angular/commit/20a2bae))
-* **bazel:** do not throw if ts compile action does not create esm5 outputs ([#27401](https://github.com/angular/angular/issues/27401)) ([c61a8b7](https://github.com/angular/angular/commit/c61a8b7))
-* **bazel:** ng_package cannot be run multiple times without clean ([#27200](https://github.com/angular/angular/issues/27200)) ([4f93749](https://github.com/angular/angular/commit/4f93749))
-* **bazel:** ng_package not generating UMD bundles on windows ([#27200](https://github.com/angular/angular/issues/27200)) ([7d59880](https://github.com/angular/angular/commit/7d59880))
-* **bazel:** ng_package should correctly map to source maps in secondary entry-points ([#27313](https://github.com/angular/angular/issues/27313)) ([eb17502](https://github.com/angular/angular/commit/eb17502)), closes [#25510](https://github.com/angular/angular/issues/25510)
-* **bazel:** Respect existing angular installation ([#27495](https://github.com/angular/angular/issues/27495)) ([4da739a](https://github.com/angular/angular/commit/4da739a))
-* **common:** KeyValuePipe should return empty array for empty objects ([#27258](https://github.com/angular/angular/issues/27258)) ([b39efdd](https://github.com/angular/angular/commit/b39efdd))
-* **common:** expose request url in network error ([#27143](https://github.com/angular/angular/issues/27143)) ([1db53da](https://github.com/angular/angular/commit/1db53da)), closes [#27029](https://github.com/angular/angular/issues/27029)
-* **compiler-cli:** create LiteralLikeNode for String and Number literal ([#27536](https://github.com/angular/angular/issues/27536)) ([2c9b6c0](https://github.com/angular/angular/commit/2c9b6c0))
-* **compiler-cli:** flatModuleIndex files not generated on windows with multiple input files ([#27200](https://github.com/angular/angular/issues/27200)) ([d3c08e7](https://github.com/angular/angular/commit/d3c08e7))
-* **core:** export a value for InjectFlags ([#27279](https://github.com/angular/angular/issues/27279)) ([23b06af](https://github.com/angular/angular/commit/23b06af)), closes [#27251](https://github.com/angular/angular/issues/27251)
-* **core:** More precise return type for `InjectableDecorator` ([#27360](https://github.com/angular/angular/issues/27360)) ([4b9948c](https://github.com/angular/angular/commit/4b9948c)), closes [#26942](https://github.com/angular/angular/issues/26942)
-* **forms:** typed argument for FormBuilder group ([#26985](https://github.com/angular/angular/issues/26985)) ([b0c7561](https://github.com/angular/angular/commit/b0c7561))
-* **platform-server:** add [@angular](https://github.com/angular)/http to the list of peerDependencies ([#27307](https://github.com/angular/angular/issues/27307)) ([32c5be9](https://github.com/angular/angular/commit/32c5be9)), closes [#26154](https://github.com/angular/angular/issues/26154)
-* **router:** ensure URL is updated after second redirect with UrlUpdateStrategy="eager" ([#27523](https://github.com/angular/angular/issues/27523)) ([ad26cd6](https://github.com/angular/angular/commit/ad26cd6)), closes [#27116](https://github.com/angular/angular/issues/27116)
-* **router:** update URL after redirects when urlHandlingStrategy='eager' ([#27356](https://github.com/angular/angular/issues/27356)) ([11a8bd8](https://github.com/angular/angular/commit/11a8bd8)), closes [#27076](https://github.com/angular/angular/issues/27076)
-* **upgrade:** allow nesting components from different downgraded modules ([#27217](https://github.com/angular/angular/issues/27217)) ([bc0ee01](https://github.com/angular/angular/commit/bc0ee01))
-* **upgrade:** correctly handle nested downgraded components with `downgradeModule()` ([#27217](https://github.com/angular/angular/issues/27217)) ([326b464](https://github.com/angular/angular/commit/326b464)), closes [#22581](https://github.com/angular/angular/issues/22581) [#22869](https://github.com/angular/angular/issues/22869) [#27083](https://github.com/angular/angular/issues/27083)
-* **upgrade:** upgrade Directive facade should not return different instance from constructor ([#27660](https://github.com/angular/angular/issues/27660)) ([c986d3d](https://github.com/angular/angular/commit/c986d3d))
-* **upgrade:** don't rely upon the runtime to resolve forward refs ([#27132](https://github.com/angular/angular/issues/27132)) ([a4462c2](https://github.com/angular/angular/commit/a4462c2))
-
-
-
-<a name="7.1.4"></a>
-## [7.1.4](https://github.com/angular/angular/compare/7.1.3...7.1.4) (2018-12-18)
-
-
-### Bug Fixes
-
-* **animations:** do not truncate decimals for delay ([#24455](https://github.com/angular/angular/issues/24455)) ([cd1e206](https://github.com/angular/angular/commit/cd1e206))
-* **animations:** mark actual descendant node as disabled ([#26180](https://github.com/angular/angular/issues/26180)) ([453589f](https://github.com/angular/angular/commit/453589f))
-* **bazel:** devserver entry_module should have underscore name ([#27719](https://github.com/angular/angular/issues/27719)) ([b108e9a](https://github.com/angular/angular/commit/b108e9a))
-* **bazel:** emit full node stack traces when Angular compilation crashes ([#27678](https://github.com/angular/angular/issues/27678)) ([0d8528b](https://github.com/angular/angular/commit/0d8528b))
-* **bazel:** fix major/minor semver check between [@angular](https://github.com/angular)/bazel npm packager version and angular bazel repo version ([#27635](https://github.com/angular/angular/issues/27635)) ([3ed1e84](https://github.com/angular/angular/commit/3ed1e84))
-* **bazel:** Load http_archive and rules_nodejs dependencies ([#27609](https://github.com/angular/angular/issues/27609)) ([89ace1a](https://github.com/angular/angular/commit/89ace1a))
-* **bazel:** ng_package writes unrelevant definitions to bazel out ([#27519](https://github.com/angular/angular/issues/27519)) ([ef056c5](https://github.com/angular/angular/commit/ef056c5)), closes [/github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts#L105-L124](https://github.com//github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts/issues/L105-L124)
-* **bazel:** Read latest versions from latest-versions.ts & use semver check ([#27591](https://github.com/angular/angular/issues/27591)) ([93078e3](https://github.com/angular/angular/commit/93078e3))
-* **bazel:** Set module_name and enable ng test ([#27715](https://github.com/angular/angular/issues/27715)) ([183f278](https://github.com/angular/angular/commit/183f278))
-* **common:** KeyValuePipe should return empty array for empty objects ([#27258](https://github.com/angular/angular/issues/27258)) ([fa3af8b](https://github.com/angular/angular/commit/fa3af8b))
-
-
-
-<a name="7.1.3"></a>
-## [7.1.3](https://github.com/angular/angular/compare/7.1.2...7.1.3) (2018-12-11)
-
-
-### Bug Fixes
-
-* **bazel:** tsickle dependency not working with typescript 3.1.x ([#27402](https://github.com/angular/angular/issues/27402)) ([a9f39a4](https://github.com/angular/angular/commit/a9f39a4))
-
-
-
 <a name="7.1.2"></a>
 ## [7.1.2](https://github.com/angular/angular/compare/7.1.1...7.1.2) (2018-12-06)

--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -51,15 +51,19 @@ and help you to craft the change so that it is successfully accepted into the pr

 Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

-We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we will systematically ask you to provide a minimal reproduction. Having a minimal reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions.
+We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we will systematically ask you to provide a minimal reproduction scenario using http://plnkr.co. Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:

-A minimal reproduction allows us to quickly confirm a bug (or point out a coding problem) as well as confirm that we are fixing the right problem.
+- version of Angular used
+- 3rd-party libraries and their versions
+- and most importantly - a use-case that fails

-We will be insisting on a minimal reproduction scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal reproduction. We understand that sometimes it might be hard to extract essential bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
+A minimal reproduce scenario using http://plnkr.co/ allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem. If plunker is not a suitable way to demonstrate the problem (for example for issues related to our npm packaging), please create a standalone git repository demonstrating the problem.
+
+We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal plunk. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.

 Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.

-You can file new issues by selecting from our [new issue templates](https://github.com/angular/angular/issues/new/choose) and filling out the issue template.
+You can file new issues by filling out our [new issue form](https://github.com/angular/angular/issues/new).


 ### <a name="submit-pr"></a> Submitting a Pull Request (PR)
@ -191,7 +195,7 @@ If the commit reverts a previous commit, it should begin with `revert: `, follow
 Must be one of the following:

 * **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
-* **ci**: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
+* **ci**: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 * **docs**: Documentation only changes
 * **feat**: A new feature
 * **fix**: A bug fix
--- a/2
+++ b/2
@ -1,6 +1,6 @@
 The MIT License

-Copyright (c) 2010-2019 Google LLC. http://angular.io/license
+Copyright (c) 2014-2018 Google, Inc. http://angular.io

 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
--- a/README.md
+++ b/README.md
@ -1,3 +1,4 @@
+[![Build Status](https://travis-ci.org/angular/angular.svg?branch=master)](https://travis-ci.org/angular/angular)
 [![CircleCI](https://circleci.com/gh/angular/angular/tree/master.svg?style=shield)](https://circleci.com/gh/angular/angular/tree/master)
 [![BrowserStack Status](https://www.browserstack.com/automate/badge.svg?badge_key=LzF3RzBVVGt6VWE2S0hHaC9uYllOZz09LS1BVjNTclBKV0x4eVRlcjA4QVY1M0N3PT0=--eb4ce8c8dc2c1c5b2b5352d473ee12a73ac20e06)](https://www.browserstack.com/automate/public-build/LzF3RzBVVGt6VWE2S0hHaC9uYllOZz09LS1BVjNTclBKV0x4eVRlcjA4QVY1M0N3PT0=--eb4ce8c8dc2c1c5b2b5352d473ee12a73ac20e06)
 [![Join the chat at https://gitter.im/angular/angular](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/angular/angular?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
--- a/128
+++ b/128
@ -1,6 +1,10 @@
 workspace(name = "angular")

-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+load(
+    "//packages/bazel:package.bzl",
+    "rules_angular_dependencies",
+    "rules_angular_dev_dependencies",
+)

 # Uncomment for local bazel rules development
 #local_repository(
@ -8,91 +12,93 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 #    path = "../rules_nodejs",
 #)
 #local_repository(
-#    name = "npm_bazel_typescript",
+#    name = "build_bazel_rules_typescript",
 #    path = "../rules_typescript",
 #)

-# Fetch rules_nodejs so we can install our npm dependencies
+# Angular Bazel users will call this function
+rules_angular_dependencies()
+# These are the dependencies only for us
+rules_angular_dev_dependencies()
+
+# Install transitive deps of rules_typescript
+load("@build_bazel_rules_typescript//:package.bzl", "rules_typescript_dependencies")
+rules_typescript_dependencies()
+
+# Install transitive deps of rules_nodejs
+load("@build_bazel_rules_nodejs//:package.bzl", "rules_nodejs_dependencies")
+rules_nodejs_dependencies()
+
+#
+# Point Bazel to WORKSPACEs that live in subdirectories
+#
 http_archive(
-    name = "build_bazel_rules_nodejs",
-    sha256 = "1416d03823fed624b49a0abbd9979f7c63bbedfd37890ddecedd2fe25cccebc6",
-    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.18.6/rules_nodejs-0.18.6.tar.gz"],
+    name = "rxjs",
+    url = "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz",
+    strip_prefix = "package/src",
+    sha256 = "72b0b4e517f43358f554c125e40e39f67688cd2738a8998b4a266981ed32f403",
+)
+
+# Point to the integration test workspace just so that Bazel doesn't descend into it
+# when expanding the //... pattern
+local_repository(
+    name = "bazel_integration_test",
+    path = "integration/bazel",
+)
+
+#
+# Load and install our dependencies downloaded above.
+#
+load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_repositories", "yarn_install")
+
+check_bazel_version("0.18.0", """
+If you are on a Mac and using Homebrew, there is a breaking change to the installation in Bazel 0.16
+See https://blog.bazel.build/2018/08/22/bazel-homebrew.html
+
+""")
+
+node_repositories(
+    node_version = "10.9.0",
+    package_json = ["//:package.json"],
+    preserve_symlinks = True,
+    yarn_version = "1.12.1",
 )

-# Use a mock @npm repository while we are building angular from source
-# downstream. Angular will get its npm dependencies with in @ngdeps which
-# is setup in ng_setup_workspace().
-# TODO(gregmagolan): remove @ngdeps once angular is no longer build from source
-#   downstream and have build use @npm for npm dependencies
 local_repository(
    name = "npm",
    path = "tools/npm_workspace",
 )

-# Check the bazel version and download npm dependencies
-load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version", "node_repositories")
+load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")

-# Bazel version must be at least v0.21.0 because:
-#   - 0.21.0 Using --incompatible_strict_action_env flag fixes cache when running `yarn bazel`
-#            (see https://github.com/angular/angular/issues/27514#issuecomment-451438271)
-check_bazel_version("0.21.0", """
-You no longer need to install Bazel on your machine.
-Angular has a dependency on the @bazel/bazel package which supplies it.
-Try running `yarn bazel` instead.
-    (If you did run that, check that you've got a fresh `yarn install`)
+go_rules_dependencies()

-""")
+go_register_toolchains()

-# Setup the Node.js toolchain
-node_repositories(
-    node_version = "10.9.0",
-    package_json = ["//:package.json"],
-    preserve_symlinks = True,
-    vendored_yarn = "@angular//third_party/github.com/yarnpkg/yarn/releases/download:v1.13.0",
-)
-
-# Setup the angular toolchain which installs npm dependencies into @ngdeps
-load("//tools:ng_setup_workspace.bzl", "ng_setup_workspace")
-
-ng_setup_workspace()
-
-# Install all bazel dependencies of the @ngdeps npm packages
-load("@ngdeps//:install_bazel_dependencies.bzl", "install_bazel_dependencies")
-
-install_bazel_dependencies()
-
-# Load angular dependencies
-load("//packages/bazel:package.bzl", "rules_angular_dev_dependencies")
-
-rules_angular_dev_dependencies()
-
-# Load karma dependencies
-load("@npm_bazel_karma//:package.bzl", "rules_karma_dependencies")
-
-rules_karma_dependencies()
-
-# Setup the rules_webtesting toolchain
-load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")
+load("@io_bazel_rules_webtesting//web:repositories.bzl", "browser_repositories", "web_test_repositories")

 web_test_repositories()

-# Temporary work-around for https://github.com/angular/angular/issues/28681
-# TODO(gregmagolan): go back to @io_bazel_rules_webtesting browser_repositories
-load("@npm_bazel_karma//:browser_repositories.bzl", "browser_repositories")
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)

-browser_repositories()
-
-# Setup the rules_typescript tooolchain
-load("@npm_bazel_typescript//:defs.bzl", "ts_setup_workspace")
+load("@build_bazel_rules_typescript//:defs.bzl", "ts_setup_workspace")

 ts_setup_workspace()

-# Setup the rules_sass toolchain
+load("@angular//:index.bzl", "ng_setup_workspace")
+
+ng_setup_workspace()
+
+##################################
+# Skylark documentation generation
+
 load("@io_bazel_rules_sass//sass:sass_repositories.bzl", "sass_repositories")

 sass_repositories()

-# Setup the skydoc toolchain
 load("@io_bazel_skydoc//skylark:skylark.bzl", "skydoc_repositories")

 skydoc_repositories()
--- a/aio/.gitignore
+++ b/aio/.gitignore
@ -26,13 +26,11 @@
 !.vscode/extensions.json

 # misc
-/.firebase/
 /.sass-cache
 /connect.lock
 /coverage
 /libpeerconnection.log
 debug.log
-firebase-debug.log
 npm-debug.log
 testem.log
 /typings
--- a/aio/aio-builds-setup/dockerbuild/Dockerfile
+++ b/aio/aio-builds-setup/dockerbuild/Dockerfile
@ -26,8 +26,8 @@ ARG      AIO_GITHUB_ORGANIZATION=angular
 ARG TEST_AIO_GITHUB_ORGANIZATION=test-org
 ARG      AIO_GITHUB_REPO=angular
 ARG TEST_AIO_GITHUB_REPO=test-repo
-ARG      AIO_GITHUB_TEAM_SLUGS=aio-contributors
-ARG TEST_AIO_GITHUB_TEAM_SLUGS=aio-contributors
+ARG      AIO_GITHUB_TEAM_SLUGS=team,aio-contributors
+ARG TEST_AIO_GITHUB_TEAM_SLUGS=team,aio-contributors
 ARG      AIO_NGINX_HOSTNAME=$AIO_DOMAIN_NAME
 ARG TEST_AIO_NGINX_HOSTNAME=$TEST_AIO_DOMAIN_NAME
 ARG      AIO_NGINX_PORT_HTTP=80
--- a/aio/angular.json
+++ b/aio/angular.json
@ -2,10 +2,7 @@
  "$schema": "./node_modules/@angular-devkit/core/src/workspace/workspace-schema.json",
  "version": 1,
  "cli": {
-    "packageManager": "yarn",
-    "warnings": {
-      "typescriptMismatch": false
-    }
+    "packageManager": "yarn"
  },
  "newProjectRoot": "projects",
  "projects": {
@ -104,9 +101,6 @@
            },
            "archive": {
              "browserTarget": "site:build:archive"
-            },
-            "ci": {
-              "progress": false
            }
          }
        },
@ -169,11 +163,6 @@
          "options": {
            "protractorConfig": "tests/e2e/protractor.conf.js",
            "devServerTarget": "site:serve"
-          },
-          "configurations": {
-            "ci": {
-              "devServerTarget": "site:serve:ci"
-            }
          }
        },
        "lint": {
--- a/aio/content/cli/index.md
+++ b/aio/content/cli/index.md
@ -74,10 +74,7 @@ Command syntax is shown as follows:
 * Option names are prefixed with a double dash (--).
    Option aliases are prefixed with a single dash (-).
    Arguments are not prefixed.
-    For example: 
-    <code-example format="." language="bash">
-        ng build my-app -c production
-    </code-example>
+    For example: `ng build my-app -c production`

 * Typically, the name of a generated artifact can be given as an argument to the command or specified with the --name option.

--- a/aio/content/examples/.gitignore
+++ b/aio/content/examples/.gitignore
@ -57,9 +57,7 @@ dist/

 # aot
 **/*.ngsummary.json
-upgrade-module/tsconfig-aot.json
 !rollup-config.js
-upgrade-module/rollup-config.js
 aot-compiler/**/*.d.ts
 aot-compiler/**/*.factory.d.ts
 upgrade-phonecat-2-hybrid/aot/**/*
@ -86,9 +84,5 @@ upgrade-phonecat-2-hybrid/aot/**/*
 *stackblitz.no-link.html

 # ngUpgrade testing
-upgrade-phonecat-1-typescript/tsconfig-aot.json
-upgrade-phonecat-1-typescript/rollup-config.js
-upgrade-phonecat-3-final/tsconfig-aot.json
-upgrade-phonecat-3-final/rollup-config.js
 !upgrade-phonecat-*/**/karma.conf.js
 !upgrade-phonecat-*/**/karma-test-shim.js
--- a/aio/content/examples/ajs-quick-reference/src/app/app.component.ts
+++ b/aio/content/examples/ajs-quick-reference/src/app/app.component.ts
@ -20,7 +20,7 @@ export class AppComponent {
  movies: IMovie[] = [];
  showImage = true;
  title = 'AngularJS to Angular Quick Ref Cookbook';
-  toggleImage(event?: UIEvent) {
+  toggleImage(event: UIEvent) {
    this.showImage = !this.showImage;
    this.eventType = (event && event.type) || 'not provided';
  }
--- a/aio/content/examples/ajs-quick-reference/src/app/date.pipe.ts
+++ b/aio/content/examples/ajs-quick-reference/src/app/date.pipe.ts
@ -0,0 +1,14 @@
+import { Injectable, Pipe, PipeTransform } from '@angular/core';
+import { DatePipe } from '@angular/common';
+
+@Injectable()
+// #docregion date-pipe
+@Pipe({name: 'date', pure: true})
+export class StringSafeDatePipe extends DatePipe implements PipeTransform {
+ transform(value: any, format: string): string {
+   value = typeof value === 'string' ?
+           Date.parse(value) : value;
+   return super.transform(value, format);
+ }
+}
+// #enddocregion date-pipe
--- a/aio/content/examples/animations/src/app/app.module.ts
+++ b/aio/content/examples/animations/src/app/app.module.ts
@ -19,7 +19,6 @@ import { HeroListAutoCalcPageComponent } from './hero-list-auto-page.component';
 import { HeroListAutoComponent } from './hero-list-auto.component';
 import { HomeComponent } from './home.component';
 import { AboutComponent } from './about.component';
-import { InsertRemoveComponent } from './insert-remove.component';


@NgModule({
@ -57,7 +56,6 @@ import { InsertRemoveComponent } from './insert-remove.component';
    HeroListAutoCalcPageComponent,
    HeroListAutoComponent,
    HomeComponent,
-    InsertRemoveComponent,
    AboutComponent
  ],
  bootstrap: [AppComponent]
--- a/aio/content/examples/attribute-directives/src/app/app.component.1.html
+++ b/aio/content/examples/attribute-directives/src/app/app.component.1.html
@ -2,7 +2,7 @@
 <h1>My First Attribute Directive</h1>
 <!-- #docregion applied -->
 <p appHighlight>Highlight me!</p>
-<!-- #enddocregion applied  -->
+<!-- #enddocregion applied,  -->

 <!-- #docregion color-1 -->
 <p appHighlight highlightColor="yellow">Highlighted in yellow</p>
@ -11,4 +11,4 @@

 <!-- #docregion color-2 -->
 <p appHighlight [highlightColor]="color">Highlighted with parent component's color</p>
-<!-- #enddocregion color-2 -->
+<!-- #enddocregion color-2 -->
--- a/aio/content/examples/attribute-directives/src/app/app.component.avoid.html
+++ b/aio/content/examples/attribute-directives/src/app/app.component.avoid.html
@ -1,3 +0,0 @@
-<!-- #docregion unsupported -->
-<p app:Highlight>This is invalid</p>
-<!-- #enddocregion unsupported  -->
--- a/aio/content/examples/component-interaction/example-config.json
+++ b/aio/content/examples/component-interaction/example-config.json
@ -1,11 +0,0 @@
-{
-  "e2e": [
-    {
-      "cmd": "yarn",
-      "args": [
-        "e2e",
-        "--no-webdriver-update"
-      ]
-    }
-  ]
-}
--- a/aio/content/examples/dependency-injection-in-action/src/app/parent-finder.component.ts
+++ b/aio/content/examples/dependency-injection-in-action/src/app/parent-finder.component.ts
@ -19,20 +19,20 @@ const DifferentParent = Parent;
 // #enddocregion provide-the-parent
 // The `parentType` defaults to `Parent` when omitting the second parameter.
 // #docregion provide-the-parent
-export function provideParent
+const provideParent =
 // #enddocregion provide-parent, provide-the-parent
 // #docregion provide-parent
-  (component: any, parentType?: any) {
+  (component: any, parentType?: any) => {
    return { provide: parentType || Parent, useExisting: forwardRef(() => component) };
-  }
+  };
 // #enddocregion provide-parent

 // Simpler syntax version that always provides the component in the name of `Parent`.
-export function provideTheParent
+const provideTheParent =
 // #docregion provide-the-parent
-  (component: any) {
+  (component: any) => {
    return { provide: Parent, useExisting: forwardRef(() => component) };
-  }
+  };
 // #enddocregion provide-the-parent


--- a/aio/content/examples/dependency-injection/example-config.json
+++ b/aio/content/examples/dependency-injection/example-config.json
@ -1,11 +0,0 @@
-{
-  "e2e": [
-    {
-      "cmd": "yarn",
-      "args": [
-        "e2e",
-        "--no-webdriver-update"
-      ]
-    }
-  ]
-}
--- a/aio/content/examples/displaying-data/src/app/app-ctor.component.1.ts
+++ b/aio/content/examples/displaying-data/src/app/app-ctor.component.1.ts
--- a/aio/content/examples/http/e2e/src/app.e2e-spec.ts
+++ b/aio/content/examples/http/e2e/src/app.e2e-spec.ts
@ -28,7 +28,10 @@ let checkLogForMessage = (message: string) => {
  expect(page.logList.getText()).toContain(message);
 };

-describe('Http Tests', function() {
+// TODO(i): temorarily disable these tests because angular-in-memory-web-api is not compatible with rxjs v6 yet
+//          and we don't have the backwards compatibility package yet.
+//          Reenable after rxjs v6 compatibility package is out or angular-in-memory-web-api is compatible with rxjs v6
+xdescribe('Http Tests', function() {
  beforeEach(() => {
    browser.get('');
  });
--- a/aio/content/examples/i18n/example-config.json
+++ b/aio/content/examples/i18n/example-config.json
@ -1,12 +1,3 @@
 {
-  "projectType": "i18n",
-  "e2e": [
-    {
-      "cmd": "yarn",
-      "args": [
-        "e2e",
-        "--no-webdriver-update"
-      ]
-    }
-  ]
-}
+  "projectType": "i18n"
+}
--- a/aio/content/examples/interpolation/e2e/src/app.e2e-spec.ts
+++ b/aio/content/examples/interpolation/e2e/src/app.e2e-spec.ts
@ -1,47 +0,0 @@
-import { browser, element, by } from 'protractor';
-
-describe('Interpolation e2e tests', () => {
-
-  beforeEach(function () {
-    browser.get('');
-  });
-
-  it('should display Interpolation and Template Expressions', function () {
-    expect(element(by.css('h1')).getText()).toEqual('Interpolation and Template Expressions');
-  });
-
-  it('should display Current customer: Maria', function () {
-    expect(element.all(by.css('h3')).get(0).getText()).toBe(`Current customer: Maria`);
-  });
-
-  it('should display The sum of 1 + 1 is not 4.', function () {
-    expect(element.all(by.css('p:last-child')).get(0).getText()).toBe(`The sum of 1 + 1 is not 4.`);
-  });
-
-  it('should display Expression Context', function () {
-    expect(element.all(by.css('h2')).get(1).getText()).toBe(`Expression Context`);
-  });
-
-  it('should display a list of customers', function () {
-    expect(element.all(by.css('li')).get(0).getText()).toBe(`Maria`);
-  });
-
-  it('should display two pictures', function() {
-    let pottedPlant = element.all(by.css('img')).get(0);
-    let lamp = element.all(by.css('img')).get(1);
-
-    expect(pottedPlant.getAttribute('src')).toContain('pottedPlant');
-    expect(pottedPlant.isDisplayed()).toBe(true);
-
-    expect(lamp.getAttribute('src')).toContain('lamp');
-    expect(lamp.isDisplayed()).toBe(true);
-  });
-
-  it('should support user input', function () {
-    let input = element(by.css('input'));
-    let label = element(by.css('label'));
-    expect(label.getText()).toEqual('Type something:');
-    input.sendKeys('abc');
-    expect(label.getText()).toEqual('Type something: abc');
-  });
-});
--- a/aio/content/examples/interpolation/src/app/app.component.html
+++ b/aio/content/examples/interpolation/src/app/app.component.html
@ -1,60 +0,0 @@
-
-<div>
-  <h1>Interpolation and Template Expressions</h1>
-  <hr />
-
-  <div>
-    <h2>Interpolation</h2>
-    <!-- #docregion interpolation-example1 -->
-    <h3>Current customer: {{ currentCustomer }}</h3>
-    <!-- #enddocregion interpolation-example1 -->
-
-    <!-- #docregion component-property -->
-    <p>{{title}}</p>
-    <div><img src="{{itemImageUrl}}"></div>
-    <!-- #enddocregion component-property -->
-
-    <h3>Evaluating template expressions </h3>
-    <h4>Simple evaluation (to a string):</h4>
-    <!-- #docregion convert-string -->
-    <!-- "The sum of 1 + 1 is 2" -->
-    <p>The sum of 1 + 1 is {{1 + 1}}.</p>
-    <!-- #enddocregion convert-string -->
-
-    <h4>Evaluates using a method (also evaluates to a string):</h4>
-    <!-- #docregion invoke-method -->
-    <!-- "The sum of 1 + 1 is not 4" -->
-    <p>The sum of 1 + 1 is not {{1 + 1 + getVal()}}.</p>
-    <!-- #enddocregion invoke-method -->
-  </div>
-
-  <hr />
-<h2>Expression Context</h2>
-
-<div>
-  <h3>Component context, properties of app.component.ts:</h3>
-  <!-- #docregion component-context -->
-  <h4>{{recommended}}</h4>
-  <img [src]="itemImageUrl2">
-  <!-- #enddocregion component-context -->
-</div>
-
-<div>
-  <h4>Template context, template input variables (let customer):</h4>
-  <!-- #docregion template-input-variable -->
-  <ul>
-    <li *ngFor="let customer of customers">{{customer.name}}</li>
-  </ul>
-  <!-- #enddocregion template-input-variable -->
-</div>
-
-<div (keyup)="0">
-  <h4>Template context: template reference variables (#customerInput):</h4>
-  <!-- #docregion template-reference-variable -->
-  <label>Type something:
-    <input #customerInput>{{customerInput.value}}
-  </label>
-  <!-- #enddocregion template-reference-variable -->
-</div>
-
-</div>
--- a/aio/content/examples/interpolation/src/app/app.component.spec.ts
+++ b/aio/content/examples/interpolation/src/app/app.component.spec.ts
@ -1,27 +0,0 @@
-import { TestBed, async } from '@angular/core/testing';
-import { AppComponent } from './app.component';
-describe('AppComponent', () => {
-  beforeEach(async(() => {
-    TestBed.configureTestingModule({
-      declarations: [
-        AppComponent
-      ],
-    }).compileComponents();
-  }));
-  it('should create the app', async(() => {
-    const fixture = TestBed.createComponent(AppComponent);
-    const app = fixture.debugElement.componentInstance;
-    expect(app).toBeTruthy();
-  }));
-  it(`should have as title 'Featured product:'`, async(() => {
-    const fixture = TestBed.createComponent(AppComponent);
-    const app = fixture.debugElement.componentInstance;
-    expect(app.title).toEqual('Featured product:');
-  }));
-  it('should render title in a p tag', async(() => {
-    const fixture = TestBed.createComponent(AppComponent);
-    fixture.detectChanges();
-    const compiled = fixture.debugElement.nativeElement;
-    expect(compiled.querySelector('p').textContent).toContain('Featured product:');
-  }));
-});
--- a/aio/content/examples/interpolation/src/app/app.component.ts
+++ b/aio/content/examples/interpolation/src/app/app.component.ts
@ -1,25 +0,0 @@
-import { Component } from '@angular/core';
-
-import { CUSTOMERS } from './customers';
-
-@Component({
-  selector: 'app-root',
-  templateUrl: './app.component.html',
-  styleUrls: ['./app.component.css']
-})
-export class AppComponent {
-  customers = CUSTOMERS;
-
-  currentCustomer = 'Maria';
-  title = 'Featured product:';
-  itemImageUrl = '../assets/pottedPlant.png';
-
-  recommended = 'You might also like:';
-  itemImageUrl2 = '../assets/lamp.png';
-
-
-
-  getVal(): number { return 2; }
-
-
-}
--- a/aio/content/examples/interpolation/src/app/app.module.ts
+++ b/aio/content/examples/interpolation/src/app/app.module.ts
@ -1,18 +0,0 @@
-import { BrowserModule } from '@angular/platform-browser';
-import { NgModule } from '@angular/core';
-
-
-import { AppComponent } from './app.component';
-
-
-@NgModule({
-  declarations: [
-    AppComponent
-  ],
-  imports: [
-    BrowserModule
-  ],
-  providers: [],
-  bootstrap: [AppComponent]
-})
-export class AppModule { }
--- a/aio/content/examples/interpolation/src/app/customer.ts
+++ b/aio/content/examples/interpolation/src/app/customer.ts
@ -1,3 +0,0 @@
-export class Customer {
-  name: string;
-}
--- a/aio/content/examples/interpolation/src/app/customers.ts
+++ b/aio/content/examples/interpolation/src/app/customers.ts
@ -1,9 +0,0 @@
-import { Customer } from './customer';
-
-export const CUSTOMERS: Customer[] = [
-  { name: 'Maria' },
-  { name: 'Oliver' },
-  { name: 'Walter' },
-  { name: 'Lakshmi' },
-  { name: 'Yasha' }
-];
--- a/aio/content/examples/interpolation/src/assets/lamp.png
+++ b/aio/content/examples/interpolation/src/assets/lamp.png
--- a/aio/content/examples/interpolation/src/assets/potted-plant.png
+++ b/aio/content/examples/interpolation/src/assets/potted-plant.png
--- a/aio/content/examples/interpolation/src/index.html
+++ b/aio/content/examples/interpolation/src/index.html
@ -1,14 +0,0 @@
-<!doctype html>
-<html lang="en">
-<head>
-  <meta charset="utf-8">
-  <title>Interpolation</title>
-  <base href="/">
-
-  <meta name="viewport" content="width=device-width, initial-scale=1">
-  <link rel="icon" type="image/x-icon" href="favicon.ico">
-</head>
-<body>
-  <app-root></app-root>
-</body>
-</html>
--- a/aio/content/examples/interpolation/src/main.ts
+++ b/aio/content/examples/interpolation/src/main.ts
@ -1,12 +0,0 @@
-import { enableProdMode } from '@angular/core';
-import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
-
-import { AppModule } from './app/app.module';
-import { environment } from './environments/environment';
-
-if (environment.production) {
-  enableProdMode();
-}
-
-platformBrowserDynamic().bootstrapModule(AppModule)
-  .catch(err => console.log(err));
--- a/aio/content/examples/interpolation/stackblitz.json
+++ b/aio/content/examples/interpolation/stackblitz.json
@ -1,10 +0,0 @@
-{
-  "description": "Interpolation",
-  "files": [
-    "!**/*.d.ts",
-    "!**/*.js",
-    "!**/*.[1,2].*"
-  ],
-  "file": "src/app/app.component.ts",
-  "tags": ["interpolation"]
-}
--- a/aio/content/examples/ngmodule-faq/src/app/app.module.3.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/app.module.3.ts
@ -13,8 +13,8 @@ import { AppComponent }       from './app.component';
 // #enddocregion
 */
 // #docregion
-import { HighlightDirective } from './highlight.directive.1';
-import { TitleComponent }     from './title.component.1';
+import { HighlightDirective } from './highlight.directive';
+import { TitleComponent }     from './title.component';
 import { UserService }        from './user.service';

 /* Routing Module */
--- a/aio/content/examples/ngmodule-faq/src/app/contact/awesome.pipe.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/contact/awesome.pipe.ts
@ -0,0 +1,10 @@
+// #docregion
+import { Pipe, PipeTransform } from '@angular/core';
+
+@Pipe({ name: 'awesome' })
+/** Precede the input string with the word "Awesome " */
+export class AwesomePipe implements PipeTransform {
+  transform(phrase: string) {
+    return phrase ? 'Awesome ' + phrase : '';
+  }
+}
--- a/aio/content/examples/ngmodule-faq/src/app/contact/contact-highlight.directive.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/contact/contact-highlight.directive.ts
@ -0,0 +1,20 @@
+// #docplaster
+// Same directive name and selector as
+// HighlightDirective in parent AppModule
+// It selects for both input boxes and  'highlight' attr
+// and it highlights in blue instead of gold
+
+// #docregion
+import { Directive, ElementRef } from '@angular/core';
+
+// Highlight the host element or any InputElement in blue
+@Directive({ selector: '[highlight], input' })
+export class ContactHighlightDirective {
+  constructor(el: ElementRef) {
+    el.nativeElement.style.backgroundColor = 'powderblue';
+    // #enddocregion
+    console.log(`* Contact highlight called for ${el.nativeElement.tagName}`);
+    // #docregion
+  }
+}
+// #enddocregion
--- a/aio/content/examples/ngmodule-faq/src/app/hero/highlight.directive.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/hero/highlight.directive.ts
@ -0,0 +1,14 @@
+// #docregion
+import { Directive, ElementRef } from '@angular/core';
+
+// Same directive name and selector as
+// HighlightDirective in parent AppRootModule
+// It selects for both input boxes and  'highlight' attr
+// and it highlights in beige instead of yellow
+@Directive({ selector: '[highlight]' })
+export class HighlightDirective {
+    constructor(el: ElementRef) {
+       el.nativeElement.style.backgroundColor = 'beige';
+       console.log(`* Hero highlight called for ${el.nativeElement.tagName}`);
+    }
+}
--- a/aio/content/examples/ngmodule-faq/src/app/highlight.directive.1.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/highlight.directive.1.ts
--- a/aio/content/examples/ngmodule-faq/src/app/title.component.1.html
+++ b/aio/content/examples/ngmodule-faq/src/app/title.component.1.html
--- a/aio/content/examples/ngmodule-faq/src/app/title.component.1.ts
+++ b/aio/content/examples/ngmodule-faq/src/app/title.component.1.ts
@ -8,7 +8,7 @@ import { UserService } from './user.service';

@Component({
  selector: 'app-title',
-  templateUrl: './title.component.1.html'
+  templateUrl: './title.component.html'
 })
 export class TitleComponent {
  title = 'Angular Modules';
--- a/aio/content/examples/ngmodules/src/app/items/items.service.ts
+++ b/aio/content/examples/ngmodules/src/app/items/items.service.ts
@ -16,7 +16,7 @@ const ITEMS: Item[] = [

 const FETCH_LATENCY = 500;

-/** Simulate a data service that retrieves items from a server */
+/** Simulate a data service that retrieves crises from a server */
@Injectable()
 export class ItemService implements OnDestroy {

--- a/aio/content/examples/observables-in-angular/src/main.ts
+++ b/aio/content/examples/observables-in-angular/src/main.ts
@ -61,7 +61,7 @@ export class Routable1Component implements OnInit {
  navStart: Observable<NavigationStart>;

  constructor(private router: Router) {
-    // Create a new Observable that publishes only the NavigationStart event
+    // Create a new Observable the publishes only the NavigationStart event
    this.navStart = router.events.pipe(
      filter(evt => evt instanceof NavigationStart)
    ) as Observable<NavigationStart>;
--- a/aio/content/examples/practical-observable-usage/src/backoff.ts
+++ b/aio/content/examples/practical-observable-usage/src/backoff.ts
@ -5,9 +5,10 @@ import { retryWhen, map, mergeMap } from 'rxjs/operators';

 function backoff(maxTries, ms) {
 return pipe(
-   retryWhen(attempts => zip(range(1, maxTries), attempts)
+   retryWhen(attempts => range(1, maxTries)
     .pipe(
-       map(([i]) => i * i),
+       zip(attempts, (i) => i),
+       map(i => i * i),
       mergeMap(i =>  timer(i * ms))
     )
   )
--- a/aio/content/examples/property-binding/src/app/app.component.ts
+++ b/aio/content/examples/property-binding/src/app/app.component.ts
@ -1,30 +0,0 @@
-import { Component } from '@angular/core';
-
-
-@Component({
-  selector: 'app-root',
-  templateUrl: './app.component.html',
-  styleUrls: ['./app.component.css']
-})
-export class AppComponent {
-  itemImageUrl = '../assets/lamp.png';
-  isUnchanged = true;
-  classes = 'special';
-  // #docregion parent-data-type
-  parentItem = 'bananas';
-  // #enddocregion parent-data-type
-
-  // #docregion pass-object
-  currentItem = [{
-    id: 21,
-    name: 'peaches'
-  }];
-  // #enddocregion pass-object
-
-  interpolationTitle = 'Interpolation';
-  propertyTitle = 'Property binding';
-
-  // #docregion malicious-content
-  evilTitle = 'Template <script>alert("evil never sleeps")</script>Syntax';
-  // #enddocregion malicious-content
-}
--- a/aio/content/examples/quickstart/bs-config.1.json
+++ b/aio/content/examples/quickstart/bs-config.1.json
@ -0,0 +1,8 @@
+{
+  "server": {
+    "baseDir": "src",
+    "routes": {
+      "/node_modules": "node_modules"
+    }
+  }
+}
--- a/aio/content/examples/setup/e2e/src/app.e2e-spec.ts
+++ b/aio/content/examples/setup/e2e/src/app.e2e-spec.ts
--- a/aio/content/examples/interpolation/example-config.json
+++ b/aio/content/examples/interpolation/example-config.json
--- a/aio/content/examples/quickstart/src/app/app.component.ts
+++ b/aio/content/examples/quickstart/src/app/app.component.ts
@ -0,0 +1,8 @@
+// #docregion
+import { Component } from '@angular/core';
+
+@Component({
+  selector: 'my-app',
+  template: `<h1>Hello {{name}}</h1>`
+})
+export class AppComponent { name = 'Angular'; }
--- a/aio/content/examples/quickstart/src/app/app.module.ts
+++ b/aio/content/examples/quickstart/src/app/app.module.ts
@ -0,0 +1,11 @@
+// #docregion
+import { NgModule }      from '@angular/core';
+import { BrowserModule } from '@angular/platform-browser';
+import { AppComponent }  from './app.component';
+
+@NgModule({
+  imports:      [ BrowserModule ],
+  declarations: [ AppComponent ],
+  bootstrap:    [ AppComponent ]
+})
+export class AppModule { }
--- a/aio/content/examples/quickstart/src/index.html
+++ b/aio/content/examples/quickstart/src/index.html
@ -0,0 +1,31 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Angular Quickstart</title>
+    <base href="/">
+    <meta charset="UTF-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+    <style>
+      body {color:#369;font-family: Arial,Helvetica,sans-serif;}
+    </style>
+
+    <!-- Polyfills -->
+    <!-- #docregion polyfills -->
+    <script src="node_modules/core-js/client/shim.min.js"></script>
+    <!-- #enddocregion polyfills -->
+
+    <script src="node_modules/zone.js/dist/zone.js"></script>
+    <script src="node_modules/systemjs/dist/system.src.js"></script>
+    <script src="systemjs.config.js"></script>
+    <script>
+      System.import('main.js').catch(function(err){ console.error(err); });
+    </script>
+  </head>
+
+  <body>
+    <!-- #docregion my-app-->
+    <my-app>Loading AppComponent content here ...</my-app>
+    <!-- #enddocregion my-app-->
+  </body>
+
+</html>
--- a/aio/content/examples/quickstart/src/main.ts
+++ b/aio/content/examples/quickstart/src/main.ts
@ -0,0 +1,5 @@
+import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
+
+import { AppModule } from './app/app.module';
+
+platformBrowserDynamic().bootstrapModule(AppModule);
--- a/aio/content/examples/quickstart/src/tsconfig.1.json
+++ b/aio/content/examples/quickstart/src/tsconfig.1.json
@ -0,0 +1,13 @@
+{
+  "compilerOptions": {
+    "target": "es5",
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "sourceMap": true,
+    "emitDecoratorMetadata": true,
+    "experimentalDecorators": true,
+    "lib": [ "es2015", "dom" ],
+    "noImplicitAny": true,
+    "suppressImplicitAnyIndexErrors": true
+  }
+}
--- a/aio/content/examples/quickstart/stackblitz.json
+++ b/aio/content/examples/quickstart/stackblitz.json
@ -0,0 +1,11 @@
+{
+  "description": "QuickStart",
+  "files": [
+    "src/app/app.component.ts",
+    "src/app/app.module.ts",
+    "src/main.ts",
+    "src/index.html"
+  ],
+  "file": "src/app/app.component.ts",
+  "tags": ["quickstart"]
+}
--- a/aio/content/examples/router/src/app/crisis-list/crisis-list.component.css
+++ b/aio/content/examples/router/src/app/crisis-list/crisis-list.component.css
--- a/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.html
+++ b/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.html
--- a/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.ts
+++ b/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.ts
@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
  selector: 'app-crisis-list',
-  templateUrl: './crisis-list.component.1.html',
-  styleUrls: ['./crisis-list.component.1.css']
+  templateUrl: './crisis-list.component.html',
+  styleUrls: ['./crisis-list.component.css']
 })
 export class CrisisListComponent { }
--- a/aio/content/examples/router/src/app/hero-list/hero-list.component.1.css
+++ b/aio/content/examples/router/src/app/hero-list/hero-list.component.1.css
--- a/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.css
+++ b/aio/content/examples/router/src/app/crisis-list/crisis-list.component.1.css
--- a/aio/content/examples/router/src/app/hero-list/hero-list.component.1.html
+++ b/aio/content/examples/router/src/app/hero-list/hero-list.component.1.html
--- a/aio/content/examples/router/src/app/hero-list/hero-list.component.1.ts
+++ b/aio/content/examples/router/src/app/hero-list/hero-list.component.1.ts
@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
  selector: 'app-hero-list',
-  templateUrl: './hero-list.component.1.html',
-  styleUrls: ['./hero-list.component.1.css']
+  templateUrl: './hero-list.component.html',
+  styleUrls: ['./hero-list.component.css']
 })
 export class HeroListComponent { }
--- a/aio/content/examples/rx-library/src/simple-creation.ts
+++ b/aio/content/examples/rx-library/src/simple-creation.ts
@ -1,10 +1,10 @@

 // #docregion promise

-import { from } from 'rxjs';
+import { fromPromise } from 'rxjs';

 // Create an Observable out of a promise
-const data = from(fetch('/api/endpoint'));
+const data = fromPromise(fetch('/api/endpoint'));
 // Subscribe to begin listening for async result
 data.subscribe({
 next(response) { console.log(response); },
--- a/aio/content/examples/service-worker-getting-started/e2e/src/app.e2e-spec.ts
+++ b/aio/content/examples/service-worker-getting-started/e2e/src/app.e2e-spec.ts
@ -34,9 +34,8 @@ describe('sw-example App', () => {
        expect(items[3].getText()).toBe('Angular blog');
      });
  });
-
-  // Check for a rejected promise as the service worker is not enabled
-  it('SwUpdate.checkForUpdate() should return a rejected promise', () => {
+   // Check for a rejected promise as the service worker is not enabled
+   it('SwUpdate.checkForUpdate() should return a rejected promise', () => {
    const button = element(by.css('button'));
    const rejectMessage = element(by.css('p'));
    button.click();
--- a/aio/content/examples/service-worker-getting-started/example-config.json
+++ b/aio/content/examples/service-worker-getting-started/example-config.json
@ -1,10 +0,0 @@
-{
-  "projectType": "service-worker",
-  "e2e": [
-    {"cmd": "yarn", "args": ["e2e", "--no-webdriver-update"]},
-    {"cmd": "yarn", "args": ["build", "--prod"]},
-    {"cmd": "node", "args": ["--eval", "assert(fs.existsSync('./dist/ngsw.json'), 'ngsw.json is missing')"]},
-    {"cmd": "node", "args": ["--eval", "assert(fs.existsSync('./dist/ngsw-worker.js'), 'ngsw-worker.js is missing')"]},
-    {"cmd": "node", "args": ["--eval", "assert(require('./package.json').dependencies['@angular/service-worker'], '@angular/service-worker is missing')"]}
-  ]
-}
--- a/aio/content/examples/service-worker-getting-started/src/app/app.component.ts
+++ b/aio/content/examples/service-worker-getting-started/src/app/app.component.ts
@ -12,9 +12,9 @@ export class AppComponent {
  constructor(private update: SwUpdate) {}

  updateCheck(): void {
-    this.update
+      this.update
        .checkForUpdate()
        .then(() => this.updateCheckText = 'resolved')
        .catch(err => this.updateCheckText = `rejected: ${err.message}`);
-  }
+    }
 }
--- a/aio/content/examples/service-worker-getting-started/src/app/check-for-update.service.ts
+++ b/aio/content/examples/service-worker-getting-started/src/app/check-for-update.service.ts
@ -1,17 +1,15 @@
-import { ApplicationRef, Injectable } from '@angular/core';
+import { Injectable } from '@angular/core';
 import { SwUpdate } from '@angular/service-worker';
-import { concat, interval } from 'rxjs';
-import { first } from 'rxjs/operators';
+
+
+// #docregion sw-check-update
+import { interval } from 'rxjs';

@Injectable()
 export class CheckForUpdateService {

-  constructor(appRef: ApplicationRef, updates: SwUpdate) {
-    // Allow the app to stabilize first, before starting polling for updates with `interval()`.
-    const appIsStable$ = appRef.isStable.pipe(first(isStable => isStable === true));
-    const everySixHours$ = interval(6 * 60 * 60 * 1000);
-    const everySixHoursOnceAppIsStable$ = concat(appIsStable$, everySixHours$);
-
-    everySixHoursOnceAppIsStable$.subscribe(() => updates.checkForUpdate());
+  constructor(updates: SwUpdate) {
+    interval(6 * 60 * 60).subscribe(() => updates.checkForUpdate());
  }
 }
+// #enddocregion sw-check-update
--- a/aio/content/examples/service-worker-getting-started/src/ngsw-config.json
+++ b/aio/content/examples/service-worker-getting-started/src/ngsw-config.json
--- a/aio/content/examples/setup/e2e-spec.ts
+++ b/aio/content/examples/setup/e2e-spec.ts
@ -0,0 +1,17 @@
+'use strict'; // necessary for es6 output in node
+
+import { browser, element, by } from 'protractor';
+
+describe('QuickStart E2E Tests', function () {
+
+  let expectedMsg = 'Hello Angular';
+
+  beforeEach(function () {
+    browser.get('');
+  });
+
+  it(`should display: ${expectedMsg}`, function () {
+    expect(element(by.css('h1')).getText()).toEqual(expectedMsg);
+  });
+
+});
--- a/aio/content/examples/structural-directives/src/app/app.component.html
+++ b/aio/content/examples/structural-directives/src/app/app.component.html
@ -152,7 +152,7 @@
 <div [ngSwitch]="hero?.emotion">
  <app-happy-hero    *ngSwitchCase="'happy'"    [hero]="hero"></app-happy-hero>
  <app-sad-hero      *ngSwitchCase="'sad'"      [hero]="hero"></app-sad-hero>
-  <app-confused-hero *ngSwitchCase="'confused'" [hero]="hero"></app-confused-hero>
+  <app-confused-hero *ngSwitchCase="'app-confused'" [hero]="hero"></app-confused-hero>
  <app-unknown-hero  *ngSwitchDefault           [hero]="hero"></app-unknown-hero>
 </div>
 <!-- #enddocregion built-in, ngswitch -->
--- a/aio/content/examples/styleguide/src/03-06/app/core/spinner/index.ts
+++ b/aio/content/examples/styleguide/src/03-06/app/core/spinner/index.ts
@ -1,2 +1,3 @@
 // #docregion
+export * from './spinner.component';
 export * from './spinner.service';
--- a/aio/content/examples/styleguide/src/03-06/app/core/spinner/spinner.component.ts
+++ b/aio/content/examples/styleguide/src/03-06/app/core/spinner/spinner.component.ts
@ -0,0 +1,16 @@
+import { Component, OnDestroy, OnInit } from '@angular/core';
+
+import { SpinnerService } from './spinner.service';
+
+@Component({
+  selector: 'toh-spinner',
+  template: '<div>spinner</div>'
+})
+
+export class SpinnerComponent implements OnDestroy, OnInit {
+  constructor(private spinnerService: SpinnerService) { }
+
+  ngOnInit() { }
+
+  ngOnDestroy() { }
+}
--- a/aio/content/examples/styleguide/src/03-06/app/core/toast/index.ts
+++ b/aio/content/examples/styleguide/src/03-06/app/core/toast/index.ts
@ -1,2 +1,3 @@
 // #docregion
+export * from './toast.component';
 export * from './toast.service';
--- a/aio/content/examples/styleguide/src/03-06/app/core/toast/toast.component.ts
+++ b/aio/content/examples/styleguide/src/03-06/app/core/toast/toast.component.ts
@ -0,0 +1,13 @@
+import { Component, OnInit } from '@angular/core';
+
+import { ToastService } from './toast.service';
+
+@Component({
+  selector: 'toh-toast',
+  template: '<div>toast</div>'
+})
+export class ToastComponent implements OnInit {
+  constructor(toastService: ToastService) { }
+
+  ngOnInit() { }
+}
--- a/aio/content/examples/styleguide/src/03-06/app/shared/toast/toast.component.ts
+++ b/aio/content/examples/styleguide/src/03-06/app/shared/toast/toast.component.ts
@ -0,0 +1,13 @@
+import { Component, OnInit } from '@angular/core';
+
+import { ToastService } from '../../core';
+
+@Component({
+  selector: 'toh-toast',
+  template: '<div>toast</div>'
+})
+export class ToastComponent implements OnInit {
+  constructor(toastService: ToastService) { }
+
+  ngOnInit() { }
+}
--- a/aio/content/examples/styleguide/src/04-11/app/core/nav/nav.component.css
+++ b/aio/content/examples/styleguide/src/04-11/app/core/nav/nav.component.css
@ -32,6 +32,8 @@
  height: 56px;
  padding: 0 16px 0 72px;
  padding-left: 8px;
+  background-color: #673AB7;
+  background: #0033FF;
  background-color: #222;
 }

--- a/aio/content/examples/styleguide/src/04-11/app/core/spinner/spinner.component.css
+++ b/aio/content/examples/styleguide/src/04-11/app/core/spinner/spinner.component.css
@ -1,5 +1,6 @@
 /*#docregion*/
 .spinner {
+  position: absolute;
  left: 7em;
  top: 20em;
  position: absolute;
--- a/aio/content/examples/styleguide/src/04-12/app/core/nav/nav.component.css
+++ b/aio/content/examples/styleguide/src/04-12/app/core/nav/nav.component.css
@ -32,6 +32,8 @@
  height: 56px;
  padding: 0 16px 0 72px;
  padding-left: 8px;
+  background-color: #673AB7;
+  background: #0033FF;
  background-color: #222;
 }

--- a/aio/content/examples/styleguide/src/05-13/app/app.component.ts
+++ b/aio/content/examples/styleguide/src/05-13/app/app.component.ts
@ -4,7 +4,4 @@ import { Component } from '@angular/core';
  selector: 'sg-app',
  templateUrl: './app.component.html'
 })
-export class AppComponent {
-
-  doSomething() {}
-}
+export class AppComponent { }
--- a/aio/content/examples/styleguide/src/05-16/app/app.component.ts
+++ b/aio/content/examples/styleguide/src/05-16/app/app.component.ts
@ -4,7 +4,4 @@ import { Component } from '@angular/core';
  selector: 'sg-app',
  templateUrl: './app.component.html'
 })
-export class AppComponent {
-
-  onSavedTheDay(event$: any) { }
-}
+export class AppComponent { }
--- a/aio/content/examples/template-syntax/src/app/app.component.ts
+++ b/aio/content/examples/template-syntax/src/app/app.component.ts
@ -66,7 +66,7 @@ export class AppComponent implements AfterViewInit, OnInit {

  currentHero: Hero;

-  deleteHero(hero?: Hero) {
+  deleteHero(hero: Hero) {
    this.alert(`Delete ${hero ? hero.name : 'the hero'}.`);
  }

@ -105,18 +105,18 @@ export class AppComponent implements AfterViewInit, OnInit {

  get nullHero(): Hero { return null; }

-  onClickMe(event?: KeyboardEvent) {
+  onClickMe(event: KeyboardEvent) {
    let evtMsg = event ? ' Event target class is ' + (<HTMLElement>event.target).className  : '';
    this.alert('Click me.' + evtMsg);
  }

-  onSave(event?: KeyboardEvent) {
+  onSave(event: KeyboardEvent) {
    let evtMsg = event ? ' Event target is ' + (<HTMLElement>event.target).textContent : '';
    this.alert('Saved.' + evtMsg);
    if (event) { event.stopPropagation(); }
  }

-  onSubmit(data: any) {/* referenced but not used */}
+  onSubmit() {/* referenced but not used */}

  product = {
    name: 'frimfram',
--- a/aio/content/examples/testing/src/testing/router-link-directive-stub.ts
+++ b/aio/content/examples/testing/src/testing/router-link-directive-stub.ts
@ -1,4 +1,4 @@
-import { Directive, Input, HostListener } from '@angular/core';
+import { Directive, Input } from '@angular/core';

 // export for convenience.
 export { RouterLink} from '@angular/router';
@ -6,13 +6,13 @@ export { RouterLink} from '@angular/router';
 /* tslint:disable:directive-class-suffix */
 // #docregion router-link
@Directive({
-  selector: '[routerLink]'
+  selector: '[routerLink]',
+  host: { '(click)': 'onClick()' }
 })
 export class RouterLinkDirectiveStub {
  @Input('routerLink') linkParams: any;
  navigatedTo: any = null;

-  @HostListener('click')
  onClick() {
    this.navigatedTo = this.linkParams;
  }
--- a/aio/content/examples/toh-pt6/src/app/hero.service.ts
+++ b/aio/content/examples/toh-pt6/src/app/hero.service.ts
@ -97,7 +97,7 @@ export class HeroService {
  /** POST: add a new hero to the server */
  addHero (hero: Hero): Observable<Hero> {
    return this.http.post<Hero>(this.heroesUrl, hero, httpOptions).pipe(
-      tap((newHero: Hero) => this.log(`added hero w/ id=${newHero.id}`)),
+      tap((hero: Hero) => this.log(`added hero w/ id=${hero.id}`)),
      catchError(this.handleError<Hero>('addHero'))
    );
  }
--- a/aio/content/examples/upgrade-phonecat-2-hybrid/karma.conf.js
+++ b/aio/content/examples/upgrade-phonecat-2-hybrid/karma.conf.js
@ -23,6 +23,15 @@ module.exports = function(config) {
      clearContext: false // leave Jasmine Spec Runner output visible in browser
    },

+    customLaunchers: {
+      // From the CLI. Not used here but interesting
+      // chrome setup for travis CI using chromium
+      Chrome_travis_ci: {
+        base: 'Chrome',
+        flags: ['--no-sandbox']
+      }
+    },
+
    files: [
      // System.js for module loading
      'node_modules/systemjs/dist/system.src.js',
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Igor Minar	11d2a8cc81	release: cut the v7.1.2 release	2018-12-06 15:08:57 -08:00
Minko Gechev	ad106abece	build: introduce remote bazel caching (#27358 ) This PR introduces: 1. Google Cloud Store bucket which contains build artifacts 2. Documentation on how to enable remote caching in development Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts. PR Close #27358	2018-12-06 11:25:03 -08:00
Paul Gschwendtner	84f2928c8c	fix(compiler-cli): ngtsc shim files not being generated on case-insensitive platforms (#27466 ) Common insensitive platforms are `win32/win64` (see: [here](`3e4c5c95ab/src/compiler/sys.ts (L681-L682)`)) Currently when running `bazel build packages/core --define=compile=aot`, the `compiler-cli` will throw because it cannot find the `index.ngfactory.ts` file in the compiler host. This is because the shim host wrapper is not properly generating the requested `ngfactory` file. This happens because we call `getCanonicalFileName` that returns a path that is different to the actual program filenames that are used to construct a map of generated files. Since the generators always use the paths which are not "canonical" and pases them internally like that, we can just stop manually calling `getCanonicalFileName`. PR Close #27466	2018-12-06 09:24:53 -08:00
Igor Minar	610472bf3b	Revert "fix(router): change processing url tree children condition (#26243 )" (#27516 ) This reverts commit `ccc77ca441`. Breaks Pantheon see cl/224256517. PR Close #27516	2018-12-06 09:17:21 -08:00
Igor Minar	7bed896f11	Revert "fix(router): process empty path segment when preceding a named outlet (#26243 )" (#27516 ) This reverts commit `20cef5078d`. Breaks Pantheon see cl/224256517. PR Close #27516	2018-12-06 09:17:21 -08:00
Igor Minar	d7c72fced7	build: remove obsolete gulp build task (#27386 ) PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	3ca5de7efd	ci: don't run node unit tests on travis (#27386 ) we run all these tests on CircleCI with bazel. PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	485e2a147a	test(benchpress): make most of the tests run under bazel (#27386 ) PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	b24f1984f3	ci: remove validate-commit-message tests from travis (#27386 ) we alredy run them via bazel. I also removed a bunch of obsolete files that bazel doesn't need. PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	f8846ef14e	docs: remove obsolete packages/examples/web_workers/ts/.gitkeep (#27386 ) PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	9a93259b64	test: correct bazel visibility for @angular/private/testing (#27386 ) we don't want anyone else to depened on this stuff. PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	194f1f084f	test(service-worker): run the remaining service-worker tests under bazel (#27386 ) PR Close #27386	2018-12-05 20:55:33 -08:00
Igor Minar	fba9fa2302	test(common): run @angular/common/http/testing tests under bazel (#27386 ) PR Close #27386	2018-12-05 20:55:32 -08:00
Igor Minar	820e2027e0	ci: don't run router tests on travis (#27386 ) we already run them on circle under bazel PR Close #27386	2018-12-05 20:55:32 -08:00
Kara Erickson	0508143128	build: add kara to more approval lists (#27493 ) PR Close #27493	2018-12-05 14:41:50 -08:00
George Kalpakas	a97fbfd823	refactor(docs-infra): remove unused custom element (#27250 ) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	e552cadc90	fix(docs-infra): do not use an Angular element in hard-coded `FETCH_ERROR` document (#27250 ) The `FETCH_ERROR` document is used when we are unable to retrieve a document (except for 404 errors), which includes when there is no internet connection. Using the `<current-location>` element in the document's template to show the path of the page we failed to retrieve assumes that the element's bundle is available (e.g. cached by the SW) or can be fetched from the server. When none of these conditions is met, the `DocViewer` is unable to prepare the document and fails, never showing the `FETCH_ERROR` page to the user. Furthermore, the path we are looking to retrieve via `<current-location>` is essentially the document ID, which we already have. Thus, loading and instantiating a whole component just for that is overkill. This commit addresses both issues by getting rid of the `<current-location>` component and directly embedding the document ID into the `FETCH_ERROR` content. PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	35ab809326	fix(docs-infra): fix sidenav positioning when notification is shown (#27250 ) _Before:_ ![sidenav-scrollbar-before](https://user-images.githubusercontent.com/8604205/49089078-62519d00-f263-11e8-8369-f39e73dcc239.png) _After:_ ![sidenav-scrollbar-after](https://user-images.githubusercontent.com/8604205/49089077-62519d00-f263-11e8-8a94-0c34044c4ba1.png) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	919ef66a7c	build(docs-infra): remove dependency on FontAwesome (#27250 ) We were only using two FontAwesome icons (`link` and `twitter`). The twitter icon is already available as an SVG (used in the topbar) and a similar link icon is available via 'Material Icons', which we are already brining in. This commit removes the dependency on FontAwesome and uses the available icons instead. _Before:_ ![contributor-info-before](https://user-images.githubusercontent.com/8604205/49089076-61b90680-f263-11e8-8c5f-c52d332e6e64.png) _After:_ ![contributor-info-after](https://user-images.githubusercontent.com/8604205/49089075-61b90680-f263-11e8-9785-b8df15aaacd3.png) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	a37c65827a	fix(docs-infra): correctly cache footer image by the SW (#27250 ) When using relative paths for CSS resources (such as background images), `@angular/cli` will move them to the root `dist/` directory (and update the paths in CSS accordingly). This results in the SW being unable to cache the resource, because it is not where it expects it to be. This commit fixes this issue for the footer background image, by using an absolute path for the URL. (It also removes an unused style that would have been affected by the same issue.) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	1371cf6d33	fix(docs-infra): ensure material icons are cached for offline access (#27250 ) In order for 'Material Icons' to work offline, their `.woff2` file needs to have been cached by the SW. This file is not requested by the browser, until an element needs to use the icon font. In order to speed up the initial page load and avoid FOUC, we use inlined SVGs for all icons in the app shell. As a result, the `.woff2` file may not be requested, when a user visits angular.io. If they go offline before visiting a page that does actually use 'Material Icons', then such icons will not work correctly (e.g. the `error_outline` icon used in the error page for failed requests due to network unanvailability). This commit fixes this, by adding a non-visible element that needs the 'Material Icons' font on the main component. Thids ensures that the `.woff2` file will always be loaded, even if the page does not use any material icons. (Note: The element is inserted lazily to avoid affecting the initial rendering.) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	e9655720f8	fix(docs-infra): remove hard-coded color from inlined SVG icons (#27250 ) This allows the icons to inherit the color of their HTMLElement parent. PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	8512e34521	fix(docs-infra): inline SVG icons used in page load sensitive UI (#27250 ) These icons are part of the app shell and used on every load (on both desktop and mobile). Inlining them ensures they are rendered asap. PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	21c9cfff5a	fix(docs-infra): always fetch Roboto font (#27250 ) Previously, we did not load the Roboto font, instead relying on the user to have it available on their system and falling back to different fonts otherwise. This resulted in the page being styled slightly differently for those people that didn't have the font installed locally. PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	e902f5ee6a	fix(docs-infra): do not create an anchor for the `file-not-found` header (#27250 ) PR Close #27250	2018-12-05 13:26:28 -08:00
George Kalpakas	013a241b94	refactor(docs-infra): move minified `lunr` script to the `generated` directory (#27250 ) PR Close #27250	2018-12-05 13:26:27 -08:00
George Kalpakas	0d0bc1f725	build: error when files specified in payload size limits are missing (#27250 ) PR Close #27250	2018-12-05 13:26:27 -08:00
Filipe Silva	a655d288ca	ci: test ts-api-guardian on windows (#27205 ) PR Close #27205	2018-12-05 12:49:55 -08:00
Igor Minar	e55088a364	build: to fsevents@2.0.1 (#27469 ) the old version was failing to compile on MacOS Mojave 10.14.1. PR Close #27469	2018-12-05 10:48:20 -08:00
Greg Magolan	2e41631026	build(bazel): replace yarn_install(name = "npm") with @npm local_reporsitory() to speed up build (#27469 ) PR Close #27469	2018-12-05 10:48:20 -08:00
miginmrs	2bc85fb77e	fix(router): process empty path segment when preceding a named outlet (#26243 ) PR Close #10726 PR Close #26243	2018-12-05 10:39:30 -08:00
miginmrs	8167bfc87c	fix(router): change processing url tree children condition (#26243 ) stop adding next path of pathless activated route to the url PR Close #26224 PR Close #26243	2018-12-05 10:39:30 -08:00
Alex Eagle	711ef2ded4	build: update to newest ibazel (#27441 ) this supports the --define flag which we use for Ivy development PR Close #27441	2018-12-04 20:00:06 -08:00
George Kalpakas	5c57920dbb	fix(docs-infra): log the successful creation of previews (#27436 ) This can help with debugging issues, e.g. with the communication between the preview server and CI, as it gives a better idea of exactly when was the preview made available and how long it took. PR Close #27436	2018-12-04 19:59:25 -08:00
Paul Gschwendtner	9b4d95974a	fix(bazel): do not throw if ts compile action does not create esm5 outputs (#27401 ) In some applications, developers define a `ts_library` that just consists of `d.ts` files (e.g. to type `module.id`; see: https://github.com/angular/material2/blob/master/src/module-typings.d.ts), and expect the `esm5.bzl` file to not throw an error like: ``` target.typescript.replay_params.outputs struct' object has no attribute 'outputs' ``` The "replay_parameters" property will exist in that case, but is set to "None" because there is no action that should be replayed in favor of producing ES5 outputs. See: https://github.com/bazelbuild/rules_typescript/pull/326. Notice that this right now breaks similarly because an empty `struct()` is returned that does not have a property called `outputs`. [#326](https://github.com/bazelbuild/rules_typescript/pull/326) fixes that by being explicit that there is no _action_ at all. PR Close #27401	2018-12-04 19:58:36 -08:00
Paul Gschwendtner	8087b6b611	fix(compiler-cli): flatModuleIndex files not generated on windows with multiple input files (#27200 ) * Currently when building a `ng_module` with Bazel and having the flat module id option set, the flat module files are not being generated because `@angular/compiler-cli` does not properly determine the entry-point file. Note that this logic is not necessarily specific to Bazel and the same problem can happen without Bazel if multiple TypeScript input files are specified while the `flatModuleIndex` option has been enabled. PR Close #27200	2018-12-04 14:01:25 -08:00
Paul Gschwendtner	1ca292392b	fix(bazel): ng_package cannot be run multiple times without clean (#27200 ) Currently when building the `ng_package` multiple times, the old `ng_package` output will be copied over to the new `ng_package` content. Resulting in packages like `src/cdk/npm_package/npm_package/npm_package/AND_MORE`. This happens because currently all TypeScript definition files are resolved from within the `binDir`. This is just wrong because it could then take up the `d.ts` files from the previous `ng_package` output. All typescript definitions that belong to the target package, should be resolved through Bazel and copied based on that computation. Also fixes that `esm` files aren't written to the `ng_package` on Windows. This is because we try to flatten paths using the `path.delimiter` while the path is always using Posix delimiters (causing the paths to be incorrect) PR Close #27200	2018-12-04 14:01:25 -08:00
Paul Gschwendtner	079c4b3482	fix(bazel): do not throw error when writing tsickle externs (#27200 ) * Currently when building the ES5 and ES2015 output, `ngc_wrapped` will fail because it tries to write the `fs.openSync` the tsickle output file at the same time. This causes a runtime exception in Windows and can be fixed by just writing the externs for ES5 mode to the proper ES5 "output root". PR Close #27200	2018-12-04 14:01:25 -08:00
Paul Gschwendtner	e476c38dee	fix(bazel): ng_package not generating UMD bundles on windows (#27200 ) * Fixes that `ng_package` does not work generate UMD bundles on Windows because the `esm5/` files are not written to the output directory. This is because `rootDirs` and `rootDir` are posix paths and cause invalid relative paths when mixed with Windows backslash paths. PR Close #27200	2018-12-04 14:01:25 -08:00
George Kalpakas	8799ea7ea0	ci(docs-infra): manually trigger the preview server webhook (#27458 ) With this change, we no longer depend on CircleCI to trigger the webhook (which it sometimes does with considerable delay or not at all). This has the added benefit that other jobs will not unnecessarily trigger webhooks and spam the preview server logs. It is only the `aio_preview` job's webhook that we care about. Related to #27352. PR Close #27458	2018-12-04 13:59:54 -08:00
volshibenik	03787924da	docs: fix typo in toh-pt6.md (#27403 ) PR Close #27403	2018-12-03 08:24:19 -08:00
Christopher Dahm	1022db1c8c	test(common): add PercentPipe round and trim tests (#27365 ) Add tests to cover the percent's decimal to be rounded and trimmed. PR Close #27365	2018-12-03 08:22:25 -08:00
Christopher Dahm	560cb99f55	docs(common): update PercentPipe default maxFractionDigits value (#27365 ) Change the docs to reflect the actual default value Fixes #27079 PR Close #27365	2018-12-03 08:22:25 -08:00
Alex Eagle	5acfdee3ca	build: only stamp version info when releasing (#27362 ) Also build releases into a dedicated output_base so you can't accidentally publish with outdated version stamp. Bump the version of rules_nodejs so we don't need to create the symlink_prefixes for the .publish command to work. PR Close #27362	2018-11-30 16:08:23 -08:00
Igor Minar	fc2c23ef4b	fix(bazel): ng_package should correctly map to source maps in secondary entry-points (#27313 ) This fixes the issue with broken source maps for @angular/common/http/testing. Fixes #25510 PR Close #27313	2018-11-30 13:40:01 -08:00
Greg Magolan	1ddc34cbc5	build(bazel): update handling of rules_nodejs transitive deps (#27264 ) BREAKING CHANGES: Bazel users: rules_angular_dependencies() will no longer install transitive dependencies of build_bazel_rules_nodejs and build_bazel_rules_typescript. User WORKSPACE files will now need to install rules_nodejs and rules_typescript transitive deps directly: ``` load("@build_bazel_rules_typescript//:package.bzl", "rules_typescript_dependencies") rules_typescript_dependencies() load("@build_bazel_rules_nodejs//:package.bzl", "rules_nodejs_dependencies") rules_nodejs_dependencies() ``` PR Close #27264	2018-11-30 13:35:52 -08:00
dennisameling	184d63d91d	docs: fix dynamic-component-loader example for Adblock Plus + EasyList (#27212 ) Reported issue in #18138 is due to EasyList being selected in ABP. This commit fixes both the image at the bottom of the Dynamic Component Loader example, and the Stackblitz demo. Fixes #18138 PR Close #27212	2018-11-30 13:35:38 -08:00
Igor Minar	236ac060b0	fix(platform-server): add @angular/http to the list of peerDependencies (#27307 ) Fixes #26154 PR Close #27307	2018-11-30 10:02:44 -08:00
ryo.s	2cce8d4ebc	docs: fix typo (#27294 ) PR Close #27294	2018-11-29 22:15:28 -08:00
Brandon Roberts	a149c3a8db	docs(forms): update API reference for common APIs and template-driven directives (#27033 ) PR Close #27033	2018-11-29 21:33:08 -08:00
seunggabi	013c0ae2e1	style: change style css syntax (#27253 ) PR Close #27253	2018-11-29 21:26:53 -08:00
Miško Hevery	c8aebaeb76	build: Replace iteration over depsets with an explicit .to_list() call. (#27336 ) PR Close #27336	2018-11-29 21:22:39 -08:00
Kara Erickson	56254b53bd	build: add kara to approvers for packages needing ivy TestBed updates (#27337 ) PR Close #27337	2018-11-29 21:22:24 -08:00
Minko Gechev	5d0e1147df	docs: move Minko to Angular (#27339 ) Joined the team at Google about a month ago ✨ PR Close #27339	2018-11-29 21:21:54 -08:00
Grant Timmerman	a0f239fc71	docs: move past events on events page (#27342 ) Moves events that have already happened to the list of past events. PR Close #27342	2018-11-29 21:21:24 -08:00
Jacob Foshee	88032eb302	docs: Minor: insert missing space (#27213 ) PR Close #27213	2018-11-28 11:41:21 -08:00
Amadou Sall	827e223edb	docs: replace ChromeNoSandbox by ChromeHeadlessCI (#27304 ) the custom launcher name should be named ChromeHeadlessCI instead of ChromeNoSandbox. PR Close #27304	2018-11-28 11:40:03 -08:00
Filipe Silva	14d75d6971	docs: add instructions to diagnose slow Bazel builds (#27324 ) PR Close #27324	2018-11-28 11:39:38 -08:00
Jason Aden	8282e15c2b	release: cut the v7.1.1 release	2018-11-28 10:09:48 -08:00
Alex Rickabaugh	bdf5f3e499	fix(core): export a value for InjectFlags (#27279 ) A recent commit (probably `2c7386c`) has changed the import graph of the DI types in core, and somehow results in the ngc compiler deciding to re-export core DI types from application factories which tangentially use inject(). This is not really surprising; ngc's import graph can be very unstable. However, this results in a re-export of InjectFlags surviving JS compilation. InjectFlags was a const enum, akin to an interface in TS, with no runtime repesentation. This causes a warning to be emitted by Webpack when it sees the re-export of InjectFlags. This commit avoids the issue by removing 'const' from the declaration of InjectFlags, causing it to have a runtime value. This is a temporary fix. The real fix will be for ngc to no longer write exports of const enums. Testing strategy: manually verified. Due to the problem only manifesting when recompiling after a change and then running Webpack, there is no existing framework via which this could be easily tested with an integration test. Additionally, the potential for this issue is gone in Ivy, so this solution is only temporarily needed. Fixes #27251. PR Close #27279	2018-11-27 13:40:39 -08:00
George Kalpakas	a71038b5fa	build(docs-infra): upgrade `npm-run-all` to latest version for security (#27274 ) Earlier versions may transitively depend on a malicious version of `flatmap-stream` (see dominictarr/event-stream#116). The `aio-builds-setup/` had an older version of `event-stream` (3.3.4), which did not depend on `flatmap-stream`, but upgraded it anyway. PR Close #27274	2018-11-27 13:38:36 -08:00
onlyflix	d735160a11	fix(docs-infra): don't call setSearch when not clicking in the searchBox and no searchResults (#26590 ) Fix to call locationService.setSearch less often to avoid unnecessary downloading of favicons Fixes #26544 PR Close #26590	2018-11-27 13:38:28 -08:00
Brandon Roberts	498c4c32b1	docs: add forms terms to glossary (#27075 ) PR Close #27075	2018-11-27 13:38:20 -08:00
Paul Gschwendtner	b9c7da6503	build: fix source-map warnings for ts-api-guardian (#27098 ) * Fixes that running `ts-api-guardian` targets always causes source map warnings to appear. PR Close #27098	2018-11-27 13:38:13 -08:00