Go to file

crisbeto 835618c678 fix(ivy): error when accessing NgModuleRef.componentFactoryResolver in constructor (#35637 )

Currently we resolve the `NgModuleRef.componentFactoryResolver` by going through the injector, but the problem is that `ComponentFactoryResolver` has a dependency on `NgModuleRef`, which means that if the module that's attached to the ref tries to inject  `ComponentFactoryResolver` in its constructor, we'll create a circular dependency which throws at runtime.

These changes resolve the issue by creating the `ComponentFactoryResolver` manually ahead of time without going through the injector. We can do this safely, because the only dependency for the resolver is the current module ref which is providing it.

Aside from fixing the issue, another advantage to this approach is that it should reduce the amount of generated JS, because it removes a getter and a provider definitio.

Fixes #35580.

PR Close #35637

2020-02-25 13:19:13 -08:00

.circleci

ci: move saucelabs_ivy & saucelabs_view_engine to the daily monitoring CircleCI workflow (#35516 )

2020-02-24 17:27:21 -08:00

.devcontainer

build: update the recommended Dockerfile for VSCode remote development (#34697 )

2020-01-09 13:31:14 -08:00

.github

ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814 )

2020-01-28 09:19:34 -08:00

.vscode

build: migrate references and scripts that set to build with ivy via compile=aot to use config=ivy (#33983 )

2019-11-26 16:38:40 -05:00

.yarn

build: vendor yarn using the .yarnrc yarn-path value (#34902 )

2020-01-23 11:41:23 -08:00

aio

docs: update getting started topics to avoid duplicate topic names (#35457 )

2020-02-25 13:10:30 -08:00

docs

docs: minor typo fix (#35423 )

2020-02-13 10:08:23 -08:00

integration

build: add instructions for adding new integration tests to integration/README.md (#33927 )

2020-02-24 08:59:18 -08:00

modules

refactor(benchpress): delete outdated/unused folder (#35147 )

2020-02-07 16:14:27 -08:00

packages

fix(ivy): error when accessing NgModuleRef.componentFactoryResolver in constructor (#35637 )

2020-02-25 13:19:13 -08:00

scripts

build: several minor fixes related to using puppeteer (#35381 )

2020-02-18 12:42:47 -08:00

third_party

ci: Remove old vendoring solution in favor of relying on yarn-path (#35083 )

2020-02-06 15:30:51 -08:00

tools

test: saucelab targets for all karma tests (#35516 )

2020-02-24 17:27:21 -08:00

.bazelignore

build: add new integration tests & bazel-in-bazel tests to … glob (#33927 )

2020-02-24 08:59:18 -08:00

.bazelrc

build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-schematics (#33927 )

2020-02-24 08:59:18 -08:00

.clang-format

feat(tooling): Add a .clang-format for automated JavaScript formatting.

2015-04-02 08:44:34 -07:00

.editorconfig

build: use https link to editorconfig.org in .editorconfig (#27664 )

2018-12-18 09:30:09 -08:00

.gitattributes

test: fix ts api guardian and public guard tests on windows (#30105 )

2019-04-26 16:32:22 -07:00

.gitignore

ci: do not run benchmark measurements in circleci (#34753 )

2020-01-29 09:22:27 -08:00

.mailmap

build: add a Git .mailmap with my new name (#19550 )

2017-10-09 14:35:30 -07:00

.nvmrc

build: migrate to node@12.14.1 (#34955 )

2020-01-27 09:31:22 -08:00

.pullapprove.yml

build: add npm_integration_test && angular_integration_test (#33927 )

2020-02-24 08:59:18 -08:00

.yarnrc

build: vendor yarn using the .yarnrc yarn-path value (#34902 )

2020-01-23 11:41:23 -08:00

browser-providers.conf.js

ci: update the browser test matrix to match supported browsers (#35202 )

2020-02-14 11:14:05 -08:00

BUILD.bazel

test: saucelab targets for all karma tests (#35516 )

2020-02-24 17:27:21 -08:00

CHANGELOG.md

release: cut the v9.1.0-next.1 release

2020-02-19 12:15:43 -08:00

CODE_OF_CONDUCT.md

docs: fix community tab in GitHub by copying CoC

2018-02-27 19:02:30 -08:00

CONTRIBUTING.md

docs: document golden file requirement (#33900 )

2020-01-07 10:58:53 -08:00

gulpfile.js

build: create bazel marco to test for circular dependencies (#34774 )

2020-01-23 11:36:40 -08:00

karma-js.conf.js

ci: ensure saucelabs browsers can load karma test page (#35171 )

2020-02-06 15:36:27 -08:00

LICENSE

build: bump year (#34651 )

2020-01-13 07:21:43 -08:00

package.json

build: add npm_integration_test && angular_integration_test (#33927 )

2020-02-24 08:59:18 -08:00

protractor-perf.conf.js

test: ensure global options for benchmark tests can be set in bazel (#34753 )

2020-01-29 09:22:27 -08:00

README.md

docs: fix typo of Typescript to TypeScript (#32153 )

2019-08-15 12:44:41 -07:00

shims_for_IE.js

Revert "refactor: add license header to JS files & format files (#12035 )"

2016-10-04 14:06:41 -07:00

test-events.js

refactor: rename unpatched event flag in Zone from BLACK_LISTED_EVENTS to UNPATCHED_EVENTS (#29617 )

2019-10-04 08:44:58 -07:00

test-main.js

feat(ivy): i18n - implement compile-time inlining (#32881 )

2019-10-09 13:19:38 -07:00

tslint.json

style: enforce disallowance of object constructor (#33211 )

2019-12-03 10:08:25 -08:00

WORKSPACE

build: add npm_integration_test && angular_integration_test (#33927 )

2020-02-24 08:59:18 -08:00

yarn.lock

build: add npm_integration_test && angular_integration_test (#33927 )

2020-02-24 08:59:18 -08:00

yarn.lock.readme.md

build: remove travisci leftovers (#27979 )

2019-01-09 10:41:16 -08:00

README.md

Angular

Angular is a development platform for building mobile and desktop web applications using TypeScript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.

Languages

TypeScript 86.3%

JavaScript 8.5%

HTML 1.8%

Starlark 1.7%

CSS 1%

Other 0.6%