Go to file

Kristiyan Kostadinov 862697d4bd fix(ivy): return new ViewRef when detaching view (#27437 )

When detaching a view by its index via `ViewContainerRef.detach(index)`, in `ViewEngine` we used to return a new `ViewRef` ([for reference](https://github.com/angular/angular/blob/master/packages/core/src/view/refs.ts#L227)), however in Ivy we return the same `ViewRef` which means that its internal `_viewContainerRef` is never reset and we'll throw an error if the consumer tried to attach it to the `ApplicationRef`. These changes return a new `ViewRef` in order to match the original behavior.

These changes also add the same errors as `ViewEngine` when attempting to attach a view that is attached already. This was the original goal of this PR, however it ended up uncovering the issues with the `ViewRef`.

PR Close #27437

2018-12-04 19:59:37 -08:00

.circleci

ci(docs-infra): manually trigger the preview server webhook (#27458 )

2018-12-04 13:59:54 -08:00

.github

build: fix size artifacts not measured by github robot (#27042 )

2018-11-20 10:44:12 -08:00

aio

fix(docs-infra): log the successful creation of previews (#27436 )

2018-12-04 19:59:24 -08:00

docs

test(elements): run tests with Ivy (#27300 )

2018-12-04 14:03:44 -08:00

integration

test(ivy): ngcc - update integration test dependency lock file (#26906 )

2018-11-30 14:02:03 -08:00

modules

build(bazel): upgrade benchmarks to protractor_web_test_suite for CI without local chrome (#26908 )

2018-11-07 16:47:39 -08:00

packages

fix(ivy): return new ViewRef when detaching view (#27437 )

2018-12-04 19:59:37 -08:00

scripts

build: only stamp version info when releasing (#27362 )

2018-11-30 16:08:23 -08:00

tools

fix(ivy): Implement remaining methods for DebugNode (#27387 )

2018-12-04 19:58:25 -08:00

.bazelignore

build: add aio/tools/examples/shared/node_modules to .bazelignore (#27278 )

2018-11-27 10:30:58 -08:00

.bazelrc

build: only stamp version info when releasing (#27362 )

2018-11-30 16:08:23 -08:00

.bowerrc

chore(dgeni): clean up legacy typings bundle creation

2015-10-29 21:19:59 +00:00

.clang-format

feat(tooling): Add a .clang-format for automated JavaScript formatting.

2015-04-02 08:44:34 -07:00

.editorconfig

chore(.editorconfig): include markdown config

2015-01-27 00:14:48 -08:00

.gitattributes

chore: force lf EOL for ts files (#11143 )

2016-08-29 12:41:58 -07:00

.gitignore

feat(bazel): Bazel workspace schematics (#26971 )

2018-11-16 12:18:06 -08:00

.mailmap

build: add a Git .mailmap with my new name (#19550 )

2017-10-09 14:35:30 -07:00

.nvmrc

build: update .nvmrc file to correct node version (#25992 )

2018-09-18 13:11:58 -07:00

.pullapprove.yml

build: add kara to approvers for packages needing ivy TestBed updates (#27337 )

2018-11-29 21:22:24 -08:00

.travis.yml

ci(docs-infra): remove jobs from Travis config (#26377 )

2018-10-23 14:35:38 -07:00

bower.json

docs: branding fixes (#14132 )

2017-01-27 15:03:11 -06:00

browser-providers.conf.js

feat(elements): enable Shadow DOM v1 and slots (#24861 )

2018-08-30 21:33:14 -07:00

BUILD.bazel

build: use bazel version from node modules (#26691 )

2018-10-30 16:19:13 -04:00

build.sh

feat(ivy): implement TestBed (#25369 )

2018-08-14 11:58:47 -07:00

CHANGELOG.md

release: cut the v7.2.0-beta.0 release

2018-11-28 11:18:04 -08:00

CODE_OF_CONDUCT.md

docs: fix community tab in GitHub by copying CoC

2018-02-27 19:02:30 -08:00

CONTRIBUTING.md

docs: Indicate that PRs should have an associated issue (#25436 )

2018-10-15 16:51:46 -07:00

gulpfile.js

style: update gulp task to format untracked and diff files separately (#24969 )

2018-09-27 12:09:08 -07:00

index.bzl

style: format .bzl files with buildifier (#23544 )

2018-08-08 13:12:07 -07:00

karma-js.conf.js

build(bazel): use fine-grained npm deps (#26111 ) (#26488 )

2018-10-19 20:59:29 -07:00

LICENSE

docs(common): update copyright years (#21232 )

2018-01-04 17:45:36 -05:00

package.json

build(bazel): change package.json back to 7.1.0 as a workaround for check_version.js failure

2018-11-28 16:53:46 -08:00

protractor-e2e.conf.js

refactor: add license header to JS files & format files (#12081 )

2016-10-04 20:39:20 -07:00

protractor-examples-e2e.conf.js

refactor: format and lint code

2016-12-12 11:30:25 -08:00

protractor-perf.conf.js

ci: configure chrome options for protractor (#26735 )

2018-10-26 14:48:05 -04:00

README.md

build: run CI (#26488 )

2018-10-19 20:59:29 -07:00

shims_for_IE.js

Revert "refactor: add license header to JS files & format files (#12035 )"

2016-10-04 14:06:41 -07:00

test-events.js

fix(platform-browser): run BLACK_LISTED_EVENTS outside of ngZone (#18993 )

2017-09-05 15:33:22 -05:00

test-main.js

refactor(core): remove withBody from public testing API (#25171 )

2018-07-31 15:09:32 -07:00

test.sh

feat: typescript 2.9 support (#24652 )

2018-07-03 13:32:06 -07:00

tslint.json

style: tslint enforces no debugger statements left behind (#25532 )

2018-08-16 16:00:22 -07:00

WORKSPACE

build(bazel): update handling of rules_nodejs transitive deps (#27264 )

2018-11-30 13:35:51 -08:00

yarn.lock

build(bazel): Add Bazel builders (#27141 )

2018-11-21 07:46:42 -08:00

yarn.lock.readme.md

docs: replace npm with yarn in lockfile readme (#25309 )

2018-08-06 13:38:13 -07:00

README.md

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.

Languages

TypeScript 86.3%

JavaScript 8.5%

HTML 1.8%

Starlark 1.7%

CSS 1%

Other 0.6%